sanityops-cli 0.1.7__tar.gz → 0.1.8__tar.gz

{sanityops_cli-0.1.7 → sanityops_cli-0.1.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: sanityops-cli
-Version: 0.1.7
+Version: 0.1.8
 Summary: CLI tool for static defect inspection of AI logical artifacts
 Project-URL: Homepage, https://sanityops.org
 Project-URL: Documentation, https://sanityops.org

{sanityops_cli-0.1.7 → sanityops_cli-0.1.8}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "sanityops-cli"
-version = "0.1.7"
+version = "0.1.8"
 description = "CLI tool for static defect inspection of AI logical artifacts"
 readme = "README.md"
 requires-python = ">=3.11"

{sanityops_cli-0.1.7 → sanityops_cli-0.1.8}/src/sanityops_cli/__init__.py

@@ -13,4 +13,4 @@
 # limitations under the License.
 #
 
-__version__ = "0.1.7"
+__version__ = "0.1.8"

{sanityops_cli-0.1.7 → sanityops_cli-0.1.8}/src/sanityops_cli/defect_checker/llm_config.py

@@ -102,10 +102,13 @@ def resolve_llm_config(config_path: str | None = None) -> dict[str, str]:
     if config_values:
         return config_values
 
-    # Fall back to ProviderConfig (env vars)
+    # Fall back to ProviderConfig (env vars). PROVIDER is the field that reads
+    # the documented LLM_PROVIDER variable (env_prefix is "LLM_"); the
+    # LLM_PROVIDER *alias* field listens on LLM_LLM_PROVIDER, so reading it here
+    # left llm_provider None and made the SDK refuse every env-configured run.
     config = ProviderConfig()
     return {
-        "llm_provider": config.LLM_PROVIDER,
+        "llm_provider": config.PROVIDER,
         "llm_api_key": config.API_KEY,
         "llm_model_id": config.MODEL_ID,
         "llm_base_url": config.BASE_URL or "",

{sanityops_cli-0.1.7 → sanityops_cli-0.1.8}/tests/unit/defect_checker/test_llm_config.py

@@ -1,47 +1,85 @@
 """Unit tests for LLM config resolution."""
 from pathlib import Path
-from unittest import mock
 
 import yaml
 
 from sanityops_cli.defect_checker.llm_config import resolve_llm_config
 
+LLM_ENV_NAMES = (
+    "LLM_PROVIDER",
+    "LLM_LLM_PROVIDER",
+    "LLM_API_KEY",
+    "LLM_MODEL_ID",
+    "LLM_BASE_URL",
+)
 
-class TestResolveLlmConfig:
-    def test_returns_four_expected_keys(self):
+
+def _set_llm_env(monkeypatch, tmp_path: Path, **values: str) -> None:
+    """Point the LLM_* environment variables at `values`, clearing the rest.
+
+    Also chdirs into tmp_path so ProviderConfig's `.env` lookup (env_file)
+    cannot leak values from the repository into the test.
+    """
+    monkeypatch.chdir(tmp_path)
+    for name in LLM_ENV_NAMES:
+        monkeypatch.delenv(name, raising=False)
+    for name, value in values.items():
+        monkeypatch.setenv(name, value)
+
+
+class TestResolveLlmConfigFromEnvironment:
+    """The env fallback must read the documented LLM_* variable names.
+
+    Regression: resolve_llm_config read ``ProviderConfig.LLM_PROVIDER``, the
+    deprecated constructor alias, instead of ``ProviderConfig.PROVIDER``. The
+    settings model sets ``env_prefix="LLM_"``, so that alias listens on
+    ``LLM_LLM_PROVIDER``; the documented ``LLM_PROVIDER`` never reached the
+    defect-check SDK, which refused the run with LLM_CONFIGURATION_MISSING and
+    left the report at zero defects with a PASS gate.
+    """
+
+    def test_returns_four_expected_keys(self, tmp_path: Path, monkeypatch):
+        _set_llm_env(monkeypatch, tmp_path)
         cfg = resolve_llm_config()
         assert set(cfg.keys()) == {"llm_provider", "llm_api_key", "llm_model_id", "llm_base_url"}
 
-    def test_maps_provider_config_fields(self):
-        fake = mock.Mock()
-        fake.LLM_PROVIDER = "anthropic"
-        fake.API_KEY = "sk-test"
-        fake.MODEL_ID = "claude-sonnet-4-20250514"
-        fake.BASE_URL = "https://api.example.com"
-        with mock.patch(
-            "sanityops_cli.defect_checker.llm_config.ProviderConfig",
-            return_value=fake,
-        ):
-            cfg = resolve_llm_config()
-        assert cfg == {
+    def test_reads_documented_env_var_names(self, tmp_path: Path, monkeypatch):
+        """LLM_PROVIDER and friends resolve into the provider the SDK receives."""
+        _set_llm_env(
+            monkeypatch,
+            tmp_path,
+            LLM_PROVIDER="anthropic",
+            LLM_API_KEY="sk-test",
+            LLM_MODEL_ID="claude-sonnet-4-20250514",
+            LLM_BASE_URL="https://api.example.com",
+        )
+        assert resolve_llm_config() == {
             "llm_provider": "anthropic",
             "llm_api_key": "sk-test",
             "llm_model_id": "claude-sonnet-4-20250514",
             "llm_base_url": "https://api.example.com",
         }
 
-    def test_none_base_url_becomes_empty_string(self):
-        fake = mock.Mock()
-        fake.LLM_PROVIDER = "openai"
-        fake.API_KEY = "k"
-        fake.MODEL_ID = "gpt-4o"
-        fake.BASE_URL = None
-        with mock.patch(
-            "sanityops_cli.defect_checker.llm_config.ProviderConfig",
-            return_value=fake,
-        ):
-            cfg = resolve_llm_config()
-        assert cfg["llm_base_url"] == ""
+    def test_deprecated_double_prefixed_provider_name_still_resolves(self, tmp_path: Path, monkeypatch):
+        """LLM_LLM_PROVIDER is the deprecated alias' own env name; keep it working."""
+        _set_llm_env(
+            monkeypatch,
+            tmp_path,
+            LLM_LLM_PROVIDER="openai",
+            LLM_API_KEY="sk-test",
+            LLM_MODEL_ID="gpt-4o",
+        )
+        assert resolve_llm_config()["llm_provider"] == "openai"
+
+    def test_unset_base_url_becomes_empty_string(self, tmp_path: Path, monkeypatch):
+        _set_llm_env(
+            monkeypatch,
+            tmp_path,
+            LLM_PROVIDER="openai",
+            LLM_API_KEY="k",
+            LLM_MODEL_ID="gpt-4o",
+        )
+        assert resolve_llm_config()["llm_base_url"] == ""
 
 
 class TestResolveLlmConfigFromConfigFile:
@@ -103,7 +141,7 @@ class TestResolveLlmConfigFromConfigFile:
 
     def test_model_section_absent_falls_back_to_env_vars(self, tmp_path: Path, monkeypatch):
         """Should fall back to ProviderConfig when model section absent."""
-        monkeypatch.chdir(tmp_path)
+        _set_llm_env(monkeypatch, tmp_path)
         config_dir = tmp_path / ".sanityops"
         config_dir.mkdir()
         config_file = config_dir / "inspect_config.yaml"
@@ -117,17 +155,15 @@ class TestResolveLlmConfigFromConfigFile:
         with open(config_file, "w") as f:
             yaml.dump(config_content, f)
 
-        fake = mock.Mock()
-        fake.LLM_PROVIDER = "env-provider"
-        fake.API_KEY = "env-key"
-        fake.MODEL_ID = "env-model"
-        fake.BASE_URL = "https://env.url"
-        with mock.patch(
-            "sanityops_cli.defect_checker.llm_config.ProviderConfig",
-            return_value=fake,
-        ):
-            cfg = resolve_llm_config(str(config_file))
-        assert cfg == {
+        _set_llm_env(
+            monkeypatch,
+            tmp_path,
+            LLM_PROVIDER="env-provider",
+            LLM_API_KEY="env-key",
+            LLM_MODEL_ID="env-model",
+            LLM_BASE_URL="https://env.url",
+        )
+        assert resolve_llm_config(str(config_file)) == {
             "llm_provider": "env-provider",
             "llm_api_key": "env-key",
             "llm_model_id": "env-model",
@@ -136,19 +172,14 @@ class TestResolveLlmConfigFromConfigFile:
 
     def test_config_file_missing_falls_back_to_env_vars(self, tmp_path: Path, monkeypatch):
         """Should fall back to ProviderConfig when config file doesn't exist."""
-        monkeypatch.chdir(tmp_path)
-
-        fake = mock.Mock()
-        fake.LLM_PROVIDER = "fallback-provider"
-        fake.API_KEY = "fallback-key"
-        fake.MODEL_ID = "fallback-model"
-        fake.BASE_URL = None
-        with mock.patch(
-            "sanityops_cli.defect_checker.llm_config.ProviderConfig",
-            return_value=fake,
-        ):
-            cfg = resolve_llm_config("/nonexistent/config.yaml")
-        assert cfg == {
+        _set_llm_env(
+            monkeypatch,
+            tmp_path,
+            LLM_PROVIDER="fallback-provider",
+            LLM_API_KEY="fallback-key",
+            LLM_MODEL_ID="fallback-model",
+        )
+        assert resolve_llm_config("/nonexistent/config.yaml") == {
             "llm_provider": "fallback-provider",
             "llm_api_key": "fallback-key",
             "llm_model_id": "fallback-model",
@@ -206,20 +237,22 @@ class TestResolveLlmConfigFromConfigFile:
         with open(config_file, "w") as f:
             yaml.dump(config_content, f)
 
-        # Set up env vars that should be ignored
-        fake = mock.Mock()
-        fake.LLM_PROVIDER = "env-provider-should-be-ignored"
-        fake.API_KEY = "env-key-should-be-ignored"
-        fake.MODEL_ID = "env-model-should-be-ignored"
-        fake.BASE_URL = "https://env.url.ignored"
-        with mock.patch(
-            "sanityops_cli.defect_checker.llm_config.ProviderConfig",
-            return_value=fake,
-        ):
-            cfg = resolve_llm_config(str(config_file))
+        # Env vars that must be ignored in favour of the config file's model: section
+        _set_llm_env(
+            monkeypatch,
+            tmp_path,
+            LLM_PROVIDER="env-provider-should-be-ignored",
+            LLM_API_KEY="env-key-should-be-ignored",
+            LLM_MODEL_ID="env-model-should-be-ignored",
+            LLM_BASE_URL="https://env.url.ignored",
+        )
+
+        cfg = resolve_llm_config(str(config_file))
 
         # Config values win
-        assert cfg["llm_provider"] == "config-provider"
-        assert cfg["llm_api_key"] == "config-key"
-        assert cfg["llm_model_id"] == "config-model"
-        assert cfg["llm_base_url"] == ""
+        assert cfg == {
+            "llm_provider": "config-provider",
+            "llm_api_key": "config-key",
+            "llm_model_id": "config-model",
+            "llm_base_url": "",
+        }