rummage 4.18__tar.gz → 4.20__tar.gz

{rummage-4.18 → rummage-4.20}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.1
+Metadata-Version: 2.3
 Name: rummage
-Version: 4.18
+Version: 4.20
 Summary: A GUI search and replace app.
 Project-URL: Homepage, https://github.com/facelessuser/Rummage
 Author-email: Isaac Muse <Isaac.Muse@gmail.com>
@@ -13,7 +13,6 @@ Classifier: Intended Audience :: Developers
 Classifier: License :: OSI Approved :: MIT License
 Classifier: Operating System :: OS Independent
 Classifier: Programming Language :: Python :: 3
-Classifier: Programming Language :: Python :: 3.7
 Classifier: Programming Language :: Python :: 3.8
 Classifier: Programming Language :: Python :: 3.9
 Classifier: Programming Language :: Python :: 3.10
@@ -23,16 +22,16 @@ Classifier: Topic :: Software Development :: Libraries :: Python Modules
 Classifier: Topic :: Text Processing :: Filters
 Classifier: Topic :: Text Processing :: Markup :: HTML
 Requires-Python: >=3.7
-Requires-Dist: backrefs<6.0,>=5.5
-Requires-Dist: bracex>=2.3
+Requires-Dist: backrefs<6.0,>=5.6
+Requires-Dist: bracex>=2.4
 Requires-Dist: chardet>=5.1.0
-Requires-Dist: coloraide>=2.4
+Requires-Dist: coloraide>=2.9.1
 Requires-Dist: filelock>=3.12.2
-Requires-Dist: markdown>=3.3.4
+Requires-Dist: markdown>=3.4.4
 Requires-Dist: pygments>=2.14.1
-Requires-Dist: pymdown-extensions>=10.0.1
+Requires-Dist: pymdown-extensions>=10.3
 Requires-Dist: send2trash>=1.8.2
-Requires-Dist: wcmatch<9.0,>=8.4.1
+Requires-Dist: wcmatch<9.0,>=8.5
 Requires-Dist: wxpython>=4.1.0
 Provides-Extra: extras
 Requires-Dist: faust-cchardet>=2.1.18; extra == 'extras'

{rummage-4.18 → rummage-4.20}/docs/src/markdown/about/changelog.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 4.20
+
+-   **NEW**: Add new autocomplete setting to disable/enable autocomplete. Mainly for Linux systems where autocomplete
+    functionality can sometimes work well or not so well depending on the distro.
+-   **FIX**: Fix issue with autocomplete shortcuts not working on every platform.
+
+## 4.19
+
+-   **NEW**: Drop support for Python 3.7.
+-   **NEW**: Update some dependencies for latest bug fixes and improvements.
+-   **FIX**: Minor bug fixes.
+
 ## 4.18
 
 -   **NEW**: Officially support Python 3.11.

rummage-4.20/docs/src/markdown/installation.md

@@ -0,0 +1,180 @@
+# Installation
+
+## Requirements
+
+Rummage, when installed via `pip`, will install all of your required dependencies, but there are a few optional
+dependencies. If desired, you can install these dependencies manually, or install them automatically with
+[`pip`](#installation_1).
+
+Name                   | Details
+---------------------- | -------
+[`regex`][regex]       | Regex is a great regular expression engine that adds some nice features such as fuzzy searching, nested char sets, better Unicode support, and more.
+[`cchardet`][cchardet] | `cchardet` is high speed universal character encoding detector. Much faster than the default `chardet`.
+
+## Installation
+
+For well supported platforms, Python wheels are usually available for Rummage and its dependencies. In most cases,
+installation can be done quickly and easily through `pip`. Some platforms, like Linux,  may require some additional
+hoops that you must jump through. Additionally, wxPython, the GUI library that Rummage depends on, may sometimes have
+support lagging for the latest Python version.
+
+In general, it is always recommended to try and install `wxpython` first and make sure it is properly available
+before installing Rummage. The wxPython installation may be more complicated depending on the platform. But in general,
+for non-Linux systems, the following steps are usually sufficient.
+
+Make sure wxPython is installed first. It is important to first ensure wxPython can be installed for your platform and
+specific Python version first.
+
+```console
+$ pip install wxpython
+```
+
+Install Rummage:
+
+```console
+$ pip install rummage
+```
+
+Install Rummage with optional modules.
+
+```console
+$ pip install rummage[extras]
+```
+
+Upgrade Rummage:
+
+```console
+$ pip install --upgrade rummage
+```
+
+### Windows and macOS
+
+On Windows, installation is pretty straight forward as wheels are provided for all packages in `pip`. In recent years,
+macOS installation also usually has wheels available as well. Support for the latest Python version may not always be
+available as the development cycle for wxPython can take a bit to catch up.
+
+Simply using `pip` to install is sufficient.
+
+```console
+$ pip install rummage
+```
+
+### Linux
+
+Linux doesn't often have pre-built wheels for wxPython, so often, you must first ensure some prerequisites are in place
+before using `pip install` (or other methods). Additionally, Linux, in recent years, has made managing libraries and
+applications in Python a bit more complex with its new restrictions. Despite all of this, Rummage is still supported,
+but may require slightly more complex installation.
+
+#### pipx
+
+If installing Rummage on Linux, you may consider `pipx`, especially if your distro has a new enough wxPython [distro
+packages](#distro-packages). On Ubuntu, installation may look similar to the following:
+
+``` console
+$ sudo apt install python3-wgtk4.0 python3-wxgtk-webview4.0
+$ pipx install --system-site-packages rummage
+```
+
+The `--system-site-packages` flag is necessary as by default, `pipx` will create a brand new virtual environment that
+does not have access to the globally available distro package.
+
+#### venv
+
+Another approach on Linux is to use the `venv` package to install Rummage and its dependencies. If your distro has a new
+enough wxPython [distro package](#distro-packages), you can install the wxPython and then create your virtual
+environment with the `--system-site-packages` flag to ensure it has access to the installed package. On Ubuntu, it may
+look similar to:
+
+``` console
+$ sudo apt install python3-wgtk4.0 python3-wxgtk-webview4.0
+$ python3 -m venv --system-site-packages ./venv/rummage
+$ source ./venv/rummage/bin/activate
+$ (rummage) $ pip install rummage
+```
+
+If your distro does not have a proper wxPython package, you may have to install it from another source under your
+virtual environment.
+
+#### Prerequisites
+
+The most important prerequisite to getting Rummage installed is `wxpython`. It is always recommended to ensure it is
+installed before trying to install Rummage. If it is not, installation may try and download `wxpython` and build it
+from scratch. This can take a long time and can fail.
+
+##### Distro Packages
+
+Many Linux distros make wxPython available via their package manager. Assuming the package is not too old and is still
+supported by Rummage, this should automatically fulfill all the needed requirements. As an example, on Ubuntu, you must
+install the following:
+
+``` console
+$ sudo apt install python3-wgtk4.0 python3-wxgtk-webview4.0
+```
+
+##### Pre-built Wheels
+
+Another option, if your distro packages are too old, is to see if there is a readily available pre-built wheel from the
+wxPython team. These are usually kept here: https://extras.wxpython.org/wxPython4/extras/linux/.  It is possible through
+that even after this, there may be some Linux dependencies missing. The wheel can be installed in a virtual environment
+using pip:
+
+```console
+$ pip install -U -f https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-20.04 wxPython
+```
+
+While the wheel should install fine, when you actually run Rummage, you may see some libraries missing. A common one
+on Ubuntu is `libSDL` libraries. If you see a complaint about a library not being found or loaded, and you are on
+Ubuntu, you can install `apt-find` and search for the package containing the file, then you can install it.
+
+```shell-session
+$ sudo apt install apt-file
+$ sudo apt-file update
+$ apt-file search libSDL2-2.0.so.0
+libsdl2-2.0-0: /usr/lib/x86_64-linux-gnu/libSDL2-2.0.so.0
+libsdl2-2.0-0: /usr/lib/x86_64-linux-gnu/libSDL2-2.0.so.0.10.0
+$ sudo apt install libsdl2-2.0-0
+```
+
+##### Manual Building
+
+If you have installed a version of Python on your machine that does not have a pre-built wxPython package, or are using
+a distro that does not have a pre-built wheel, you may have to build it.
+
+You can build the package by installing with `pip`, but you may find that it won't build until you get all the
+dependencies installed. Once the dependencies for building are in place, you can run pip to install the package.
+
+We do not have updated lists of prerequisites for distros. The last updated list was from Ubuntu 18.04 and Fedora 26.
+What you must install may vary depend on what is already installed on your distro out of the box. Also, the version of
+each prerequisites may vary from distro to distro or from distro release to distro release.
+
+Usually the requirements deal with `gstreamer`, `gtk`, `libsdl`, etc. Below are some examples, but are most likely out
+of date:
+
+/// define
+Ubuntu 18.04
+
+- 
+    ```shell-session
+    $ sudo apt-get install python3.6-dev dpkg-dev build-essential libwebkitgtk-dev libjpeg-dev libtiff-dev libsdl1.2-dev libgstreamer-plugins-base1.0-dev libnotify-dev freeglut3 freeglut3-dev libgtk-3-dev libwebkitgtk-3.0-dev
+    ```
+
+Fedora 26
+
+- 
+    ```shell-session
+    $ sudo dnf install gcc-c++ wxGTK-devel gstreamer-devel webkitgtk-devel GConf2-devel gstreamer-plugins-base-devel
+    ```
+///
+
+Once dependencies are in place, you can finally install wxPython with pip (`pip install wxpython`). Be patient when
+installing wxPython manually as Linux must build the package, and it won't give much in the way of status while it
+builds. If it fails and complains about a missing library, you may have to install more dependencies.
+
+For a complete list of dependencies please check wxPython's official documentation on dependencies before installing.
+Particularly under [this section][wxpython-prereq]. If they are out of date, please contact the wxPython team for better
+instructions.
+
+other systems, there may be some prerequisites. If on Linux, it is recommended to make sure you can install `wxpython`
+first. This is due to the fact that installation of that library may require special instructions and will cause the
+installation of Rummage to fail if `wxpython` fails due to not having the necessary prerequisites.

{rummage-4.18 → rummage-4.20}/docs/src/markdown/preferences.md

@@ -23,7 +23,6 @@ Language
 -   Rummage has internal support to display dialog labels in different languages. Currently Rummage has English. Russian
     is outdated but includes a fair bit of the needed translations. See [Localization](./extras.md#localization) to
     learn more about improving current translations or adding additional translations.
-///
 
 Updates
 
@@ -34,7 +33,7 @@ Updates
     The check is only a check for new versions and doesn't perform an upgrade.  Rummage must be upgraded via `pip` from
     command line.
 
-    /// info | Update Issues: Python 3.6+ on macOS
+    //// info | Update Issues: Python 3.6+ on macOS
     There is a small issue on macOS with Python 3.6+: Python 3.6 changed how it gets the default certificates
     required to properly check URLs. The details are actually documented here: https://bugs.python.org/issue28150#msg276516.
 
@@ -44,13 +43,26 @@ Updates
     will use `pip` to install `certifi` and creates a symlink in the OpenSSL directory to `certifi`'s installed
     bundle location. If you are using something like macports, then you'll probably have to research to find out how
     to do the same thing.
-    ///
+    ////
 
 International Time
 
 -   Rummage displays file creation and modified time in the form `Jul 01, 2018, 03:00:00 AM`, but you can enable this
     option to display the times in international format: `2018-07-01 03:00:00`.
 
+Alternate Row Colors
+
+-   In search results, Rummage can show alternating colors for each row. This can be enabled/disabled.
+
+Autocomplete
+
+-   For certain text boxes that retain a history of previous inputs, Rummage will employ an autocomplete feature.
+    Unfortunately, in some Linux distros, this autocomplete doesn't work quite right. Autocomplete can be
+    enabled/disabled for those who are having trouble with the feature.
+
+///
+
+
 ## Search
 
 ![Preferences: Search](images/settings_search.png)

{rummage-4.18 → rummage-4.20}/gui.fbp

@@ -7615,6 +7615,129 @@
                                                         <event name="OnCheckBox">on_alt_row_toggle</event>
                                                     </object>
                                                 </object>
+                                                <object class="sizeritem" expanded="0">
+                                                    <property name="border">5</property>
+                                                    <property name="flag">wxEXPAND | wxALL</property>
+                                                    <property name="proportion">0</property>
+                                                    <object class="wxStaticLine" expanded="0">
+                                                        <property name="BottomDockable">1</property>
+                                                        <property name="LeftDockable">1</property>
+                                                        <property name="RightDockable">1</property>
+                                                        <property name="TopDockable">1</property>
+                                                        <property name="aui_layer"></property>
+                                                        <property name="aui_name"></property>
+                                                        <property name="aui_position"></property>
+                                                        <property name="aui_row"></property>
+                                                        <property name="best_size"></property>
+                                                        <property name="bg"></property>
+                                                        <property name="caption"></property>
+                                                        <property name="caption_visible">1</property>
+                                                        <property name="center_pane">0</property>
+                                                        <property name="close_button">1</property>
+                                                        <property name="context_help"></property>
+                                                        <property name="context_menu">1</property>
+                                                        <property name="default_pane">0</property>
+                                                        <property name="dock">Dock</property>
+                                                        <property name="dock_fixed">0</property>
+                                                        <property name="docking">Left</property>
+                                                        <property name="enabled">1</property>
+                                                        <property name="fg"></property>
+                                                        <property name="floatable">1</property>
+                                                        <property name="font"></property>
+                                                        <property name="gripper">0</property>
+                                                        <property name="hidden">0</property>
+                                                        <property name="id">wxID_ANY</property>
+                                                        <property name="max_size"></property>
+                                                        <property name="maximize_button">0</property>
+                                                        <property name="maximum_size"></property>
+                                                        <property name="min_size"></property>
+                                                        <property name="minimize_button">0</property>
+                                                        <property name="minimum_size"></property>
+                                                        <property name="moveable">1</property>
+                                                        <property name="name">m_staticline15</property>
+                                                        <property name="pane_border">1</property>
+                                                        <property name="pane_position"></property>
+                                                        <property name="pane_size"></property>
+                                                        <property name="permission">protected</property>
+                                                        <property name="pin_button">1</property>
+                                                        <property name="pos"></property>
+                                                        <property name="resize">Resizable</property>
+                                                        <property name="show">1</property>
+                                                        <property name="size"></property>
+                                                        <property name="style">wxLI_HORIZONTAL</property>
+                                                        <property name="subclass">; ; forward_declare</property>
+                                                        <property name="toolbar_pane">0</property>
+                                                        <property name="tooltip"></property>
+                                                        <property name="window_extra_style"></property>
+                                                        <property name="window_name"></property>
+                                                        <property name="window_style"></property>
+                                                    </object>
+                                                </object>
+                                                <object class="sizeritem" expanded="0">
+                                                    <property name="border">5</property>
+                                                    <property name="flag">wxALL</property>
+                                                    <property name="proportion">0</property>
+                                                    <object class="wxCheckBox" expanded="0">
+                                                        <property name="BottomDockable">1</property>
+                                                        <property name="LeftDockable">1</property>
+                                                        <property name="RightDockable">1</property>
+                                                        <property name="TopDockable">1</property>
+                                                        <property name="aui_layer"></property>
+                                                        <property name="aui_name"></property>
+                                                        <property name="aui_position"></property>
+                                                        <property name="aui_row"></property>
+                                                        <property name="best_size"></property>
+                                                        <property name="bg"></property>
+                                                        <property name="caption"></property>
+                                                        <property name="caption_visible">1</property>
+                                                        <property name="center_pane">0</property>
+                                                        <property name="checked">0</property>
+                                                        <property name="close_button">1</property>
+                                                        <property name="context_help"></property>
+                                                        <property name="context_menu">1</property>
+                                                        <property name="default_pane">0</property>
+                                                        <property name="dock">Dock</property>
+                                                        <property name="dock_fixed">0</property>
+                                                        <property name="docking">Left</property>
+                                                        <property name="enabled">1</property>
+                                                        <property name="fg"></property>
+                                                        <property name="floatable">1</property>
+                                                        <property name="font"></property>
+                                                        <property name="gripper">0</property>
+                                                        <property name="hidden">0</property>
+                                                        <property name="id">wxID_ANY</property>
+                                                        <property name="label">Enable autocomplete</property>
+                                                        <property name="max_size"></property>
+                                                        <property name="maximize_button">0</property>
+                                                        <property name="maximum_size"></property>
+                                                        <property name="min_size"></property>
+                                                        <property name="minimize_button">0</property>
+                                                        <property name="minimum_size"></property>
+                                                        <property name="moveable">1</property>
+                                                        <property name="name">m_autocomplete_checkbox</property>
+                                                        <property name="pane_border">1</property>
+                                                        <property name="pane_position"></property>
+                                                        <property name="pane_size"></property>
+                                                        <property name="permission">protected</property>
+                                                        <property name="pin_button">1</property>
+                                                        <property name="pos"></property>
+                                                        <property name="resize">Resizable</property>
+                                                        <property name="show">1</property>
+                                                        <property name="size"></property>
+                                                        <property name="style"></property>
+                                                        <property name="subclass">; ; forward_declare</property>
+                                                        <property name="toolbar_pane">0</property>
+                                                        <property name="tooltip"></property>
+                                                        <property name="validator_data_type"></property>
+                                                        <property name="validator_style">wxFILTER_NONE</property>
+                                                        <property name="validator_type">wxDefaultValidator</property>
+                                                        <property name="validator_variable"></property>
+                                                        <property name="window_extra_style"></property>
+                                                        <property name="window_name"></property>
+                                                        <property name="window_style"></property>
+                                                        <event name="OnCheckBox">on_autocomplete_toggle</event>
+                                                    </object>
+                                                </object>
                                             </object>
                                         </object>
                                     </object>

{rummage-4.18 → rummage-4.20}/hatch_build.py

@@ -22,9 +22,7 @@ def get_requirements(root, requirements):
 
     install_requires = []
     with open(os.path.join(root, requirements)) as f:
-        for line in f:
-            if not line.startswith("#"):
-                install_requires.append(line.strip())
+        install_requires = [line.strip() for line in f if not line.startswith("#")]
     return install_requires
 
 
@@ -45,11 +43,11 @@ class CustomMetadataHook(MetadataHookInterface):
             "License :: OSI Approved :: MIT License",
             "Operating System :: OS Independent",
             "Programming Language :: Python :: 3",
-            "Programming Language :: Python :: 3.7",
             "Programming Language :: Python :: 3.8",
             "Programming Language :: Python :: 3.9",
             "Programming Language :: Python :: 3.10",
             "Programming Language :: Python :: 3.11",
+            # "Programming Language :: Python :: 3.12",
             "Topic :: Internet :: WWW/HTTP :: Dynamic Content",
             "Topic :: Software Development :: Libraries :: Python Modules",
             "Topic :: Text Processing :: Filters",

{rummage-4.18 → rummage-4.20}/mkdocs-internal.yml

@@ -55,8 +55,8 @@ markdown_extensions:
   - pymdownx.caret:
   - pymdownx.smartsymbols:
   - pymdownx.emoji:
-      emoji_index: !!python/name:materialx.emoji.twemoji
-      emoji_generator: !!python/name:materialx.emoji.to_svg
+      emoji_index: !!python/name:material.extensions.emoji.twemoji
+      emoji_generator: !!python/name:material.extensions.emoji.to_svg
   - pymdownx.escapeall:
       hardbreak: True
       nbsp: True

{rummage-4.18 → rummage-4.20}/mkdocs.yml

@@ -82,8 +82,8 @@ markdown_extensions:
   - pymdownx.caret:
   - pymdownx.smartsymbols:
   - pymdownx.emoji:
-      emoji_index: !!python/name:materialx.emoji.twemoji
-      emoji_generator: !!python/name:materialx.emoji.to_svg
+      emoji_index: !!python/name:material.extensions.emoji.twemoji
+      emoji_generator: !!python/name:material.extensions.emoji.to_svg
   - pymdownx.escapeall:
       hardbreak: True
       nbsp: True

{rummage-4.18 → rummage-4.20}/pyproject.toml

@@ -100,3 +100,86 @@ extract = "pybabel extract --input-dirs=rummage --output-file=rummage/lib/gui/lo
 init = "pybabel init --domain=rummage --input-file=rummage/lib/gui/localization/locale/rummage.pot --output-dir=rummage/lib/gui/localization/locale"
 update = "pybabel update --domain=rummage --input-file=rummage/lib/gui/localization/locale/rummage.pot --output-dir=rummage/lib/gui/localization/locale"
 compile = "pybabel compile --domain=rummage --directory=rummage/lib/gui/localization/locale"
+
+[tool.ruff]
+line-length = 120
+
+extend-exclude = [
+    "rummage/lib/gui/gui.py",
+    "tests/encodings/*",
+    "*tiger.py",
+    "*whirlpool.py",
+    "*png.py"
+]
+
+select = [
+    "A",    # flake8-builtins
+    "B",    # flake8-bugbear
+    "D",    # pydocstyle
+    "C4",   # flake8-comprehensions
+    "N",    # pep8-naming
+    "E",    # pycodestyle
+    "F",    # pyflakes
+    "PGH",  # pygrep-hooks
+    "RUF",  # ruff
+    # "UP",   # pyupgrade
+    "W",    # pycodestyle
+    "YTT",  # flake8-2020,
+    "PERF"  # Perflint
+]
+
+ignore = [
+    "B034",
+    "E741",
+    "D202",
+    "D401",
+    "D212",
+    "D203",
+    "D417",
+    "N802",
+    "N801",
+    "N803",
+    "N806",
+    "N818",
+    "RUF012",
+    "RUF005",
+    "PGH004",
+    "RUF100"
+]
+
+[tool.tox]
+legacy_tox_ini = """
+[tox]
+skipsdist=true
+envlist=
+    {py38,py39,py310,py311,py312},
+    lint
+
+[testenv]
+passenv = *
+deps=
+    -r requirements/test-project.txt
+    -r requirements/extras.txt
+    -r requirements/test.txt
+commands=
+    {envbindir}/py.test --cov rummage --cov-append tests
+    {envbindir}/coverage html -d {envtmpdir}/coverage
+    {envbindir}/coverage xml
+    {envbindir}/coverage report --show-missing
+
+[testenv:lint]
+passenv = *
+deps=
+    -r requirements/lint.txt
+commands=
+    "{envbindir}"/ruff check .
+
+[testenv:documents]
+passenv = *
+deps=
+    -r requirements/docs.txt
+commands=
+    {envpython} -m mkdocs build --clean --verbose --strict
+    {envpython} -m pyspelling
+    {envpython} {toxinidir}/tools/gen_docs.py --verbose --test
+"""

rummage-4.20/requirements/lint.txt

@@ -0,0 +1 @@
+ruff

rummage-4.20/requirements/project.txt

@@ -0,0 +1,11 @@
+chardet>=5.1.0
+backrefs>=5.6,<6.0
+bracex>=2.4
+wcmatch>=8.5,<9.0
+wxpython>=4.1.0
+filelock>=3.12.2
+send2trash>=1.8.2
+markdown>=3.4.4
+pymdown-extensions>=10.3
+pygments>=2.14.1
+coloraide>=2.9.1

{rummage-4.18 → rummage-4.20}/rummage/lib/__meta__.py

@@ -189,7 +189,7 @@ def parse_version(ver):
 
 
 #   (major, minor, micro, release type, pre-release build, post-release build, development-release)
-__version_info__ = Version(4, 18, 0, 'final')
+__version_info__ = Version(4, 20, 0, 'final')
 __version__ = __version_info__._get_canonical()
 __app__ = "Rummage"
 __status__ = __version_info__[3]

{rummage-4.18 → rummage-4.20}/rummage/lib/gui/actions/checksum/__init__.py

@@ -134,11 +134,11 @@ def _verify_hashes(hashes):
         try:
             hashlib.new(item)
             VALID_HASH.append(item)
-        except Exception:
+        except Exception:  # noqa: PERF203
             pass
 
 
-_available_hashes = list(set([x.lower() for x in hashlib.algorithms_available]))
+_available_hashes = list({x.lower() for x in hashlib.algorithms_available})
 _verify_hashes(_available_hashes)
 
 _additional_hashes = {
@@ -153,10 +153,10 @@ _additional_hashes = {
     'whirlpool': whirlpool.whirlpool
 }
 
-for k, v in _additional_hashes.items():
+for k in _additional_hashes.keys():
     try:
         hashlib.new(k)
-    except Exception:
+    except Exception:  # noqa: PERF203
         VALID_HASH.append(k)
 
 VALID_HASH.sort()

{rummage-4.18 → rummage-4.20}/rummage/lib/gui/actions/export_csv.py

@@ -89,7 +89,7 @@ def export(export_csv, chain, result_list, result_content_list):
     literal_search = csv_encode(_("Literal Search"))
 
     with codecs.open(export_csv, "w", encoding="utf-8-sig") as csv:
-        for pattern, replace, flags in chain:
+        for pattern, _replace, flags in chain:
             csv.write(
                 "%s,%s\n" % (
                     (literal_search if flags & rumcore.LITERAL else regex_search), csv_encode(pattern)

{rummage-4.18 → rummage-4.20}/rummage/lib/gui/actions/export_html.py

@@ -145,7 +145,7 @@ def export_result_list(res, html):
     )
 
     for item in res.values():
-        content.append(
+        content.append(  # noqa: PERF401
             RESULT_ROW % {
                 "file": html_encode(item[0]),
                 "matches": util.to_ustr(item[1]),
@@ -189,7 +189,7 @@ def export_result_content_list(res, html):
     )
 
     for item in res.values():
-        content.append(
+        content.append(  # noqa: PERF401
             RESULT_CONTENT_ROW % {
                 "file_sort": html_encode(os.path.join(item[0][1], item[0][0])),
                 "file": html_encode(item[0][0]),
@@ -282,7 +282,7 @@ def export(export_html, chain, result_list, result_content_list):
 
         search_label_regex = html_encode(_("Regex search:"))
         search_label_literal = html_encode(_("Literal search:"))
-        for pattern, replace, flags in chain:
+        for pattern, _replace, flags in chain:
             html.write(
                 TABS_END % {
                     "search": html_encode(pattern),