rumdl 0.0.157__tar.gz → 0.0.158__tar.gz

{rumdl-0.0.157 → rumdl-0.0.158}/CHANGELOG.md

@@ -7,7 +7,56 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [0.0.157] - 2025-10-13 (unreleased)
+## [0.0.158] - 2025-10-14
+
+### Fixed
+
+- **CRLF Line Ending Support**: Fixed byte position calculations in multiple rules for Windows-style line endings
+  - Fixed MD034, MD046, MD057 byte position calculations
+  - Fixed MD037, MD049, MD011 byte position calculations
+  - Fixed MD050, MD037, MD010, MD026 byte position calculations
+  - Fixed code_block_utils byte position calculation in `is_in_code_span`
+  - All rules now correctly handle CRLF line endings in fixes and diagnostics
+
+- **Test Stability**: Fixed flaky tests with dependency injection pattern
+  - Eliminated race conditions from parallel test execution
+  - Tests no longer modify global environment variables
+  - Added `serial_test` crate for unavoidable global operations
+  - All 1731 tests now pass reliably in parallel execution
+
+### Changed
+
+- **Code Architecture**: Major refactoring to improve maintainability
+  - Extracted `formatter` module (397 lines) - output formatting logic
+  - Extracted `watch` module (491 lines) - watch mode functionality
+  - Extracted `file_processor` module (792 lines) - file processing logic
+  - Extracted `stdin_processor` module (212 lines) - stdin handling
+  - main.rs reduced from 3268 to 1394 lines (57% reduction)
+  - Improved code organization and testability
+
+- **Line Ending Handling**: Refactored line ending preservation
+  - Line ending detection and normalization now at I/O boundaries
+  - Internal code always works with consistent LF line endings
+  - More efficient: 1 normalization per file instead of per-rule
+  - Cleaner separation of concerns
+  - Simplified MD047, MD012, MD022 to always use LF internally
+  - Removed unnecessary line ending detection from rules
+  - Added comprehensive end-to-end CRLF tests
+
+### Removed
+
+- **Legacy Fix Implementation**: Removed deprecated fix wrapper functions
+  - Removed `apply_fixes()` wrapper
+  - Removed `apply_fixes_stdin_coordinated()` wrapper
+  - Removed `apply_fixes_stdin()` legacy implementation
+  - Removed `RUMDL_NO_FIX_COORDINATOR` environment variable
+  - Fix Coordinator is now the only fix strategy (3 weeks stable, ~75% faster)
+
+## [0.0.157] - 2025-10-13
+
+### Changed
+
+- **Removed legacy fix implementation** - Removed old single-pass fix implementation and `RUMDL_NO_FIX_COORDINATOR` environment variable. Fix Coordinator is now the only fix strategy, providing ~75% faster fixes with better coverage.
 
 ### Added
 

{rumdl-0.0.157 → rumdl-0.0.158}/Cargo.lock

@@ -586,6 +586,7 @@ checksum = "65bc07b1a8bc7c85c5f2e110c476c7389b4554ba72af57d8445ea63a576b0876"
 dependencies = [
  "futures-channel",
  "futures-core",
+ "futures-executor",
  "futures-io",
  "futures-sink",
  "futures-task",
@@ -608,6 +609,17 @@ version = "0.3.31"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "05f29059c0c2090612e8d742178b0580d2dc940c837851ad723096f87af6663e"
 
+[[package]]
+name = "futures-executor"
+version = "0.3.31"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1e28d1d997f585e54aebc3f97d39e72338912123a67330d723fdbb564d646c9f"
+dependencies = [
+ "futures-core",
+ "futures-task",
+ "futures-util",
+]
+
 [[package]]
 name = "futures-io"
 version = "0.3.31"
@@ -1566,7 +1578,7 @@ checksum = "caf4aa5b0f434c91fe5c7f1ecb6a5ece2130b02ad2a590589dda5146df959001"
 
 [[package]]
 name = "rumdl"
-version = "0.0.157"
+version = "0.0.158"
 dependencies = [
  "anyhow",
  "assert_cmd",
@@ -1600,6 +1612,7 @@ dependencies = [
  "serde",
  "serde_json",
  "serde_yaml",
+ "serial_test",
  "strsim",
  "tempfile",
  "thiserror",
@@ -1669,6 +1682,15 @@ dependencies = [
  "winapi-util",
 ]
 
+[[package]]
+name = "scc"
+version = "2.4.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "46e6f046b7fef48e2660c57ed794263155d713de679057f2d0c169bfc6e756cc"
+dependencies = [
+ "sdd",
+]
+
 [[package]]
 name = "schemars"
 version = "0.8.22"
@@ -1699,6 +1721,12 @@ version = "1.2.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "94143f37725109f92c262ed2cf5e59bce7498c01bcc1502d7b9afe439a4e9f49"
 
+[[package]]
+name = "sdd"
+version = "3.0.10"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "490dcfcbfef26be6800d11870ff2df8774fa6e86d047e3e8c8a76b25655e41ca"
+
 [[package]]
 name = "serde"
 version = "1.0.226"
@@ -1786,6 +1814,31 @@ dependencies = [
  "unsafe-libyaml",
 ]
 
+[[package]]
+name = "serial_test"
+version = "3.2.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1b258109f244e1d6891bf1053a55d63a5cd4f8f4c30cf9a1280989f80e7a1fa9"
+dependencies = [
+ "futures",
+ "log",
+ "once_cell",
+ "parking_lot",
+ "scc",
+ "serial_test_derive",
+]
+
+[[package]]
+name = "serial_test_derive"
+version = "3.2.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "5d69265a08751de7844521fd15003ae0a888e035773ba05695c5c759a6f89eef"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn",
+]
+
 [[package]]
 name = "shlex"
 version = "1.3.0"

{rumdl-0.0.157 → rumdl-0.0.158}/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rumdl"
-version = "0.0.157"
+version = "0.0.158"
 edition = "2024"
 rust-version = "1.89.0"
 description = "A fast Markdown linter written in Rust (Ru(st) MarkDown Linter)"
@@ -103,6 +103,7 @@ rand = "0.9.1"
 pretty_assertions = "1.4"
 unicode-segmentation = "1.12"
 unicode-width = "0.2"
+serial_test = "3.2"
 
 [target.'cfg(not(target_env = "msvc"))'.dependencies]
 tikv-jemallocator = "0.6"

{rumdl-0.0.157 → rumdl-0.0.158}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rumdl
-Version: 0.0.157
+Version: 0.0.158
 Classifier: Development Status :: 4 - Beta
 Classifier: Environment :: Console
 Classifier: Intended Audience :: Developers

{rumdl-0.0.157 → rumdl-0.0.158}/src/config.rs

@@ -1706,52 +1706,55 @@ impl SourcedConfig {
         None
     }
 
-    /// Discover user-level configuration file from platform-specific config directory.
-    /// Returns the first configuration file found in the user config directory.
-    fn user_configuration_path() -> Option<std::path::PathBuf> {
-        use etcetera::{BaseStrategy, choose_base_strategy};
+    /// Internal implementation that accepts config directory for testing
+    fn user_configuration_path_impl(config_dir: &Path) -> Option<std::path::PathBuf> {
+        let config_dir = config_dir.join("rumdl");
 
-        match choose_base_strategy() {
-            Ok(strategy) => {
-                let config_dir = strategy.config_dir().join("rumdl");
+        // Check for config files in precedence order (same as project discovery)
+        const USER_CONFIG_FILES: &[&str] = &[".rumdl.toml", "rumdl.toml", "pyproject.toml"];
 
-                // Check for config files in precedence order (same as project discovery)
-                const USER_CONFIG_FILES: &[&str] = &[".rumdl.toml", "rumdl.toml", "pyproject.toml"];
+        log::debug!(
+            "[rumdl-config] Checking for user configuration in: {}",
+            config_dir.display()
+        );
 
-                log::debug!(
-                    "[rumdl-config] Checking for user configuration in: {}",
-                    config_dir.display()
-                );
+        for filename in USER_CONFIG_FILES {
+            let config_path = config_dir.join(filename);
 
-                for filename in USER_CONFIG_FILES {
-                    let config_path = config_dir.join(filename);
-
-                    if config_path.exists() {
-                        // For pyproject.toml, verify it contains [tool.rumdl] section
-                        if *filename == "pyproject.toml" {
-                            if let Ok(content) = std::fs::read_to_string(&config_path) {
-                                if content.contains("[tool.rumdl]") || content.contains("tool.rumdl") {
-                                    log::debug!(
-                                        "[rumdl-config] Found user configuration at: {}",
-                                        config_path.display()
-                                    );
-                                    return Some(config_path);
-                                }
-                                log::debug!("[rumdl-config] Found user pyproject.toml but no [tool.rumdl] section");
-                                continue;
-                            }
-                        } else {
+            if config_path.exists() {
+                // For pyproject.toml, verify it contains [tool.rumdl] section
+                if *filename == "pyproject.toml" {
+                    if let Ok(content) = std::fs::read_to_string(&config_path) {
+                        if content.contains("[tool.rumdl]") || content.contains("tool.rumdl") {
                             log::debug!("[rumdl-config] Found user configuration at: {}", config_path.display());
                             return Some(config_path);
                         }
+                        log::debug!("[rumdl-config] Found user pyproject.toml but no [tool.rumdl] section");
+                        continue;
                     }
+                } else {
+                    log::debug!("[rumdl-config] Found user configuration at: {}", config_path.display());
+                    return Some(config_path);
                 }
+            }
+        }
 
-                log::debug!(
-                    "[rumdl-config] No user configuration found in: {}",
-                    config_dir.display()
-                );
-                None
+        log::debug!(
+            "[rumdl-config] No user configuration found in: {}",
+            config_dir.display()
+        );
+        None
+    }
+
+    /// Discover user-level configuration file from platform-specific config directory.
+    /// Returns the first configuration file found in the user config directory.
+    fn user_configuration_path() -> Option<std::path::PathBuf> {
+        use etcetera::{BaseStrategy, choose_base_strategy};
+
+        match choose_base_strategy() {
+            Ok(strategy) => {
+                let config_dir = strategy.config_dir();
+                Self::user_configuration_path_impl(&config_dir)
             }
             Err(e) => {
                 log::debug!("[rumdl-config] Failed to determine user config directory: {e}");
@@ -1760,12 +1763,13 @@ impl SourcedConfig {
         }
     }
 
-    /// Load and merge configurations from files and CLI overrides.
-    /// If skip_auto_discovery is true, only explicit config paths are loaded.
-    pub fn load_with_discovery(
+    /// Internal implementation that accepts user config directory for testing
+    #[doc(hidden)]
+    pub fn load_with_discovery_impl(
         config_path: Option<&str>,
         cli_overrides: Option<&SourcedGlobalConfig>,
         skip_auto_discovery: bool,
+        user_config_dir: Option<&Path>,
     ) -> Result<Self, ConfigError> {
         use std::env;
         log::debug!("[rumdl-config] Current working directory: {:?}", env::current_dir());
@@ -1831,7 +1835,13 @@ impl SourcedConfig {
         // Only perform auto-discovery if not skipped AND no explicit config path provided
         if !skip_auto_discovery && config_path.is_none() {
             // Step 1: Load user configuration first (as a base)
-            if let Some(user_config_path) = Self::user_configuration_path() {
+            let user_config_path = if let Some(dir) = user_config_dir {
+                Self::user_configuration_path_impl(dir)
+            } else {
+                Self::user_configuration_path()
+            };
+
+            if let Some(user_config_path) = user_config_path {
                 let path_str = user_config_path.display().to_string();
                 let filename = user_config_path.file_name().and_then(|n| n.to_str()).unwrap_or("");
 
@@ -1950,6 +1960,16 @@ impl SourcedConfig {
 
         Ok(sourced_config)
     }
+
+    /// Load and merge configurations from files and CLI overrides.
+    /// If skip_auto_discovery is true, only explicit config paths are loaded.
+    pub fn load_with_discovery(
+        config_path: Option<&str>,
+        cli_overrides: Option<&SourcedGlobalConfig>,
+        skip_auto_discovery: bool,
+    ) -> Result<Self, ConfigError> {
+        Self::load_with_discovery_impl(config_path, cli_overrides, skip_auto_discovery, None)
+    }
 }
 
 impl From<SourcedConfig> for Config {