rumdl 0.0.137__tar.gz → 0.0.138__tar.gz

{rumdl-0.0.137 → rumdl-0.0.138}/CHANGELOG.md

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.0.138] - 2025-09-05
+
+### Fixed
+- **LSP**: Fixed formatting to return empty array instead of null when no edits available (fixes #79)
+  - Helix editor now properly receives LSP formatting responses
+  - Added textDocument/rangeFormatting support for better editor compatibility
+  - Fixed critical position calculation bug that could cause incorrect text edit ranges
+
 ## [0.0.137] - 2025-09-04
 
 ### Fixed
@@ -569,7 +577,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Initial implementation of remaining rules for markdownlint parity
 
-[Unreleased]: https://github.com/rvben/rumdl/compare/v0.0.137...HEAD
+[Unreleased]: https://github.com/rvben/rumdl/compare/v0.0.138...HEAD
+[0.0.138]: https://github.com/rvben/rumdl/compare/v0.0.137...v0.0.138
 [0.0.137]: https://github.com/rvben/rumdl/compare/v0.0.136...v0.0.137
 [0.0.136]: https://github.com/rvben/rumdl/compare/v0.0.135...v0.0.136
 [0.0.135]: https://github.com/rvben/rumdl/compare/v0.0.134...v0.0.135

{rumdl-0.0.137 → rumdl-0.0.138}/Cargo.lock

@@ -1012,9 +1012,9 @@ dependencies = [
 
 [[package]]
 name = "js-sys"
-version = "0.3.77"
+version = "0.3.78"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1cfaf33c695fc6e08064efbc1f72ec937429614f25eef83af942d0e227c3a28f"
+checksum = "0c0b063578492ceec17683ef2f8c5e89121fbd0b172cbc280635ab7567db2738"
 dependencies = [
  "once_cell",
  "wasm-bindgen",
@@ -1632,7 +1632,7 @@ checksum = "caf4aa5b0f434c91fe5c7f1ecb6a5ece2130b02ad2a590589dda5146df959001"
 
 [[package]]
 name = "rumdl"
-version = "0.0.137"
+version = "0.0.138"
 dependencies = [
  "anyhow",
  "assert_cmd",
@@ -2279,21 +2279,22 @@ dependencies = [
 
 [[package]]
 name = "wasm-bindgen"
-version = "0.2.100"
+version = "0.2.101"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1edc8929d7499fc4e8f0be2262a241556cfc54a0bea223790e71446f2aab1ef5"
+checksum = "7e14915cadd45b529bb8d1f343c4ed0ac1de926144b746e2710f9cd05df6603b"
 dependencies = [
  "cfg-if",
  "once_cell",
  "rustversion",
  "wasm-bindgen-macro",
+ "wasm-bindgen-shared",
 ]
 
 [[package]]
 name = "wasm-bindgen-backend"
-version = "0.2.100"
+version = "0.2.101"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2f0a0651a5c2bc21487bde11ee802ccaf4c51935d0d3d42a6101f98161700bc6"
+checksum = "e28d1ba982ca7923fd01448d5c30c6864d0a14109560296a162f80f305fb93bb"
 dependencies = [
  "bumpalo",
  "log",
@@ -2305,9 +2306,9 @@ dependencies = [
 
 [[package]]
 name = "wasm-bindgen-macro"
-version = "0.2.100"
+version = "0.2.101"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7fe63fc6d09ed3792bd0897b314f53de8e16568c2b3f7982f468c0bf9bd0b407"
+checksum = "7c3d463ae3eff775b0c45df9da45d68837702ac35af998361e2c84e7c5ec1b0d"
 dependencies = [
  "quote",
  "wasm-bindgen-macro-support",
@@ -2315,9 +2316,9 @@ dependencies = [
 
 [[package]]
 name = "wasm-bindgen-macro-support"
-version = "0.2.100"
+version = "0.2.101"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8ae87ea40c9f689fc23f209965b6fb8a99ad69aeeb0231408be24920604395de"
+checksum = "7bb4ce89b08211f923caf51d527662b75bdc9c9c7aab40f86dcb9fb85ac552aa"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -2328,18 +2329,18 @@ dependencies = [
 
 [[package]]
 name = "wasm-bindgen-shared"
-version = "0.2.100"
+version = "0.2.101"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1a05d73b933a847d6cccdda8f838a22ff101ad9bf93e33684f39c1f5f0eece3d"
+checksum = "f143854a3b13752c6950862c906306adb27c7e839f7414cec8fea35beab624c1"
 dependencies = [
  "unicode-ident",
 ]
 
 [[package]]
 name = "web-sys"
-version = "0.3.77"
+version = "0.3.78"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "33b6dd2ef9186f1f2072e409e99cd22a975331a6b3591b12c764e0e55c60d5d2"
+checksum = "77e4b637749ff0d92b8fad63aa1f7cff3cbe125fd49c175cd6345e7272638b12"
 dependencies = [
  "js-sys",
  "wasm-bindgen",

{rumdl-0.0.137 → rumdl-0.0.138}/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rumdl"
-version = "0.0.137"
+version = "0.0.138"
 edition = "2024"
 rust-version = "1.89.0"
 description = "A fast Markdown linter written in Rust (Ru(st) MarkDown Linter)"

{rumdl-0.0.137 → rumdl-0.0.138}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rumdl
-Version: 0.0.137
+Version: 0.0.138
 Classifier: Development Status :: 4 - Beta
 Classifier: Environment :: Console
 Classifier: Intended Audience :: Developers

{rumdl-0.0.137 → rumdl-0.0.138}/src/lsp/server.rs

@@ -160,9 +160,18 @@ impl RumdlLanguageServer {
 
     /// Get the end position of a document
     fn get_end_position(&self, text: &str) -> Position {
-        let lines: Vec<&str> = text.lines().collect();
-        let line = lines.len().saturating_sub(1) as u32;
-        let character = lines.last().map_or(0, |l| l.len() as u32);
+        let mut line = 0u32;
+        let mut character = 0u32;
+
+        for ch in text.chars() {
+            if ch == '\n' {
+                line += 1;
+                character = 0;
+            } else {
+                character += 1;
+            }
+        }
+
         Position { line, character }
     }
 
@@ -331,6 +340,7 @@ impl LanguageServer for RumdlLanguageServer {
                 text_document_sync: Some(TextDocumentSyncCapability::Kind(TextDocumentSyncKind::FULL)),
                 code_action_provider: Some(CodeActionProviderCapability::Simple(true)),
                 document_formatting_provider: Some(OneOf::Left(true)),
+                document_range_formatting_provider: Some(OneOf::Left(true)),
                 diagnostic_provider: Some(DiagnosticServerCapabilities::Options(DiagnosticOptions {
                     identifier: Some("rumdl".to_string()),
                     inter_file_dependencies: false,
@@ -489,22 +499,57 @@ impl LanguageServer for RumdlLanguageServer {
         }
     }
 
+    async fn range_formatting(&self, params: DocumentRangeFormattingParams) -> JsonRpcResult<Option<Vec<TextEdit>>> {
+        // For markdown linting, we format the entire document because:
+        // 1. Many markdown rules have document-wide implications (e.g., heading hierarchy, list consistency)
+        // 2. Fixes often need surrounding context to be applied correctly
+        // 3. This approach is common among linters (ESLint, rustfmt, etc. do similar)
+        log::debug!(
+            "Range formatting requested for {:?}, formatting entire document due to rule interdependencies",
+            params.range
+        );
+
+        let formatting_params = DocumentFormattingParams {
+            text_document: params.text_document,
+            options: params.options,
+            work_done_progress_params: params.work_done_progress_params,
+        };
+
+        self.formatting(formatting_params).await
+    }
+
     async fn formatting(&self, params: DocumentFormattingParams) -> JsonRpcResult<Option<Vec<TextEdit>>> {
         let uri = params.text_document.uri;
 
+        log::debug!("Formatting request for: {uri}");
+
         if let Some(text) = self.documents.read().await.get(&uri) {
+            // Get config with LSP overrides
+            let config_guard = self.config.read().await;
+            let lsp_config = config_guard.clone();
+            drop(config_guard);
+
             // Get all rules from config
             let rumdl_config = self.rumdl_config.read().await;
             let all_rules = rules::all_rules(&rumdl_config);
             let flavor = rumdl_config.markdown_flavor();
 
             // Use the standard filter_rules function which respects config's disabled rules
-            let filtered_rules = rules::filter_rules(&all_rules, &rumdl_config.global);
+            let mut filtered_rules = rules::filter_rules(&all_rules, &rumdl_config.global);
             drop(rumdl_config);
 
+            // Apply LSP config overrides
+            filtered_rules = self.apply_lsp_config_overrides(filtered_rules, &lsp_config);
+
             // Lint the document to get all warnings
             match crate::lint(text, &filtered_rules, false, flavor) {
                 Ok(warnings) => {
+                    log::debug!(
+                        "Found {} warnings, {} with fixes",
+                        warnings.len(),
+                        warnings.iter().filter(|w| w.fix.is_some()).count()
+                    );
+
                     // Check if there are any fixable warnings
                     let has_fixes = warnings.iter().any(|w| w.fix.is_some());
 
@@ -514,6 +559,7 @@ impl LanguageServer for RumdlLanguageServer {
                             Ok(fixed_content) => {
                                 // Only return edits if the content actually changed
                                 if fixed_content != *text {
+                                    log::debug!("Returning formatting edits");
                                     // Create a single TextEdit that replaces the entire document
                                     // Calculate proper end position by iterating through all characters
                                     let mut line = 0u32;
@@ -543,18 +589,23 @@ impl LanguageServer for RumdlLanguageServer {
                                 log::error!("Failed to apply fixes: {e}");
                             }
                         }
+                    } else {
+                        log::debug!("No fixes available for formatting");
                     }
 
-                    // No fixes available or applied
-                    Ok(None)
+                    // No fixes available or applied - return empty array
+                    Ok(Some(Vec::new()))
                 }
                 Err(e) => {
                     log::error!("Failed to format document: {e}");
-                    Ok(None)
+                    // Return empty array on error
+                    Ok(Some(Vec::new()))
                 }
             }
         } else {
-            Ok(None)
+            log::warn!("Document not found in cache: {uri}");
+            // Return empty array when document not found
+            Ok(Some(Vec::new()))
         }
     }
 
@@ -826,10 +877,10 @@ mod tests {
         assert_eq!(pos.line, 0);
         assert_eq!(pos.character, 0);
 
-        // Ends with newline - lines() doesn't include the empty line after \n
+        // Ends with newline - position should be at start of next line
         let pos = server.get_end_position("Hello\n");
-        assert_eq!(pos.line, 0);
-        assert_eq!(pos.character, 5);
+        assert_eq!(pos.line, 1);
+        assert_eq!(pos.character, 0);
     }
 
     #[tokio::test]