rosotacom-dev 2.5.dev36__tar.gz → 2.5.dev38__tar.gz

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/DEVELOPMENT_PRINCIPLES.md

@@ -13,10 +13,16 @@ A change is complete only if:
 
 ## Compatibility Policy
 
-Preserve documented CLI behavior and the legacy `start_rosotacom` and
-`stop_rosotacom` entry points. Do not add silent aliases for removed behavior
+Preserve documented CLI behavior. Do not add silent aliases for removed behavior
 unless a migration explicitly requires them.
 
+`rosotacom` is the only console script this package installs. The
+`start_rosotacom` / `stop_rosotacom` entry points were the one standing
+exception to rule 6 above; they were removed on 2026-08-14 because they were
+nothing but `rosotacom start` and `rosotacom stop` under a second name, and a
+second name is what makes a stale shim on a machine indistinguishable from a
+live command. `rosotacom doctor` reports one that is still lying around.
+
 ## Testing Policy
 
 Test public behavior and contracts.

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rosotacom-dev
-Version: 2.5.dev36
+Version: 2.5.dev38
 Summary: Host CLI for ROS OTA communication sessions.
 Author: develNor
 License-Expression: BSD-3-Clause

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/install.sh

@@ -85,8 +85,18 @@ echo "  just setup"
 if [[ "$INSTALL_GLOBAL_SYMLINKS" == true ]]; then
   mkdir -p "$BIN_DIR"
   ln -sf "$VENV_DIR/bin/rosotacom" "$BIN_DIR/rosotacom"
-  ln -sf "$VENV_DIR/bin/start_rosotacom" "$BIN_DIR/start_rosotacom"
-  ln -sf "$VENV_DIR/bin/stop_rosotacom" "$BIN_DIR/stop_rosotacom"
   echo
-  echo "Installed legacy global symlinks into: $BIN_DIR"
+  echo "Installed global symlink into: $BIN_DIR"
+  # `start_rosotacom` / `stop_rosotacom` were entry points until 2026-08-14. A
+  # machine that ran an older install.sh still has their symlinks, and they now
+  # point into a venv whose package no longer provides them. Only links this
+  # script could have written are touched — into THIS checkout's venv, never a
+  # file or a link belonging to something else.
+  for retired in start_rosotacom stop_rosotacom; do
+    link="$BIN_DIR/$retired"
+    if [[ -L "$link" && "$(readlink -- "$link")" == "$VENV_DIR/bin/$retired" ]]; then
+      rm -- "$link"
+      echo "Removed retired symlink: $link  (use 'rosotacom start' / 'rosotacom stop')"
+    fi
+  done
 fi

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/justfile

@@ -19,7 +19,7 @@ format:
 lint:
 	{{python}} -m ruff check .
 	{{python}} -m ruff format --check .
-	{{python}} -m py_compile src/rosotacom/*.py run_session_in_container.py stop_session_in_container.py
+	{{python}} -m py_compile src/rosotacom/*.py
 
 typecheck:
 	{{python}} -m mypy

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/pyproject.toml

@@ -61,8 +61,6 @@ plots = [
 
 [project.scripts]
 rosotacom = "rosotacom.cli:main"
-start_rosotacom = "rosotacom.cli:start_compat_main"
-stop_rosotacom = "rosotacom.cli:stop_compat_main"
 
 [tool.setuptools]
 include-package-data = true

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/src/rosotacom/cli.py

@@ -5676,18 +5676,21 @@ def doctor(args: argparse.Namespace) -> int:
     except Exception as exc:  # noqa: BLE001 - doctor reports all setup failures.
         line("ERROR", "config", str(exc))
 
-    stale = Path.home() / ".local" / "bin" / "start_rosotacom"
-    if stale.exists() or stale.is_symlink():
-        try:
-            target = stale.resolve(strict=False)
-        except OSError:
-            target = Path(os.readlink(stale))
-        if PROJECT_DIR not in [target, *target.parents]:
-            line("WARN", "legacy start_rosotacom", f"{stale} points to {target}, outside this checkout")
-        else:
-            line("OK", "legacy start_rosotacom", f"{stale} points to this checkout")
+    # `start_rosotacom` / `stop_rosotacom` were entry points of this package until
+    # 2026-08-14; `rosotacom start` and `rosotacom stop` are the command. A shim
+    # left behind keeps dispatching through whichever venv it points at, which is
+    # exactly the stale-install confusion this check used to report — so it is a
+    # leftover to delete now, not a second way to run this.
+    retired = [Path.home() / ".local" / "bin" / name for name in ("start_rosotacom", "stop_rosotacom")]
+    leftovers = [p for p in retired if p.exists() or p.is_symlink()]
+    if leftovers:
+        line(
+            "WARN",
+            "retired entry points",
+            f"{', '.join(str(p) for p in leftovers)} — remove; `rosotacom start` / `rosotacom stop` replaced them",
+        )
     else:
-        line("INFO", "legacy start_rosotacom", "no global legacy symlink found")
+        line("OK", "retired entry points", "no start_rosotacom/stop_rosotacom shim left")
 
     tmux = shutil.which("tmux")
     if tmux:
@@ -9757,13 +9760,5 @@ def main(argv: list[str] | None = None) -> int:
         return 1
 
 
-def start_compat_main() -> int:
-    return main(["start", *sys.argv[1:]])
-
-
-def stop_compat_main() -> int:
-    return main(["stop", *sys.argv[1:]])
-
-
 if __name__ == "__main__":
     raise SystemExit(main())

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/src/rosotacom/resources/ws/ros2src/com_py/com_py/universal_ota_unwrapper.py

@@ -11,6 +11,7 @@ from rosidl_runtime_py.utilities import get_message
 
 from com_msgs.msg import OtaStamped
 from com_py.qos import get_topic_qos, load_qos_config
+from com_py.status_overview_core import is_sequence_epoch_reset
 
 
 class UniversalOtaUnwrapperNode(Node):
@@ -142,20 +143,35 @@ class UniversalOtaUnwrapperNode(Node):
             return publisher, typed_cls
 
     def _check_sequence(self, wrapped_topic: str, seq: int):
+        """Say which of the three things a sequence break is.
+
+        A backward jump is either reordering or the sending peer restarting, and
+        this pane log was the last place still calling both "reordering". Three
+        consumers now agree that a jump larger than the transport can reorder is
+        a new epoch -- the live accounting, the transit join and the offline bag
+        join -- and a breadcrumb that disagrees with them costs exactly the time
+        it takes to trust it.
+        """
         last_seq = self._last_seq.get(wrapped_topic)
         self._last_seq[wrapped_topic] = seq
         if last_seq is None:
             return
         expected = last_seq + 1
-        if seq != expected:
-            if seq < last_seq:
-                self.get_logger().warning(
-                    f"[{wrapped_topic}] Sequence reordering detected: received {seq} after {last_seq}"
-                )
-            else:
-                self.get_logger().warning(
-                    f"[{wrapped_topic}] Sequence jump detected: expected {expected}, received {seq}"
-                )
+        if seq == expected:
+            return
+        if is_sequence_epoch_reset(seq, expected):
+            self.get_logger().warning(
+                f"[{wrapped_topic}] Sending peer restarted: sequence begins again at {seq} "
+                f"after {last_seq}. Counts and delays are per epoch from here."
+            )
+        elif seq < last_seq:
+            self.get_logger().warning(
+                f"[{wrapped_topic}] Sequence reordering detected: received {seq} after {last_seq}"
+            )
+        else:
+            self.get_logger().warning(
+                f"[{wrapped_topic}] Sequence jump detected: expected {expected}, received {seq}"
+            )
 
     def unwrapper_callback(self, wrapped_msg: OtaStamped, wrapped_topic: str, out_topic: str):
         try:

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/src/rosotacom_dev.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rosotacom-dev
-Version: 2.5.dev36
+Version: 2.5.dev38
 Summary: Host CLI for ROS OTA communication sessions.
 Author: develNor
 License-Expression: BSD-3-Clause

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/src/rosotacom_dev.egg-info/SOURCES.txt

@@ -14,9 +14,7 @@ justfile
 pyproject.toml
 requirements.txt
 rosotacom.yaml
-run_session_in_container.py
 session-configuration.md
-stop_session_in_container.py
 terminology.md
 .devcontainer/devcontainer.json.template
 .devcontainer/re_generate_devcontainer_json.py
@@ -335,6 +333,7 @@ tests/unit/test_link_bytes.py
 tests/unit/test_link_trace.py
 tests/unit/test_network_profiles.py
 tests/unit/test_network_shaper.py
+tests/unit/test_ota_unwrapper.py
 tests/unit/test_ota_wrapper.py
 tests/unit/test_ota_xml.py
 tests/unit/test_plots.py

rosotacom_dev-2.5.dev38/src/rosotacom_dev.egg-info/entry_points.txt

@@ -0,0 +1,2 @@
+[console_scripts]
+rosotacom = rosotacom.cli:main

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/src/rosotacom_dev.egg-info/scm_file_list.json

@@ -87,7 +87,6 @@
     "pyproject.toml",
     "requirements.txt",
     "rosotacom.yaml",
-    "run_session_in_container.py",
     "session-configuration.md",
     "src/rosotacom/__init__.py",
     "src/rosotacom/__main__.py",
@@ -281,7 +280,6 @@
     "src/rosotacom/trace_profiles.py",
     "src/rosotacom/transit.py",
     "src/rosotacom/video_quality.py",
-    "stop_session_in_container.py",
     "terminology.md",
     "tests/contract/test_benched_set_registry.py",
     "tests/contract/test_findings.py",
@@ -330,6 +328,7 @@
     "tests/unit/test_link_trace.py",
     "tests/unit/test_network_profiles.py",
     "tests/unit/test_network_shaper.py",
+    "tests/unit/test_ota_unwrapper.py",
     "tests/unit/test_ota_wrapper.py",
     "tests/unit/test_ota_xml.py",
     "tests/unit/test_plots.py",

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/src/rosotacom_dev.egg-info/scm_version.json

@@ -1,7 +1,7 @@
 {
   "tag": "2.4",
-  "distance": 36,
-  "node": "gc4530f284a5644a8a04e8fc462e031603e0b4134",
+  "distance": 38,
+  "node": "g7225afdbd611cdd9749c876bb0193dc2911dfd81",
   "dirty": false,
   "branch": "HEAD",
   "node_date": "2026-08-14"

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/tests/contract/test_package_metadata.py

@@ -15,12 +15,20 @@ def test_package_version_is_derived_from_scm_metadata() -> None:
     assert '__version__ = "0.1.0"' not in package_init
 
 
-def test_console_scripts_target_package_cli() -> None:
+def test_rosotacom_is_the_only_console_script() -> None:
+    """One installed command, so a shim in ~/.local/bin cannot be mistaken for it.
+
+    `start_rosotacom` / `stop_rosotacom` were removed on 2026-08-14: they were
+    `rosotacom start` / `rosotacom stop` under a second name (see
+    DEVELOPMENT_PRINCIPLES.md, Compatibility Policy). This pins that no second
+    name comes back.
+    """
     pyproject = (PACKAGE_ROOT / "pyproject.toml").read_text(encoding="utf-8")
+    scripts = pyproject.split("[project.scripts]", 1)[1].split("\n[", 1)[0]
+    entries = [line.split("=", 1)[0].strip() for line in scripts.splitlines() if "=" in line]
 
     assert 'rosotacom = "rosotacom.cli:main"' in pyproject
-    assert 'start_rosotacom = "rosotacom.cli:start_compat_main"' in pyproject
-    assert 'stop_rosotacom = "rosotacom.cli:stop_compat_main"' in pyproject
+    assert entries == ["rosotacom"], entries
 
 
 def test_videoquality_reader_dependencies_are_packaged() -> None:

{rosotacom_dev-2.5.dev36 → rosotacom_dev-2.5.dev38}/tests/unit/test_cli.py

@@ -1990,20 +1990,14 @@ rosbag2_bagfile_information:
     assert "TEST OK" in capsys.readouterr().out
 
 
-def test_start_and_stop_compat_entrypoints_prefix_commands(monkeypatch: pytest.MonkeyPatch) -> None:
-    calls: list[list[str]] = []
-
-    def fake_main(argv: list[str] | None = None) -> int:
-        calls.append(list(argv or []))
-        return 0
+def test_the_retired_compat_entrypoints_are_gone() -> None:
+    """Removed on 2026-08-14 — they were `start`/`stop` under a second name.
 
-    monkeypatch.setattr(rosotacom, "main", fake_main)
-    monkeypatch.setattr(sys, "argv", ["start_rosotacom", "1_heartbeat"])
-    assert rosotacom.start_compat_main() == 0
-    monkeypatch.setattr(sys, "argv", ["stop_rosotacom", "1_heartbeat"])
-    assert rosotacom.stop_compat_main() == 0
-
-    assert calls == [["start", "1_heartbeat"], ["stop", "1_heartbeat"]]
+    Asserting their absence is the point: a re-added alias would otherwise pass
+    every other test in this file silently.
+    """
+    assert not hasattr(rosotacom, "start_compat_main")
+    assert not hasattr(rosotacom, "stop_compat_main")
 
 
 def test_path_yaml_and_network_helpers(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:

rosotacom_dev-2.5.dev38/tests/unit/test_ota_unwrapper.py

@@ -0,0 +1,140 @@
+"""What the unwrapper calls a break in the sequence.
+
+A backward jump is either the transport reordering two messages or the sending
+peer restarting, and they mean opposite things: one is a property of the link,
+the other resets the numbering everything downstream keys on. Three consumers
+already distinguish them — the live status accounting, the transit join and the
+offline bag join — and this pane log was the last place still calling both
+"reordering".
+
+The node imports rclpy, which the host suite does not have, so its ROS surface
+is stubbed before the module is loaded by file path (same approach as
+`tests/unit/test_ota_wrapper.py`).
+"""
+
+from __future__ import annotations
+
+import importlib.util
+import sys
+from collections.abc import Iterator
+from pathlib import Path
+from types import ModuleType, SimpleNamespace
+
+import pytest
+
+REPO_ROOT = Path(__file__).resolve().parents[2]
+COM_PY = REPO_ROOT / "src" / "rosotacom" / "resources" / "ws" / "ros2src" / "com_py" / "com_py"
+UNWRAPPER_PY = COM_PY / "universal_ota_unwrapper.py"
+CORE_PY = COM_PY / "status_overview_core.py"
+
+_STUBBED = (
+    "rclpy",
+    "rclpy.node",
+    "rclpy.serialization",
+    "rosidl_runtime_py",
+    "rosidl_runtime_py.utilities",
+    "com_msgs",
+    "com_msgs.msg",
+    "com_py",
+    "com_py.qos",
+    "com_py.status_overview_core",
+)
+
+
+class _FakeNode:
+    pass
+
+
+def _stub_module(name: str, **attrs: object) -> ModuleType:
+    module = ModuleType(name)
+    for key, value in attrs.items():
+        setattr(module, key, value)
+    sys.modules[name] = module
+    return module
+
+
+def _load(path: Path, name: str) -> ModuleType:
+    spec = importlib.util.spec_from_file_location(name, path)
+    assert spec and spec.loader
+    module = importlib.util.module_from_spec(spec)
+    sys.modules[name] = module
+    spec.loader.exec_module(module)
+    return module
+
+
+@pytest.fixture(scope="module")
+def unwrapper_module() -> Iterator[ModuleType]:
+    saved = {name: sys.modules.get(name) for name in _STUBBED}
+    _stub_module("rclpy", init=lambda *a, **k: None, shutdown=lambda *a, **k: None, spin=lambda *a, **k: None)
+    _stub_module("rclpy.node", Node=_FakeNode)
+    _stub_module("rclpy.serialization", deserialize_message=lambda *a, **k: None)
+    _stub_module("rosidl_runtime_py", utilities=None)
+    _stub_module("rosidl_runtime_py.utilities", get_message=lambda type_str: None)
+    _stub_module("com_msgs", msg=None)
+    _stub_module("com_msgs.msg", OtaStamped=object)
+    _stub_module("com_py", qos=None)
+    _stub_module("com_py.qos", get_topic_qos=lambda *a, **k: None, load_qos_config=lambda *a, **k: {})
+    # The real rule, not a stub: the point of this test is that the unwrapper
+    # and the accounting agree about what a restart is.
+    core = _load(CORE_PY, "rosotacom_status_overview_core_unwrapper")
+    _stub_module("com_py.status_overview_core", is_sequence_epoch_reset=core.is_sequence_epoch_reset)
+
+    module = _load(UNWRAPPER_PY, "rosotacom_universal_ota_unwrapper")
+    yield module
+
+    sys.modules.pop("rosotacom_universal_ota_unwrapper", None)
+    sys.modules.pop("rosotacom_status_overview_core_unwrapper", None)
+    for name, previous in saved.items():
+        if previous is None:
+            sys.modules.pop(name, None)
+        else:
+            sys.modules[name] = previous
+
+
+def _node(unwrapper_module: ModuleType, warnings: list[str]):
+    node = object.__new__(unwrapper_module.UniversalOtaUnwrapperNode)
+    node._last_seq = {}
+    node.get_logger = lambda: SimpleNamespace(
+        warning=warnings.append, error=lambda *a, **k: None, info=lambda *a, **k: None
+    )
+    return node
+
+
+def _feed(unwrapper_module: ModuleType, sequence: list[int]) -> list[str]:
+    warnings: list[str] = []
+    node = _node(unwrapper_module, warnings)
+    for value in sequence:
+        node._check_sequence("/x/ota_stamped", value)
+    return warnings
+
+
+def test_an_uninterrupted_stream_says_nothing(unwrapper_module: ModuleType) -> None:
+    assert _feed(unwrapper_module, list(range(20))) == []
+
+
+def test_a_restart_is_called_a_restart(unwrapper_module: ModuleType) -> None:
+    """The field shape: seq 28983, then the new run's first arrival at 37."""
+    (warning,) = _feed(unwrapper_module, [28982, 28983, 37, 38])
+
+    assert "Sending peer restarted" in warning
+    assert "37" in warning and "28983" in warning
+
+
+def test_a_reset_to_zero_is_a_restart_too(unwrapper_module: ModuleType) -> None:
+    (warning,) = _feed(unwrapper_module, [40, 41, 0, 1])
+    assert "Sending peer restarted" in warning
+
+
+def test_reordering_is_still_reordering(unwrapper_module: ModuleType) -> None:
+    # 1002 after 1000 is a forward gap (one warning); 1001 after 1002 is the
+    # reordering (the second). Both are real and both keep their old words.
+    gap, reorder = _feed(unwrapper_module, [1000, 1002, 1001])
+
+    assert "Sequence jump" in gap
+    assert "reordering" in reorder.lower()
+    assert "restarted" not in reorder
+
+
+def test_a_forward_gap_is_a_jump(unwrapper_module: ModuleType) -> None:
+    (warning,) = _feed(unwrapper_module, [10, 15])
+    assert "Sequence jump" in warning

rosotacom_dev-2.5.dev36/run_session_in_container.py

@@ -1,9 +0,0 @@
-#!/usr/bin/env python3
-"""Compatibility entrypoint for the legacy `start_rosotacom` command."""
-
-from __future__ import annotations
-
-from rosotacom.cli import start_compat_main
-
-if __name__ == "__main__":
-    raise SystemExit(start_compat_main())

rosotacom_dev-2.5.dev36/src/rosotacom_dev.egg-info/entry_points.txt

@@ -1,4 +0,0 @@
-[console_scripts]
-rosotacom = rosotacom.cli:main
-start_rosotacom = rosotacom.cli:start_compat_main
-stop_rosotacom = rosotacom.cli:stop_compat_main

rosotacom_dev-2.5.dev36/stop_session_in_container.py

@@ -1,9 +0,0 @@
-#!/usr/bin/env python3
-"""Compatibility entrypoint for the legacy `stop_rosotacom` command."""
-
-from __future__ import annotations
-
-from rosotacom.cli import stop_compat_main
-
-if __name__ == "__main__":
-    raise SystemExit(stop_compat_main())