rosotacom-dev 2.5.dev2__tar.gz → 2.5.dev3__tar.gz

{rosotacom_dev-2.5.dev2 → rosotacom_dev-2.5.dev3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rosotacom-dev
-Version: 2.5.dev2
+Version: 2.5.dev3
 Summary: Host CLI for ROS OTA communication sessions.
 Author: develNor
 License-Expression: BSD-3-Clause

{rosotacom_dev-2.5.dev2 → rosotacom_dev-2.5.dev3}/src/rosotacom/cli.py

@@ -98,7 +98,19 @@ SESSION_CONFIG_CONTAINER_DIR = "/session/configs"
 SESSION_DEFINITION_CONTAINER_DIR = "/session/definitions"
 SESSION_INSTANCE_CONTAINER_DIR = "/session/instances"
 EXTERNAL_SESSION_CONTAINER_DIR = "/session/current"
-RUN_SESSION_CONTAINER_PATH = "/ws/session/creation/run_session.py"
+# Run through the interpreter, never as a bare path. `docker exec` on a bare
+# path relies on the file's executable bit, and a wheel does not carry
+# executable bits for package data: the bit is present in a checkout and gone
+# after an install. Every packaged machine therefore failed with
+# `exec: "/ws/session/creation/run_session.py": permission denied` and exit 126,
+# while the development laptop — an editable install over the checkout — worked.
+# That is the one shape no test exercised, and the only shape a control centre,
+# a vehicle or a bench machine ever runs.
+#
+# Not relying on the bit beats making the bit survive packaging: one is a
+# property of this command, the other a property of every tool in the chain.
+# `anonymize_bag.py` two thousand lines below already does it this way.
+RUN_SESSION_CONTAINER_ARGV = ("python3", "/ws/session/creation/run_session.py")
 DEFAULT_SMOKE_SESSION = "1_heartbeat"
 OTA_SUDO_MODES = ("passwordless", "askpass")
 
@@ -4299,7 +4311,7 @@ def _session_command(
     link_trace_modem_command: str | None = None,
 ) -> list[str]:
     parts = [
-        RUN_SESSION_CONTAINER_PATH,
+        *RUN_SESSION_CONTAINER_ARGV,
         "--session-dir",
         session.container_dir,
         "--output-dir",

{rosotacom_dev-2.5.dev2 → rosotacom_dev-2.5.dev3}/src/rosotacom_dev.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rosotacom-dev
-Version: 2.5.dev2
+Version: 2.5.dev3
 Summary: Host CLI for ROS OTA communication sessions.
 Author: develNor
 License-Expression: BSD-3-Clause

{rosotacom_dev-2.5.dev2 → rosotacom_dev-2.5.dev3}/src/rosotacom_dev.egg-info/scm_version.json

@@ -1,7 +1,7 @@
 {
   "tag": "2.4",
-  "distance": 2,
-  "node": "gfda483e09a3d70a2b162eb6dad210c288dd33e3d",
+  "distance": 3,
+  "node": "g07f0fe6e171dd825cb669cb2bb14ca0ee6fb0b98",
   "dirty": false,
   "branch": "HEAD",
   "node_date": "2026-08-09"

{rosotacom_dev-2.5.dev2 → rosotacom_dev-2.5.dev3}/tests/unit/test_cli.py

@@ -1759,6 +1759,7 @@ def test_peer_binding_identity_and_command_helpers(tmp_path: Path, monkeypatch:
         peer_address_overrides={"a": "10.0.0.1", "b": "10.0.0.2"},
         attach_mode="attach",
     ) == [
+        "python3",
         "/ws/session/creation/run_session.py",
         "--session-dir",
         "/session/current",
@@ -1801,6 +1802,41 @@ def test_peer_binding_identity_and_command_helpers(tmp_path: Path, monkeypatch:
         rosotacom._parse_peer_address_overrides(["a=1.1.1.1", "a=2.2.2.2"])
 
 
+def test_container_scripts_run_through_the_interpreter() -> None:
+    """No `docker exec` may depend on a file's executable bit.
+
+    A wheel does not carry executable bits for package data, so a bare script
+    path works from a checkout and fails from an install with
+
+        exec: "/ws/session/creation/run_session.py": permission denied
+
+    and exit 126. That broke `rosotacom start` on every packaged machine —
+    bench, control centre, vehicle — while the development laptop's editable
+    install kept working, which is why it survived to a two-host bring-up on
+    2026-08-09 before anyone saw it.
+
+    Asserted as a property rather than as one literal command, so a second
+    script added later fails here instead of on a machine.
+    """
+    assert rosotacom.RUN_SESSION_CONTAINER_ARGV[0] == "python3"
+    assert rosotacom.RUN_SESSION_CONTAINER_ARGV[1].endswith("/run_session.py")
+
+    # And the same for any container script added later. Comment lines are
+    # dropped first: the explanation above quotes the failing path, and a test
+    # that reads prose as code would fail on the wrong thing.
+    code = "\n".join(
+        line
+        for line in Path(rosotacom.__file__).read_text(encoding="utf-8").splitlines()
+        if not line.lstrip().startswith("#")
+    )
+    for match in re.finditer(r'"(/ws/[^"]*\.py)"', code):
+        preceding = code[max(0, match.start() - 200) : match.start()]
+        assert '"python3"' in preceding, (
+            f"{match.group(1)} is handed to the container without an interpreter; "
+            "a wheel install has no executable bit and this fails with exit 126"
+        )
+
+
 def test_resolve_session_and_base_extra_run_args(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
     session = tmp_path / "sessions" / "1_heartbeat"
     session.mkdir(parents=True)