rootly-mcp-server 2.3.1__tar.gz → 2.3.2__tar.gz

{rootly_mcp_server-2.3.1 → rootly_mcp_server-2.3.2}/CHANGELOG.md

@@ -5,6 +5,16 @@ All notable changes to the Rootly MCP Server will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.3.2] - Released 2026-04-23
+
+### Fixed
+
+- **Generated Write Payload Forwarding**: Normalized generated OpenAPI write-tool payloads to unwrap top-level `body` envelopes before forwarding to the Rootly API, fixing failures such as `createWorkflow` returning `Invalid payload ({data: "Expected hash"})`
+
+### Testing
+
+- **Request-Path Regression Coverage**: Added transport regression tests that assert write requests forward unwrapped JSON payloads and preserve already-correct non-envelope payloads
+
 ## [2.3.1] - Released 2026-04-23
 
 ### Fixed

{rootly_mcp_server-2.3.1 → rootly_mcp_server-2.3.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rootly-mcp-server
-Version: 2.3.1
+Version: 2.3.2
 Summary: Secure Model Context Protocol server for Rootly APIs with AI SRE capabilities, comprehensive error handling, and input validation
 Project-URL: Homepage, https://github.com/Rootly-AI-Labs/Rootly-MCP-server
 Project-URL: Issues, https://github.com/Rootly-AI-Labs/Rootly-MCP-server/issues

{rootly_mcp_server-2.3.1 → rootly_mcp_server-2.3.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "rootly-mcp-server"
-version = "2.3.1"
+version = "2.3.2"
 description = "Secure Model Context Protocol server for Rootly APIs with AI SRE capabilities, comprehensive error handling, and input validation"
 readme = "README.md"
 requires-python = ">=3.12"

{rootly_mcp_server-2.3.1 → rootly_mcp_server-2.3.2}/src/rootly_mcp_server/transport.py

@@ -651,6 +651,8 @@ class AuthenticatedHTTPXClient:
         # Transform query parameters
         if "params" in kwargs:
             kwargs["params"] = self._transform_params(kwargs["params"])
+        if "json" in kwargs:
+            kwargs["json"] = self._normalize_request_json_payload(method, kwargs["json"])
 
         # Log incoming headers for debugging (before transformation)
         incoming_headers = kwargs.get("headers", {})
@@ -723,6 +725,23 @@ class AuthenticatedHTTPXClient:
 
         return response
 
+    @staticmethod
+    def _normalize_request_json_payload(method: str, payload: Any) -> Any:
+        """Normalize JSON payloads forwarded by generated tools.
+
+        Some generated write tools expose a top-level `body` parameter, which can
+        result in JSON payloads of shape `{"body": {...}}`. Rootly API write
+        endpoints expect the inner object as the actual request body.
+        """
+        if method.upper() not in {"POST", "PUT", "PATCH"}:
+            return payload
+        if not isinstance(payload, dict):
+            return payload
+        body = payload.get("body")
+        if len(payload) == 1 and isinstance(body, dict):
+            return body
+        return payload
+
     @staticmethod
     def _is_alert_endpoint(url: str) -> bool:
         """Check if a URL is an alert endpoint (but not alert sub-resources like events)."""

{rootly_mcp_server-2.3.1 → rootly_mcp_server-2.3.2}/tests/unit/test_transport_module.py

@@ -523,6 +523,54 @@ class TestTransportModule:
         assert error_context["upstream_path"] == "/v1/alerts"
         assert error_context["upstream_log_level"] == "error"
 
+    @pytest.mark.asyncio
+    async def test_authenticated_client_unwraps_body_envelope_on_write_requests(self):
+        response = httpx.Response(
+            200,
+            request=httpx.Request("POST", "https://api.rootly.com/v1/workflows"),
+            content=b'{"data":{"id":"wf-1"}}',
+        )
+
+        with patch.object(
+            transport.AuthenticatedHTTPXClient, "_get_api_token", return_value="token"
+        ):
+            client = transport.AuthenticatedHTTPXClient(hosted=False, transport="stdio")
+            client.client.request = AsyncMock(return_value=response)
+
+            await client.request(
+                "POST",
+                "/v1/workflows",
+                json={"body": {"genius_workflow": {"name": "MCP verification workflow"}}},
+            )
+
+            _, kwargs = client.client.request.call_args
+            assert kwargs["json"] == {"genius_workflow": {"name": "MCP verification workflow"}}
+
+    @pytest.mark.asyncio
+    async def test_authenticated_client_preserves_non_envelope_payload_on_update_requests(self):
+        response = httpx.Response(
+            200,
+            request=httpx.Request("PATCH", "https://api.rootly.com/v1/workflows/wf-1"),
+            content=b'{"data":{"id":"wf-1"}}',
+        )
+
+        with patch.object(
+            transport.AuthenticatedHTTPXClient, "_get_api_token", return_value="token"
+        ):
+            client = transport.AuthenticatedHTTPXClient(hosted=False, transport="stdio")
+            client.client.request = AsyncMock(return_value=response)
+
+            await client.request(
+                "PATCH",
+                "/v1/workflows/wf-1",
+                json={"data": {"type": "workflows", "attributes": {"name": "Updated"}}},
+            )
+
+            _, kwargs = client.client.request.call_args
+            assert kwargs["json"] == {
+                "data": {"type": "workflows", "attributes": {"name": "Updated"}}
+            }
+
     def test_sanitize_log_excerpt_redacts_tokens_and_paths(self):
         excerpt = transport._sanitize_log_excerpt(
             'Bearer rootly_1234567890 File "/Users/spencercheng/app.py" failed'
@@ -560,6 +608,29 @@ class TestTransportModule:
         assert result["data"][0]["relationships"]["alerts"] == {"count": 2}
         assert "included" not in result
 
+    def test_normalize_request_json_payload_unwraps_body_for_write_methods(self):
+        payload = {"body": {"genius_workflow": {"name": "workflow-name"}}}
+
+        result = transport.AuthenticatedHTTPXClient._normalize_request_json_payload("POST", payload)
+
+        assert result == {"genius_workflow": {"name": "workflow-name"}}
+
+    def test_normalize_request_json_payload_does_not_unwrap_for_get(self):
+        payload = {"body": {"query": "database timeout"}}
+
+        result = transport.AuthenticatedHTTPXClient._normalize_request_json_payload("GET", payload)
+
+        assert result == payload
+
+    def test_normalize_request_json_payload_keeps_non_envelope_dict(self):
+        payload = {"data": {"type": "incidents"}, "body": {"ignored": True}}
+
+        result = transport.AuthenticatedHTTPXClient._normalize_request_json_payload(
+            "PATCH", payload
+        )
+
+        assert result == payload
+
     def test_strip_heavy_user_data_keeps_profile_essentials(self):
         data = {
             "data": [