rom24-quickmud-python 2.5.1__tar.gz → 2.5.3__tar.gz

{rom24_quickmud_python-2.5.1 → rom24_quickmud_python-2.5.3}/CHANGELOG.md

@@ -7,6 +7,47 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.5.2] - 2025-12-30
+
+### Added
+
+- **Command Integration ROM Parity Tests** (70 new tests):
+  - `tests/test_act_comm_rom_parity.py` - 23 tests for communication commands (ROM `act_comm.c`)
+    - Channel status display (`do_channels`)
+    - Communication flag toggles (`do_deaf`, `do_quiet`, `do_afk`)
+    - Channel blocking logic (QUIET, NOCHANNELS flags)
+    - Delete command NPC blocking
+    - Replay command behaviors
+  - `tests/test_act_enter_rom_parity.py` - 22 tests for portal mechanics (ROM `act_enter.c`)
+    - Random room selection with flag exclusions (`get_random_room`)
+    - Portal entry mechanics (closed, curse, trust checks)
+    - Portal charge system and flag handling (RANDOM, BUGGY, GOWITH)
+    - Follower cascading through portals
+  - `tests/test_act_wiz_rom_parity.py` - 25 tests for wiznet/admin commands (ROM `act_wiz.c`)
+    - Wiznet channel toggle and flag management
+    - Wiznet broadcast filtering (WIZ_ON, flag filters, min_level)
+    - Admin commands (freeze, transfer, goto, trust)
+    - Trust level enforcement
+
+- **Documentation**:
+  - `COMMAND_INTEGRATION_PARITY_REPORT.md` - Comprehensive command integration test completion report
+    - Detailed ROM C to Python mapping for all 70 tests
+    - Test philosophy and design decisions
+    - ROM C source analysis summary
+    - Quality metrics and coverage matrix
+
+### Changed
+
+- **ROM 2.4b6 Parity Certification Updates**:
+  - Updated total ROM parity test count: 735 → 805 tests (+70)
+  - Updated total test count: 2507 → 2577 tests (+70)
+  - Added Command Integration Tests section to certification document
+  - Updated ROM C source verification to include `act_comm.c`, `act_enter.c`, `act_wiz.c`
+
+- **Test Coverage**:
+  - Increased command integration test coverage (communication, portal, wiznet modules)
+  - Total ROM parity tests: 805 (127 P0/P1/P2 + 608 combat/spells/skills + 70 command integration)
+
 ## [2.5.1] - 2025-12-30
 
 ### Added

{rom24_quickmud_python-2.5.1/rom24_quickmud_python.egg-info → rom24_quickmud_python-2.5.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rom24-quickmud-python
-Version: 2.5.1
+Version: 2.5.3
 Summary: A modern Python port of the ROM 2.4b6 MUD engine with full telnet server and JSON world loading
 Author-email: Mark Jedrzejczyk <mark.jedrzejczyk@gmail.com>
 Maintainer-email: Mark Jedrzejczyk <mark.jedrzejczyk@gmail.com>
@@ -56,10 +56,10 @@ Dynamic: license-file
 [![Version](https://img.shields.io/badge/version-2.5.0-blue.svg)](https://github.com/avinson/rom24-quickmud)
 [![Python 3.10+](https://img.shields.io/badge/python-3.10+-blue.svg)](https://www.python.org/downloads/)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![Tests](https://img.shields.io/badge/tests-700+%20passing-brightgreen.svg)](https://github.com/Nostoi/rom24-quickmud-python)
+[![Tests](https://img.shields.io/badge/tests-1435%2F1436%20passing-brightgreen.svg)](https://github.com/Nostoi/rom24-quickmud-python)
 [![ROM 2.4b Parity](https://img.shields.io/badge/ROM%202.4b%20Parity-100%25%20CERTIFIED-success.svg)](ROM_2.4B6_PARITY_CERTIFICATION.md)
 [![Function Coverage](https://img.shields.io/badge/ROM%20C%20Functions-96.1%25-blue.svg)](FUNCTION_MAPPING.md)
-[![Integration Tests](https://img.shields.io/badge/integration%20tests-43%2F43%20passing-brightgreen.svg)](tests/integration/)
+[![Integration Tests](https://img.shields.io/badge/integration%20tests-688%2F701%20passing-brightgreen.svg)](tests/integration/)
 
 **QuickMUD is a modern Python port of the legendary ROM 2.4b6 MUD engine**, derived from ROM 2.4b6, Merc 2.1 and DikuMUD. This is a complete rewrite that brings the classic text-based MMORPG experience to modern Python with async networking, JSON world data, and **100% ROM 2.4b behavioral parity**.
 
@@ -77,7 +77,7 @@ A "[Multi-User Dungeon](https://en.wikipedia.org/wiki/MUD)" (MUD) is a text-base
 - **⚔️ ROM Combat System**: Classic ROM combat mechanics and skill system
 - **👥 Social Features**: Say, tell, shout, and 100+ social interactions
 - **🛠️ Admin Commands**: Teleport, spawn, ban management, and OLC building
-- **📊 Comprehensive Testing**: 700+ tests with 43/43 integration tests passing (100%)
+- **📊 Comprehensive Testing**: 1435+ tests with 688/701 integration tests passing (98.1%)
 - **🔧 ROM C-Compatible API**: Public API wrappers for external tools and scripts (27 functions)
 
 ## 📦 Installation
@@ -149,7 +149,7 @@ pip install -e .[dev]
 
 ```bash
 pytest  # Run all tests (~16 seconds)
-pytest tests/integration/ -v  # Run integration tests (43/43 passing)
+pytest tests/integration/ -v  # Run integration tests (688/701 passing)
 ```
 
 ### Development Server
@@ -163,8 +163,8 @@ python -m mud  # Start development server
 - **Version**: 2.5.0 (Production Ready - ROM 2.4b6 Parity Certified)
 - **ROM 2.4b Parity**: ✅ **100% CERTIFIED** ([official certification](ROM_2.4B6_PARITY_CERTIFICATION.md))
 - **ROM C Function Coverage**: 96.1% (716/745 functions mapped)
-- **Test Coverage**: 700+ tests passing, 43/43 integration tests (100%)
-- **Performance**: Full test suite completes in ~16 seconds
+- **Test Coverage**: 1435/1436 tests passing (99.93%), 688/701 integration tests (98.1%)
+- **Performance**: Full test suite completes in ~75 seconds
 - **Compatibility**: Python 3.10+, cross-platform
 
 ## 🏛️ Architecture

{rom24_quickmud_python-2.5.1 → rom24_quickmud_python-2.5.3}/README.md

@@ -3,10 +3,10 @@
 [![Version](https://img.shields.io/badge/version-2.5.0-blue.svg)](https://github.com/avinson/rom24-quickmud)
 [![Python 3.10+](https://img.shields.io/badge/python-3.10+-blue.svg)](https://www.python.org/downloads/)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![Tests](https://img.shields.io/badge/tests-700+%20passing-brightgreen.svg)](https://github.com/Nostoi/rom24-quickmud-python)
+[![Tests](https://img.shields.io/badge/tests-1435%2F1436%20passing-brightgreen.svg)](https://github.com/Nostoi/rom24-quickmud-python)
 [![ROM 2.4b Parity](https://img.shields.io/badge/ROM%202.4b%20Parity-100%25%20CERTIFIED-success.svg)](ROM_2.4B6_PARITY_CERTIFICATION.md)
 [![Function Coverage](https://img.shields.io/badge/ROM%20C%20Functions-96.1%25-blue.svg)](FUNCTION_MAPPING.md)
-[![Integration Tests](https://img.shields.io/badge/integration%20tests-43%2F43%20passing-brightgreen.svg)](tests/integration/)
+[![Integration Tests](https://img.shields.io/badge/integration%20tests-688%2F701%20passing-brightgreen.svg)](tests/integration/)
 
 **QuickMUD is a modern Python port of the legendary ROM 2.4b6 MUD engine**, derived from ROM 2.4b6, Merc 2.1 and DikuMUD. This is a complete rewrite that brings the classic text-based MMORPG experience to modern Python with async networking, JSON world data, and **100% ROM 2.4b behavioral parity**.
 
@@ -24,7 +24,7 @@ A "[Multi-User Dungeon](https://en.wikipedia.org/wiki/MUD)" (MUD) is a text-base
 - **⚔️ ROM Combat System**: Classic ROM combat mechanics and skill system
 - **👥 Social Features**: Say, tell, shout, and 100+ social interactions
 - **🛠️ Admin Commands**: Teleport, spawn, ban management, and OLC building
-- **📊 Comprehensive Testing**: 700+ tests with 43/43 integration tests passing (100%)
+- **📊 Comprehensive Testing**: 1435+ tests with 688/701 integration tests passing (98.1%)
 - **🔧 ROM C-Compatible API**: Public API wrappers for external tools and scripts (27 functions)
 
 ## 📦 Installation
@@ -96,7 +96,7 @@ pip install -e .[dev]
 
 ```bash
 pytest  # Run all tests (~16 seconds)
-pytest tests/integration/ -v  # Run integration tests (43/43 passing)
+pytest tests/integration/ -v  # Run integration tests (688/701 passing)
 ```
 
 ### Development Server
@@ -110,8 +110,8 @@ python -m mud  # Start development server
 - **Version**: 2.5.0 (Production Ready - ROM 2.4b6 Parity Certified)
 - **ROM 2.4b Parity**: ✅ **100% CERTIFIED** ([official certification](ROM_2.4B6_PARITY_CERTIFICATION.md))
 - **ROM C Function Coverage**: 96.1% (716/745 functions mapped)
-- **Test Coverage**: 700+ tests passing, 43/43 integration tests (100%)
-- **Performance**: Full test suite completes in ~16 seconds
+- **Test Coverage**: 1435/1436 tests passing (99.93%), 688/701 integration tests (98.1%)
+- **Performance**: Full test suite completes in ~75 seconds
 - **Compatibility**: Python 3.10+, cross-platform
 
 ## 🏛️ Architecture

rom24_quickmud_python-2.5.3/data/time.json

@@ -0,0 +1,7 @@
+{
+  "hour": 0,
+  "day": 0,
+  "month": 0,
+  "year": 0,
+  "sunlight": 0
+}

{rom24_quickmud_python-2.5.1 → rom24_quickmud_python-2.5.3}/mud/ai/__init__.py

@@ -16,7 +16,8 @@ from mud.models.constants import (
     EX_CLOSED,
 )
 from mud.models.obj import ObjectData
-from mud.models.room import Exit, Room, room_registry
+from mud.models.room import Exit, Room
+from mud.registry import room_registry
 from mud.utils import rng_mm
 from mud.world.movement import move_character
 
@@ -209,14 +210,20 @@ def _room_contents(room: Room | None) -> Iterable[ObjectData]:
 
 
 def _take_object(mob: Character, obj: ObjectData) -> None:
-    room = getattr(obj, "in_room", None) or getattr(mob, "room", None)
+    room = getattr(obj, "in_room", None) or getattr(obj, "location", None) or getattr(mob, "room", None)
     if room is not None:
         contents = getattr(room, "contents", None)
         if isinstance(contents, list) and obj in contents:
             contents.remove(obj)
-    obj.in_room = None
-    obj.in_obj = None
-    obj.carried_by = mob
+
+    if hasattr(obj, "in_room"):
+        obj.in_room = None
+    if hasattr(obj, "location"):
+        obj.location = None
+    if hasattr(obj, "in_obj"):
+        obj.in_obj = None
+    if hasattr(obj, "carried_by"):
+        obj.carried_by = mob
 
     inventory = getattr(mob, "inventory", None)
     if isinstance(inventory, list) and obj not in inventory:
@@ -280,9 +287,8 @@ def _maybe_wander(mob: Character, room: Room) -> None:
     if rng_mm.number_bits(3) != 0:
         return
 
-    door = rng_mm.number_bits(5)
-    if door > int(Direction.DOWN):
-        return
+    # ROM C mob_cmds.c:1274 uses number_door() for random direction
+    door = rng_mm.number_door()
 
     exit_obj = _valid_exit(room, door)
     if exit_obj is None:

{rom24_quickmud_python-2.5.1 → rom24_quickmud_python-2.5.3}/mud/characters/follow.py

@@ -67,4 +67,18 @@ def stop_follower(follower: "Character") -> None:
     follower.leader = None
 
 
-__all__ = ["add_follower", "stop_follower"]
+def die_follower(char: "Character") -> None:
+    """Stop all followers when character dies.
+
+    ROM Reference: src/handler.c die_follower
+    Mirrors ROM behavior: when character dies, all their followers stop following.
+    """
+    from mud.models.character import character_registry
+
+    for follower in list(character_registry):
+        master = getattr(follower, "master", None)
+        if master is char:
+            stop_follower(follower)
+
+
+__all__ = ["add_follower", "stop_follower", "die_follower"]

{rom24_quickmud_python-2.5.1 → rom24_quickmud_python-2.5.3}/mud/combat/death.py

@@ -145,7 +145,9 @@ def _is_floating_slot(slot: str | None, obj: Object) -> bool:
 
 
 def _format_corpse_labels(corpse: Object, name: str) -> None:
-    short_template = getattr(corpse.prototype, "short_descr", None) or getattr(corpse, "short_descr", "the corpse of %s")
+    short_template = getattr(corpse.prototype, "short_descr", None) or getattr(
+        corpse, "short_descr", "the corpse of %s"
+    )
     desc_template = getattr(corpse.prototype, "description", None) or getattr(
         corpse, "description", "The corpse of %s is lying here."
     )
@@ -216,11 +218,7 @@ def _broadcast_neighbor_cry(victim: Character) -> None:
     if room is None:
         return
 
-    message = (
-        "You hear something's death cry."
-        if getattr(victim, "is_npc", False)
-        else "You hear someone's death cry."
-    )
+    message = "You hear something's death cry." if getattr(victim, "is_npc", False) else "You hear someone's death cry."
 
     for exit_data in getattr(room, "exits", []) or []:
         if exit_data is None:
@@ -341,7 +339,7 @@ def death_cry(victim: Character) -> None:
 def _fallback_corpse(vnum: int, *, item_type: ItemType) -> Object:
     """Return a minimal corpse object when the real prototype is missing."""
 
-    proto = ObjIndex(vnum=vnum, short_descr="a corpse", description="The corpse of someone lies here.")
+    proto = ObjIndex(vnum=vnum, short_descr="the corpse of %s", description="The corpse of %s is lying here.")
     proto.item_type = int(item_type)
     corpse = Object(instance_id=None, prototype=proto)
     corpse.item_type = int(item_type)
@@ -368,19 +366,6 @@ def _strip_inventory(victim: Character) -> list[tuple[Object, bool]]:
     return items
 
 
-def _set_corpse_coins(corpse: Object, gold: int, silver: int) -> None:
-    """Persist coin totals on the corpse and mirror into ``value[0:2]``."""
-
-    corpse.gold = gold
-    corpse.silver = silver
-    values = list(getattr(corpse, "value", []) or [])
-    while len(values) < 2:
-        values.append(0)
-    values[0] = gold
-    values[1] = silver
-    corpse.value = values
-
-
 def _handle_corpse_item(
     corpse: Object,
     room,
@@ -445,9 +430,18 @@ def make_corpse(victim: Character) -> Object | None:
 
     gold = max(0, int(getattr(victim, "gold", 0) or 0))
     silver = max(0, int(getattr(victim, "silver", 0) or 0))
-    _set_corpse_coins(corpse, gold, silver)
-    victim.gold = max(0, int(getattr(victim, "gold", 0) or 0) - gold)
-    victim.silver = max(0, int(getattr(victim, "silver", 0) or 0) - silver)
+
+    # ROM C fight.c:1473-1478 - Create money object inside corpse
+    if gold > 0 or silver > 0:
+        from mud.handler import create_money
+
+        money_obj = create_money(gold, silver)
+        if money_obj:
+            corpse.contained_items.append(money_obj)
+            money_obj.location = None  # Inside corpse, not in room
+
+    victim.gold = 0
+    victim.silver = 0
 
     if not is_npc:
         _clear_player_flag(victim, PlayerFlag.CANLOOT)
@@ -557,16 +551,18 @@ def raw_kill(victim: Character) -> Object | None:
     """Handle character death by creating a corpse and removing the victim."""
 
     from mud.combat.engine import stop_fighting as _stop_fighting
-    
+    from mud.characters.follow import die_follower
+
     # Trigger death mobprog handled in apply_damage before raw_kill
     # ROM Reference: src/fight.c:1136-1180 (mp_death_trigger called before raw_kill)
-    
+
+    _nuke_pets(victim, room=getattr(victim, "room", None))
+    die_follower(victim)
     _stop_fighting(victim, True)
     death_cry(victim)
     corpse = make_corpse(victim)
 
     room = getattr(victim, "room", None)
-    _nuke_pets(victim, room)
     if room is not None:
         room.remove_character(victim)
 

{rom24_quickmud_python-2.5.1 → rom24_quickmud_python-2.5.3}/mud/combat/engine.py

@@ -499,6 +499,20 @@ def apply_damage(
     if victim.position == Position.DEAD:
         return "Already dead."
 
+    # Set up fighting state BEFORE defense checks (ROM parity: src/fight.c:damage sets fighting before parry/dodge)
+    if victim != attacker:
+        if victim.position > Position.STUNNED:
+            if victim.fighting is None:
+                set_fighting(victim, attacker)
+                if getattr(victim, "is_npc", False):
+                    mobprog.mp_kill_trigger(victim, attacker)
+            if getattr(victim, "timer", 0) <= 4:
+                victim.position = Position.FIGHTING
+
+        if victim.position > Position.STUNNED:
+            if attacker.fighting is None:
+                set_fighting(attacker, victim)
+
     # Check for parry, dodge, and shield block following C src/fight.c:damage() order
     # These are checked AFTER hit determination but BEFORE damage application
     # Order is critical: shield_block → parry → dodge (per ROM C src/fight.c:one_hit)
@@ -533,23 +547,6 @@ def apply_damage(
         message_bundle = dam_message(attacker, victim, damage, dt, immune)
         _dispatch_damage_messages(attacker, victim, message_bundle)
 
-    # Set up fighting state if not already fighting
-    if victim != attacker:
-        # Victim starts fighting back if able
-        if victim.position > Position.STUNNED:
-            if victim.fighting is None:
-                set_fighting(victim, attacker)
-                if getattr(victim, "is_npc", False):
-                    mobprog.mp_kill_trigger(victim, attacker)
-            # Update victim to fighting position if timer allows
-            if getattr(victim, "timer", 0) <= 4:
-                victim.position = Position.FIGHTING
-
-        # Attacker starts fighting if not already
-        if victim.position > Position.STUNNED:
-            if attacker.fighting is None:
-                set_fighting(attacker, victim)
-
     if damage <= 0:
         if message_bundle and message_bundle.attacker:
             return message_bundle.attacker
@@ -752,30 +749,53 @@ def _object_has_wear_flag(obj, flag: WearFlag) -> bool:
 
 
 def _transfer_corpse_coins(attacker: Character, corpse) -> bool:
-    """Move coins from *corpse* to *attacker*, returning True when any moved."""
+    """Extract gold/silver from money objects and add to attacker's purse.
 
-    try:
-        gold = int(getattr(corpse, "gold", 0) or 0)
-    except (TypeError, ValueError):
-        gold = 0
-    try:
-        silver = int(getattr(corpse, "silver", 0) or 0)
-    except (TypeError, ValueError):
-        silver = 0
+    ROM Reference: src/fight.c auto_loot handles money extraction.
+    QuickMUD uses actual money objects (ItemType.MONEY) instead of corpse attributes.
+    Money objects may already be in attacker's inventory if AUTOLOOT moved them.
+    """
+    from mud.models.constants import ItemType
+
+    contained = list(getattr(corpse, "contained_items", []) or [])
+    attacker_inv = list(getattr(attacker, "inventory", []) or [])
 
-    if gold == 0 and silver == 0:
+    money_in_corpse = [obj for obj in contained if getattr(obj, "item_type", None) == int(ItemType.MONEY)]
+    money_in_inventory = [obj for obj in attacker_inv if getattr(obj, "item_type", None) == int(ItemType.MONEY)]
+
+    all_money_objects = money_in_corpse + money_in_inventory
+
+    if not all_money_objects:
         return False
 
-    attacker.gold = int(getattr(attacker, "gold", 0) or 0) + gold
-    attacker.silver = int(getattr(attacker, "silver", 0) or 0) + silver
-    corpse.gold = 0
-    corpse.silver = 0
-    values = list(getattr(corpse, "value", []) or [])
-    if len(values) < 2:
-        values.extend([0] * (2 - len(values)))
-    values[0] = 0
-    values[1] = 0
-    corpse.value = values
+    total_gold = 0
+    total_silver = 0
+
+    for money_obj in all_money_objects:
+        values = list(getattr(money_obj, "value", [0, 0]) or [0, 0])
+        while len(values) < 2:
+            values.append(0)
+
+        silver = int(values[0] or 0)
+        gold = int(values[1] or 0)
+
+        total_silver += silver
+        total_gold += gold
+
+        if money_obj in money_in_corpse:
+            try:
+                corpse.contained_items.remove(money_obj)
+            except (AttributeError, ValueError):
+                pass
+        else:
+            try:
+                attacker.remove_object(money_obj)
+            except (AttributeError, ValueError):
+                pass
+
+    attacker.gold = int(getattr(attacker, "gold", 0) or 0) + total_gold
+    attacker.silver = int(getattr(attacker, "silver", 0) or 0) + total_silver
+
     return True
 
 

{rom24_quickmud_python-2.5.1 → rom24_quickmud_python-2.5.3}/mud/commands/admin_commands.py

@@ -34,6 +34,8 @@ def cmd_who(char: Character, args: str) -> str:
 
 
 def cmd_teleport(char: Character, args: str) -> str:
+    if char.level < 52:
+        return "You don't have permission to use this command."
     if not args.isdigit() or int(args) not in room_registry:
         return "Invalid room."
     target = room_registry[int(args)]

{rom24_quickmud_python-2.5.1 → rom24_quickmud_python-2.5.3}/mud/commands/advancement.py

@@ -188,9 +188,17 @@ def do_practice(char: Character, args: str) -> str:
     new_value = min(adept, current + increment)
     char.skills[skill_key] = new_value
 
+    # ROM C parity: Send messages to both char and room (src/act_info.c:2767-2777)
     if new_value >= adept:
-        return f"You are now learned at {skill.name}."
-    return f"You practice {skill.name}."
+        char.messages.append(f"You are now learned at {skill.name}.")
+        if char.room:
+            char.room.broadcast(f"{char.name} is now learned at {skill.name}.", exclude=char)
+    else:
+        char.messages.append(f"You practice {skill.name}.")
+        if char.room:
+            char.room.broadcast(f"{char.name} practices {skill.name}.", exclude=char)
+
+    return ""
 
 
 def do_train(char: Character, args: str) -> str:

rom24_quickmud_python-2.5.3/mud/commands/affects.py

@@ -0,0 +1,149 @@
+"""
+Affects command - show active spell/affect effects on character.
+
+ROM Reference: src/act_info.c do_affects (lines 2300-2400)
+"""
+
+from __future__ import annotations
+
+from mud.models.character import Character
+from mud.models.constants import AffectFlag
+
+
+# Mapping of affect flags to human-readable names
+_AFFECT_NAMES = {
+    AffectFlag.BLIND: "blindness",
+    AffectFlag.INVISIBLE: "invisibility",
+    AffectFlag.DETECT_EVIL: "detect evil",
+    AffectFlag.DETECT_INVIS: "detect invisibility",
+    AffectFlag.DETECT_MAGIC: "detect magic",
+    AffectFlag.DETECT_HIDDEN: "detect hidden",
+    AffectFlag.DETECT_GOOD: "detect good",
+    AffectFlag.SANCTUARY: "sanctuary",
+    AffectFlag.FAERIE_FIRE: "faerie fire",
+    AffectFlag.INFRARED: "infrared vision",
+    AffectFlag.CURSE: "curse",
+    AffectFlag.POISON: "poison",
+    AffectFlag.PROTECT_EVIL: "protection evil",
+    AffectFlag.PROTECT_GOOD: "protection good",
+    AffectFlag.SNEAK: "sneak",
+    AffectFlag.HIDE: "hide",
+    AffectFlag.SLEEP: "sleep",
+    AffectFlag.CHARM: "charm",
+    AffectFlag.FLYING: "fly",
+    AffectFlag.PASS_DOOR: "pass door",
+    AffectFlag.HASTE: "haste",
+    AffectFlag.CALM: "calm",
+    AffectFlag.PLAGUE: "plague",
+    AffectFlag.WEAKEN: "weaken",
+    AffectFlag.DARK_VISION: "dark vision",
+    AffectFlag.BERSERK: "berserk",
+    AffectFlag.SWIM: "swim",
+    AffectFlag.REGENERATION: "regeneration",
+    AffectFlag.SLOW: "slow",
+}
+
+
+def affect_loc_name(location: int) -> str:
+    """
+    Return ASCII name of an affect location.
+
+    ROM Reference: src/handler.c affect_loc_name (lines 2718-2775)
+
+    Args:
+        location: APPLY_* constant (0-25)
+
+    Returns:
+        Human-readable location name (e.g., "strength", "armor class", "hit roll")
+    """
+    # ROM C APPLY_* constants (src/merc.h lines 1205-1231)
+    APPLY_NAMES = {
+        0: "none",  # APPLY_NONE
+        1: "strength",  # APPLY_STR
+        2: "dexterity",  # APPLY_DEX
+        3: "intelligence",  # APPLY_INT
+        4: "wisdom",  # APPLY_WIS
+        5: "constitution",  # APPLY_CON
+        6: "sex",  # APPLY_SEX
+        7: "class",  # APPLY_CLASS
+        8: "level",  # APPLY_LEVEL
+        9: "age",  # APPLY_AGE
+        10: "height",  # APPLY_HEIGHT (not shown in ROM affect_loc_name)
+        11: "weight",  # APPLY_WEIGHT (not shown in ROM affect_loc_name)
+        12: "mana",  # APPLY_MANA
+        13: "hp",  # APPLY_HIT
+        14: "moves",  # APPLY_MOVE
+        15: "gold",  # APPLY_GOLD
+        16: "experience",  # APPLY_EXP
+        17: "armor class",  # APPLY_AC
+        18: "hit roll",  # APPLY_HITROLL
+        19: "damage roll",  # APPLY_DAMROLL
+        20: "saves",  # APPLY_SAVES / APPLY_SAVING_PARA
+        21: "save vs rod",  # APPLY_SAVING_ROD
+        22: "save vs petrification",  # APPLY_SAVING_PETRI
+        23: "save vs breath",  # APPLY_SAVING_BREATH
+        24: "save vs spell",  # APPLY_SAVING_SPELL
+        25: "none",  # APPLY_SPELL_AFFECT (returns "none" in ROM C)
+    }
+
+    return APPLY_NAMES.get(location, "(unknown)")
+
+
+def do_affects(char: Character, args: str) -> str:
+    """
+    Display active affects on the character.
+
+    ROM Reference: src/act_info.c do_affects (lines 1714-1755)
+
+    Usage: affects
+
+    Behavior:
+    - Level <20: Shows simple format (spell name only)
+    - Level 20+: Shows detailed format (modifier, location, duration)
+    - Stacked affects (same spell, multiple modifiers): Indented continuation lines
+    """
+    # Primary ROM C behavior: iterate ch.affected list (AFFECT_DATA structures)
+    affected = getattr(char, "affected", [])
+
+    if not affected:
+        return "You are not affected by any spells."
+
+    lines = ["You are affected by the following spells:"]
+    paf_last = None
+
+    for paf in affected:
+        # Deduplication: check if same spell as previous affect
+        if paf_last and paf.type == paf_last.type:
+            if char.level >= 20:
+                # Level 20+: Show duplicate affects with indentation (22 spaces + ": ")
+                buf = " " * 22 + ": "
+            else:
+                # Level <20: Skip duplicate spells entirely
+                continue
+        else:
+            # New spell: show spell name (left-aligned, 15 chars)
+            # TODO: Replace with proper skill_table[paf.type].name lookup when SN mapping is available
+            # For now, assume paf.type is already a skill name string (temporary until spell system updated)
+            spell_name = str(paf.type) if paf.type else "(unknown)"
+
+            buf = f"Spell: {spell_name:15s}"
+
+        # Level 20+: Show detailed modifier information
+        if char.level >= 20:
+            location_name = affect_loc_name(paf.location)
+
+            # ROM C line 1737: uses raw %d (no explicit + sign)
+            modifier_str = str(paf.modifier)
+
+            if paf.duration == -1:
+                duration_str = "permanently"
+            else:
+                duration_str = f"for {paf.duration} hours"
+
+            # ROM C line 1736: ": modifies..." (colon prefix)
+            buf += f": modifies {location_name} by {modifier_str} {duration_str}"
+
+        lines.append(buf)
+        paf_last = paf
+
+    return "\n".join(lines)