rom24-quickmud-python 2.5.0__tar.gz → 2.5.2__tar.gz

{rom24_quickmud_python-2.5.0 → rom24_quickmud_python-2.5.2}/CHANGELOG.md

@@ -7,6 +7,58 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.5.2] - 2025-12-30
+
+### Added
+
+- **Command Integration ROM Parity Tests** (70 new tests):
+  - `tests/test_act_comm_rom_parity.py` - 23 tests for communication commands (ROM `act_comm.c`)
+    - Channel status display (`do_channels`)
+    - Communication flag toggles (`do_deaf`, `do_quiet`, `do_afk`)
+    - Channel blocking logic (QUIET, NOCHANNELS flags)
+    - Delete command NPC blocking
+    - Replay command behaviors
+  - `tests/test_act_enter_rom_parity.py` - 22 tests for portal mechanics (ROM `act_enter.c`)
+    - Random room selection with flag exclusions (`get_random_room`)
+    - Portal entry mechanics (closed, curse, trust checks)
+    - Portal charge system and flag handling (RANDOM, BUGGY, GOWITH)
+    - Follower cascading through portals
+  - `tests/test_act_wiz_rom_parity.py` - 25 tests for wiznet/admin commands (ROM `act_wiz.c`)
+    - Wiznet channel toggle and flag management
+    - Wiznet broadcast filtering (WIZ_ON, flag filters, min_level)
+    - Admin commands (freeze, transfer, goto, trust)
+    - Trust level enforcement
+
+- **Documentation**:
+  - `COMMAND_INTEGRATION_PARITY_REPORT.md` - Comprehensive command integration test completion report
+    - Detailed ROM C to Python mapping for all 70 tests
+    - Test philosophy and design decisions
+    - ROM C source analysis summary
+    - Quality metrics and coverage matrix
+
+### Changed
+
+- **ROM 2.4b6 Parity Certification Updates**:
+  - Updated total ROM parity test count: 735 → 805 tests (+70)
+  - Updated total test count: 2507 → 2577 tests (+70)
+  - Added Command Integration Tests section to certification document
+  - Updated ROM C source verification to include `act_comm.c`, `act_enter.c`, `act_wiz.c`
+
+- **Test Coverage**:
+  - Increased command integration test coverage (communication, portal, wiznet modules)
+  - Total ROM parity tests: 805 (127 P0/P1/P2 + 608 combat/spells/skills + 70 command integration)
+
+## [2.5.1] - 2025-12-30
+
+### Added
+
+- **Session Summary Documentation**:
+  - `P0_P1_P2_EXTENDED_TESTING_SESSION_SUMMARY.md` - Verification session summary documenting that all P0/P1/P2 ROM C parity tests were already complete from previous sessions (December 29-30, 2025)
+
+### Changed
+
+- Updated README badges and project status to reflect complete ROM C parity test coverage (735 total ROM parity tests including 127 P0/P1/P2 formula verification tests)
+
 ## [2.5.0] - 2025-12-29
 
 ### Added

{rom24_quickmud_python-2.5.0/rom24_quickmud_python.egg-info → rom24_quickmud_python-2.5.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rom24-quickmud-python
-Version: 2.5.0
+Version: 2.5.2
 Summary: A modern Python port of the ROM 2.4b6 MUD engine with full telnet server and JSON world loading
 Author-email: Mark Jedrzejczyk <mark.jedrzejczyk@gmail.com>
 Maintainer-email: Mark Jedrzejczyk <mark.jedrzejczyk@gmail.com>

{rom24_quickmud_python-2.5.0 → rom24_quickmud_python-2.5.2}/mud/commands/combat.py

@@ -246,14 +246,17 @@ def do_rescue(char: Character, args: str) -> str:
 
 
 def _find_room_target(char: Character, name: str) -> Character | None:
+    """Find a character in the same room by name.
+
+    ROM Reference: src/act_info.c get_char_room()
+    Note: ROM allows finding self - individual commands check victim == ch.
+    """
     room = getattr(char, "room", None)
     if room is None or not name:
         return None
 
     lowered = name.lower()
     for candidate in getattr(room, "people", []) or []:
-        if candidate is char:
-            continue
         candidate_name = getattr(candidate, "name", "") or ""
         if lowered in candidate_name.lower():
             return candidate
@@ -797,51 +800,22 @@ def do_dirt(char: Character, args: str) -> str:
         if victim is None:
             return "They aren't here."
 
-    # Check if already blinded
+    # Match ROM safety/validation gates in the command layer.
+    if victim is char:
+        return "Very funny."
+
     victim_affected = getattr(victim, "affected_by", 0)
     if victim_affected & AffectFlag.BLIND:
         return "They're already blinded."
 
-    if victim is char:
-        return "Very funny."
-
-    # Safety checks
     safety_msg = _kill_safety_message(char, victim)
     if safety_msg:
         return safety_msg
 
-    # Calculate chance
-    chance = skill_level
-    char_dex = skill_handlers._coerce_int(
-        getattr(char, "perm_stat", [13] * 5)[1] if isinstance(getattr(char, "perm_stat", []), list) else 13
-    )
-    victim_dex = skill_handlers._coerce_int(
-        getattr(victim, "perm_stat", [13] * 5)[1] if isinstance(getattr(victim, "perm_stat", []), list) else 13
-    )
-    chance += char_dex - 2 * victim_dex
-
-    # Level modifier
-    char_level = skill_handlers._coerce_int(getattr(char, "level", 1))
-    victim_level = skill_handlers._coerce_int(getattr(victim, "level", 1))
-    chance += (char_level - victim_level) * 2
-
-    # Roll
-    if rng_mm.number_percent() < chance:
-        # Success - blind the victim
-        victim.affected_by = victim_affected | AffectFlag.BLIND
-        skill_registry._apply_wait_state(char, get_pulse_violence())
-
-        # Start combat if not already fighting
-        if not getattr(char, "fighting", None):
-            char.fighting = victim
-        if not getattr(victim, "fighting", None):
-            victim.fighting = char
-
-        check_killer(char, victim)
-        return f"You kick dirt into {getattr(victim, 'name', 'their')} eyes!"
-    else:
-        skill_registry._apply_wait_state(char, get_pulse_violence())
-        return "You kick dirt but miss their eyes."
+    # Delegate parity math/effects to the skill handler.
+    result = skill_handlers.dirt_kicking(char, target=victim)
+    check_killer(char, victim)
+    return result
 
 
 def do_trip(char: Character, args: str) -> str:
@@ -943,57 +917,21 @@ def do_disarm(char: Character, args: str) -> str:
     if victim is None:
         return "You aren't fighting anyone."
 
-    # Victim must be wielding a weapon
-    victim_equipped = getattr(victim, "equipped", {})
-    victim_weapon = victim_equipped.get("wield") or victim_equipped.get("main_hand")
-    if victim_weapon is None:
-        return "Your opponent is not wielding a weapon."
-
-    # Attacker should have weapon (or hand-to-hand skill)
-    char_equipped = getattr(char, "equipped", {})
-    char_weapon = char_equipped.get("wield") or char_equipped.get("main_hand")
+    # Attacker must have a weapon, or meet ROM hand-to-hand / NPC OFF_DISARM exception.
+    caster_weapon = get_wielded_weapon(char)
     hth_skill = char.skills.get("hand to hand", 0)
-
-    if char_weapon is None and hth_skill == 0:
+    if caster_weapon is None and hth_skill == 0:
         return "You must wield a weapon to disarm."
 
-    # Calculate chance
-    if char_weapon is None:
-        chance = skill_level * hth_skill // 150
-    else:
-        chance = skill_level
-
-    # Dex vs Str
-    char_dex = skill_handlers._coerce_int(
-        getattr(char, "perm_stat", [13] * 5)[1] if isinstance(getattr(char, "perm_stat", []), list) else 13
-    )
-    victim_str = skill_handlers._coerce_int(
-        getattr(victim, "perm_stat", [13] * 5)[0] if isinstance(getattr(victim, "perm_stat", []), list) else 13
-    )
-    chance += char_dex - 2 * victim_str
-
-    # Level modifier
-    char_level = skill_handlers._coerce_int(getattr(char, "level", 1))
-    victim_level = skill_handlers._coerce_int(getattr(victim, "level", 1))
-    chance += (char_level - victim_level) * 2
-
-    skill_registry._apply_wait_state(char, get_pulse_violence())
+    # Victim must be wielding a weapon
+    victim_weapon = get_wielded_weapon(victim)
+    if victim_weapon is None:
+        return "Your opponent is not wielding a weapon."
 
-    # Roll
-    if rng_mm.number_percent() < chance:
-        # Success - remove weapon from victim
-        if "wield" in victim_equipped:
-            del victim_equipped["wield"]
-        elif "main_hand" in victim_equipped:
-            del victim_equipped["main_hand"]
-
-        # Drop to room
-        victim_room = getattr(victim, "room", None)
-        if victim_room and hasattr(victim_room, "contents"):
-            victim_room.contents.append(victim_weapon)
-            victim_weapon.in_room = victim_room
+    success = skill_handlers.disarm(char, target=victim)
+    check_killer(char, victim)
 
-        check_killer(char, victim)
-        return f"You disarm {getattr(victim, 'name', 'them')}!"
-    else:
-        return f"You fail to disarm {getattr(victim, 'name', 'them')}."
+    victim_name = getattr(victim, "name", "them")
+    if success:
+        return f"You disarm {victim_name}!"
+    return f"You fail to disarm {victim_name}."

{rom24_quickmud_python-2.5.0 → rom24_quickmud_python-2.5.2}/mud/commands/healer.py

@@ -21,16 +21,16 @@ def _find_healer(char: Character) -> object | None:
 
 
 PRICE_GOLD = {
-    "light": 10,
-    "serious": 15,
-    "critical": 25,
-    "heal": 50,
-    "blindness": 20,
-    "disease": 15,
-    "poison": 25,
-    "uncurse": 50,
-    "refresh": 5,
-    "mana": 10,
+    "light": 10,  # ROM healer.c:88: cost = 1000 (10 gold)
+    "serious": 16,  # ROM healer.c:96: cost = 1600 (16 gold) - NOTE: Display says 15g but actual cost is 16g!
+    "critical": 25,  # ROM healer.c:104: cost = 2500 (25 gold)
+    "heal": 50,  # ROM healer.c:112: cost = 5000 (50 gold)
+    "blindness": 20,  # ROM healer.c:120: cost = 2000 (20 gold)
+    "disease": 15,  # ROM healer.c:128: cost = 1500 (15 gold)
+    "poison": 25,  # ROM healer.c:136: cost = 2500 (25 gold)
+    "uncurse": 50,  # ROM healer.c:144: cost = 5000 (50 gold)
+    "refresh": 5,  # ROM healer.c:161: cost = 500 (5 gold)
+    "mana": 10,  # ROM healer.c:152: cost = 1000 (10 gold)
 }
 
 

{rom24_quickmud_python-2.5.0 → rom24_quickmud_python-2.5.2}/mud/commands/magic_items.py

@@ -152,8 +152,7 @@ def do_recite(ch: Character, args: str) -> str:
     if not scroll:
         return "You do not have that scroll."
 
-    # Check if it's actually a scroll
-    if scroll.item_type != ItemType.ITEM_SCROLL:
+    if scroll.item_type != ItemType.SCROLL:
         return "You can recite only scrolls."
 
     # Check level requirement

{rom24_quickmud_python-2.5.0 → rom24_quickmud_python-2.5.2}/mud/game_loop.py

@@ -198,10 +198,12 @@ def hit_gain(character: Character) -> int:
     gain = gain * getattr(room, "heal_rate", 100) // 100
 
     furniture = getattr(character, "on", None)
-    if furniture is not None and getattr(furniture, "item_type", None) == ItemType.FURNITURE:
-        values = getattr(furniture, "value", [100, 100, 100, 100, 100])
-        if len(values) > 3:
-            gain = gain * int(values[3]) // 100
+    if furniture is not None:
+        item_type = getattr(furniture.prototype, "item_type", None)
+        if item_type == ItemType.FURNITURE or item_type == int(ItemType.FURNITURE):
+            values = getattr(furniture, "value", [100, 100, 100, 100, 100])
+            if len(values) > 3:
+                gain = gain * int(values[3]) // 100
 
     if _has_affect(character, AffectFlag.POISON):
         gain //= 4
@@ -262,13 +264,15 @@ def mana_gain(character: Character) -> int:
             if character.pcdata.condition[Condition.THIRST] == 0:
                 gain //= 2
 
-    gain = gain * getattr(room, "mana_rate", 100) // 100
+    gain = gain * getattr(room, "heal_rate", 100) // 100
 
     furniture = getattr(character, "on", None)
-    if furniture is not None and getattr(furniture, "item_type", None) == ItemType.FURNITURE:
-        values = getattr(furniture, "value", [100, 100, 100, 100, 100])
-        if len(values) > 4:
-            gain = gain * int(values[4]) // 100
+    if furniture is not None:
+        item_type = getattr(furniture.prototype, "item_type", None)
+        if item_type == ItemType.FURNITURE or item_type == int(ItemType.FURNITURE):
+            values = getattr(furniture, "value", [100, 100, 100, 100, 100])
+            if len(values) > 3:
+                gain = gain * int(values[3]) // 100
 
     if _has_affect(character, AffectFlag.POISON):
         gain //= 4
@@ -307,10 +311,12 @@ def move_gain(character: Character) -> int:
     gain = gain * getattr(room, "heal_rate", 100) // 100
 
     furniture = getattr(character, "on", None)
-    if furniture is not None and getattr(furniture, "item_type", None) == ItemType.FURNITURE:
-        values = getattr(furniture, "value", [100, 100, 100, 100, 100])
-        if len(values) > 3:
-            gain = gain * int(values[3]) // 100
+    if furniture is not None:
+        item_type = getattr(furniture.prototype, "item_type", None)
+        if item_type == ItemType.FURNITURE or item_type == int(ItemType.FURNITURE):
+            values = getattr(furniture, "value", [100, 100, 100, 100, 100])
+            if len(values) > 3:
+                gain = gain * int(values[3]) // 100
 
     if _has_affect(character, AffectFlag.POISON):
         gain //= 4

{rom24_quickmud_python-2.5.0 → rom24_quickmud_python-2.5.2}/mud/models/character.py

@@ -260,20 +260,20 @@ class Character:
     description: str | None = None
     prompt: str | None = None
     prefix: str | None = None
-    
+
     # Class/Race/Clan
     sex: int = 0
     ch_class: int = 0
     race: int = 0
     clan: int = 0
     group: int = 0  # Group number for area repop (ROM: sh_int group)
-    
+
     # Levels and trust
     level: int = 0
     trust: int = 0
     invis_level: int = 0
     incog_level: int = 0
-    
+
     # Stats
     hit: int = 0
     max_hit: int = 0
@@ -284,76 +284,77 @@ class Character:
     gold: int = 0
     silver: int = 0
     exp: int = 0
-    
+
     # Flags
     act: int = 0
     affected_by: int = 0
-    
+
     # Location
     position: int = Position.STANDING
     room: Room | None = None  # ROM: in_room
     was_in_room: Room | None = None  # ROM: was_in_room
     zone: object | None = None  # ROM: AREA_DATA *zone
-    
+
     # Relationships
     master: Character | None = None
     leader: Character | None = None
     pet: "Character | None" = None
     reply: Character | None = None  # ROM: reply target for tells
     mprog_target: "Character | None" = None  # ROM: mob program target
-    
+    on: "Object | None" = None  # ROM: furniture character is sitting/resting on (affects heal rate)
+
     # Skills and training
     practice: int = 0
     train: int = 0
     skills: dict[str, int] = field(default_factory=dict)
-    
+
     # Encumbrance
     carry_weight: int = 0
     carry_number: int = 0
-    
+
     # Combat stats
     saving_throw: int = 0
     alignment: int = 0
     hitroll: int = 0
     damroll: int = 0
     wimpy: int = 0
-    
+
     # Display/UI
     lines: int = DEFAULT_PAGE_LINES
     newbie_help_seen: bool = False
-    
+
     # Time tracking
     played: int = 0
     logon: int = 0
     timer: int = 0  # ROM: idle timer
-    
+
     # Stats (permanent and temporary modifiers)
     perm_stat: list[int] = field(default_factory=list)
     mod_stat: list[int] = field(default_factory=list)
-    
+
     # Body form and parts
     form: int = 0
     parts: int = 0
     size: int = 0
     material: str | None = None
     off_flags: int = 0
-    
+
     # ROM parity: immunity/resistance/vulnerability bitvectors (merc.h)
     imm_flags: int = 0
     res_flags: int = 0
     vuln_flags: int = 0
-    
+
     # Damage and attack type
     damage: list[int] = field(default_factory=lambda: [0, 0, 0])
     dam_type: int = 0
     start_pos: int = 0
     default_pos: int = 0
-    
+
     # Mob programs
     mprog_delay: int = 0
     mob_programs: list[MobProgram] = field(default_factory=list)
     spec_fun: str | None = None  # ROM: special function name
-    
+
     # Custom fields (Python-specific)
     hometown_vnum: int = 0
     pcdata: PCData | None = None
@@ -365,7 +366,7 @@ class Character:
     connection: object | None = None
     desc: object | None = None  # ROM: DESCRIPTOR_DATA
     is_admin: bool = False
-    
+
     # Communication and channels
     imc_permission: str = "Mort"  # IMC permission level (Notset/None/Mort/Imm/Admin/Imp)
     muted_channels: set[str] = field(default_factory=set)
@@ -374,33 +375,33 @@ class Character:
     wiznet: int = 0  # ROM: wiznet flags
     comm: int = 0  # ROM: comm flags
     log_commands: bool = False  # Per-character admin logging flag mirroring ROM PLR_LOG
-    
+
     # Wait state and delays
     wait: int = 0  # Wait-state (pulses) applied by actions like movement (ROM WAIT_STATE)
     daze: int = 0  # Daze (pulses) — separate action delay used by ROM combat
-    
+
     # Armor class per index [AC_PIERCE, AC_BASH, AC_SLASH, AC_EXOTIC]
     armor: list[int] = field(default_factory=lambda: [100, 100, 100, 100])
-    
+
     # Per-character command aliases: name -> expansion (pre-dispatch)
     aliases: dict[str, str] = field(default_factory=dict)
-    
+
     # Optional defense chances (percent) for parity-friendly tests
     shield_block_chance: int = 0
     parry_chance: int = 0
     dodge_chance: int = 0
-    
+
     # Combat skill levels (0-100) for multi-attack mechanics
     second_attack_skill: int = 0
     third_attack_skill: int = 0
     enhanced_damage_skill: int = 0  # Enhanced damage skill level (0-100)
-    
+
     # Combat state - currently fighting target
     fighting: Character | None = None
-    
+
     # Character type flag
     is_npc: bool = True  # Default to NPC, set to False for PCs
-    
+
     # Spell effects and character generation
     spell_effects: dict[str, SpellEffect] = field(default_factory=dict)  # Active spell effects keyed by skill name
     default_weapon_vnum: int = 0

{rom24_quickmud_python-2.5.0 → rom24_quickmud_python-2.5.2}/mud/skills/handlers.py

@@ -1354,7 +1354,7 @@ def bless(caster: Character, target: Character | None = None) -> bool:
     if target is None:
         raise ValueError("bless requires a target")
 
-    if target.position == Position.FIGHTING:
+    if target.position == Position.FIGHTING or target.has_spell_effect("bless"):
         return False
 
     level = max(getattr(caster, "level", 0), 0)
@@ -1890,31 +1890,29 @@ def chain_lightning(caster: Character, target: Character | None = None) -> bool:
             if level <= 0:
                 break
 
-        if found or level <= 0:
-            continue
+        if not found:
+            if last_victim is caster:
+                broadcast_room(
+                    room,
+                    "The bolt seems to have fizzled out.",
+                    exclude=caster,
+                )
+                _send_to_char(caster, "The bolt grounds out through your body.")
+                break
 
-        if last_victim is caster:
+            last_victim = caster
             broadcast_room(
                 room,
-                "The bolt seems to have fizzled out.",
+                f"The bolt arcs to {caster_name}...whoops!",
                 exclude=caster,
             )
-            _send_to_char(caster, "The bolt grounds out through your body.")
-            break
-
-        last_victim = caster
-        broadcast_room(
-            room,
-            f"The bolt arcs to {caster_name}...whoops!",
-            exclude=caster,
-        )
-        _send_to_char(caster, "You are struck by your own lightning!")
-        damage = rng_mm.dice(level, 6)
-        if saves_spell(level, caster, DamageType.LIGHTNING):
-            damage = c_div(damage, 3)
-        apply_damage(caster, caster, damage, DamageType.LIGHTNING, dt="chain lightning")
-        any_hit = any_hit or damage > 0
-        level -= 4
+            _send_to_char(caster, "You are struck by your own lightning!")
+            damage = rng_mm.dice(level, 6)
+            if saves_spell(level, caster, DamageType.LIGHTNING):
+                damage = c_div(damage, 3)
+            apply_damage(caster, caster, damage, DamageType.LIGHTNING, dt="chain lightning")
+            any_hit = any_hit or damage > 0
+            level -= 4
 
     return any_hit
 
@@ -3100,7 +3098,11 @@ def disarm(caster: Character, target: Character | None = None) -> bool:
         victim_weapon.wear_loc = int(WearLocation.NONE)
 
     drop_room = getattr(victim, "room", None)
-    if drop_room is not None and hasattr(drop_room, "add_object"):
+
+    # ROM src/fight.c:2258-2265 - ITEM_NODROP/ITEM_INVENTORY keep weapon on victim.
+    if extra_flags & (int(ExtraFlag.NODROP) | int(ExtraFlag.INVENTORY)):
+        victim.add_object(victim_weapon)
+    elif drop_room is not None and hasattr(drop_room, "add_object"):
         drop_room.add_object(victim_weapon)
     else:
         victim.add_object(victim_weapon)