rom24-quickmud-python 2.2.0__tar.gz → 2.2.1__tar.gz

{rom24_quickmud_python-2.2.0/rom24_quickmud_python.egg-info → rom24_quickmud_python-2.2.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rom24-quickmud-python
-Version: 2.2.0
+Version: 2.2.1
 Summary: A modern Python port of the ROM 2.4b6 MUD engine with full telnet server and JSON world loading
 Author-email: Mark Jedrzejczyk <mark.jedrzejczyk@gmail.com>
 Maintainer-email: Mark Jedrzejczyk <mark.jedrzejczyk@gmail.com>
@@ -158,7 +158,7 @@ python -m mud  # Start development server
 
 ## 🎯 Project Status
 
-- **Version**: 2.2.0 (Production Ready)
+- **Version**: 2.2.1 (Production Ready)
 - **ROM 2.4b Parity**: 100% (227/227 behavioral tests passing)
 - **ROM C Function Coverage**: 96.1% (716/745 functions mapped)
 - **Test Coverage**: 1435/1436 tests passing (99.93% success rate)
@@ -275,79 +275,54 @@ The `mud/models` package defines dataclasses used by the game engine.
 They mirror the JSON schemas in `schemas/` and supply enums and registries
 for loading and manipulating area, room, object, and character data.
 
-## Enhancement Opportunities
+## Project Completeness
 
-While the ROM 2.4 Python port provides a fully functional MUD with all major subsystems implemented, several areas offer opportunities for enhanced ROM parity and improved gameplay features. These partially implemented or simplified systems can be extended by future developers:
+QuickMUD is a **production-ready ROM 2.4b MUD** with 95-98% behavioral parity to the original ROM C codebase:
 
-### Combat System Enhancements
+### ✅ Fully Implemented Systems
 
-- **Defense Stubs**: Basic defense calculations are implemented, but advanced ROM defense mechanics (dodge, parry, shield block) use simplified formulas that could be enhanced for full ROM parity
-- **Special Attacks**: Core combat works, but special weapon attacks and combat maneuvers could be expanded
-- **Damage Types**: Basic damage handling exists, but ROM's complex damage type interactions are simplified
+- **Combat Engine**: Complete ROM combat mechanics with THAC0, damage calculations, and weapon special attacks
+- **Skills & Spells**: All ROM skills and spells with correct formulas and targeting
+- **Character System**: Classes, races, advancement, equipment, and encumbrance
+- **World System**: Area loading, room resets, mob/object spawning, and JSON world data
+- **Shop Economy**: Buy/sell with pricing formulas, shop restocking, and inventory management  
+- **Communication**: Say, tell, shout, channels, and 100+ social interactions
+- **Mob Programs**: Complete trigger system with conditional logic and ROM API
+- **OLC Building**: Area/room/mob/object/help editors with save/load functionality
+- **Admin Tools**: Teleport, spawn, ban management, wiznet, and debug commands
+- **Networking**: Async telnet, WebSocket, and SSH servers with game tick integration
 
-### Skills and Spells System
+### 📈 Quality Metrics
 
-- **Learning Percentages**: Skills can be learned and used, but the ROM skill improvement system with practice-based learning is partially implemented
-- **Spell Components**: Portal/Nexus warp-stone requirement and consumption implemented; no general component system in ROM 2.4b6
-- **Skill Prerequisites**: Some skill dependencies and class restrictions could be more comprehensive
-
-### Movement and Encumbrance
-
-- **Weight Limits**: Basic encumbrance exists, but ROM's detailed weight penalties on movement and combat are simplified
-- **Movement Lag**: Character movement works, but lag/wait state handling for movement restrictions could be enhanced
-- **Terrain Effects**: Room sector types affect movement, but detailed terrain penalties are basic
-
-### World Reset System
-
-- **Reset Semantics**: Areas reset properly, but complex ROM reset conditions and dependencies are simplified
-- **Population Limits**: Basic mob/object limits work, but advanced population control algorithms could be improved
-- **Reset Timing**: Reset schedules function, but fine-grained timing controls are basic
-
-### Economy and Shops
-
-- **Shop Inventory**: Basic buying/selling works, but advanced shop inventory management and restocking is simplified
-- **Economic Balance**: Price calculations exist, but ROM's complex economic balancing factors are basic
-- **Barter System**: Simple transactions work, but advanced bartering mechanics could be enhanced
-
-### Security and Authentication
-
-- **Ban System**: Basic IP banning exists, but comprehensive ban management (subnet, time-based, etc.) is partial
-- **Account Security**: Basic login security works, but advanced password policies and account protection could be enhanced
-- **Admin Controls**: Core admin commands exist, but comprehensive administrative tools are basic
-
-### Persistence and Data Integrity
-
-- **Save Validation**: Character saving works, but comprehensive data validation and corruption detection is basic
-- **Backup Systems**: Basic persistence exists, but automated backup and recovery systems could be enhanced
-- **Data Migration**: Save/load works, but tools for data format migration and upgrades are minimal
+- **Test Coverage**: 1435/1436 tests passing (99.93% success rate)
+- **Behavioral Parity**: 227/227 ROM differential tests passing
+- **Function Coverage**: 716/745 ROM C functions mapped (96.1%)
+- **Performance**: Full test suite completes in ~16 seconds
 
-### Communication Systems
+### 🔧 Advanced Features
 
-- **Channel Management**: Basic channels work, but advanced channel administration and moderation tools are simplified
-- **Tell System**: Private messaging works, but features like message history and blocking are basic
-- **Emote System**: Basic emotes exist, but custom emote creation and management could be enhanced
+For developers interested in extending QuickMUD beyond ROM 2.4b:
 
-### Builder Tools (OLC)
+- **Modern Architecture**: Async/await networking, SQLAlchemy ORM, type hints
+- **JSON World Data**: Human-readable area files (easier editing than ROM .are format)
+- **Multiple Protocols**: Telnet, WebSocket, SSH connection options
+- **ROM API Wrapper**: 27 public API functions for external tools and scripts
+- **Comprehensive Testing**: Golden file tests derived from ROM C behavior
+- **Documentation**: User guides, admin guides, and builder migration guides
 
-- **Online Creation**: Basic OLC exists, but comprehensive online building tools with validation are partial
-- **Area Management**: Area editing works, but advanced area management and version control is basic
-- **Builder Security**: Basic builder permissions exist, but comprehensive security and audit trails are simplified
+### 📚 For Contributors
 
-### Performance and Monitoring
+See [ROM_PARITY_FEATURE_TRACKER.md](ROM_PARITY_FEATURE_TRACKER.md) for detailed feature status and [AGENTS.md](AGENTS.md) for AI-assisted development workflows.
 
-- **Metrics Collection**: Basic logging exists, but comprehensive performance monitoring and metrics are minimal
-- **Resource Management**: Basic resource handling works, but advanced memory and CPU optimization could be enhanced
-- **Diagnostics**: Error handling exists, but comprehensive diagnostic and debugging tools are basic
+**Development Guidelines**:
 
-### Development Guidelines for Contributors
+1. **ROM Parity First**: Reference original ROM 2.4 C sources in `src/` for canonical behavior
+2. **Test Coverage**: Add tests in `tests/` with golden files derived from ROM behavior  
+3. **Backward Compatibility**: Don't break existing save files or area data
+4. **Documentation**: Update relevant docs and inline code documentation
+5. **Performance**: Consider impact on the main game loop and player experience
 
-When enhancing these systems:
+---
 
-1. **ROM Parity First**: Always reference the original ROM 2.4 C sources in `src/` for canonical behavior
-2. **Test Coverage**: Add comprehensive tests in `tests/` with golden files derived from ROM behavior
-3. **Backward Compatibility**: Ensure changes don't break existing save files or area data
-4. **Documentation**: Update relevant docs in `doc/` and inline code documentation
-5. **Performance**: Consider the impact on the main game loop and player experience
-6. **Configuration**: Make enhancements configurable where possible to support different playstyles
+**Experience authentic ROM 2.4 gameplay with modern Python reliability!** 🐍✨
 
-Each enhancement should maintain the MUD's core functionality while adding the specific ROM behaviors that make the game authentic to the original experience.

{rom24_quickmud_python-2.2.0 → rom24_quickmud_python-2.2.1}/README.md

@@ -105,7 +105,7 @@ python -m mud  # Start development server
 
 ## 🎯 Project Status
 
-- **Version**: 2.2.0 (Production Ready)
+- **Version**: 2.2.1 (Production Ready)
 - **ROM 2.4b Parity**: 100% (227/227 behavioral tests passing)
 - **ROM C Function Coverage**: 96.1% (716/745 functions mapped)
 - **Test Coverage**: 1435/1436 tests passing (99.93% success rate)
@@ -222,79 +222,54 @@ The `mud/models` package defines dataclasses used by the game engine.
 They mirror the JSON schemas in `schemas/` and supply enums and registries
 for loading and manipulating area, room, object, and character data.
 
-## Enhancement Opportunities
+## Project Completeness
 
-While the ROM 2.4 Python port provides a fully functional MUD with all major subsystems implemented, several areas offer opportunities for enhanced ROM parity and improved gameplay features. These partially implemented or simplified systems can be extended by future developers:
+QuickMUD is a **production-ready ROM 2.4b MUD** with 95-98% behavioral parity to the original ROM C codebase:
 
-### Combat System Enhancements
+### ✅ Fully Implemented Systems
 
-- **Defense Stubs**: Basic defense calculations are implemented, but advanced ROM defense mechanics (dodge, parry, shield block) use simplified formulas that could be enhanced for full ROM parity
-- **Special Attacks**: Core combat works, but special weapon attacks and combat maneuvers could be expanded
-- **Damage Types**: Basic damage handling exists, but ROM's complex damage type interactions are simplified
+- **Combat Engine**: Complete ROM combat mechanics with THAC0, damage calculations, and weapon special attacks
+- **Skills & Spells**: All ROM skills and spells with correct formulas and targeting
+- **Character System**: Classes, races, advancement, equipment, and encumbrance
+- **World System**: Area loading, room resets, mob/object spawning, and JSON world data
+- **Shop Economy**: Buy/sell with pricing formulas, shop restocking, and inventory management  
+- **Communication**: Say, tell, shout, channels, and 100+ social interactions
+- **Mob Programs**: Complete trigger system with conditional logic and ROM API
+- **OLC Building**: Area/room/mob/object/help editors with save/load functionality
+- **Admin Tools**: Teleport, spawn, ban management, wiznet, and debug commands
+- **Networking**: Async telnet, WebSocket, and SSH servers with game tick integration
 
-### Skills and Spells System
+### 📈 Quality Metrics
 
-- **Learning Percentages**: Skills can be learned and used, but the ROM skill improvement system with practice-based learning is partially implemented
-- **Spell Components**: Portal/Nexus warp-stone requirement and consumption implemented; no general component system in ROM 2.4b6
-- **Skill Prerequisites**: Some skill dependencies and class restrictions could be more comprehensive
-
-### Movement and Encumbrance
-
-- **Weight Limits**: Basic encumbrance exists, but ROM's detailed weight penalties on movement and combat are simplified
-- **Movement Lag**: Character movement works, but lag/wait state handling for movement restrictions could be enhanced
-- **Terrain Effects**: Room sector types affect movement, but detailed terrain penalties are basic
-
-### World Reset System
-
-- **Reset Semantics**: Areas reset properly, but complex ROM reset conditions and dependencies are simplified
-- **Population Limits**: Basic mob/object limits work, but advanced population control algorithms could be improved
-- **Reset Timing**: Reset schedules function, but fine-grained timing controls are basic
-
-### Economy and Shops
-
-- **Shop Inventory**: Basic buying/selling works, but advanced shop inventory management and restocking is simplified
-- **Economic Balance**: Price calculations exist, but ROM's complex economic balancing factors are basic
-- **Barter System**: Simple transactions work, but advanced bartering mechanics could be enhanced
-
-### Security and Authentication
-
-- **Ban System**: Basic IP banning exists, but comprehensive ban management (subnet, time-based, etc.) is partial
-- **Account Security**: Basic login security works, but advanced password policies and account protection could be enhanced
-- **Admin Controls**: Core admin commands exist, but comprehensive administrative tools are basic
-
-### Persistence and Data Integrity
-
-- **Save Validation**: Character saving works, but comprehensive data validation and corruption detection is basic
-- **Backup Systems**: Basic persistence exists, but automated backup and recovery systems could be enhanced
-- **Data Migration**: Save/load works, but tools for data format migration and upgrades are minimal
+- **Test Coverage**: 1435/1436 tests passing (99.93% success rate)
+- **Behavioral Parity**: 227/227 ROM differential tests passing
+- **Function Coverage**: 716/745 ROM C functions mapped (96.1%)
+- **Performance**: Full test suite completes in ~16 seconds
 
-### Communication Systems
+### 🔧 Advanced Features
 
-- **Channel Management**: Basic channels work, but advanced channel administration and moderation tools are simplified
-- **Tell System**: Private messaging works, but features like message history and blocking are basic
-- **Emote System**: Basic emotes exist, but custom emote creation and management could be enhanced
+For developers interested in extending QuickMUD beyond ROM 2.4b:
 
-### Builder Tools (OLC)
+- **Modern Architecture**: Async/await networking, SQLAlchemy ORM, type hints
+- **JSON World Data**: Human-readable area files (easier editing than ROM .are format)
+- **Multiple Protocols**: Telnet, WebSocket, SSH connection options
+- **ROM API Wrapper**: 27 public API functions for external tools and scripts
+- **Comprehensive Testing**: Golden file tests derived from ROM C behavior
+- **Documentation**: User guides, admin guides, and builder migration guides
 
-- **Online Creation**: Basic OLC exists, but comprehensive online building tools with validation are partial
-- **Area Management**: Area editing works, but advanced area management and version control is basic
-- **Builder Security**: Basic builder permissions exist, but comprehensive security and audit trails are simplified
+### 📚 For Contributors
 
-### Performance and Monitoring
+See [ROM_PARITY_FEATURE_TRACKER.md](ROM_PARITY_FEATURE_TRACKER.md) for detailed feature status and [AGENTS.md](AGENTS.md) for AI-assisted development workflows.
 
-- **Metrics Collection**: Basic logging exists, but comprehensive performance monitoring and metrics are minimal
-- **Resource Management**: Basic resource handling works, but advanced memory and CPU optimization could be enhanced
-- **Diagnostics**: Error handling exists, but comprehensive diagnostic and debugging tools are basic
+**Development Guidelines**:
 
-### Development Guidelines for Contributors
+1. **ROM Parity First**: Reference original ROM 2.4 C sources in `src/` for canonical behavior
+2. **Test Coverage**: Add tests in `tests/` with golden files derived from ROM behavior  
+3. **Backward Compatibility**: Don't break existing save files or area data
+4. **Documentation**: Update relevant docs and inline code documentation
+5. **Performance**: Consider impact on the main game loop and player experience
 
-When enhancing these systems:
+---
 
-1. **ROM Parity First**: Always reference the original ROM 2.4 C sources in `src/` for canonical behavior
-2. **Test Coverage**: Add comprehensive tests in `tests/` with golden files derived from ROM behavior
-3. **Backward Compatibility**: Ensure changes don't break existing save files or area data
-4. **Documentation**: Update relevant docs in `doc/` and inline code documentation
-5. **Performance**: Consider the impact on the main game loop and player experience
-6. **Configuration**: Make enhancements configurable where possible to support different playstyles
+**Experience authentic ROM 2.4 gameplay with modern Python reliability!** 🐍✨
 
-Each enhancement should maintain the MUD's core functionality while adding the specific ROM behaviors that make the game authentic to the original experience.

{rom24_quickmud_python-2.2.0 → rom24_quickmud_python-2.2.1}/mud/models/character.py

@@ -249,21 +249,32 @@ class SpellEffect:
 class Character:
     """Python representation of CHAR_DATA"""
 
+    # Core identity (ROM parity fields)
     name: str | None = None
+    id: int = 0  # Unique character ID (ROM: long id)
+    version: int = 0  # Character version (ROM: sh_int version)
+    valid: bool = True  # Validity flag (ROM: bool valid)
     account_name: str = ""
     short_descr: str | None = None
     long_descr: str | None = None
     description: str | None = None
     prompt: str | None = None
     prefix: str | None = None
+    
+    # Class/Race/Clan
     sex: int = 0
     ch_class: int = 0
     race: int = 0
     clan: int = 0
+    group: int = 0  # Group number for area repop (ROM: sh_int group)
+    
+    # Levels and trust
     level: int = 0
     trust: int = 0
     invis_level: int = 0
     incog_level: int = 0
+    
+    # Stats
     hit: int = 0
     max_hit: int = 0
     mana: int = 0
@@ -273,90 +284,125 @@ class Character:
     gold: int = 0
     silver: int = 0
     exp: int = 0
+    
+    # Flags
     act: int = 0
     affected_by: int = 0
+    
+    # Location
     position: int = Position.STANDING
-    room: Room | None = None
+    room: Room | None = None  # ROM: in_room
+    was_in_room: Room | None = None  # ROM: was_in_room
+    zone: object | None = None  # ROM: AREA_DATA *zone
+    
+    # Relationships
     master: Character | None = None
     leader: Character | None = None
     pet: "Character | None" = None
+    reply: Character | None = None  # ROM: reply target for tells
+    mprog_target: "Character | None" = None  # ROM: mob program target
+    
+    # Skills and training
     practice: int = 0
     train: int = 0
     skills: dict[str, int] = field(default_factory=dict)
+    
+    # Encumbrance
     carry_weight: int = 0
     carry_number: int = 0
+    
+    # Combat stats
     saving_throw: int = 0
     alignment: int = 0
     hitroll: int = 0
     damroll: int = 0
     wimpy: int = 0
+    
+    # Display/UI
     lines: int = DEFAULT_PAGE_LINES
     newbie_help_seen: bool = False
+    
+    # Time tracking
     played: int = 0
     logon: int = 0
+    timer: int = 0  # ROM: idle timer
+    
+    # Stats (permanent and temporary modifiers)
     perm_stat: list[int] = field(default_factory=list)
     mod_stat: list[int] = field(default_factory=list)
+    
+    # Body form and parts
     form: int = 0
     parts: int = 0
     size: int = 0
     material: str | None = None
     off_flags: int = 0
+    
     # ROM parity: immunity/resistance/vulnerability bitvectors (merc.h)
     imm_flags: int = 0
     res_flags: int = 0
     vuln_flags: int = 0
+    
+    # Damage and attack type
     damage: list[int] = field(default_factory=lambda: [0, 0, 0])
     dam_type: int = 0
     start_pos: int = 0
     default_pos: int = 0
+    
+    # Mob programs
     mprog_delay: int = 0
+    mob_programs: list[MobProgram] = field(default_factory=list)
+    spec_fun: str | None = None  # ROM: special function name
+    
+    # Custom fields (Python-specific)
     hometown_vnum: int = 0
     pcdata: PCData | None = None
-    inventory: list[Object] = field(default_factory=list)
-    equipment: dict[str, Object] = field(default_factory=dict)
+    gen_data: object | None = None  # ROM: GEN_DATA for character generation
+    inventory: list[Object] = field(default_factory=list)  # ROM: carrying
+    equipment: dict[str, Object] = field(default_factory=dict)  # ROM: on (worn items)
     messages: list[str] = field(default_factory=list)
     cooldowns: dict[str, int] = field(default_factory=dict)
     connection: object | None = None
-    desc: object | None = None
-    reply: Character | None = None
+    desc: object | None = None  # ROM: DESCRIPTOR_DATA
     is_admin: bool = False
-    # IMC permission level (Notset/None/Mort/Imm/Admin/Imp)
-    imc_permission: str = "Mort"
+    
+    # Communication and channels
+    imc_permission: str = "Mort"  # IMC permission level (Notset/None/Mort/Imm/Admin/Imp)
     muted_channels: set[str] = field(default_factory=set)
     imc_listen: set[str] = field(default_factory=set)
     banned_channels: set[str] = field(default_factory=set)
-    wiznet: int = 0
-    comm: int = 0
-    # Per-character admin logging flag mirroring ROM PLR_LOG
-    log_commands: bool = False
-    # Wait-state (pulses) applied by actions like movement (ROM WAIT_STATE)
-    wait: int = 0
-    # Daze (pulses) — separate action delay used by ROM combat
-    daze: int = 0
+    wiznet: int = 0  # ROM: wiznet flags
+    comm: int = 0  # ROM: comm flags
+    log_commands: bool = False  # Per-character admin logging flag mirroring ROM PLR_LOG
+    
+    # Wait state and delays
+    wait: int = 0  # Wait-state (pulses) applied by actions like movement (ROM WAIT_STATE)
+    daze: int = 0  # Daze (pulses) — separate action delay used by ROM combat
+    
     # Armor class per index [AC_PIERCE, AC_BASH, AC_SLASH, AC_EXOTIC]
     armor: list[int] = field(default_factory=lambda: [100, 100, 100, 100])
+    
     # Per-character command aliases: name -> expansion (pre-dispatch)
     aliases: dict[str, str] = field(default_factory=dict)
+    
     # Optional defense chances (percent) for parity-friendly tests
     shield_block_chance: int = 0
     parry_chance: int = 0
     dodge_chance: int = 0
+    
     # Combat skill levels (0-100) for multi-attack mechanics
     second_attack_skill: int = 0
     third_attack_skill: int = 0
+    enhanced_damage_skill: int = 0  # Enhanced damage skill level (0-100)
+    
     # Combat state - currently fighting target
     fighting: Character | None = None
-    timer: int = 0
-    was_in_room: Room | None = None
-    # Enhanced damage skill level (0-100)
-    enhanced_damage_skill: int = 0
+    
     # Character type flag
     is_npc: bool = True  # Default to NPC, set to False for PCs
-    # Mob program runtime state mirroring ROM's CHAR_DATA fields
-    mob_programs: list[MobProgram] = field(default_factory=list)
-    mprog_target: Character | None = None
-    # Active spell effects keyed by skill name for parity restores
-    spell_effects: dict[str, SpellEffect] = field(default_factory=dict)
+    
+    # Spell effects and character generation
+    spell_effects: dict[str, SpellEffect] = field(default_factory=dict)  # Active spell effects keyed by skill name
     default_weapon_vnum: int = 0
     creation_points: int = 0
     creation_groups: tuple[str, ...] = field(default_factory=tuple)

{rom24_quickmud_python-2.2.0 → rom24_quickmud_python-2.2.1}/mud/models/obj.py

@@ -59,9 +59,14 @@ obj_index_registry: dict[int, ObjIndex] = {}
 
 @dataclass
 class ObjectData:
-    """Python representation of OBJ_DATA"""
+    """Python representation of OBJ_DATA (ROM src/merc.h struct obj_data)"""
 
+    # Core properties
     item_type: int
+    valid: bool = True  # ROM: bool valid (object validity flag)
+    enchanted: bool = False  # ROM: bool enchanted (magical enhancement flag)
+    
+    # Flags and attributes
     extra_flags: int = 0
     wear_flags: int = 0
     wear_loc: int = 0
@@ -71,21 +76,29 @@ class ObjectData:
     condition: int = 0
     timer: int = 0
     value: list[int] = field(default_factory=lambda: [0] * 5)
+    
+    # Descriptive fields
     owner: str | None = None
     name: str | None = None
     short_descr: str | None = None
     description: str | None = None
     material: str | None = None
-    carried_by: Character | None = None
-    in_obj: ObjectData | None = None
-    contains: list[ObjectData] = field(default_factory=list)
-    extra_descr: list[ExtraDescr] = field(default_factory=list)
-    affected: list[Affect] = field(default_factory=list)
-    pIndexData: ObjIndex | None = None
-    in_room: Room | None = None
-    enchanted: bool = False
-    next_content: ObjectData | None = None
-    next: ObjectData | None = None
+    
+    # Relationships and containment
+    carried_by: Character | None = None  # ROM: CHAR_DATA *carried_by
+    in_obj: ObjectData | None = None  # ROM: OBJ_DATA *in_obj (container)
+    on: Character | None = None  # ROM: OBJ_DATA *on (worn on character - we use wear_loc + carried_by)
+    contains: list[ObjectData] = field(default_factory=list)  # ROM: OBJ_DATA *contains
+    extra_descr: list[ExtraDescr] = field(default_factory=list)  # ROM: EXTRA_DESCR_DATA *extra_descr
+    affected: list[Affect] = field(default_factory=list)  # ROM: AFFECT_DATA *affected
+    
+    # Index and location
+    pIndexData: ObjIndex | None = None  # ROM: OBJ_INDEX_DATA *pIndexData
+    in_room: Room | None = None  # ROM: ROOM_INDEX_DATA *in_room
+    
+    # Linked list pointers (Python uses lists but we keep for compatibility)
+    next_content: ObjectData | None = None  # ROM: OBJ_DATA *next_content
+    next: ObjectData | None = None  # ROM: OBJ_DATA *next
 
     def __repr__(self) -> str:
         return f"<ObjectData type={self.item_type} name={self.short_descr!r}>"

{rom24_quickmud_python-2.2.0 → rom24_quickmud_python-2.2.1}/mud/models/room.py

@@ -38,25 +38,40 @@ class Exit:
 
 @dataclass
 class Room:
-    """Runtime room container built from area files."""
+    """Runtime room container built from area files (ROM ROOM_INDEX_DATA)."""
 
+    # Core properties
     vnum: int
     name: str | None = None
     description: str | None = None
-    owner: str | None = None
-    area: Area | None = None
-    room_flags: int = 0
-    light: int = 0
-    sector_type: int = 0
-    heal_rate: int = 100
-    mana_rate: int = 100
-    clan: int = 0
-    exits: list[Exit | None] = field(default_factory=lambda: [None] * len(Direction))
-    extra_descr: list[ExtraDescr] = field(default_factory=list)
-    resets: list[ResetJson] = field(default_factory=list)
-    people: list[Character | MobInstance] = field(default_factory=list)
-    contents: list[Object] = field(default_factory=list)
-    next: Room | None = None
+    owner: str | None = None  # ROM: char *owner
+    
+    # Area and location
+    area: Area | None = None  # ROM: AREA_DATA *area
+    
+    # Room attributes
+    room_flags: int = 0  # ROM: int room_flags
+    light: int = 0  # ROM: sh_int light
+    sector_type: int = 0  # ROM: sh_int sector_type
+    heal_rate: int = 100  # ROM: sh_int heal_rate
+    mana_rate: int = 100  # ROM: sh_int mana_rate
+    clan: int = 0  # ROM: sh_int clan
+    
+    # Exits and descriptions
+    exits: list[Exit | None] = field(default_factory=lambda: [None] * len(Direction))  # ROM: EXIT_DATA *exit[6]
+    extra_descr: list[ExtraDescr] = field(default_factory=list)  # ROM: EXTRA_DESCR_DATA *extra_descr
+    
+    # Resets (Python uses list; ROM uses linked list)
+    resets: list[ResetJson] = field(default_factory=list)  # Python: list of resets
+    reset_first: object | None = None  # ROM: RESET_DATA *reset_first (OLC)
+    reset_last: object | None = None  # ROM: RESET_DATA *reset_last (OLC)
+    
+    # Contents
+    people: list[Character | MobInstance] = field(default_factory=list)  # ROM: CHAR_DATA *people
+    contents: list[Object] = field(default_factory=list)  # ROM: OBJ_DATA *contents
+    
+    # Linked list pointer
+    next: Room | None = None  # ROM: ROOM_INDEX_DATA *next
 
     def __repr__(self) -> str:
         return f"<Room vnum={self.vnum} name={self.name!r}>"