rldoctor 0.1.0__tar.gz
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- rldoctor-0.1.0/.gitattributes +1 -0
- rldoctor-0.1.0/.github/ISSUE_TEMPLATE/bug.yml +21 -0
- rldoctor-0.1.0/.github/ISSUE_TEMPLATE/config.yml +1 -0
- rldoctor-0.1.0/.github/ISSUE_TEMPLATE/unrecognised_key.yml +22 -0
- rldoctor-0.1.0/.github/ISSUE_TEMPLATE/wrong_verdict.yml +44 -0
- rldoctor-0.1.0/.github/workflows/ci.yml +78 -0
- rldoctor-0.1.0/.github/workflows/release.yml +68 -0
- rldoctor-0.1.0/.github/workflows/validation.yml +42 -0
- rldoctor-0.1.0/.gitignore +17 -0
- rldoctor-0.1.0/CHANGELOG.md +40 -0
- rldoctor-0.1.0/CITATION.cff +25 -0
- rldoctor-0.1.0/CONTRIBUTING.md +84 -0
- rldoctor-0.1.0/LICENSE +202 -0
- rldoctor-0.1.0/PKG-INFO +606 -0
- rldoctor-0.1.0/README.md +366 -0
- rldoctor-0.1.0/docs/assets/demo_saturated.txt +128 -0
- rldoctor-0.1.0/docs/assets/report.svg +36 -0
- rldoctor-0.1.0/docs/assets/sample_report.html +64 -0
- rldoctor-0.1.0/docs/detectors.md +263 -0
- rldoctor-0.1.0/examples/custom_detector.py +58 -0
- rldoctor-0.1.0/examples/diagnose_your_own_loop.py +33 -0
- rldoctor-0.1.0/pyproject.toml +82 -0
- rldoctor-0.1.0/src/rldoctor/__init__.py +50 -0
- rldoctor-0.1.0/src/rldoctor/aliases.py +268 -0
- rldoctor-0.1.0/src/rldoctor/cli.py +253 -0
- rldoctor-0.1.0/src/rldoctor/detectors/__init__.py +75 -0
- rldoctor-0.1.0/src/rldoctor/detectors/advantage_collapse.py +244 -0
- rldoctor-0.1.0/src/rldoctor/detectors/base.py +146 -0
- rldoctor-0.1.0/src/rldoctor/detectors/clip_saturation.py +136 -0
- rldoctor-0.1.0/src/rldoctor/detectors/entropy_collapse.py +239 -0
- rldoctor-0.1.0/src/rldoctor/detectors/grad_pathology.py +202 -0
- rldoctor-0.1.0/src/rldoctor/detectors/kl_drift.py +163 -0
- rldoctor-0.1.0/src/rldoctor/detectors/length_hacking.py +196 -0
- rldoctor-0.1.0/src/rldoctor/detectors/plateau.py +175 -0
- rldoctor-0.1.0/src/rldoctor/detectors/reward_composition.py +190 -0
- rldoctor-0.1.0/src/rldoctor/detectors/reward_hacking.py +154 -0
- rldoctor-0.1.0/src/rldoctor/diagnosis.py +133 -0
- rldoctor-0.1.0/src/rldoctor/economics.py +138 -0
- rldoctor-0.1.0/src/rldoctor/ingest/__init__.py +5 -0
- rldoctor-0.1.0/src/rldoctor/ingest/base.py +332 -0
- rldoctor-0.1.0/src/rldoctor/ingest/tensorboard_source.py +77 -0
- rldoctor-0.1.0/src/rldoctor/ingest/wandb_source.py +62 -0
- rldoctor-0.1.0/src/rldoctor/integrations/__init__.py +5 -0
- rldoctor-0.1.0/src/rldoctor/integrations/trl.py +122 -0
- rldoctor-0.1.0/src/rldoctor/live.py +144 -0
- rldoctor-0.1.0/src/rldoctor/report/__init__.py +69 -0
- rldoctor-0.1.0/src/rldoctor/report/html.py +232 -0
- rldoctor-0.1.0/src/rldoctor/report/markdown.py +69 -0
- rldoctor-0.1.0/src/rldoctor/report/terminal.py +258 -0
- rldoctor-0.1.0/src/rldoctor/schema.py +207 -0
- rldoctor-0.1.0/src/rldoctor/simulate.py +236 -0
- rldoctor-0.1.0/src/rldoctor/stats.py +409 -0
- rldoctor-0.1.0/tests/test_detectors.py +130 -0
- rldoctor-0.1.0/tests/test_ingest.py +152 -0
- rldoctor-0.1.0/tests/test_live.py +141 -0
- rldoctor-0.1.0/tests/test_real_log_shapes.py +298 -0
- rldoctor-0.1.0/tests/test_report_and_cli.py +121 -0
- rldoctor-0.1.0/tests/test_stats.py +110 -0
- rldoctor-0.1.0/tools/ansi2svg.py +109 -0
- rldoctor-0.1.0/tools/make_banner.py +51 -0
- rldoctor-0.1.0/validation/fetch.py +47 -0
- rldoctor-0.1.0/validation/run.py +60 -0
- rldoctor-0.1.0/validation/runs.json +54 -0
|
@@ -0,0 +1 @@
|
|
|
1
|
+
* text=auto eol=lf
|
|
@@ -0,0 +1,21 @@
|
|
|
1
|
+
name: Bug
|
|
2
|
+
description: Something crashed, or did not run.
|
|
3
|
+
labels: [bug]
|
|
4
|
+
body:
|
|
5
|
+
- type: textarea
|
|
6
|
+
id: what
|
|
7
|
+
attributes:
|
|
8
|
+
label: What happened
|
|
9
|
+
description: The command you ran and what it printed. Tracebacks are welcome.
|
|
10
|
+
validations:
|
|
11
|
+
required: true
|
|
12
|
+
- type: input
|
|
13
|
+
id: version
|
|
14
|
+
attributes:
|
|
15
|
+
label: Version
|
|
16
|
+
placeholder: output of `--version`
|
|
17
|
+
- type: input
|
|
18
|
+
id: env
|
|
19
|
+
attributes:
|
|
20
|
+
label: Python and OS
|
|
21
|
+
placeholder: Python 3.11, Ubuntu 22.04
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
blank_issues_enabled: true
|
|
@@ -0,0 +1,22 @@
|
|
|
1
|
+
name: Unrecognised metric key
|
|
2
|
+
description: rldoctor --verbose listed a key from your framework that it should understand.
|
|
3
|
+
labels: [aliases]
|
|
4
|
+
body:
|
|
5
|
+
- type: input
|
|
6
|
+
id: key
|
|
7
|
+
attributes:
|
|
8
|
+
label: The key, exactly as logged
|
|
9
|
+
placeholder: actor/entropy_mean
|
|
10
|
+
validations:
|
|
11
|
+
required: true
|
|
12
|
+
- type: input
|
|
13
|
+
id: meaning
|
|
14
|
+
attributes:
|
|
15
|
+
label: What it measures
|
|
16
|
+
validations:
|
|
17
|
+
required: true
|
|
18
|
+
- type: input
|
|
19
|
+
id: framework
|
|
20
|
+
attributes:
|
|
21
|
+
label: Framework and version
|
|
22
|
+
placeholder: verl 0.6
|
|
@@ -0,0 +1,44 @@
|
|
|
1
|
+
name: Wrong verdict
|
|
2
|
+
description: rldoctor said something about your run that is not true -- or missed something that is.
|
|
3
|
+
labels: [wrong-verdict]
|
|
4
|
+
body:
|
|
5
|
+
- type: markdown
|
|
6
|
+
attributes:
|
|
7
|
+
value: |
|
|
8
|
+
This is the most valuable issue you can file. A false positive is treated as a
|
|
9
|
+
higher-severity bug than a missed detection: a diagnostic that cries wolf gets
|
|
10
|
+
uninstalled, and then it catches nothing.
|
|
11
|
+
- type: dropdown
|
|
12
|
+
id: kind
|
|
13
|
+
attributes:
|
|
14
|
+
label: Which way was it wrong?
|
|
15
|
+
options:
|
|
16
|
+
- It warned about a run that was fine (false positive)
|
|
17
|
+
- It missed a problem the run really had (false negative)
|
|
18
|
+
- The finding was right but the explanation or the fix was wrong
|
|
19
|
+
validations:
|
|
20
|
+
required: true
|
|
21
|
+
- type: input
|
|
22
|
+
id: detector
|
|
23
|
+
attributes:
|
|
24
|
+
label: Which detector
|
|
25
|
+
placeholder: e.g. entropy_collapse
|
|
26
|
+
- type: textarea
|
|
27
|
+
id: truth
|
|
28
|
+
attributes:
|
|
29
|
+
label: What was actually going on in the run
|
|
30
|
+
description: How you know -- held-out results, rollouts you read, what you changed.
|
|
31
|
+
validations:
|
|
32
|
+
required: true
|
|
33
|
+
- type: textarea
|
|
34
|
+
id: log
|
|
35
|
+
attributes:
|
|
36
|
+
label: The log
|
|
37
|
+
description: |
|
|
38
|
+
A link to a public W&B run or trainer_state.json, or an attached CSV of the
|
|
39
|
+
relevant series. The full log is not needed -- the columns the detector reads are.
|
|
40
|
+
- type: input
|
|
41
|
+
id: framework
|
|
42
|
+
attributes:
|
|
43
|
+
label: Framework and version
|
|
44
|
+
placeholder: verl 0.6 / TRL 1.2 / custom
|
|
@@ -0,0 +1,78 @@
|
|
|
1
|
+
name: CI
|
|
2
|
+
|
|
3
|
+
on:
|
|
4
|
+
push:
|
|
5
|
+
branches: [main]
|
|
6
|
+
pull_request:
|
|
7
|
+
workflow_dispatch:
|
|
8
|
+
|
|
9
|
+
concurrency:
|
|
10
|
+
group: ${{ github.workflow }}-${{ github.ref }}
|
|
11
|
+
cancel-in-progress: true
|
|
12
|
+
|
|
13
|
+
jobs:
|
|
14
|
+
test:
|
|
15
|
+
name: py${{ matrix.python }} on ${{ matrix.os }}
|
|
16
|
+
runs-on: ${{ matrix.os }}
|
|
17
|
+
strategy:
|
|
18
|
+
fail-fast: false
|
|
19
|
+
matrix:
|
|
20
|
+
os: [ubuntu-latest]
|
|
21
|
+
python: ["3.10", "3.11", "3.12", "3.13", "3.14"]
|
|
22
|
+
include:
|
|
23
|
+
# The terminal report has an ASCII fallback specifically for Windows
|
|
24
|
+
# consoles on a legacy code page, so it needs to actually run there.
|
|
25
|
+
- os: windows-latest
|
|
26
|
+
python: "3.12"
|
|
27
|
+
- os: macos-latest
|
|
28
|
+
python: "3.12"
|
|
29
|
+
steps:
|
|
30
|
+
- uses: actions/checkout@v4
|
|
31
|
+
- uses: actions/setup-python@v5
|
|
32
|
+
with:
|
|
33
|
+
python-version: ${{ matrix.python }}
|
|
34
|
+
cache: pip
|
|
35
|
+
- run: python -m pip install --upgrade pip
|
|
36
|
+
- run: pip install -e ".[dev]"
|
|
37
|
+
- name: Tests
|
|
38
|
+
run: pytest -q --cov=rldoctor --cov-report=term-missing
|
|
39
|
+
- name: Detection matrix
|
|
40
|
+
run: rldoctor selftest
|
|
41
|
+
- name: CLI smoke test
|
|
42
|
+
run: |
|
|
43
|
+
rldoctor --version
|
|
44
|
+
rldoctor detectors
|
|
45
|
+
rldoctor fields
|
|
46
|
+
rldoctor demo healthy --format json > /dev/null
|
|
47
|
+
shell: bash
|
|
48
|
+
|
|
49
|
+
lint:
|
|
50
|
+
runs-on: ubuntu-latest
|
|
51
|
+
steps:
|
|
52
|
+
- uses: actions/checkout@v4
|
|
53
|
+
- uses: actions/setup-python@v5
|
|
54
|
+
with:
|
|
55
|
+
python-version: "3.12"
|
|
56
|
+
cache: pip
|
|
57
|
+
- run: pip install ruff mypy
|
|
58
|
+
- run: ruff check src tests
|
|
59
|
+
- run: ruff format --check src tests
|
|
60
|
+
continue-on-error: true
|
|
61
|
+
- run: mypy src/rldoctor
|
|
62
|
+
continue-on-error: true
|
|
63
|
+
|
|
64
|
+
build:
|
|
65
|
+
runs-on: ubuntu-latest
|
|
66
|
+
steps:
|
|
67
|
+
- uses: actions/checkout@v4
|
|
68
|
+
- uses: actions/setup-python@v5
|
|
69
|
+
with:
|
|
70
|
+
python-version: "3.12"
|
|
71
|
+
- run: pip install build twine
|
|
72
|
+
- run: python -m build
|
|
73
|
+
- run: twine check dist/*
|
|
74
|
+
- name: Install the wheel in a clean environment
|
|
75
|
+
run: |
|
|
76
|
+
python -m venv /tmp/clean
|
|
77
|
+
/tmp/clean/bin/pip install dist/*.whl
|
|
78
|
+
/tmp/clean/bin/rldoctor selftest
|
|
@@ -0,0 +1,68 @@
|
|
|
1
|
+
name: Release
|
|
2
|
+
|
|
3
|
+
# Publishes to PyPI when a version tag is pushed, using PyPI trusted publishing:
|
|
4
|
+
# no API token is stored anywhere. One-time setup on pypi.org, under
|
|
5
|
+
# "Your projects -> Publishing -> Add a new pending publisher":
|
|
6
|
+
# PyPI project name: rldoctor
|
|
7
|
+
# Owner: junglezke
|
|
8
|
+
# Repository: rldoctor
|
|
9
|
+
# Workflow: release.yml
|
|
10
|
+
# Environment: pypi
|
|
11
|
+
# Then: git tag v0.1.0 && git push origin v0.1.0
|
|
12
|
+
|
|
13
|
+
on:
|
|
14
|
+
push:
|
|
15
|
+
tags: ["v*"]
|
|
16
|
+
|
|
17
|
+
jobs:
|
|
18
|
+
build:
|
|
19
|
+
runs-on: ubuntu-latest
|
|
20
|
+
steps:
|
|
21
|
+
- uses: actions/checkout@v4
|
|
22
|
+
- uses: actions/setup-python@v5
|
|
23
|
+
with:
|
|
24
|
+
python-version: "3.12"
|
|
25
|
+
- name: Check the tag matches the package version
|
|
26
|
+
run: |
|
|
27
|
+
version=$(python -c "import tomllib; print(tomllib.load(open('pyproject.toml','rb'))['project']['version'])")
|
|
28
|
+
test "v$version" = "${GITHUB_REF_NAME}" || { echo "tag ${GITHUB_REF_NAME} != version v$version"; exit 1; }
|
|
29
|
+
- run: pip install build twine
|
|
30
|
+
- run: python -m build
|
|
31
|
+
- run: twine check dist/*
|
|
32
|
+
- uses: actions/upload-artifact@v4
|
|
33
|
+
with:
|
|
34
|
+
name: dist
|
|
35
|
+
path: dist/
|
|
36
|
+
|
|
37
|
+
publish:
|
|
38
|
+
needs: build
|
|
39
|
+
runs-on: ubuntu-latest
|
|
40
|
+
environment:
|
|
41
|
+
name: pypi
|
|
42
|
+
url: https://pypi.org/project/rldoctor/
|
|
43
|
+
permissions:
|
|
44
|
+
id-token: write
|
|
45
|
+
steps:
|
|
46
|
+
- uses: actions/download-artifact@v4
|
|
47
|
+
with:
|
|
48
|
+
name: dist
|
|
49
|
+
path: dist/
|
|
50
|
+
- uses: pypa/gh-action-pypi-publish@release/v1
|
|
51
|
+
|
|
52
|
+
github-release:
|
|
53
|
+
needs: publish
|
|
54
|
+
runs-on: ubuntu-latest
|
|
55
|
+
permissions:
|
|
56
|
+
contents: write
|
|
57
|
+
steps:
|
|
58
|
+
- uses: actions/checkout@v4
|
|
59
|
+
- uses: actions/download-artifact@v4
|
|
60
|
+
with:
|
|
61
|
+
name: dist
|
|
62
|
+
path: dist/
|
|
63
|
+
- name: Create the GitHub release from the changelog
|
|
64
|
+
env:
|
|
65
|
+
GH_TOKEN: ${{ github.token }}
|
|
66
|
+
run: |
|
|
67
|
+
notes=$(awk '/^## \[/{n++} n==1' CHANGELOG.md | tail -n +2)
|
|
68
|
+
gh release create "${GITHUB_REF_NAME}" dist/* --title "${GITHUB_REF_NAME}" --notes "$notes"
|
|
@@ -0,0 +1,42 @@
|
|
|
1
|
+
name: Real-run validation
|
|
2
|
+
|
|
3
|
+
# Re-diagnoses the public training logs in validation/runs.json and fails if any
|
|
4
|
+
# verdict changed. Runs when the code that decides verdicts changes, and weekly
|
|
5
|
+
# so an upstream log disappearing is noticed.
|
|
6
|
+
|
|
7
|
+
on:
|
|
8
|
+
push:
|
|
9
|
+
branches: [main]
|
|
10
|
+
paths:
|
|
11
|
+
- "src/rldoctor/detectors/**"
|
|
12
|
+
- "src/rldoctor/stats.py"
|
|
13
|
+
- "src/rldoctor/aliases.py"
|
|
14
|
+
- "src/rldoctor/ingest/**"
|
|
15
|
+
- "validation/**"
|
|
16
|
+
pull_request:
|
|
17
|
+
paths:
|
|
18
|
+
- "src/rldoctor/detectors/**"
|
|
19
|
+
- "src/rldoctor/stats.py"
|
|
20
|
+
- "src/rldoctor/aliases.py"
|
|
21
|
+
- "src/rldoctor/ingest/**"
|
|
22
|
+
- "validation/**"
|
|
23
|
+
schedule:
|
|
24
|
+
- cron: "0 6 * * 1"
|
|
25
|
+
workflow_dispatch:
|
|
26
|
+
|
|
27
|
+
jobs:
|
|
28
|
+
validate:
|
|
29
|
+
runs-on: ubuntu-latest
|
|
30
|
+
steps:
|
|
31
|
+
- uses: actions/checkout@v4
|
|
32
|
+
- uses: actions/setup-python@v5
|
|
33
|
+
with:
|
|
34
|
+
python-version: "3.12"
|
|
35
|
+
cache: pip
|
|
36
|
+
- run: pip install -e .
|
|
37
|
+
- uses: actions/cache@v4
|
|
38
|
+
with:
|
|
39
|
+
path: validation/.cache
|
|
40
|
+
key: validation-${{ hashFiles('validation/runs.json') }}
|
|
41
|
+
- run: python validation/fetch.py
|
|
42
|
+
- run: python validation/run.py --check
|
|
@@ -0,0 +1,17 @@
|
|
|
1
|
+
__pycache__/
|
|
2
|
+
*.py[cod]
|
|
3
|
+
*.egg-info/
|
|
4
|
+
build/
|
|
5
|
+
dist/
|
|
6
|
+
.pytest_cache/
|
|
7
|
+
.ruff_cache/
|
|
8
|
+
.mypy_cache/
|
|
9
|
+
.coverage
|
|
10
|
+
htmlcov/
|
|
11
|
+
.venv/
|
|
12
|
+
venv/
|
|
13
|
+
*.html
|
|
14
|
+
!docs/**/*.html
|
|
15
|
+
|
|
16
|
+
# Public training logs used for validation: other people's data, fetched on demand.
|
|
17
|
+
validation/.cache/
|
|
@@ -0,0 +1,40 @@
|
|
|
1
|
+
# Changelog
|
|
2
|
+
|
|
3
|
+
All notable changes to this project are documented here. This project follows
|
|
4
|
+
[Semantic Versioning](https://semver.org/).
|
|
5
|
+
|
|
6
|
+
## [0.1.0] — 2026-10-04
|
|
7
|
+
|
|
8
|
+
First public release.
|
|
9
|
+
|
|
10
|
+
### Added
|
|
11
|
+
|
|
12
|
+
- Nine detectors: `advantage_collapse`, `entropy_collapse`, `reward_hacking`,
|
|
13
|
+
`length_pathology`, `clip_saturation`, `kl_drift`, `gradient_pathology`,
|
|
14
|
+
`reward_composition`, `plateau`. Each emits evidence, a prescription and references.
|
|
15
|
+
- Ingest from W&B runs, TensorBoard directories, JSONL, JSON and CSV, plus
|
|
16
|
+
`run_from_records` for any training loop that can hand over a list of dicts.
|
|
17
|
+
- Three-pass alias resolution (exact, suffix, token-set) across verl and TRL metric
|
|
18
|
+
names, with unresolved keys surfaced rather than dropped.
|
|
19
|
+
- Robust statistics: Theil–Sen regression, Mann–Kendall with tie correction, Spearman,
|
|
20
|
+
detrended CUSUM changepoints, and `project_threshold` model-selecting extrapolation.
|
|
21
|
+
- Cost model converting waste into GPU-hours and dollars, combining per-detector waste
|
|
22
|
+
fractions as independent survival probabilities rather than summing them.
|
|
23
|
+
- Terminal (with ASCII fallback), Markdown, JSON and self-contained HTML reports.
|
|
24
|
+
- `LiveMonitor` and `RLDoctorCallback` for in-training diagnosis.
|
|
25
|
+
- Twelve simulated pathology scenarios, doubling as the test suite's detection matrix
|
|
26
|
+
and as `rldoctor demo` / `rldoctor selftest`.
|
|
27
|
+
- Native `trainer_state.json` ingestion (every HuggingFace checkpoint ships one) and
|
|
28
|
+
verl's `file` logger format, including `val-core/<source>/<metric>/mean@N` keys.
|
|
29
|
+
- Exactly-zero gradient steps reported as dead updates, and counted as wasted rollouts.
|
|
30
|
+
- `validation/`: four public GRPO runs with pinned verdicts, re-checked in CI.
|
|
31
|
+
|
|
32
|
+
### Fixed before release, found on real logs
|
|
33
|
+
|
|
34
|
+
- `nan` padding from eval rows logged on a different cadence was counted as non-finite
|
|
35
|
+
gradient norms -- a false "numerically dead" verdict on a healthy run.
|
|
36
|
+
- Statistical outliers only 2x the median were reported as gradient spikes.
|
|
37
|
+
- Truncation was counted as wasted rollout compute, producing an indefensible "99%".
|
|
38
|
+
- TRL's `eval_` prefix was not recognised, so held-out metrics leaked into training series.
|
|
39
|
+
- A KL of exactly 0.0 at every step (a run with no KL term) was read as a pinned policy.
|
|
40
|
+
- A plateau was declared on a run less than half way to `max_steps`.
|
|
@@ -0,0 +1,25 @@
|
|
|
1
|
+
cff-version: 1.2.0
|
|
2
|
+
title: "rldoctor: diagnostics for GRPO/RLVR training runs"
|
|
3
|
+
message: "If you use this software, please cite it as below."
|
|
4
|
+
type: software
|
|
5
|
+
authors:
|
|
6
|
+
- alias: junglezke
|
|
7
|
+
repository-code: "https://github.com/junglezke/rldoctor"
|
|
8
|
+
abstract: >-
|
|
9
|
+
rldoctor reads the metric log of a reinforcement-learning post-training run and
|
|
10
|
+
reports which documented failure mode it is exhibiting, what that failure has cost
|
|
11
|
+
in GPU-hours, and what configuration change addresses it. It covers zero-variance
|
|
12
|
+
GRPO groups, entropy collapse, reward/eval divergence, length hacking, truncation,
|
|
13
|
+
clip saturation, KL drift, gradient pathologies, reward-component imbalance and
|
|
14
|
+
learning plateaus, working from logs produced by verl, TRL, or any training loop,
|
|
15
|
+
with no instrumentation required.
|
|
16
|
+
keywords:
|
|
17
|
+
- reinforcement learning
|
|
18
|
+
- RLHF
|
|
19
|
+
- RLVR
|
|
20
|
+
- GRPO
|
|
21
|
+
- large language models
|
|
22
|
+
- training diagnostics
|
|
23
|
+
- reward hacking
|
|
24
|
+
license: Apache-2.0
|
|
25
|
+
version: 0.1.0
|
|
@@ -0,0 +1,84 @@
|
|
|
1
|
+
# Contributing to rldoctor
|
|
2
|
+
|
|
3
|
+
## The most useful thing you can do
|
|
4
|
+
|
|
5
|
+
**Tell us about a metric key we do not recognise.** Run:
|
|
6
|
+
|
|
7
|
+
```bash
|
|
8
|
+
rldoctor diagnose <your run> --verbose
|
|
9
|
+
```
|
|
10
|
+
|
|
11
|
+
Anything listed under "unrecognised log keys" is a metric we dropped. If one of them is
|
|
12
|
+
something rldoctor should understand, open an issue with the key name, the framework and
|
|
13
|
+
version, and what it measures. That is usually a one-line addition to
|
|
14
|
+
`src/rldoctor/aliases.py` and it makes the tool work for everyone on that stack.
|
|
15
|
+
|
|
16
|
+
**Second most useful: a run that produced a wrong verdict.** A false positive is a bug of
|
|
17
|
+
the highest severity in this project — a diagnostic that cries wolf gets uninstalled, and
|
|
18
|
+
then it catches nothing. If rldoctor warned about a run that was fine, or stayed quiet on
|
|
19
|
+
a run that was not, please open an issue with the metric log (a CSV of the relevant series
|
|
20
|
+
is plenty) and what actually happened.
|
|
21
|
+
|
|
22
|
+
## Adding a detector
|
|
23
|
+
|
|
24
|
+
Three files:
|
|
25
|
+
|
|
26
|
+
1. **`src/rldoctor/detectors/your_check.py`** — subclass `Detector`, set `name`, `title`,
|
|
27
|
+
`requires`, `references`, and implement `run(self, run) -> Finding`. The base class
|
|
28
|
+
validates `requires` before calling you, so the body can assume its inputs exist.
|
|
29
|
+
2. **`src/rldoctor/detectors/__init__.py`** — add the class to `BUILTIN_DETECTORS`.
|
|
30
|
+
3. **`src/rldoctor/simulate.py`** — add a scenario that reproduces the failure, and record
|
|
31
|
+
the expected detection in `EXPECTED_DETECTIONS`.
|
|
32
|
+
|
|
33
|
+
That third step is not optional busywork. It is what makes the check trustworthy: it
|
|
34
|
+
proves the detector fires on the failure it claims, and the shared `healthy` scenario
|
|
35
|
+
proves it stays quiet otherwise. `pytest tests/test_detectors.py` runs the whole matrix.
|
|
36
|
+
|
|
37
|
+
### What a good detector does
|
|
38
|
+
|
|
39
|
+
- **Returns `SKIPPED` with a named missing field** rather than guessing from absent data.
|
|
40
|
+
- **Puts the numbers it fired on into `evidence`.** A reader must be able to disagree with
|
|
41
|
+
your threshold rather than with the tool.
|
|
42
|
+
- **Always prescribes.** A finding with no suggested change is a complaint. This is
|
|
43
|
+
enforced by `test_findings_are_actionable`.
|
|
44
|
+
- **Cites its source.** Thresholds pulled from a paper are defensible; thresholds pulled
|
|
45
|
+
from nowhere are not.
|
|
46
|
+
- **Checks a second signal before accusing.** Entropy decay means nothing without the
|
|
47
|
+
reward trend; length growth means nothing without a held-out score. Conditional firing
|
|
48
|
+
is the single biggest lever on the false-positive rate.
|
|
49
|
+
- **Uses the robust helpers in `stats.py`.** Curves are noisy and heavy-tailed; means and
|
|
50
|
+
OLS slopes over-react to the handful of catastrophic steps every real run contains.
|
|
51
|
+
|
|
52
|
+
## Changing a threshold
|
|
53
|
+
|
|
54
|
+
Run the real-run validation before and after:
|
|
55
|
+
|
|
56
|
+
```bash
|
|
57
|
+
python validation/fetch.py
|
|
58
|
+
python validation/run.py --check
|
|
59
|
+
```
|
|
60
|
+
|
|
61
|
+
The simulated scenarios tell you a detector *can* fire. The five public runs in
|
|
62
|
+
`validation/runs.json` tell you whether it fires on runs that exist. If a verdict moves,
|
|
63
|
+
either the new verdict is right -- update `runs.json` and say why in the commit -- or the
|
|
64
|
+
change broke something real. Adding a public run you know the ground truth for is one of
|
|
65
|
+
the most useful contributions there is.
|
|
66
|
+
|
|
67
|
+
## Development
|
|
68
|
+
|
|
69
|
+
```bash
|
|
70
|
+
pip install -e ".[dev]"
|
|
71
|
+
pytest
|
|
72
|
+
rldoctor selftest
|
|
73
|
+
ruff check src tests
|
|
74
|
+
```
|
|
75
|
+
|
|
76
|
+
Please keep the core dependency-free beyond `numpy`. Anything heavier goes behind an
|
|
77
|
+
optional extra with a lazy import, because this tool has to install cleanly next to
|
|
78
|
+
whatever a user's cluster image already pins.
|
|
79
|
+
|
|
80
|
+
## Code style
|
|
81
|
+
|
|
82
|
+
Match the surrounding code. Comments explain *why* a threshold or an approach was chosen,
|
|
83
|
+
not what the line does — the constants in this codebase are opinions, and an opinion
|
|
84
|
+
without a reason cannot be argued with or improved.
|
rldoctor-0.1.0/LICENSE
ADDED
|
@@ -0,0 +1,202 @@
|
|
|
1
|
+
|
|
2
|
+
Apache License
|
|
3
|
+
Version 2.0, January 2004
|
|
4
|
+
http://www.apache.org/licenses/
|
|
5
|
+
|
|
6
|
+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
|
|
7
|
+
|
|
8
|
+
1. Definitions.
|
|
9
|
+
|
|
10
|
+
"License" shall mean the terms and conditions for use, reproduction,
|
|
11
|
+
and distribution as defined by Sections 1 through 9 of this document.
|
|
12
|
+
|
|
13
|
+
"Licensor" shall mean the copyright owner or entity authorized by
|
|
14
|
+
the copyright owner that is granting the License.
|
|
15
|
+
|
|
16
|
+
"Legal Entity" shall mean the union of the acting entity and all
|
|
17
|
+
other entities that control, are controlled by, or are under common
|
|
18
|
+
control with that entity. For the purposes of this definition,
|
|
19
|
+
"control" means (i) the power, direct or indirect, to cause the
|
|
20
|
+
direction or management of such entity, whether by contract or
|
|
21
|
+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
|
|
22
|
+
outstanding shares, or (iii) beneficial ownership of such entity.
|
|
23
|
+
|
|
24
|
+
"You" (or "Your") shall mean an individual or Legal Entity
|
|
25
|
+
exercising permissions granted by this License.
|
|
26
|
+
|
|
27
|
+
"Source" form shall mean the preferred form for making modifications,
|
|
28
|
+
including but not limited to software source code, documentation
|
|
29
|
+
source, and configuration files.
|
|
30
|
+
|
|
31
|
+
"Object" form shall mean any form resulting from mechanical
|
|
32
|
+
transformation or translation of a Source form, including but
|
|
33
|
+
not limited to compiled object code, generated documentation,
|
|
34
|
+
and conversions to other media types.
|
|
35
|
+
|
|
36
|
+
"Work" shall mean the work of authorship, whether in Source or
|
|
37
|
+
Object form, made available under the License, as indicated by a
|
|
38
|
+
copyright notice that is included in or attached to the work
|
|
39
|
+
(an example is provided in the Appendix below).
|
|
40
|
+
|
|
41
|
+
"Derivative Works" shall mean any work, whether in Source or Object
|
|
42
|
+
form, that is based on (or derived from) the Work and for which the
|
|
43
|
+
editorial revisions, annotations, elaborations, or other modifications
|
|
44
|
+
represent, as a whole, an original work of authorship. For the purposes
|
|
45
|
+
of this License, Derivative Works shall not include works that remain
|
|
46
|
+
separable from, or merely link (or bind by name) to the interfaces of,
|
|
47
|
+
the Work and Derivative Works thereof.
|
|
48
|
+
|
|
49
|
+
"Contribution" shall mean any work of authorship, including
|
|
50
|
+
the original version of the Work and any modifications or additions
|
|
51
|
+
to that Work or Derivative Works thereof, that is intentionally
|
|
52
|
+
submitted to Licensor for inclusion in the Work by the copyright owner
|
|
53
|
+
or by an individual or Legal Entity authorized to submit on behalf of
|
|
54
|
+
the copyright owner. For the purposes of this definition, "submitted"
|
|
55
|
+
means any form of electronic, verbal, or written communication sent
|
|
56
|
+
to the Licensor or its representatives, including but not limited to
|
|
57
|
+
communication on electronic mailing lists, source code control systems,
|
|
58
|
+
and issue tracking systems that are managed by, or on behalf of, the
|
|
59
|
+
Licensor for the purpose of discussing and improving the Work, but
|
|
60
|
+
excluding communication that is conspicuously marked or otherwise
|
|
61
|
+
designated in writing by the copyright owner as "Not a Contribution."
|
|
62
|
+
|
|
63
|
+
"Contributor" shall mean Licensor and any individual or Legal Entity
|
|
64
|
+
on behalf of whom a Contribution has been received by Licensor and
|
|
65
|
+
subsequently incorporated within the Work.
|
|
66
|
+
|
|
67
|
+
2. Grant of Copyright License. Subject to the terms and conditions of
|
|
68
|
+
this License, each Contributor hereby grants to You a perpetual,
|
|
69
|
+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
|
70
|
+
copyright license to reproduce, prepare Derivative Works of,
|
|
71
|
+
publicly display, publicly perform, sublicense, and distribute the
|
|
72
|
+
Work and such Derivative Works in Source or Object form.
|
|
73
|
+
|
|
74
|
+
3. Grant of Patent License. Subject to the terms and conditions of
|
|
75
|
+
this License, each Contributor hereby grants to You a perpetual,
|
|
76
|
+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
|
77
|
+
(except as stated in this section) patent license to make, have made,
|
|
78
|
+
use, offer to sell, sell, import, and otherwise transfer the Work,
|
|
79
|
+
where such license applies only to those patent claims licensable
|
|
80
|
+
by such Contributor that are necessarily infringed by their
|
|
81
|
+
Contribution(s) alone or by combination of their Contribution(s)
|
|
82
|
+
with the Work to which such Contribution(s) was submitted. If You
|
|
83
|
+
institute patent litigation against any entity (including a
|
|
84
|
+
cross-claim or counterclaim in a lawsuit) alleging that the Work
|
|
85
|
+
or a Contribution incorporated within the Work constitutes direct
|
|
86
|
+
or contributory patent infringement, then any patent licenses
|
|
87
|
+
granted to You under this License for that Work shall terminate
|
|
88
|
+
as of the date such litigation is filed.
|
|
89
|
+
|
|
90
|
+
4. Redistribution. You may reproduce and distribute copies of the
|
|
91
|
+
Work or Derivative Works thereof in any medium, with or without
|
|
92
|
+
modifications, and in Source or Object form, provided that You
|
|
93
|
+
meet the following conditions:
|
|
94
|
+
|
|
95
|
+
(a) You must give any other recipients of the Work or
|
|
96
|
+
Derivative Works a copy of this License; and
|
|
97
|
+
|
|
98
|
+
(b) You must cause any modified files to carry prominent notices
|
|
99
|
+
stating that You changed the files; and
|
|
100
|
+
|
|
101
|
+
(c) You must retain, in the Source form of any Derivative Works
|
|
102
|
+
that You distribute, all copyright, patent, trademark, and
|
|
103
|
+
attribution notices from the Source form of the Work,
|
|
104
|
+
excluding those notices that do not pertain to any part of
|
|
105
|
+
the Derivative Works; and
|
|
106
|
+
|
|
107
|
+
(d) If the Work includes a "NOTICE" text file as part of its
|
|
108
|
+
distribution, then any Derivative Works that You distribute must
|
|
109
|
+
include a readable copy of the attribution notices contained
|
|
110
|
+
within such NOTICE file, excluding those notices that do not
|
|
111
|
+
pertain to any part of the Derivative Works, in at least one
|
|
112
|
+
of the following places: within a NOTICE text file distributed
|
|
113
|
+
as part of the Derivative Works; within the Source form or
|
|
114
|
+
documentation, if provided along with the Derivative Works; or,
|
|
115
|
+
within a display generated by the Derivative Works, if and
|
|
116
|
+
wherever such third-party notices normally appear. The contents
|
|
117
|
+
of the NOTICE file are for informational purposes only and
|
|
118
|
+
do not modify the License. You may add Your own attribution
|
|
119
|
+
notices within Derivative Works that You distribute, alongside
|
|
120
|
+
or as an addendum to the NOTICE text from the Work, provided
|
|
121
|
+
that such additional attribution notices cannot be construed
|
|
122
|
+
as modifying the License.
|
|
123
|
+
|
|
124
|
+
You may add Your own copyright statement to Your modifications and
|
|
125
|
+
may provide additional or different license terms and conditions
|
|
126
|
+
for use, reproduction, or distribution of Your modifications, or
|
|
127
|
+
for any such Derivative Works as a whole, provided Your use,
|
|
128
|
+
reproduction, and distribution of the Work otherwise complies with
|
|
129
|
+
the conditions stated in this License.
|
|
130
|
+
|
|
131
|
+
5. Submission of Contributions. Unless You explicitly state otherwise,
|
|
132
|
+
any Contribution intentionally submitted for inclusion in the Work
|
|
133
|
+
by You to the Licensor shall be under the terms and conditions of
|
|
134
|
+
this License, without any additional terms or conditions.
|
|
135
|
+
Notwithstanding the above, nothing herein shall supersede or modify
|
|
136
|
+
the terms of any separate license agreement you may have executed
|
|
137
|
+
with Licensor regarding such Contributions.
|
|
138
|
+
|
|
139
|
+
6. Trademarks. This License does not grant permission to use the trade
|
|
140
|
+
names, trademarks, service marks, or product names of the Licensor,
|
|
141
|
+
except as required for reasonable and customary use in describing the
|
|
142
|
+
origin of the Work and reproducing the content of the NOTICE file.
|
|
143
|
+
|
|
144
|
+
7. Disclaimer of Warranty. Unless required by applicable law or
|
|
145
|
+
agreed to in writing, Licensor provides the Work (and each
|
|
146
|
+
Contributor provides its Contributions) on an "AS IS" BASIS,
|
|
147
|
+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
148
|
+
implied, including, without limitation, any warranties or conditions
|
|
149
|
+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
|
|
150
|
+
PARTICULAR PURPOSE. You are solely responsible for determining the
|
|
151
|
+
appropriateness of using or redistributing the Work and assume any
|
|
152
|
+
risks associated with Your exercise of permissions under this License.
|
|
153
|
+
|
|
154
|
+
8. Limitation of Liability. In no event and under no legal theory,
|
|
155
|
+
whether in tort (including negligence), contract, or otherwise,
|
|
156
|
+
unless required by applicable law (such as deliberate and grossly
|
|
157
|
+
negligent acts) or agreed to in writing, shall any Contributor be
|
|
158
|
+
liable to You for damages, including any direct, indirect, special,
|
|
159
|
+
incidental, or consequential damages of any character arising as a
|
|
160
|
+
result of this License or out of the use or inability to use the
|
|
161
|
+
Work (including but not limited to damages for loss of goodwill,
|
|
162
|
+
work stoppage, computer failure or malfunction, or any and all
|
|
163
|
+
other commercial damages or losses), even if such Contributor
|
|
164
|
+
has been advised of the possibility of such damages.
|
|
165
|
+
|
|
166
|
+
9. Accepting Warranty or Additional Liability. While redistributing
|
|
167
|
+
the Work or Derivative Works thereof, You may choose to offer,
|
|
168
|
+
and charge a fee for, acceptance of support, warranty, indemnity,
|
|
169
|
+
or other liability obligations and/or rights consistent with this
|
|
170
|
+
License. However, in accepting such obligations, You may act only
|
|
171
|
+
on Your own behalf and on Your sole responsibility, not on behalf
|
|
172
|
+
of any other Contributor, and only if You agree to indemnify,
|
|
173
|
+
defend, and hold each Contributor harmless for any liability
|
|
174
|
+
incurred by, or claims asserted against, such Contributor by reason
|
|
175
|
+
of your accepting any such warranty or additional liability.
|
|
176
|
+
|
|
177
|
+
END OF TERMS AND CONDITIONS
|
|
178
|
+
|
|
179
|
+
APPENDIX: How to apply the Apache License to your work.
|
|
180
|
+
|
|
181
|
+
To apply the Apache License to your work, attach the following
|
|
182
|
+
boilerplate notice, with the fields enclosed by brackets "[]"
|
|
183
|
+
replaced with your own identifying information. (Don't include
|
|
184
|
+
the brackets!) The text should be enclosed in the appropriate
|
|
185
|
+
comment syntax for the file format. We also recommend that a
|
|
186
|
+
file or class name and description of purpose be included on the
|
|
187
|
+
same "printed page" as the copyright notice for easier
|
|
188
|
+
identification within third-party archives.
|
|
189
|
+
|
|
190
|
+
Copyright [yyyy] [name of copyright owner]
|
|
191
|
+
|
|
192
|
+
Licensed under the Apache License, Version 2.0 (the "License");
|
|
193
|
+
you may not use this file except in compliance with the License.
|
|
194
|
+
You may obtain a copy of the License at
|
|
195
|
+
|
|
196
|
+
http://www.apache.org/licenses/LICENSE-2.0
|
|
197
|
+
|
|
198
|
+
Unless required by applicable law or agreed to in writing, software
|
|
199
|
+
distributed under the License is distributed on an "AS IS" BASIS,
|
|
200
|
+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
201
|
+
See the License for the specific language governing permissions and
|
|
202
|
+
limitations under the License.
|