remotedesktop 0.6.0__tar.gz → 0.7.0__tar.gz

{remotedesktop-0.6.0 → remotedesktop-0.7.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: remotedesktop
-Version: 0.6.0
+Version: 0.7.0
 Summary: Remote desktop client/server for Windows computers on the same LAN, with autodiscovery. Provides screen, keyboard, mouse, and clipboard sharing without RDP or Microsoft authentication.
 Author-email: James Abel <j@abel.co>
 License-Expression: MIT

{remotedesktop-0.6.0 → remotedesktop-0.7.0}/src/remotedesktop/__init__.py

@@ -1,3 +1,3 @@
 """Remote desktop client/server for Windows computers on the same LAN."""
 
-__version__ = "0.6.0"
+__version__ = "0.7.0"

{remotedesktop-0.6.0 → remotedesktop-0.7.0}/src/remotedesktop/client.py

@@ -111,9 +111,7 @@ class ClientWindow(QMainWindow):
         self.connection_log = QPlainTextEdit(self)
         self.connection_log.setReadOnly(True)
         self.connection_log.setMaximumBlockCount(1000)
-        log_dock = QDockWidget("Connection log", self)
-        log_dock.setWidget(self.connection_log)
-        self.addDockWidget(Qt.DockWidgetArea.BottomDockWidgetArea, log_dock)
+        tabs.addTab(self.connection_log, "Connection log")
 
         self.discovery_panel.serverActivated.connect(self._on_server_activated)
         self.discovery_panel.serversFound.connect(self._record_discovered)

{remotedesktop-0.6.0 → remotedesktop-0.7.0}/src/remotedesktop/server.py

@@ -64,7 +64,7 @@ class ServerWindow(QMainWindow):
         status_layout = QVBoxLayout(status_tab)
         status_layout.addWidget(self._summary)
         status_layout.addWidget(self.autostart_checkbox, alignment=Qt.AlignmentFlag.AlignHCenter)
-        status_layout.addWidget(self.connection_log, stretch=1)
+        status_layout.addStretch(1)
 
         # Tests inject a connection to a temp database; the app uses the default.
         self._db = connection if connection is not None else db.connect(default_db_path())
@@ -75,6 +75,7 @@ class ServerWindow(QMainWindow):
             InventoryTab(self.inventory, "Revoke access", self._revoke_client),
             "Clients on LAN",
         )
+        tabs.addTab(self.connection_log, "Connection log")
         self.setCentralWidget(tabs)
 
         if credentials is None:

{remotedesktop-0.6.0 → remotedesktop-0.7.0}/src/remotedesktop/sharing.py

@@ -22,6 +22,7 @@ from typing import cast
 from PySide6.QtCore import QObject, QTimer, Signal
 from PySide6.QtGui import QGuiApplication, QImage
 from PySide6.QtNetwork import (
+    QAbstractSocket,
     QHostAddress,
     QSslCertificate,
     QSslKey,
@@ -44,7 +45,10 @@ from remotedesktop import db, tls
 
 _log = logging.getLogger("remotedesktop.sharing")
 
-DEFAULT_FPS = 10
+# 30 fps keeps key-to-glyph latency low (~17 ms average sampling delay).
+# Affordable since inter-frame compression: an unchanged screen costs only
+# a capture and a memory compare per tick — nothing is encoded or sent.
+DEFAULT_FPS = 30
 # Only for full frames to legacy (0.5.0) clients, which force-decode frames
 # as JPEG. Delta-capable clients get lossless PNG keyframes and delta bands.
 JPEG_QUALITY = 70
@@ -173,6 +177,9 @@ class ShareServer(QObject):
         while self._server.hasPendingConnections():
             # QSslServer hands out QSslSockets; the stubs say QTcpSocket.
             sock = cast(QSslSocket, self._server.nextPendingConnection())
+            # TCP_NODELAY: input events and delta frames are small messages;
+            # Nagle + delayed ACK would add tens to hundreds of ms of latency.
+            sock.setSocketOption(QAbstractSocket.SocketOption.LowDelayOption, 1)
             self.status.emit(
                 f"Incoming TLS connection from {_peer(sock)} "
                 f"(encrypted={sock.isEncrypted()}) — waiting for hello"
@@ -568,6 +575,9 @@ class ShareClient(QObject):
         self._socket.ignoreSslErrors()
 
     def _on_encrypted(self) -> None:
+        # TCP_NODELAY (settable only once connected): keystrokes are tiny
+        # messages; Nagle + delayed ACK would add tens to hundreds of ms.
+        self._socket.setSocketOption(QAbstractSocket.SocketOption.LowDelayOption, 1)
         cert = self._socket.peerCertificate()
         fingerprint = "" if cert.isNull() else tls.certificate_fingerprint(cert)
         self._server_fingerprint = fingerprint

{remotedesktop-0.6.0 → remotedesktop-0.7.0}/src/remotedesktop/viewer.py

@@ -1,6 +1,6 @@
 """Viewer widget that displays the remote desktop and forwards input to it."""
 
-from PySide6.QtCore import QPointF, QRectF, Qt, Signal
+from PySide6.QtCore import QPointF, QRectF, QSize, Qt, Signal
 from PySide6.QtGui import (
     QFocusEvent,
     QImage,
@@ -32,7 +32,10 @@ class ViewerWidget(QWidget):
         # The frame stays at the server's full resolution; what is painted is
         # a SmoothTransformation-scaled copy (proper filtering, unlike the
         # nearest-neighbor scaling of drawPixmap into a rect), cached until
-        # the frame or the display size changes.
+        # the frame or the display size changes. It is scaled to *device*
+        # pixels and stamped with the devicePixelRatio: sizing it in logical
+        # pixels would make Qt bilinear-upscale it again by the Windows
+        # display-scaling factor (125-150% on most monitors), blurring text.
         self._scaled: QPixmap | None = None
         self._message = "Not connected"
         # Buttons/keys currently held, so releases can be forwarded even when
@@ -175,10 +178,21 @@ class ViewerWidget(QWidget):
             painter.drawText(self.rect(), Qt.AlignmentFlag.AlignCenter, self._message)
             return
         rect = self._display_rect().toRect()
-        if self._scaled is None or self._scaled.size() != rect.size():
-            self._scaled = self._frame.scaled(
-                rect.size(),
-                Qt.AspectRatioMode.IgnoreAspectRatio,  # rect is already aspect-correct
-                Qt.TransformationMode.SmoothTransformation,
-            )
+        dpr = self.devicePixelRatioF()
+        target = QSize(round(rect.width() * dpr), round(rect.height() * dpr))
+        if (
+            self._scaled is None
+            or self._scaled.size() != target
+            or self._scaled.devicePixelRatio() != dpr
+        ):
+            if self._frame.size() == target:
+                # Displayed at exactly 1:1 device pixels — no resample at all.
+                self._scaled = QPixmap(self._frame)
+            else:
+                self._scaled = self._frame.scaled(
+                    target,
+                    Qt.AspectRatioMode.IgnoreAspectRatio,  # rect is already aspect-correct
+                    Qt.TransformationMode.SmoothTransformation,
+                )
+            self._scaled.setDevicePixelRatio(dpr)
         painter.drawPixmap(rect.topLeft(), self._scaled)

{remotedesktop-0.6.0 → remotedesktop-0.7.0}/tests/test_sharing.py

@@ -3,7 +3,7 @@ import time
 
 from PySide6.QtCore import QEventLoop
 from PySide6.QtGui import QColor, QImage, QPainter
-from PySide6.QtNetwork import QSslSocket
+from PySide6.QtNetwork import QAbstractSocket, QSslSocket
 
 from remotedesktop import db, tls
 from remotedesktop.config import KnownServers, PairedClients
@@ -399,6 +399,22 @@ def test_disconnected_client_paths_are_noops(qapp, tmp_path):
     client.close()
 
 
+def test_low_delay_is_set_on_both_ends(qapp, credentials, tmp_path):
+    server = make_server(credentials, tmp_path, approve=lambda *_: True)
+    client = make_client(tmp_path)
+    names = []
+    client.connected.connect(names.append)
+    client.connect_to("127.0.0.1", server.port)
+    try:
+        pump(qapp, lambda: names and server._streams)
+        option = QAbstractSocket.SocketOption.LowDelayOption
+        assert client._socket.socketOption(option) == 1
+        assert server._streams[0].socket.socketOption(option) == 1
+    finally:
+        client.close()
+        server.close()
+
+
 def solid_image(color, *, width=64, height=128):
     image = QImage(width, height, QImage.Format.Format_RGB32)
     image.fill(QColor(color))

{remotedesktop-0.6.0 → remotedesktop-0.7.0}/tests/test_smoke.py

@@ -56,3 +56,19 @@ def test_viewer_widget_shows_and_clears_frames(qapp) -> None:
     assert viewer.has_frame
     viewer.clear("gone")
     assert not viewer.has_frame
+
+
+def test_viewer_scales_frames_in_device_pixels(qapp) -> None:
+    from PySide6.QtGui import QImage
+
+    viewer = ViewerWidget()
+    viewer.resize(320, 240)
+    viewer.show_frame(QImage(640, 480, QImage.Format.Format_RGB32))  # same 4:3 aspect
+    viewer.grab()  # forces a paint pass without showing a window
+    assert viewer._scaled is not None
+    dpr = viewer.devicePixelRatioF()
+    # Scaled to physical pixels and stamped with the ratio, so painting it
+    # never resamples a second time.
+    assert viewer._scaled.devicePixelRatio() == dpr
+    assert viewer._scaled.size().width() == round(320 * dpr)
+    assert viewer._scaled.size().height() == round(240 * dpr)