rekordbox-edit 0.4.0.dev40__tar.gz → 0.4.0.dev42__tar.gz

{rekordbox_edit-0.4.0.dev40 → rekordbox_edit-0.4.0.dev42}/CHANGELOG.md

@@ -1,6 +1,8 @@
-## v0.4.0.dev40 (2026-06-05)
+## v0.4.0.dev42 (2026-06-05)
 
 
+- refactor(commands): group command-specific args into EditArgs and ConvertArgs dataclasses
+- refactor(commands): group confirmation flags into ConfirmationArgs dataclass
 - docs: update README.md
 - refactor(query): group filter args into FilterArgs dataclass
 - refactor(cli): extract convert-specific options into convert_click_options

{rekordbox_edit-0.4.0.dev40 → rekordbox_edit-0.4.0.dev42}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rekordbox-edit
-Version: 0.4.0.dev40
+Version: 0.4.0.dev42
 Summary: Tools for managing and modifying a RekordBox library en-masse
 Project-URL: Homepage, https://github.com/jviall/rekordbox-edit
 Project-URL: Repository, https://github.com/jviall/rekordbox-edit

{rekordbox_edit-0.4.0.dev40 → rekordbox_edit-0.4.0.dev42}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "rekordbox-edit"
-version = "0.4.0.dev40"
+version = "0.4.0.dev42"
 description = "Tools for managing and modifying a RekordBox library en-masse"
 authors = [{ name = "James Viall", email= "jamesviall@pm.me"}]
 license = "MIT"

{rekordbox_edit-0.4.0.dev40 → rekordbox_edit-0.4.0.dev42}/rekordbox_edit/args.py

@@ -52,3 +52,74 @@ def filter_args_from_kwargs(**kwargs) -> FilterArgs:
         format=list(kwargs.get("format") or []),
         match_all=bool(kwargs.get("match_all", False)),
     )
+
+
+@dataclass
+class ConfirmationArgs:
+    """How the user gates a side effect before it lands.
+
+    `dry_run` skips the change entirely. `yes` skips confirmation and applies
+    the batch. `interactive` prompts per item. With all three false, the
+    caller is expected to prompt once for the batch.
+    """
+
+    dry_run: bool = False
+    yes: bool = False
+    interactive: bool = False
+
+
+def confirmation_args_from_kwargs(**kwargs) -> ConfirmationArgs:
+    """Pack the flat Click kwargs for the `global_click_confirmations` group into a ConfirmationArgs."""
+    return ConfirmationArgs(
+        dry_run=bool(kwargs.get("dry_run", False)),
+        yes=bool(kwargs.get("yes", False)),
+        interactive=bool(kwargs.get("interactive", False)),
+    )
+
+
+@dataclass
+class EditArgs:
+    """Edit-command inputs that describe what to change.
+
+    `field` names a column from `FIELD_COLUMNS` in `commands/edit.py`.
+    `match_pattern` is the optional substring to find within the current value;
+    when omitted, the whole value is replaced. `multi` allows the edit to
+    apply to more than one matched track.
+    """
+
+    field: str
+    replace_value: str
+    match_pattern: str | None = None
+    multi: bool = False
+
+
+def edit_args_from_kwargs(**kwargs) -> EditArgs:
+    """Pack the flat Click kwargs for the `edit_click_options` group plus `field` into an EditArgs."""
+    return EditArgs(
+        field=kwargs["field"],
+        replace_value=kwargs["replace_value"],
+        match_pattern=kwargs.get("match_pattern"),
+        multi=bool(kwargs.get("multi", False)),
+    )
+
+
+@dataclass
+class ConvertArgs:
+    """Convert-command inputs that describe the output and conflict policy.
+
+    `delete` is tri-state: `None` defers to a per-format default in
+    `_convert`, while `True` / `False` are explicit.
+    """
+
+    format_out: str
+    delete: bool | None = None
+    overwrite: bool = False
+
+
+def convert_args_from_kwargs(**kwargs) -> ConvertArgs:
+    """Pack the flat Click kwargs for the `convert_click_options` group into a ConvertArgs."""
+    return ConvertArgs(
+        format_out=kwargs["format_out"],
+        delete=kwargs.get("delete"),
+        overwrite=bool(kwargs.get("overwrite", False)),
+    )

{rekordbox_edit-0.4.0.dev40 → rekordbox_edit-0.4.0.dev42}/rekordbox_edit/commands/convert.py

@@ -22,7 +22,14 @@ from rekordbox_edit._click import (
     print_option,
     track_ids_argument,
 )
-from rekordbox_edit.args import filter_args_from_kwargs
+from rekordbox_edit.args import (
+    ConfirmationArgs,
+    ConvertArgs,
+    FilterArgs,
+    confirmation_args_from_kwargs,
+    convert_args_from_kwargs,
+    filter_args_from_kwargs,
+)
 from rekordbox_edit.logger import get_debug_file_path, set_level
 from rekordbox_edit.query import get_filtered_content
 from rekordbox_edit.display import PrintableField, print_track_info
@@ -286,15 +293,57 @@ def convert_command(
 
     Skips lossy formats and files already in the target format.
     """
+    filters = filter_args_from_kwargs(
+        track_id=track_id,
+        track_ids=track_ids,
+        playlist=playlist,
+        exact_playlist=exact_playlist,
+        album=album,
+        exact_album=exact_album,
+        artist=artist,
+        exact_artist=exact_artist,
+        title=title,
+        exact_title=exact_title,
+        path=path,
+        exact_path=exact_path,
+        format=format,
+        match_all=match_all,
+    )
+    confirmation = confirmation_args_from_kwargs(
+        dry_run=dry_run, yes=yes, interactive=interactive
+    )
+    convert_args = convert_args_from_kwargs(
+        format_out=format_out, delete=delete, overwrite=overwrite
+    )
+    _convert(filters, confirmation, convert_args, print_opt)
+
+
+def _convert(
+    filters: FilterArgs,
+    confirmation: ConfirmationArgs,
+    convert_args: ConvertArgs,
+    print_opt: PrintChoice | None,
+) -> None:
+    """Convert audio files for tracks matching `filters`."""
     from rekordbox_edit.utils import ffmpeg_in_path, get_ffmpeg_directions
 
+    dry_run, yes, interactive = (
+        confirmation.dry_run,
+        confirmation.yes,
+        confirmation.interactive,
+    )
+    format_out, delete, overwrite = (
+        convert_args.format_out,
+        convert_args.delete,
+        convert_args.overwrite,
+    )
     set_level(print_opt)
 
     piped_stdin = not sys.stdin.isatty()
     if piped_stdin:
         stdin_data = sys.stdin.read().strip()
         if stdin_data:
-            track_ids = list(track_ids or []) + stdin_data.split()
+            filters.track_ids = list(filters.track_ids) + stdin_data.split()
 
     # Validate --print option requirements
     scripting_mode = print_opt in (PrintChoice.IDS, PrintChoice.SILENT)
@@ -362,22 +411,6 @@ def convert_command(
         logger.debug("Database connection established")
 
         # === QUERY & FILTER ===
-        filters = filter_args_from_kwargs(
-            track_id=track_id,
-            track_ids=track_ids,
-            playlist=playlist,
-            exact_playlist=exact_playlist,
-            album=album,
-            exact_album=exact_album,
-            artist=artist,
-            exact_artist=exact_artist,
-            title=title,
-            exact_title=exact_title,
-            path=path,
-            exact_path=exact_path,
-            format=format,
-            match_all=match_all,
-        )
         result = get_filtered_content(db, filters)
         filtered_content = result.scalars().all()
         logger.debug(f"Query returned {len(filtered_content)} tracks")

{rekordbox_edit-0.4.0.dev40 → rekordbox_edit-0.4.0.dev42}/rekordbox_edit/commands/edit.py

@@ -16,7 +16,14 @@ from rekordbox_edit._click import (
     print_option,
     track_ids_argument,
 )
-from rekordbox_edit.args import filter_args_from_kwargs
+from rekordbox_edit.args import (
+    ConfirmationArgs,
+    EditArgs,
+    FilterArgs,
+    confirmation_args_from_kwargs,
+    edit_args_from_kwargs,
+    filter_args_from_kwargs,
+)
 from rekordbox_edit.logger import get_debug_file_path, set_level
 from rekordbox_edit.query import get_filtered_content
 from rekordbox_edit.display import PrintableField, print_track_info
@@ -84,7 +91,52 @@ def edit_command(
     print_opt: PrintChoice | None,
 ):
     """Edit a metadata field on tracks in the RekordBox database."""
+    filters = filter_args_from_kwargs(
+        track_id=track_id,
+        track_ids=track_ids,
+        playlist=playlist,
+        exact_playlist=exact_playlist,
+        album=album,
+        exact_album=exact_album,
+        artist=artist,
+        exact_artist=exact_artist,
+        title=title,
+        exact_title=exact_title,
+        path=path,
+        exact_path=exact_path,
+        format=format,
+        match_all=match_all,
+    )
+    confirmation = confirmation_args_from_kwargs(
+        dry_run=dry_run, yes=yes, interactive=interactive
+    )
+    edit_args = edit_args_from_kwargs(
+        field=field,
+        replace_value=replace_value,
+        match_pattern=match_pattern,
+        multi=multi,
+    )
+    _edit(filters, confirmation, edit_args, print_opt)
+
 
+def _edit(
+    filters: FilterArgs,
+    confirmation: ConfirmationArgs,
+    edit_args: EditArgs,
+    print_opt: PrintChoice | None,
+) -> None:
+    """Apply a field edit to tracks matching `filters`."""
+    dry_run, yes, interactive = (
+        confirmation.dry_run,
+        confirmation.yes,
+        confirmation.interactive,
+    )
+    field, replace_value, match_pattern, multi = (
+        edit_args.field,
+        edit_args.replace_value,
+        edit_args.match_pattern,
+        edit_args.multi,
+    )
     set_level(print_opt)
 
     piped_stdin = False
@@ -92,7 +144,7 @@ def edit_command(
         stdin_data = sys.stdin.read().strip()
         if stdin_data:
             piped_stdin = True
-            track_ids = list(track_ids or []) + stdin_data.split()
+            filters.track_ids = list(filters.track_ids) + stdin_data.split()
 
     scripting_mode = print_opt in (PrintChoice.IDS, PrintChoice.SILENT)
     if scripting_mode and not (dry_run or yes):
@@ -107,22 +159,6 @@ def edit_command(
     if not db.session:
         raise RuntimeError("Failed to connect to Rekordbox Database: No Session.")
 
-    filters = filter_args_from_kwargs(
-        track_id=track_id,
-        track_ids=track_ids,
-        playlist=playlist,
-        exact_playlist=exact_playlist,
-        album=album,
-        exact_album=exact_album,
-        artist=artist,
-        exact_artist=exact_artist,
-        title=title,
-        exact_title=exact_title,
-        path=path,
-        exact_path=exact_path,
-        format=format,
-        match_all=match_all,
-    )
     result = get_filtered_content(db, filters)
     tracks = result.scalars().all()
 

{rekordbox_edit-0.4.0.dev40 → rekordbox_edit-0.4.0.dev42}/uv.lock

@@ -1010,7 +1010,7 @@ wheels = [
 
 [[package]]
 name = "rekordbox-edit"
-version = "0.4.0.dev40"
+version = "0.4.0.dev42"
 source = { editable = "." }
 dependencies = [
     { name = "click" },