rekordbox-edit 0.4.0.dev21__tar.gz → 0.4.0.dev22__tar.gz

{rekordbox_edit-0.4.0.dev21 → rekordbox_edit-0.4.0.dev22}/CHANGELOG.md

@@ -1,6 +1,11 @@
-## v0.4.0.dev21 (2026-05-16)
+## v0.4.0.dev22 (2026-05-17)
 
 
+- feat(edit): add --match for literal find/replace within field value
+- Introduces a _compute_new_value helper and --match option so that
+rbe edit can replace a substring of the current field value instead of
+performing a wholesale replacement; None current values and non-matching
+patterns are treated as no-ops.
 - chore: add max-complexity lint rule
 - docs: update AGENTS.md
 - test: add coverage for --interactive + --yes skipping all confirms

{rekordbox_edit-0.4.0.dev21 → rekordbox_edit-0.4.0.dev22}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rekordbox-edit
-Version: 0.4.0.dev21
+Version: 0.4.0.dev22
 Summary: Tools for managing and modifying a RekordBox library en-masse
 Project-URL: Homepage, https://github.com/jviall/rekordbox-edit
 Project-URL: Repository, https://github.com/jviall/rekordbox-edit

{rekordbox_edit-0.4.0.dev21 → rekordbox_edit-0.4.0.dev22}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "rekordbox-edit"
-version = "0.4.0.dev21"
+version = "0.4.0.dev22"
 description = "Tools for managing and modifying a RekordBox library en-masse"
 authors = [{ name = "James Viall", email= "jamesviall@pm.me"}]
 license = "MIT"

{rekordbox_edit-0.4.0.dev21 → rekordbox_edit-0.4.0.dev22}/rekordbox_edit/commands/edit.py

@@ -26,6 +26,18 @@ FIELD_COLUMNS = {
 }
 
 
+def _compute_new_value(
+    current: str | int | None,
+    match_pattern: str | None,
+    replace_value: str | int,
+) -> str | int | None:
+    """Derive the new field value."""
+    if current is None:
+        return None
+    if match_pattern is not None:
+        return str(current).replace(match_pattern, str(replace_value))
+    return replace_value
+
 
 @click.command(
     epilog=f"Debug logs for each run can be found at:\n{get_debug_file_path().parent}"
@@ -54,6 +66,13 @@ FIELD_COLUMNS = {
     required=True,
     help="The new value to write to the field",
 )
+@click.option(
+    "--match",
+    "match_pattern",
+    default=None,
+    metavar="PATTERN",
+    help="Find this literal string within the field value and replace only that portion",
+)
 @track_ids_argument
 @click.argument(
     "field",
@@ -62,10 +81,11 @@ FIELD_COLUMNS = {
 def edit_command(
     field: str,
     replace_value: str,
+    match_pattern: str | None,
     dry_run: bool,
     yes: bool,
     interactive: bool,
-    track_ids: tuple,
+    track_ids: List[str] | None,
     track_id: List[str] | None,
     playlist: List[str] | None,
     exact_playlist: List[str] | None,
@@ -99,9 +119,7 @@ def edit_command(
         )
 
     if piped_stdin and not (dry_run or yes):
-        raise click.UsageError(
-            "Piping track IDs into edit requires --dry-run or --yes"
-        )
+        raise click.UsageError("Piping track IDs into edit requires --dry-run or --yes")
 
     db = Rekordbox6Database()
     if not db.session:
@@ -127,11 +145,13 @@ def edit_command(
     tracks = result.scalars().all()
 
     col_name = FIELD_COLUMNS[field]
-    edits = [
-        (track, replace_value)
-        for track in tracks
-        if getattr(track, col_name) != replace_value
-    ]
+    edits = []
+    for track in tracks:
+        current = getattr(track, col_name)
+        new_value = _compute_new_value(current, match_pattern, replace_value)
+        if new_value is None or new_value == current:
+            continue
+        edits.append((track, new_value))
 
     if not edits:
         logger.info("No changes to make.")

{rekordbox_edit-0.4.0.dev21 → rekordbox_edit-0.4.0.dev22}/tests/commands/test_edit.py

@@ -246,3 +246,184 @@ class TestEditCommandPhase1:
 
         assert result.exit_code == 0
         assert "99999" in result.output
+
+
+class TestEditCommandPhase3:
+    """Phase 3: --match flag for literal find/replace within field value."""
+
+    @patch("rekordbox_edit.commands.edit.confirm")
+    @patch("rekordbox_edit.commands.edit.get_filtered_content")
+    @patch("rekordbox_edit.commands.edit.Rekordbox6Database")
+    def test_match_replaces_substring(
+        self, mock_db_class, mock_gfc, mock_confirm, make_djmd_content_item
+    ):
+        """--match substitutes the pattern within the current value."""
+        track = make_djmd_content_item(Title="Dark Matter (feat. Jane)")
+        mock_db, mock_result = _make_db_and_result([track])
+        mock_db_class.return_value = mock_db
+        mock_gfc.return_value = mock_result
+        mock_confirm.return_value = True
+
+        from click.testing import CliRunner
+        result = CliRunner().invoke(
+            edit_command,
+            ["Title", "--match", "feat.", "--replace", "ft."],
+        )
+
+        assert result.exit_code == 0
+        assert track.Title == "Dark Matter (ft. Jane)"
+        mock_db.session.commit.assert_called_once()
+
+    @patch("rekordbox_edit.commands.edit.get_filtered_content")
+    @patch("rekordbox_edit.commands.edit.Rekordbox6Database")
+    def test_match_no_match_is_noop(
+        self, mock_db_class, mock_gfc, make_djmd_content_item
+    ):
+        """When --match pattern is not found in current value, track is a no-op."""
+        track = make_djmd_content_item(Title="Dark Matter")
+        mock_db, mock_result = _make_db_and_result([track])
+        mock_db_class.return_value = mock_db
+        mock_gfc.return_value = mock_result
+
+        from click.testing import CliRunner
+        result = CliRunner().invoke(
+            edit_command,
+            ["Title", "--match", "feat.", "--replace", "ft.", "--yes"],
+        )
+
+        assert result.exit_code == 0
+        mock_db.session.commit.assert_not_called()
+
+    @patch("rekordbox_edit.commands.edit.get_filtered_content")
+    @patch("rekordbox_edit.commands.edit.Rekordbox6Database")
+    def test_match_with_none_current_value_is_noop(
+        self, mock_db_class, mock_gfc, make_djmd_content_item
+    ):
+        """--match on a track where the field is None is silently skipped."""
+        track = make_djmd_content_item(Title=None)
+        mock_db, mock_result = _make_db_and_result([track])
+        mock_db_class.return_value = mock_db
+        mock_gfc.return_value = mock_result
+
+        from click.testing import CliRunner
+        result = CliRunner().invoke(
+            edit_command,
+            ["Title", "--match", "feat.", "--replace", "ft.", "--yes"],
+        )
+
+        assert result.exit_code == 0
+        mock_db.session.commit.assert_not_called()
+
+    @patch("rekordbox_edit.commands.edit.get_filtered_content")
+    @patch("rekordbox_edit.commands.edit.Rekordbox6Database")
+    def test_match_treats_pattern_as_literal(
+        self, mock_db_class, mock_gfc, make_djmd_content_item
+    ):
+        """--match treats the pattern as a literal string, not a regex."""
+        # "1.0" as a regex would also match "1X0"; as a literal it should not
+        track = make_djmd_content_item(Title="Version 1X0")
+        mock_db, mock_result = _make_db_and_result([track])
+        mock_db_class.return_value = mock_db
+        mock_gfc.return_value = mock_result
+
+        from click.testing import CliRunner
+        result = CliRunner().invoke(
+            edit_command,
+            ["Title", "--match", "1.0", "--replace", "2.0", "--yes"],
+        )
+
+        assert result.exit_code == 0
+        mock_db.session.commit.assert_not_called()
+
+
+class TestEditCommandUnicode:
+    """Unicode and multibyte character handling in edit command fields."""
+
+    @patch("rekordbox_edit.commands.edit.confirm")
+    @patch("rekordbox_edit.commands.edit.get_filtered_content")
+    @patch("rekordbox_edit.commands.edit.Rekordbox6Database")
+    def test_wholesale_replace_with_unicode_value(
+        self, mock_db_class, mock_gfc, mock_confirm, make_djmd_content_item
+    ):
+        """--replace accepts and writes multibyte unicode titles correctly."""
+        track = make_djmd_content_item(Title="Original Title")
+        mock_db, mock_result = _make_db_and_result([track])
+        mock_db_class.return_value = mock_db
+        mock_gfc.return_value = mock_result
+        mock_confirm.return_value = True
+
+        from click.testing import CliRunner
+        result = CliRunner().invoke(
+            edit_command,
+            ["Title", "--replace", "日本語タイトル"],
+        )
+
+        assert result.exit_code == 0
+        assert track.Title == "日本語タイトル"
+        mock_db.session.commit.assert_called_once()
+
+    @patch("rekordbox_edit.commands.edit.confirm")
+    @patch("rekordbox_edit.commands.edit.get_filtered_content")
+    @patch("rekordbox_edit.commands.edit.Rekordbox6Database")
+    def test_wholesale_replace_of_unicode_current_value(
+        self, mock_db_class, mock_gfc, mock_confirm, make_djmd_content_item
+    ):
+        """A track with a unicode title can be replaced wholesale."""
+        track = make_djmd_content_item(Title="Ü-Bahn Nights (feat. Ångström)")
+        mock_db, mock_result = _make_db_and_result([track])
+        mock_db_class.return_value = mock_db
+        mock_gfc.return_value = mock_result
+        mock_confirm.return_value = True
+
+        from click.testing import CliRunner
+        result = CliRunner().invoke(
+            edit_command,
+            ["Title", "--replace", "U-Bahn Nights (feat. Angstrom)"],
+        )
+
+        assert result.exit_code == 0
+        assert track.Title == "U-Bahn Nights (feat. Angstrom)"
+        mock_db.session.commit.assert_called_once()
+
+    @patch("rekordbox_edit.commands.edit.confirm")
+    @patch("rekordbox_edit.commands.edit.get_filtered_content")
+    @patch("rekordbox_edit.commands.edit.Rekordbox6Database")
+    def test_match_replace_within_unicode_title(
+        self, mock_db_class, mock_gfc, mock_confirm, make_djmd_content_item
+    ):
+        """--match correctly finds and replaces a substring within a unicode title."""
+        track = make_djmd_content_item(Title="夜 feat. 山田太郎")
+        mock_db, mock_result = _make_db_and_result([track])
+        mock_db_class.return_value = mock_db
+        mock_gfc.return_value = mock_result
+        mock_confirm.return_value = True
+
+        from click.testing import CliRunner
+        result = CliRunner().invoke(
+            edit_command,
+            ["Title", "--match", "feat.", "--replace", "ft."],
+        )
+
+        assert result.exit_code == 0
+        assert track.Title == "夜 ft. 山田太郎"
+        mock_db.session.commit.assert_called_once()
+
+    @patch("rekordbox_edit.commands.edit.get_filtered_content")
+    @patch("rekordbox_edit.commands.edit.Rekordbox6Database")
+    def test_noop_when_unicode_values_are_equal(
+        self, mock_db_class, mock_gfc, make_djmd_content_item
+    ):
+        """No edit is made when the current unicode value already equals --replace."""
+        track = make_djmd_content_item(Title="Ø (Disambiguation)")
+        mock_db, mock_result = _make_db_and_result([track])
+        mock_db_class.return_value = mock_db
+        mock_gfc.return_value = mock_result
+
+        from click.testing import CliRunner
+        result = CliRunner().invoke(
+            edit_command,
+            ["Title", "--replace", "Ø (Disambiguation)", "--yes"],
+        )
+
+        assert result.exit_code == 0
+        mock_db.session.commit.assert_not_called()

{rekordbox_edit-0.4.0.dev21 → rekordbox_edit-0.4.0.dev22}/uv.lock

@@ -985,7 +985,7 @@ wheels = [
 
 [[package]]
 name = "rekordbox-edit"
-version = "0.4.0.dev21"
+version = "0.4.0.dev22"
 source = { editable = "." }
 dependencies = [
     { name = "click" },