rekordbox-edit 0.13.1.dev2__tar.gz → 0.13.1.dev4__tar.gz

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/CHANGELOG.md

@@ -1,6 +1,17 @@
-## v0.13.1.dev2 (2026-09-08)
-
-
+## v0.13.1.dev4 (2026-09-10)
+
+
+- fix(rating): use rekordbox's 0-5 scale, not the XML x51 encoding
+- fix(display): keep the new value visible in a change preview
+- The changed column rendered the old and new values into one cell that was
+no-wrap with ellipsis overflow. For FolderPath the old value alone fills
+the column at any ordinary terminal width, so the new value was truncated
+away and --dry-run showed only what the row already held. A bulk repoint
+was unverifiable from it; the new value first appeared around 600 columns.
+- The column now wraps instead of ellipsising when it carries a preview, and
+the new value renders beneath the struck-through old one.
+- The existing test missed this by asserting against a 400-column console
+with a single short column, which is not a width anyone runs.
 - chore(deps): update dependency click to v8.5.0
 - fix(edit): survive a row whose analysis directory is missing
 - A row can carry an AnalysisDataPath naming a directory that was never

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: rekordbox-edit
-Version: 0.13.1.dev2
+Version: 0.13.1.dev4
 Summary: Tools for managing and modifying a RekordBox library en-masse
 Project-URL: Homepage, https://github.com/jviall/rekordbox-edit
 Project-URL: Repository, https://github.com/jviall/rekordbox-edit

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "rekordbox-edit"
-version = "0.13.1.dev2"
+version = "0.13.1.dev4"
 description = "Tools for managing and modifying a RekordBox library en-masse"
 authors = [{ name = "James Viall", email= "jamesviall@pm.me"}]
 license = "MIT"

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/rekordbox_edit/api/_field_handlers.py

@@ -27,8 +27,6 @@ from rekordbox_edit.utils import (
     get_audio_info,
     get_file_type_for_probe,
     parse_star_rating,
-    star_rating_to_stored,
-    stored_to_star_rating,
 )
 
 _logger = logging.getLogger(__name__)
@@ -127,7 +125,8 @@ class StringField(FieldHandler):
 
 
 class RatingField(FieldHandler):
-    """A 0-5 star rating, stored as stars * 51. `--match` does not apply."""
+    """A 0-5 star rating, stored as the star count itself. `--match` does not
+    apply."""
 
     name = "Rating"
     supports_match = False
@@ -141,13 +140,13 @@ class RatingField(FieldHandler):
 
     def current_value(self, content):
         stored = content.Rating
-        return None if stored is None else str(stored_to_star_rating(stored))
+        return None if stored is None else str(stored)
 
     def compute_new_value(self, current, args):
         return str(parse_star_rating(args.replace_value))
 
     def apply(self, db, content, new_value):
-        content.Rating = star_rating_to_stored(int(new_value))
+        content.Rating = int(new_value)
         return NO_INCIDENTAL_ROWS
 
 

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/rekordbox_edit/display.py

@@ -22,7 +22,7 @@ from rich.table import Table
 from rich.theme import Theme
 
 from rekordbox_edit.models import Track
-from rekordbox_edit.utils import FILE_TYPES, get_file_type_name, stored_to_star_rating
+from rekordbox_edit.utils import FILE_TYPES, get_file_type_name
 
 _logger = logging.getLogger(__name__)
 
@@ -189,7 +189,7 @@ def _cell_value(track: Track, column: PrintableField) -> str:
     if column is PrintableField.FolderPath:
         return os.path.dirname(track.FolderPath or "")
     if column is PrintableField.Rating:
-        return "" if track.Rating is None else str(stored_to_star_rating(track.Rating))
+        return "" if track.Rating is None else str(track.Rating)
     value = getattr(track, column.value, None)
     return "" if value is None else str(value)
 
@@ -203,8 +203,10 @@ def print_track_info(
     """Print formatted track information.
 
     When ``changed_field`` and ``new_values`` are both provided, the matching
-    column renders each row as a before/after preview: the old value is
-    struck through and the new value is appended.
+    column renders each row as a before/after preview: the old value struck
+    through, the new value beneath it. That column wraps rather than
+    ellipsising, since both values have to stay readable at ordinary terminal
+    widths.
     """
     if (changed_field is None) != (new_values is None):
         raise ValueError("changed_field and new_values must be provided together")
@@ -232,8 +234,16 @@ def print_track_info(
     table.add_column("#", justify="right", min_width=1, no_wrap=True)
     for column in print_columns:
         cfg = _COLUMN_CONFIG.get(column, {"min_width": 5})
+        # The changed column carries both values, so it needs roughly twice the
+        # width of any other. Ellipsised at a real terminal width it shows the
+        # old value and truncates the new one away, which is the half nobody
+        # can check.
+        previewing = column is changed_field and new_values is not None
         table.add_column(
-            PRINT_HEADERS[column], no_wrap=True, overflow="ellipsis", **cfg
+            PRINT_HEADERS[column],
+            no_wrap=not previewing,
+            overflow="fold" if previewing else "ellipsis",
+            **cfg,
         )
 
     for i, track in enumerate(content_list, 1):
@@ -241,7 +251,9 @@ def print_track_info(
         for col in print_columns:
             old = _cell_value(track, col)
             if col is changed_field and new_values is not None:
-                cells.append(f"[strike]{old}[/strike] [bold]{new_values[i - 1]}[/bold]")
+                cells.append(
+                    f"[strike]{old}[/strike]\n[bold]{new_values[i - 1]}[/bold]"
+                )
             else:
                 cells.append(old)
         table.add_row(str(i), *cells)

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/rekordbox_edit/utils.py

@@ -331,8 +331,10 @@ def get_audio_info(file_path) -> AudioInfo:
         raise e
 
 
+#: DjmdContent.Rating holds the star count itself, 0-5. rekordbox's XML export
+#: encodes the same rating as 0/51/102/153/204/255, which is a property of that
+#: file format and not of this column.
 _RATING_STARS_MAX = 5
-_RATING_STEP = 51  # Rekordbox stores N stars as N * 51.
 
 
 def parse_star_rating(value: "str | int") -> int:
@@ -348,13 +350,3 @@ def parse_star_rating(value: "str | int") -> int:
             f"Rating must be between 0 and {_RATING_STARS_MAX}, got {stars}"
         )
     return stars
-
-
-def star_rating_to_stored(stars: int) -> int:
-    """Convert a 0-5 star rating to the value Rekordbox stores."""
-    return stars * _RATING_STEP
-
-
-def stored_to_star_rating(stored: int) -> int:
-    """Convert a stored rating back to a 0-5 star count."""
-    return round(stored / _RATING_STEP)

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/tests/api/test_field_handlers.py

@@ -107,10 +107,12 @@ class TestRatingField:
 
     def test_current_value_is_star_string(self, make_djmd_content_item):
         content = make_djmd_content_item(ID="1")
-        content.Rating = 153
+        content.Rating = 3
         assert FIELD_HANDLERS["Rating"].current_value(content) == "3"
 
-    def test_compute_and_apply_star_to_stored(self, make_djmd_content_item):
+    def test_apply_writes_the_star_count_itself(self, make_djmd_content_item):
+        # DjmdContent.Rating holds 0-5. The 0/51/102/153/204/255 encoding
+        # belongs to rekordbox's XML export, not to this column.
         content = make_djmd_content_item(ID="1")
         content.Rating = 0
         handler = FIELD_HANDLERS["Rating"]
@@ -118,7 +120,7 @@ class TestRatingField:
         new_value = handler.compute_new_value(handler.current_value(content), args)
         assert new_value == "4"
         handler.apply(db=MagicMock(), content=content, new_value=new_value)
-        assert content.Rating == 204
+        assert content.Rating == 4
 
 
 #: Every relational field, as (edit field, foreign key column, relation kind).

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/tests/e2e/test_edit_fields.py

@@ -110,14 +110,14 @@ def test_album_create_new_has_no_album_artist(fresh_db):
     db.close()
 
 
-def test_rating_written_as_stored_value(fresh_db):
+def test_rating_written_as_the_star_count(fresh_db):
     db = Rekordbox6Database(str(fresh_db))
     assert db.session is not None
     edit(
         db, EditRequest(exact_title=["Apple Alpha"], field="Rating", replace_value="4")
     )
     moved = db.session.query(tb.DjmdContent).filter_by(Title="Apple Alpha").one()
-    assert moved.Rating == 204
+    assert moved.Rating == 4
     db.close()
 
 

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/tests/test_display.py

@@ -86,6 +86,25 @@ def wide_console(monkeypatch):
     )
 
 
+@pytest.fixture
+def terminal_console(monkeypatch):
+    """Swap the module console for one the width of an ordinary terminal.
+
+    `wide_console` exists to keep substring assertions stable, but a preview
+    that only renders at 400 columns is not a preview anyone sees.
+    """
+    monkeypatch.setattr(
+        display,
+        "console",
+        Console(
+            record=True,
+            width=100,
+            theme=display.RBE_THEME,
+            highlighter=display.RbeHighlighter(),
+        ),
+    )
+
+
 class TestPrintTrackInfo:
     """Test print_track_info function."""
 
@@ -165,6 +184,32 @@ class TestPrintTrackInfo:
         assert "Old Name" in captured.out
         assert "New Name" in captured.out
 
+    def test_change_preview_shows_the_new_path_at_terminal_width(
+        self, capsys, terminal_console, make_track
+    ):
+        """A path rewrite is the case this preview exists for, and paths are long.
+
+        Old and new share one no-wrap ellipsis cell, so the old value alone
+        fills the column and the new value is truncated away entirely. A bulk
+        repoint is then unverifiable from --dry-run.
+        """
+        old = (
+            "A:/Music/Any Time, Any Place - Janet Jackson (1994) "
+            "{V25H-38435} [FLAC-CD]/03 Janet Jackson - Any Time, Any Place.flac"
+        )
+        new = old.replace("A:/Music/", "A:/rbe_migration_copy/Music/")
+
+        print_track_info(
+            [make_track(FolderPath=old)],
+            changed_field=PrintableField.FolderPath,
+            new_values=[new],
+        )
+
+        # The cell wraps, so the path is split across lines; join it back up.
+        rendered = "".join(capsys.readouterr().out.split())
+        assert "rbe_migration_copy/Music/" in rendered
+        assert "A:/Music/AnyTime" in rendered
+
     def test_change_preview_requires_both_args(self, make_track):
         """Providing only one of changed_field/new_values raises ValueError."""
         mock_content = make_track()
@@ -250,7 +295,7 @@ def test_comment_column_renders(capsys, wide_console, make_track):
 
 def test_rating_renders_as_stars(capsys, wide_console, make_track):
     track = make_track(ID="1")
-    track.Rating = 204
+    track.Rating = 4
     print_track_info([track], print_columns=[PrintableField.Rating])
     rendered = capsys.readouterr().out
     assert "4" in rendered

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/tests/test_utils.py

@@ -14,8 +14,6 @@ from rekordbox_edit.utils import (
     parse_star_rating,
     get_file_type_for_probe,
     probe_matches_file_type,
-    star_rating_to_stored,
-    stored_to_star_rating,
 )
 
 
@@ -494,12 +492,6 @@ class TestGetFileTypeForProbe:
         assert get_file_type_for_probe(codec, container) == expected
 
 
-@pytest.mark.parametrize("stars,stored", [(0, 0), (1, 51), (3, 153), (5, 255)])
-def test_star_stored_roundtrip(stars, stored):
-    assert star_rating_to_stored(stars) == stored
-    assert stored_to_star_rating(stored) == stars
-
-
 @pytest.mark.parametrize("value,expected", [("0", 0), ("5", 5), (3, 3)])
 def test_parse_star_rating_valid(value, expected):
     assert parse_star_rating(value) == expected

{rekordbox_edit-0.13.1.dev2 → rekordbox_edit-0.13.1.dev4}/uv.lock

@@ -1274,7 +1274,7 @@ wheels = [
 
 [[package]]
 name = "rekordbox-edit"
-version = "0.13.1.dev2"
+version = "0.13.1.dev4"
 source = { editable = "." }
 dependencies = [
     { name = "click" },