refrain 0.2.4__tar.gz → 0.2.5__tar.gz

{refrain-0.2.4 → refrain-0.2.5}/CHANGELOG.md

@@ -7,6 +7,38 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.5] - 2026-05-07
+
+A same-day patch on top of v0.2.4 driven by user feedback that the
+AUR / Flatpak update path was effectively unusable from the GUI — the
+dialog only displayed the package-manager command in a popup and
+expected the user to copy + paste it into a terminal themselves.
+
+### Changed
+
+- **AUR + Flatpak updates now spawn a terminal automatically** with
+  the package-manager command pre-typed. The user confirms any sudo
+  prompt in the terminal, the package manager retains state, and
+  Refrain just needs a restart afterwards. The
+  "Refrain never modifies system files directly" guarantee is
+  preserved — we only spawn the user's own AUR helper / `flatpak`,
+  and only inside a terminal the user can read / cancel.
+  - `_run_in_terminal()` walks a probe list (konsole, gnome-terminal,
+    xfce4-terminal, kitty, alacritty, foot, xterm, wezterm) and
+    spawns the first hit. Falls back to the previous "show command
+    in a popup" behaviour when no terminal is on PATH.
+  - `_aur_helper()` picks `yay` → `paru` → `trizen` → `pikaur` in
+    that order; falls back to `sudo pacman -Syu refrain` when no
+    helper is installed.
+  - Update dialog button label flips from "Show update command" to
+    "Run update in terminal" when the install is AUR or Flatpak.
+
+### Tests
+
+- 4 new tests in `tests/test_updater.py` covering the fallback
+  message-box path, terminal-spawn for both AUR + Flatpak, and the
+  `_aur_helper` pacman fallback when no helper is installed.
+
 ## [0.2.4] - 2026-05-07
 
 A polish + reliability release built on the v0.2.3 distro-portability
@@ -812,7 +844,9 @@ with a proper, installable Linux app.
   pip-audit, trufflehog, release), Dependabot, issue + PR templates,
   `CONTRIBUTING.md`, `CODE_OF_CONDUCT.md`, `SECURITY.md`.
 
-[Unreleased]: https://github.com/Rockykln/refrain/compare/v0.2.3...HEAD
+[Unreleased]: https://github.com/Rockykln/refrain/compare/v0.2.5...HEAD
+[0.2.5]: https://github.com/Rockykln/refrain/compare/v0.2.4...v0.2.5
+[0.2.4]: https://github.com/Rockykln/refrain/compare/v0.2.3...v0.2.4
 [0.2.3]: https://github.com/Rockykln/refrain/compare/v0.2.2...v0.2.3
 [0.2.2]: https://github.com/Rockykln/refrain/compare/v0.2.1...v0.2.2
 [0.2.1]: https://github.com/Rockykln/refrain/compare/v0.2.0...v0.2.1

{refrain-0.2.4 → refrain-0.2.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: refrain
-Version: 0.2.4
+Version: 0.2.5
 Summary: Discord Rich Presence for Apple Music on Linux
 Project-URL: Homepage, https://github.com/Rockykln/refrain
 Project-URL: Repository, https://github.com/Rockykln/refrain

{refrain-0.2.4 → refrain-0.2.5}/packaging/appimage/AppImageBuilder.yml

@@ -30,7 +30,7 @@ AppDir:
     id: io.github.Rockykln.Refrain
     name: Refrain
     icon: refrain
-    version: 0.2.4
+    version: 0.2.5
     exec: usr/bin/python3
     exec_args: -m refrain $@
 

{refrain-0.2.4 → refrain-0.2.5}/packaging/aur/refrain/.SRCINFO

@@ -1,6 +1,6 @@
 pkgbase = refrain
 	pkgdesc = Discord Rich Presence for Apple Music on Linux
-	pkgver = 0.2.3
+	pkgver = 0.2.4
 	pkgrel = 1
 	url = https://github.com/Rockykln/refrain
 	arch = any
@@ -14,7 +14,7 @@ pkgbase = refrain
 	depends = python-dbus
 	depends = pyside6
 	optdepends = python-gobject: enables MPRIS-server publication so Plasma media controls reach Refrain
-	source = refrain-0.2.3.tar.gz::https://github.com/Rockykln/refrain/archive/v0.2.3.tar.gz
-	sha256sums = 29f2371393d855f508730238a096cbdc85219616a9fab240745c1072a005b23d
+	source = refrain-0.2.4.tar.gz::https://github.com/Rockykln/refrain/archive/v0.2.4.tar.gz
+	sha256sums = cb4e712a2809bd237c4ccaebd2cc81afa28286b4d260072f74bf94ce530a0ea3
 
 pkgname = refrain

{refrain-0.2.4 → refrain-0.2.5}/packaging/aur/refrain/PKGBUILD

@@ -1,7 +1,7 @@
 # Maintainer: Rockykln <contact@rockykln.com>
 
 pkgname=refrain
-pkgver=0.2.4
+pkgver=0.2.5
 pkgrel=1
 pkgdesc="Discord Rich Presence for Apple Music on Linux"
 arch=('any')

{refrain-0.2.4 → refrain-0.2.5}/packaging/flatpak/io.github.Rockykln.Refrain.metainfo.xml

@@ -51,6 +51,19 @@
   <content_rating type="oars-1.1" />
 
   <releases>
+    <release version="0.2.5" date="2026-05-07">
+      <description>
+        <p>
+          Same-day patch over v0.2.4. AUR and Flatpak updates now
+          spawn a terminal emulator running the package-manager
+          command (yay -Syu / flatpak update) instead of just
+          displaying the command in a popup for the user to retype.
+          The user confirms any sudo prompt in the terminal, the
+          package manager retains state. Falls back to the previous
+          message-box hint when no terminal is on PATH.
+        </p>
+      </description>
+    </release>
     <release version="0.2.4" date="2026-05-07">
       <description>
         <p>

{refrain-0.2.4 → refrain-0.2.5}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "refrain"
-version = "0.2.4"
+version = "0.2.5"
 description = "Discord Rich Presence for Apple Music on Linux"
 readme = "README.md"
 requires-python = ">=3.11"

refrain-0.2.5/src/refrain/__init__.py

@@ -0,0 +1 @@
+__version__ = "0.2.5"

{refrain-0.2.4 → refrain-0.2.5}/src/refrain/ui/update_dialog.py

@@ -127,6 +127,8 @@ class UpdateDialog(QDialog):
             return self.tr("Download && replace")
         if self._install_type == "pip":
             return self.tr("Run pip upgrade")
+        if self._install_type in ("aur", "flatpak"):
+            return self.tr("Run update in terminal")
         return self.tr("Show update command")
 
     def _open_release_page(self) -> None:

{refrain-0.2.4 → refrain-0.2.5}/src/refrain/updater.py

@@ -254,12 +254,67 @@ def cleanup_orphan_downloads() -> None:
         log.debug("Could not remove orphan update download %s: %s", tmp, e)
 
 
+# Terminal emulators we know how to launch a command inside, in
+# preference order. Each entry is ``(binary, argv_template)`` where
+# ``argv_template[i] == "{cmd}"`` gets replaced with the shell command
+# string. The shell wrapper pauses at the end so the user can read
+# output before the window closes.
+_TERMINAL_PROBES: tuple[tuple[str, list[str]], ...] = (
+    ("konsole", ["konsole", "-e", "bash", "-c", "{cmd}"]),
+    ("gnome-terminal", ["gnome-terminal", "--", "bash", "-c", "{cmd}"]),
+    ("xfce4-terminal", ["xfce4-terminal", "-x", "bash", "-c", "{cmd}"]),
+    ("kitty", ["kitty", "bash", "-c", "{cmd}"]),
+    ("alacritty", ["alacritty", "-e", "bash", "-c", "{cmd}"]),
+    ("foot", ["foot", "bash", "-c", "{cmd}"]),
+    ("xterm", ["xterm", "-e", "bash", "-c", "{cmd}"]),
+    ("wezterm", ["wezterm", "start", "--", "bash", "-c", "{cmd}"]),
+)
+
+
+def _run_in_terminal(cmd: str) -> bool:
+    """Pop up a terminal emulator running ``cmd`` (a shell string).
+
+    Wraps the command so the terminal stays open after it exits — the
+    user can read the package-manager output and any error before the
+    window vanishes. Returns True iff we successfully spawned a
+    terminal; False (silently) if no known emulator is on PATH.
+    """
+    wrapped = f"{cmd}; echo; read -rp 'Press Enter to close…'"
+    for binary, template in _TERMINAL_PROBES:
+        if not shutil.which(binary):
+            continue
+        argv = [arg.format(cmd=wrapped) for arg in template]
+        try:
+            subprocess.Popen(argv, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
+            log.info("Spawned %s for update command", binary)
+            return True
+        except Exception as e:
+            log.debug("Failed to spawn %s: %s", binary, e)
+    log.info("No known terminal emulator found — falling back to message-box hint")
+    return False
+
+
+def _aur_helper() -> str:
+    """Pick the user's AUR helper. Falls back to bare ``pacman -Syu``
+    when no helper is on PATH (won't update AUR packages, but at least
+    won't be wrong — the user gets to see the issue + run their own
+    helper manually).
+    """
+    for helper in ("yay", "paru", "trizen", "pikaur"):
+        if shutil.which(helper):
+            return f"{helper} -Syu refrain"
+    return "sudo pacman -Syu refrain"
+
+
 def apply_update(
     release: ReleaseInfo,
     install_type: str | None = None,
     cancelled: Callable[[], bool] | None = None,
 ) -> UpdateResult:
-    """Type-aware update. Never modifies system files."""
+    """Type-aware update. Never modifies system files directly — for
+    AUR / Flatpak / system installs we shell out to the user's package
+    manager via a terminal emulator so the user confirms any sudo
+    prompt themselves and the package manager retains state."""
     install_type = install_type or detect_install_type()
     log.info("apply_update: target=%s install_type=%s", release.version, install_type)
 
@@ -274,15 +329,38 @@ def apply_update(
             "`git pull` and reinstall with `pip install -e .`.",
         )
     if install_type == "flatpak":
+        cmd = "flatpak update -y io.github.Rockykln.Refrain"
+        if _run_in_terminal(cmd):
+            return UpdateResult(
+                success=True,
+                message=(
+                    "Launched the update in a new terminal:\n\n"
+                    f"    {cmd}\n\n"
+                    "Confirm any prompts there. Restart Refrain afterwards "
+                    "to load the new version."
+                ),
+                needs_restart=True,
+            )
         return UpdateResult(
             success=False,
-            message="Flatpak install detected. Update via:\n\n"
-            "    flatpak update io.github.Rockykln.Refrain",
+            message=f"Flatpak install detected. Update via:\n\n    {cmd}",
         )
     if install_type == "aur":
+        cmd = _aur_helper()
+        if _run_in_terminal(cmd):
+            return UpdateResult(
+                success=True,
+                message=(
+                    "Launched the update in a new terminal:\n\n"
+                    f"    {cmd}\n\n"
+                    "Confirm any sudo prompt there. Restart Refrain "
+                    "afterwards to load the new version."
+                ),
+                needs_restart=True,
+            )
         return UpdateResult(
             success=False,
-            message="AUR install detected. Update via your AUR helper:\n\n    yay -Syu refrain",
+            message=f"AUR install detected. Update via your AUR helper:\n\n    {cmd}",
         )
     return UpdateResult(
         success=False,

{refrain-0.2.4 → refrain-0.2.5}/tests/test_updater.py

@@ -146,7 +146,7 @@ def test_check_latest_release_handles_empty_assets(monkeypatch, updater):
     assert info.appimage_size == 0
 
 
-def test_apply_update_dispatches_per_install_type(updater):
+def test_apply_update_dispatches_per_install_type(updater, monkeypatch):
     info = updater.ReleaseInfo(
         tag="v0.2.0",
         version="0.2.0",
@@ -156,19 +156,65 @@ def test_apply_update_dispatches_per_install_type(updater):
     )
     # Without an APPIMAGE env var, "appimage" path errors out cleanly
     os.environ.pop("APPIMAGE", None)
+    # Force the fallback path (no terminal available) so the
+    # assertions test the offline-friendly message-box behaviour.
+    # The terminal-spawn path is exercised separately below.
+    monkeypatch.setattr(updater, "_run_in_terminal", lambda _cmd: False)
+
     r = updater.apply_update(info, install_type="flatpak")
     assert r.success is False
     assert "flatpak update" in r.message.lower()
 
     r = updater.apply_update(info, install_type="aur")
     assert r.success is False
-    assert "yay" in r.message.lower()
+    # The hint message names whatever helper detect produced
+    # (yay/paru/trizen/pikaur or the bare-pacman fallback) — assert
+    # we mention the canonical keyword "syu" which all of them use.
+    assert "syu" in r.message.lower()
 
     r = updater.apply_update(info, install_type="dev")
     assert r.success is False
     assert "git pull" in r.message.lower()
 
 
+def test_apply_update_aur_launches_terminal_when_available(updater, monkeypatch):
+    """AUR install + a usable terminal → spawn it, mark needs_restart."""
+    spawned: list[str] = []
+
+    def fake_terminal(cmd: str) -> bool:
+        spawned.append(cmd)
+        return True
+
+    monkeypatch.setattr(updater, "_run_in_terminal", fake_terminal)
+
+    info = updater.ReleaseInfo(tag="v0.2.0", version="0.2.0", name="x", body="", html_url="")
+    r = updater.apply_update(info, install_type="aur")
+    assert r.success is True
+    assert r.needs_restart is True
+    assert spawned and "syu refrain" in spawned[0].lower()
+
+
+def test_apply_update_flatpak_launches_terminal_when_available(updater, monkeypatch):
+    spawned: list[str] = []
+    monkeypatch.setattr(updater, "_run_in_terminal", lambda cmd: spawned.append(cmd) or True)
+
+    info = updater.ReleaseInfo(tag="v0.2.0", version="0.2.0", name="x", body="", html_url="")
+    r = updater.apply_update(info, install_type="flatpak")
+    assert r.success is True
+    assert r.needs_restart is True
+    assert spawned and "flatpak update" in spawned[0].lower()
+
+
+def test_aur_helper_falls_back_to_pacman(updater, monkeypatch):
+    """When no AUR helper is installed, _aur_helper falls back to a
+    bare pacman command. Update dialog will still surface this so
+    the user can swap in their preferred helper if they prefer."""
+    monkeypatch.setattr(updater.shutil, "which", lambda _name: None)
+    cmd = updater._aur_helper()
+    assert "pacman" in cmd
+    assert "refrain" in cmd
+
+
 # ---------------------------------------------------------------------------
 # cleanup_orphan_downloads — self-heal of *.AppImage.new files left behind
 # by a SIGKILL / power-loss mid-download.

refrain-0.2.4/src/refrain/__init__.py

@@ -1 +0,0 @@
-__version__ = "0.2.4"