redisbench-admin 0.11.9__tar.gz → 0.11.11__tar.gz

{redisbench_admin-0.11.9 → redisbench_admin-0.11.11}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: redisbench-admin
-Version: 0.11.9
+Version: 0.11.11
 Summary: Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... ).
 Author: filipecosta90
 Author-email: filipecosta.90@gmail.com

{redisbench_admin-0.11.9 → redisbench_admin-0.11.11}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redisbench-admin"
-version = "0.11.9"
+version = "0.11.11"
 description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
 authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
 readme = "README.md"

{redisbench_admin-0.11.9 → redisbench_admin-0.11.11}/redisbench_admin/compare/compare.py

@@ -191,32 +191,38 @@ def compare_command_logic(args, project_name, project_version):
         logging.info("Detected github token")
         g = Github(github_token)
         if pull_request is not None and pull_request != "":
-            pull_request_n = int(pull_request)
-            github_pr = (
-                g.get_user(tf_github_org)
-                .get_repo(tf_github_repo)
-                .get_issue(pull_request_n)
-            )
-            comments = github_pr.get_comments()
-            pr_link = github_pr.html_url
-            logging.info("Working on github PR already: {}".format(pr_link))
-            is_actionable_pr = True
-            contains_regression_comment, pos = check_regression_comment(comments)
-            if contains_regression_comment:
-                regression_comment = comments[pos]
-                old_regression_comment_body = regression_comment.body
-                logging.info(
-                    "Already contains regression comment. Link: {}".format(
-                        regression_comment.html_url
+            try:
+                pull_request_n = int(pull_request)
+                github_pr = (
+                    g.get_user(tf_github_org)
+                    .get_repo(tf_github_repo)
+                    .get_issue(pull_request_n)
+                )
+                comments = github_pr.get_comments()
+                pr_link = github_pr.html_url
+                logging.info("Working on github PR already: {}".format(pr_link))
+                is_actionable_pr = True
+                contains_regression_comment, pos = check_regression_comment(comments)
+                if contains_regression_comment:
+                    regression_comment = comments[pos]
+                    old_regression_comment_body = regression_comment.body
+                    logging.info(
+                        "Already contains regression comment. Link: {}".format(
+                            regression_comment.html_url
+                        )
                     )
+                    if verbose:
+                        logging.info("Printing old regression comment:")
+                        print("".join(["-" for x in range(1, 80)]))
+                        print(regression_comment.body)
+                        print("".join(["-" for x in range(1, 80)]))
+                else:
+                    logging.info("Does not contain regression comment")
+
+            except Exception as e:
+                logging.error(
+                    f"Error while working with github. exception {e.__str__()}"
                 )
-                if verbose:
-                    logging.info("Printing old regression comment:")
-                    print("".join(["-" for x in range(1, 80)]))
-                    print(regression_comment.body)
-                    print("".join(["-" for x in range(1, 80)]))
-            else:
-                logging.info("Does not contain regression comment")
 
     grafana_dashboards_uids = {
         "redisgraph": "SH9_rQYGz",

{redisbench_admin-0.11.9 → redisbench_admin-0.11.11}/redisbench_admin/run_remote/standalone.py

@@ -157,12 +157,9 @@ def generate_remote_standalone_redis_cmd(
     enable_redis_7_config_directives=True,
     enable_debug_command="yes",
 ):
-    initial_redis_cmd = "redis-server --save '' --logfile {} --dir {} --daemonize yes --protected-mode no ".format(
+    initial_redis_cmd = "redis-server --save '' --logfile {} --dir {} --daemonize yes --protected-mode no --enable-debug-command yes ".format(
         logfile, temporary_dir
     )
-    if enable_redis_7_config_directives:
-        extra_str = " --enable-debug-command yes ".format(enable_debug_command)
-        initial_redis_cmd = initial_redis_cmd + extra_str
     full_logfile = "{}/{}".format(temporary_dir, logfile)
     if redis_configuration_parameters is not None:
         for (

{redisbench_admin-0.11.9 → redisbench_admin-0.11.11}/redisbench_admin/utils/utils.py

@@ -100,17 +100,12 @@ def generate_common_server_args(
             "''",
             "--port",
             "{}".format(port),
+            "--enable-debug-command",
+            "yes",
             "--dir",
             dbdir,
         ]
     )
-    if enable_redis_7_config_directives:
-        command.extend(
-            [
-                "--enable-debug-command",
-                "yes",
-            ]
-        )
 
     return command