redis-benchmarks-specification 0.1.87__tar.gz → 0.1.89__tar.gz

{redis_benchmarks_specification-0.1.87 → redis_benchmarks_specification-0.1.89}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: redis-benchmarks-specification
-Version: 0.1.87
+Version: 0.1.89
 Summary: The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute.
 Author: filipecosta90
 Author-email: filipecosta.90@gmail.com

{redis_benchmarks_specification-0.1.87 → redis_benchmarks_specification-0.1.89}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redis-benchmarks-specification"
-version = "0.1.87"
+version = "0.1.89"
 description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
 authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
 readme = "Readme.md"

{redis_benchmarks_specification-0.1.87 → redis_benchmarks_specification-0.1.89}/redis_benchmarks_specification/__builder__/builder.py

@@ -1,4 +1,5 @@
 import argparse
+import datetime
 import io
 import json
 import logging
@@ -36,6 +37,7 @@ from redis_benchmarks_specification.__common__.github import (
     generate_build_finished_pr_comment,
     update_comment_if_needed,
     create_new_pr_comment,
+    generate_build_started_pr_comment,
 )
 from redis_benchmarks_specification.__common__.package import (
     populate_with_poetry_data,
@@ -378,9 +380,41 @@ def builder_process_stream(
                     "redis-server",
                     build_vars_str,
                 )
+                build_start_datetime = datetime.datetime.utcnow()
                 logging.info(
-                    "Using the following build command {}".format(build_command)
+                    "Using the following build command {}.".format(build_command)
                 )
+                if is_actionable_pr:
+                    logging.info(
+                        f"updating on github we'll start the build at {build_start_datetime}"
+                    )
+                    comment_body = generate_build_started_pr_comment(
+                        build_start_datetime,
+                        commit_datetime,
+                        commit_summary,
+                        git_branch,
+                        git_hash,
+                        tests_groups_regexp,
+                        tests_priority_lower_limit,
+                        tests_priority_upper_limit,
+                        tests_regexp,
+                    )
+                    if contains_regression_comment:
+                        update_comment_if_needed(
+                            auto_approve_github_comments,
+                            comment_body,
+                            old_regression_comment_body,
+                            regression_comment,
+                            verbose,
+                        )
+                    else:
+                        regression_comment = create_new_pr_comment(
+                            auto_approve_github_comments,
+                            comment_body,
+                            github_pr,
+                            pr_link,
+                        )
+
                 docker_client.containers.run(
                     image=build_image,
                     volumes={
@@ -391,6 +425,10 @@ def builder_process_stream(
                     working_dir="/mnt/redis/",
                     command=build_command,
                 )
+                build_end_datetime = datetime.datetime.utcnow()
+                build_duration = build_end_datetime - build_start_datetime
+                build_duration_secs = build_duration.total_seconds()
+
                 build_stream_fields = {
                     "id": id,
                     "git_hash": git_hash,
@@ -416,9 +454,6 @@ def builder_process_stream(
                     build_stream_fields["git_branch"] = git_branch
                 if git_version is not None:
                     build_stream_fields["git_version"] = git_version
-                if git_timestamp_ms is not None:
-                    build_stream_fields["git_timestamp_ms"] = git_timestamp_ms
-
                 if git_timestamp_ms is not None:
                     build_stream_fields["git_timestamp_ms"] = git_timestamp_ms
                 for artifact in build_artifacts:
@@ -456,18 +491,24 @@ def builder_process_stream(
                         f"Adding information of build->benchmark stream info in list {builder_list_completed}. Adding benchmark stream id: {benchmark_stream_id_decoded}"
                     )
                     benchmark_stream_ids = [benchmark_stream_id_decoded]
-                    comment_body = generate_build_finished_pr_comment(
-                        benchmark_stream_ids,
-                        commit_datetime,
-                        commit_summary,
-                        git_branch,
-                        git_hash,
-                        tests_groups_regexp,
-                        tests_priority_lower_limit,
-                        tests_priority_upper_limit,
-                        tests_regexp,
-                    )
+
                     if is_actionable_pr:
+                        logging.info(
+                            f"updating on github that the build finished after {build_duration_secs} seconds"
+                        )
+                        comment_body = generate_build_finished_pr_comment(
+                            benchmark_stream_ids,
+                            commit_datetime,
+                            commit_summary,
+                            git_branch,
+                            git_hash,
+                            tests_groups_regexp,
+                            tests_priority_lower_limit,
+                            tests_priority_upper_limit,
+                            tests_regexp,
+                            build_start_datetime,
+                            build_duration_secs,
+                        )
                         if contains_regression_comment:
                             update_comment_if_needed(
                                 auto_approve_github_comments,

{redis_benchmarks_specification-0.1.87 → redis_benchmarks_specification-0.1.89}/redis_benchmarks_specification/__cli__/cli.py

@@ -351,6 +351,7 @@ def trigger_tests_cli_command_logic(args, project_name, project_version):
                     )
 
                     if args.wait_build is True:
+                        build_start_datetime = datetime.datetime.utcnow()
                         decoded_stream_id = stream_id.decode()
                         builder_list_streams = (
                             f"builder:{decoded_stream_id}:builds_completed"
@@ -409,6 +410,9 @@ def trigger_tests_cli_command_logic(args, project_name, project_version):
                         logging.info(
                             f"FINAL total of {len_list} already build benchmark stream ids for this build: {benchmark_stream_ids}"
                         )
+                        build_end_datetime = datetime.datetime.utcnow()
+                        build_duration = build_end_datetime - build_start_datetime
+                        build_duration_secs = build_duration.total_seconds()
 
                         comment_body = generate_build_finished_pr_comment(
                             benchmark_stream_ids,
@@ -420,6 +424,8 @@ def trigger_tests_cli_command_logic(args, project_name, project_version):
                             tests_priority_lower_limit,
                             tests_priority_upper_limit,
                             tests_regexp,
+                            build_start_datetime,
+                            build_duration_secs,
                         )
                         if is_actionable_pr:
                             if contains_regression_comment:

{redis_benchmarks_specification-0.1.87 → redis_benchmarks_specification-0.1.89}/redis_benchmarks_specification/__common__/github.py

@@ -2,6 +2,41 @@ import logging
 from github import Github
 
 
+def generate_build_started_pr_comment(
+    build_datetime,
+    commit_datetime,
+    commit_summary,
+    git_branch,
+    git_hash,
+    tests_groups_regexp,
+    tests_priority_lower_limit,
+    tests_priority_upper_limit,
+    tests_regexp,
+):
+    comment_body = (
+        f"### CE Performance Automation : step 1 of 2 (build) STARTING...\n\n"
+    )
+    comment_body += (
+        "This comment was automatically generated given a benchmark was triggered.\n"
+    )
+    comment_body += f"Started building at {build_datetime}\n"
+    comment_body += "You can check each build/benchmark progress in grafana:\n"
+    comment_body += f"   - git hash: {git_hash}\n"
+    comment_body += f"   - git branch: {git_branch}\n"
+    comment_body += f"   - commit date and time: {commit_datetime}\n"
+    comment_body += f"   - commit summary: {commit_summary}\n"
+    comment_body += f"   - test filters:\n"
+    comment_body += (
+        f"       - command priority lower limit: {tests_priority_lower_limit}\n"
+    )
+    comment_body += (
+        f"       - command priority upper limit: {tests_priority_upper_limit}\n"
+    )
+    comment_body += f"       - test name regex: {tests_regexp}\n"
+    comment_body += f"       - command group regex: {tests_groups_regexp}\n\n"
+    return comment_body
+
+
 def generate_build_finished_pr_comment(
     benchmark_stream_ids,
     commit_datetime,
@@ -12,11 +47,15 @@ def generate_build_finished_pr_comment(
     tests_priority_lower_limit,
     tests_priority_upper_limit,
     tests_regexp,
+    build_start_datetime,
+    build_duration_seconds,
 ):
-    comment_body = "### CE Performance Automation : step 1 of 2 (build) done\n\n"
+    build_duration_seconds = int(build_duration_seconds)
+    comment_body = f"### CE Performance Automation : step 1 of 2 (build) DONE.\n\n"
     comment_body += (
         "This comment was automatically generated given a benchmark was triggered.\n"
     )
+    comment_body += f"Started building at {build_start_datetime} and took {build_duration_seconds} seconds.\n"
     comment_body += "You can check each build/benchmark progress in grafana:\n"
     comment_body += f"   - git hash: {git_hash}\n"
     comment_body += f"   - git branch: {git_branch}\n"
@@ -80,6 +119,9 @@ def check_github_available_and_actionable(
                     print("".join(["-" for x in range(1, 80)]))
             else:
                 logging.info("Does not contain PR comment")
+    logging.info(
+        f"contains_regression_comment: {contains_regression_comment}, is_actionable_pr: {is_actionable_pr}, pr_link: {pr_link}"
+    )
     return (
         contains_regression_comment,
         github_pr,
@@ -112,12 +154,12 @@ def update_comment_if_needed(
     user_input = "n"
     if comment_body == old_regression_comment_body:
         logging.info(
-            "The old regression comment is the same as the new comment. skipping..."
+            "The old github comment is the same as the new comment. skipping..."
         )
         same_comment = True
     else:
         logging.info(
-            "The old regression comment is different from the new comment. updating it..."
+            "The old github comment is different from the new comment. updating it..."
         )
         comment_body_arr = comment_body.split("\n")
         old_regression_comment_body_arr = old_regression_comment_body.split("\n")
@@ -190,7 +232,7 @@ def generate_benchmark_started_pr_comment(
 
     completed = total_benchmarks - total_pending
     comment_body += (
-        f"Status: {markdown_progress_bar(completed,total_benchmarks)} pending.\n\n"
+        f"Status: {markdown_progress_bar(completed,total_benchmarks,80)} completed.\n\n"
     )
     comment_body += f"In total will run {total_benchmarks} benchmarks.\n"
     comment_body += f"    - {total_pending} pending.\n"