redis-benchmarks-specification 0.1.303__tar.gz → 0.1.305__tar.gz

{redis_benchmarks_specification-0.1.303 → redis_benchmarks_specification-0.1.305}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: redis-benchmarks-specification
-Version: 0.1.303
+Version: 0.1.305
 Summary: The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute.
 Author: filipecosta90
 Author-email: filipecosta.90@gmail.com

{redis_benchmarks_specification-0.1.303 → redis_benchmarks_specification-0.1.305}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redis-benchmarks-specification"
-version = "0.1.303"
+version = "0.1.305"
 description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
 authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
 readme = "Readme.md"

{redis_benchmarks_specification-0.1.303 → redis_benchmarks_specification-0.1.305}/redis_benchmarks_specification/__runner__/runner.py

@@ -1393,17 +1393,27 @@ def process_self_contained_coordinator_stream(
                     ssl_cert_reqs = "required"
                     if tls_skip_verify:
                         ssl_cert_reqs = None
-                    r = redis.StrictRedis(
-                        host=host,
-                        port=port,
-                        password=password,
-                        ssl=tls_enabled,
-                        ssl_cert_reqs=ssl_cert_reqs,
-                        ssl_keyfile=tls_key,
-                        ssl_certfile=tls_cert,
-                        ssl_ca_certs=tls_cacert,
-                        ssl_check_hostname=False,
-                    )
+
+                    # Build Redis connection parameters
+                    redis_params = {
+                        "host": host,
+                        "port": port,
+                        "password": password,
+                        "ssl": tls_enabled,
+                        "ssl_cert_reqs": ssl_cert_reqs,
+                        "ssl_check_hostname": False,
+                    }
+
+                    # Only add SSL certificate parameters if they are provided
+                    if tls_enabled:
+                        if tls_key is not None and tls_key != "":
+                            redis_params["ssl_keyfile"] = tls_key
+                        if tls_cert is not None and tls_cert != "":
+                            redis_params["ssl_certfile"] = tls_cert
+                        if tls_cacert is not None and tls_cacert != "":
+                            redis_params["ssl_ca_certs"] = tls_cacert
+
+                    r = redis.StrictRedis(**redis_params)
                     setup_name = "oss-standalone"
                     r.ping()
 
@@ -1456,17 +1466,26 @@ def process_self_contained_coordinator_stream(
                             slot_network_info = slot[2]
                             prefered_endpoint = slot_network_info[0]
                             prefered_port = slot_network_info[1]
-                            shard_conn = redis.StrictRedis(
-                                host=prefered_endpoint,
-                                port=prefered_port,
-                                password=password,
-                                ssl=tls_enabled,
-                                ssl_cert_reqs=ssl_cert_reqs,
-                                ssl_keyfile=tls_key,
-                                ssl_certfile=tls_cert,
-                                ssl_ca_certs=tls_cacert,
-                                ssl_check_hostname=False,
-                            )
+                            # Build shard connection parameters
+                            shard_params = {
+                                "host": prefered_endpoint,
+                                "port": prefered_port,
+                                "password": password,
+                                "ssl": tls_enabled,
+                                "ssl_cert_reqs": ssl_cert_reqs,
+                                "ssl_check_hostname": False,
+                            }
+
+                            # Only add SSL certificate parameters if they are provided
+                            if tls_enabled:
+                                if tls_key is not None and tls_key != "":
+                                    shard_params["ssl_keyfile"] = tls_key
+                                if tls_cert is not None and tls_cert != "":
+                                    shard_params["ssl_certfile"] = tls_cert
+                                if tls_cacert is not None and tls_cacert != "":
+                                    shard_params["ssl_ca_certs"] = tls_cacert
+
+                            shard_conn = redis.StrictRedis(**shard_params)
                             redis_conns.append(shard_conn)
                         logging.info(
                             "There are a total of {} shards".format(len(redis_conns))
@@ -1475,8 +1494,12 @@ def process_self_contained_coordinator_stream(
 
                     redis_pids = []
                     for conn in redis_conns:
-                        redis_pid = conn.info()["process_id"]
-                        redis_pids.append(redis_pid)
+                        redis_info = conn.info()
+                        redis_pid = redis_info.get("process_id")
+                        if redis_pid is not None:
+                            redis_pids.append(redis_pid)
+                        else:
+                            logging.warning("Redis process_id not found in INFO command, skipping PID collection for this connection")
 
                     # Check if all tested commands are supported by this Redis instance
                     supported_commands = get_supported_redis_commands(redis_conns)

{redis_benchmarks_specification-0.1.303 → redis_benchmarks_specification-0.1.305}/redis_benchmarks_specification/__self_contained_coordinator__/runners.py

@@ -310,8 +310,12 @@ def process_self_contained_coordinator_stream(
                             r = redis.StrictRedis(port=redis_proc_start_port)
                             r.ping()
                             redis_pids = []
-                            first_redis_pid = r.info()["process_id"]
-                            redis_pids.append(first_redis_pid)
+                            redis_info = r.info()
+                            first_redis_pid = redis_info.get("process_id")
+                            if first_redis_pid is not None:
+                                redis_pids.append(first_redis_pid)
+                            else:
+                                logging.warning("Redis process_id not found in INFO command")
                             ceil_client_cpu_limit = extract_client_cpu_limit(
                                 benchmark_config
                             )

{redis_benchmarks_specification-0.1.303 → redis_benchmarks_specification-0.1.305}/redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py

@@ -882,7 +882,10 @@ def process_self_contained_coordinator_stream(
                                 reset_commandstats(redis_conns)
                                 redis_pids = []
                                 redis_info = r.info()
-                                first_redis_pid = redis_info["process_id"]
+                                first_redis_pid = redis_info.get("process_id")
+                                if first_redis_pid is None:
+                                    logging.warning("Redis process_id not found in INFO command")
+                                    first_redis_pid = "unknown"
                                 if git_hash is None and "redis_git_sha1" in redis_info:
                                     git_hash = redis_info["redis_git_sha1"]
                                     if (