redis-benchmarks-specification 0.1.279__tar.gz → 0.1.281__tar.gz

{redis_benchmarks_specification-0.1.279 → redis_benchmarks_specification-0.1.281}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: redis-benchmarks-specification
-Version: 0.1.279
+Version: 0.1.281
 Summary: The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute.
 Author: filipecosta90
 Author-email: filipecosta.90@gmail.com

{redis_benchmarks_specification-0.1.279 → redis_benchmarks_specification-0.1.281}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redis-benchmarks-specification"
-version = "0.1.279"
+version = "0.1.281"
 description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
 authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
 readme = "Readme.md"

{redis_benchmarks_specification-0.1.279 → redis_benchmarks_specification-0.1.281}/redis_benchmarks_specification/__runner__/args.py

@@ -202,6 +202,12 @@ def create_client_runner_args(project_name):
         action="store_true",
         help="Assume benchmarking tool (e.g. memtier benchmark) is installed locally and execute it without using a docker container.",
     )
+    parser.add_argument(
+        "--memtier-bin-path",
+        type=str,
+        default="memtier_benchmark",
+        help="Path to memtier_benchmark binary when using --benchmark_local_install. Default is 'memtier_benchmark' (assumes it's in PATH).",
+    )
     parser.add_argument(
         "--override-test-runs",
         default=1,
@@ -235,7 +241,7 @@ def create_client_runner_args(project_name):
         "--enable-remote-profiling",
         default=False,
         action="store_true",
-        help="Enable remote profiling of Redis processes via HTTP GET endpoint. Profiles are collected in folded format during benchmark execution.",
+        help="Enable remote profiling of Redis processes via HTTP GET endpoint. Profiles are collected in pprof binary format during benchmark execution.",
     )
     parser.add_argument(
         "--remote-profile-host",
@@ -246,8 +252,8 @@ def create_client_runner_args(project_name):
     parser.add_argument(
         "--remote-profile-port",
         type=int,
-        default=8080,
-        help="Port for remote profiling HTTP endpoint. Default is 8080.",
+        default=10000,
+        help="Port for remote profiling HTTP endpoint. Default is 10000.",
     )
     parser.add_argument(
         "--remote-profile-output-dir",

{redis_benchmarks_specification-0.1.279 → redis_benchmarks_specification-0.1.281}/redis_benchmarks_specification/__runner__/remote_profiling.py

@@ -3,7 +3,7 @@ Remote profiling utilities for Redis benchmark runner.
 
 This module provides functionality to trigger remote profiling of Redis processes
 via HTTP GET endpoints during benchmark execution. Profiles are collected in
-folded format for performance analysis.
+pprof binary format for performance analysis.
 """
 
 import datetime
@@ -103,9 +103,9 @@ def trigger_remote_profile(
     timeout: int = 60,
     username: Optional[str] = None,
     password: Optional[str] = None
-) -> Optional[str]:
+) -> Optional[bytes]:
     """
-    Trigger remote profiling via HTTP GET request.
+    Trigger remote profiling via HTTP GET request using pprof endpoint.
 
     Args:
         host: Remote host address
@@ -117,9 +117,9 @@ def trigger_remote_profile(
         password: Optional password for HTTP basic authentication
 
     Returns:
-        Profile content in folded format, or None if failed
+        Profile content in pprof binary format, or None if failed
     """
-    url = f"http://{host}:{port}/debug/folded/profile"
+    url = f"http://{host}:{port}/debug/pprof/profile"
     params = {
         "pid": pid,
         "seconds": duration
@@ -136,8 +136,8 @@ def trigger_remote_profile(
         response = requests.get(url, params=params, timeout=timeout, auth=auth)
         response.raise_for_status()
 
-        profile_content = response.text
-        logging.info(f"Successfully collected profile: {len(profile_content)} characters")
+        profile_content = response.content
+        logging.info(f"Successfully collected profile: {len(profile_content)} bytes")
         return profile_content
 
     except requests.exceptions.Timeout:
@@ -157,55 +157,65 @@ def trigger_remote_profile(
 
 
 def save_profile_with_metadata(
-    profile_content: str,
+    profile_content: bytes,
     benchmark_name: str,
     output_dir: str,
     redis_metadata: Dict[str, Any],
     duration: int
 ) -> Optional[str]:
     """
-    Save profile content to file with metadata comments.
-    
+    Save profile content to file in pprof binary format.
+
     Args:
-        profile_content: Profile data in folded format
+        profile_content: Profile data in pprof binary format
         benchmark_name: Name of the benchmark
         output_dir: Output directory path
         redis_metadata: Redis metadata dictionary
         duration: Profiling duration in seconds
-        
+
     Returns:
         Path to saved file, or None if failed
     """
     try:
         # Create output directory if it doesn't exist
         Path(output_dir).mkdir(parents=True, exist_ok=True)
-        
-        # Generate filename
-        filename = f"{benchmark_name}.folded"
+
+        # Generate filename with .pb.gz extension
+        filename = f"{benchmark_name}.pb.gz"
         filepath = os.path.join(output_dir, filename)
-        
+
         # Generate timestamp
         timestamp = datetime.datetime.now().strftime("%Y-%m-%d %H:%M:%S")
-        
-        # Create metadata comment
-        metadata_comment = (
-            f"# profile from redis sha = {redis_metadata['redis_git_sha1']} "
+
+        # Write binary profile content directly
+        with open(filepath, 'wb') as f:
+            f.write(profile_content)
+
+        # Create a separate metadata file
+        metadata_filename = f"{benchmark_name}.metadata.txt"
+        metadata_filepath = os.path.join(output_dir, metadata_filename)
+
+        metadata_content = (
+            f"Profile from redis sha = {redis_metadata['redis_git_sha1']} "
             f"and pid {redis_metadata['process_id']} for duration of {duration}s. "
-            f"collection in date {timestamp}\n"
-            f"# benchmark_name={benchmark_name}\n"
-            f"# redis_git_sha1={redis_metadata['redis_git_sha1']}\n"
-            f"# redis_version={redis_metadata['redis_version']}\n"
-            f"# redis_git_dirty={redis_metadata['redis_git_dirty']}\n"
+            f"Collection date: {timestamp}\n"
+            f"benchmark_name={benchmark_name}\n"
+            f"redis_git_sha1={redis_metadata['redis_git_sha1']}\n"
+            f"redis_version={redis_metadata['redis_version']}\n"
+            f"redis_git_dirty={redis_metadata['redis_git_dirty']}\n"
+            f"redis_build_id={redis_metadata['redis_build_id']}\n"
+            f"process_id={redis_metadata['process_id']}\n"
+            f"tcp_port={redis_metadata['tcp_port']}\n"
+            f"duration_seconds={duration}\n"
         )
-        
-        # Write file with metadata and profile content
-        with open(filepath, 'w') as f:
-            f.write(metadata_comment)
-            f.write(profile_content)
-            
+
+        with open(metadata_filepath, 'w') as f:
+            f.write(metadata_content)
+
         logging.info(f"Saved profile to: {filepath}")
+        logging.info(f"Saved metadata to: {metadata_filepath}")
         return filepath
-        
+
     except Exception as e:
         logging.error(f"Failed to save profile file: {e}")
         return None
@@ -281,7 +291,7 @@ class RemoteProfiler:
                 username=self.username, password=self.password
             )
 
-            if profile_content:
+            if profile_content is not None:
                 # Save profile with metadata
                 filepath = save_profile_with_metadata(
                     profile_content, benchmark_name, self.output_dir, redis_metadata, duration

{redis_benchmarks_specification-0.1.279 → redis_benchmarks_specification-0.1.281}/redis_benchmarks_specification/__runner__/runner.py

@@ -240,13 +240,19 @@ def run_multiple_clients(
 
             # Prepare benchmark command for this client
             if "memtier_benchmark" in client_tool:
+                # Set benchmark path based on local install option
+                if args.benchmark_local_install:
+                    full_benchmark_path = getattr(args, 'memtier_bin_path', 'memtier_benchmark')
+                else:
+                    full_benchmark_path = f"/usr/local/bin/{client_tool}"
+
                 (
                     _,
                     benchmark_command_str,
                     arbitrary_command,
                 ) = prepare_memtier_benchmark_parameters(
                     client_config,
-                    client_tool,
+                    full_benchmark_path,
                     port,
                     host,
                     password,
@@ -1345,6 +1351,7 @@ def process_self_contained_coordinator_stream(
                                 oss_cluster_api_enabled,
                                 unix_socket,
                                 buffer_timeout,
+                                args,
                             )
                             if res is False:
                                 logging.warning(
@@ -1388,7 +1395,12 @@ def process_self_contained_coordinator_stream(
                     # backwards compatible
                     if benchmark_tool is None:
                         benchmark_tool = "redis-benchmark"
-                    full_benchmark_path = f"/usr/local/bin/{benchmark_tool}"
+
+                    # Set benchmark path based on local install option
+                    if args.benchmark_local_install and "memtier_benchmark" in benchmark_tool:
+                        full_benchmark_path = getattr(args, 'memtier_bin_path', 'memtier_benchmark')
+                    else:
+                        full_benchmark_path = f"/usr/local/bin/{benchmark_tool}"
 
                     # setup the benchmark
                     (
@@ -2283,6 +2295,7 @@ def data_prepopulation_step(
     oss_cluster_api_enabled=False,
     unix_socket="",
     timeout_buffer=60,
+    args=None,
 ):
     result = True
     # setup the benchmark
@@ -2301,7 +2314,12 @@ def data_prepopulation_step(
         benchmark_config["dbconfig"], "preload_tool"
     )
     preload_tool = extract_client_tool(benchmark_config["dbconfig"], "preload_tool")
-    full_benchmark_path = f"/usr/local/bin/{preload_tool}"
+
+    # Set preload tool path based on local install option
+    if benchmark_local_install and "memtier_benchmark" in preload_tool and args:
+        full_benchmark_path = getattr(args, 'memtier_bin_path', 'memtier_benchmark')
+    else:
+        full_benchmark_path = f"/usr/local/bin/{preload_tool}"
     client_mnt_point = "/mnt/client/"
 
     if "memtier_benchmark" in preload_tool: