redis-benchmarks-specification 0.1.276__tar.gz → 0.1.279__tar.gz

{redis_benchmarks_specification-0.1.276 → redis_benchmarks_specification-0.1.279}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: redis-benchmarks-specification
-Version: 0.1.276
+Version: 0.1.279
 Summary: The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute.
 Author: filipecosta90
 Author-email: filipecosta.90@gmail.com

{redis_benchmarks_specification-0.1.276 → redis_benchmarks_specification-0.1.279}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redis-benchmarks-specification"
-version = "0.1.276"
+version = "0.1.279"
 description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
 authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
 readme = "Readme.md"

{redis_benchmarks_specification-0.1.276 → redis_benchmarks_specification-0.1.279}/redis_benchmarks_specification/__runner__/remote_profiling.py

@@ -192,9 +192,10 @@ def save_profile_with_metadata(
             f"# profile from redis sha = {redis_metadata['redis_git_sha1']} "
             f"and pid {redis_metadata['process_id']} for duration of {duration}s. "
             f"collection in date {timestamp}\n"
-            f"# redis_version: {redis_metadata['redis_version']}\n"
-            f"# redis_git_dirty: {redis_metadata['redis_git_dirty']}\n"
-            f"# tcp_port: {redis_metadata['tcp_port']}\n"
+            f"# benchmark_name={benchmark_name}\n"
+            f"# redis_git_sha1={redis_metadata['redis_git_sha1']}\n"
+            f"# redis_version={redis_metadata['redis_version']}\n"
+            f"# redis_git_dirty={redis_metadata['redis_git_dirty']}\n"
         )
         
         # Write file with metadata and profile content

{redis_benchmarks_specification-0.1.276 → redis_benchmarks_specification-0.1.279}/redis_benchmarks_specification/__runner__/runner.py

@@ -349,8 +349,6 @@ def run_multiple_clients(
             )
 
             # Start container (detached)
-            import os
-
             # Set working directory based on tool
             working_dir = benchmark_tool_workdir
             if "vector-db-benchmark" in client_tool:
@@ -483,8 +481,6 @@ def run_multiple_clients(
 
     if successful_results:
         # Try to read and aggregate JSON output files
-        import json
-        import os
 
         aggregated_json = {}
         memtier_json = None
@@ -1206,7 +1202,9 @@ def process_self_contained_coordinator_stream(
                     else:
                         for conn in redis_conns:
                             maxmemory = maxmemory + get_maxmemory(conn)
-                    if benchmark_required_memory > maxmemory:
+
+                    # Only perform memory check if we have valid maxmemory information
+                    if maxmemory > 0 and benchmark_required_memory > maxmemory:
                         logging.warning(
                             "Skipping test {} given maxmemory of server is bellow the benchmark required memory: {} < {}".format(
                                 test_name, maxmemory, benchmark_required_memory
@@ -1218,6 +1216,12 @@ def process_self_contained_coordinator_stream(
                             benchmark_tool_global=benchmark_tool_global,
                         )
                         continue
+                    elif maxmemory == 0 and benchmark_required_memory > 0:
+                        logging.warning(
+                            "Cannot enforce memory checks for test {} - maxmemory information unavailable. Proceeding with test.".format(
+                                test_name
+                            )
+                        )
 
                     reset_commandstats(redis_conns)
 
@@ -1647,8 +1651,6 @@ def process_self_contained_coordinator_stream(
                             )
 
                             # Use explicit container management for single client
-                            import os
-
                             # Set working directory based on tool
                             working_dir = benchmark_tool_workdir
                             if "vector-db-benchmark" in benchmark_tool:
@@ -1821,7 +1823,6 @@ def process_self_contained_coordinator_stream(
                             )
                         elif "vector-db-benchmark" in benchmark_tool:
                             # For vector-db-benchmark, look for summary JSON file
-                            import os
                             summary_files = [f for f in os.listdir(temporary_dir_client) if f.endswith("-summary.json")]
                             if summary_files:
                                 full_result_path = os.path.join(temporary_dir_client, summary_files[0])
@@ -1973,9 +1974,16 @@ def process_self_contained_coordinator_stream(
 
 
 def get_maxmemory(r):
-    maxmemory = int(r.info("memory")["maxmemory"])
+    memory_info = r.info("memory")
+
+    # Check if maxmemory key exists in Redis memory info
+    if "maxmemory" not in memory_info:
+        logging.warning("maxmemory not present in Redis memory info. Cannot enforce memory checks.")
+        return 0
+
+    maxmemory = int(memory_info["maxmemory"])
     if maxmemory == 0:
-        total_system_memory = int(r.info("memory")["total_system_memory"])
+        total_system_memory = int(memory_info["total_system_memory"])
         logging.info(" Using total system memory as max {}".format(total_system_memory))
         maxmemory = total_system_memory
     else: