reacton 1.2.0__tar.gz → 1.2.2__tar.gz

{reacton-1.2.0 → reacton-1.2.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: reacton
-Version: 1.2.0
+Version: 1.2.2
 Project-URL: Home, https://www.github.com/widgetti/reacton
 Project-URL: Documentation, https://reacton.solara.dev
 Project-URL: Source code, https://www.github.com/widgetti/reacton

reacton-1.2.2/reacton/_version.py

@@ -0,0 +1 @@
+__version__ = "1.2.2"

{reacton-1.2.0 → reacton-1.2.2}/reacton/core.py

@@ -535,7 +535,8 @@ class ComponentFunction(Component):
         return self.widget_class()(**kwargs)
 
     def widget_class(self):
-        args = list(inspect.signature(self.f).parameters.keys())
+        parameters = inspect.signature(self.f).parameters
+        args = list(parameters.keys())
         listeners = set()
         normal_kwargs = set()
         for name in args:
@@ -554,7 +555,12 @@ class ComponentFunction(Component):
                 traits = {}
 
                 for name in normal_kwargs:
-                    traits[name] = traitlets.Any()
+                    if name != "children":  # children is a special trait we keep
+                        if name in normal_kwargs:
+                            trait = traitlets.Any(default_value=parameters[name].default)
+                        else:
+                            trait = traitlets.Any()
+                        traits[name] = trait
                 Container.add_traits(self, **traits)
                 for name, value in kwargs.items():
                     if name in normal_kwargs:
@@ -568,7 +574,8 @@ class ComponentFunction(Component):
             def _create_el(self):
                 kwargs = {}
                 for name in normal_kwargs:
-                    kwargs[name] = getattr(self, name)
+                    if name != "children":
+                        kwargs[name] = getattr(self, name)
                 for name in listeners:
                     propname = name[3:]
 

{reacton-1.2.0 → reacton-1.2.2}/reacton/core_test.py

@@ -2724,13 +2724,17 @@ def test_implicit_component():
 
 def test_create_widget():
     @react.component
-    def Test(a: int = 1, label="lala", on_a=None):
+    def Test(a: int = 1, label="lala", on_a=None, children=[]):
+        # adding children shouldn't change the children trait
+        assert children == []
         return w.IntSlider(value=a, on_value=on_a, description=label)
 
-    widget: widgets.Widget = Test.widget(a=1, label="lala")  # type: ignore
+    widget: widgets.Widget = Test.widget(a=1)  # type: ignore
+    assert widget.trait_metadata("children", "to_json") is not None
     mock = unittest.mock.Mock()
     widget.trait_names() == ["a", "label"]
     widget.observe(mock, "a")
+    assert widget.label == "lala"
     widget.a = 2
     mock.assert_called_once_with({"name": "a", "old": 1, "new": 2, "owner": widget, "type": "change"})
     slider = widget.children[0]

{reacton-1.2.0 → reacton-1.2.2}/reacton/find.py

@@ -51,7 +51,7 @@ class Finder(collections.abc.Sequence, Generic[W]):
         return parent
 
     def __repr__(self):
-        return "Finder structure:\n%r" % self._current_structure()
+        return "Finder structure:\n%s" % self._current_structure()
 
     def _reexecute_find(self):
         finder = self._root()

{reacton-1.2.0 → reacton-1.2.2}/reacton/utils.py

@@ -1,5 +1,6 @@
 import functools
 import inspect
+import sys
 import types
 from typing import Callable, TypeVar, cast
 
@@ -71,12 +72,14 @@ def equals(a, b):
 
 
 def import_item(name: str):
-    """Import an object by name like pandas.DataFrame"""
-    parts = name.rsplit(".", 2)
+    """Import an object by name like pandas.DataFrame if the module is imported, else return None"""
+    parts = name.rsplit(".", 1)
     if len(parts) == 1:
-        return __import__(name)
+        return sys.modules.get(name)
     else:
-        module = __import__(".".join(parts[:-1]), fromlist=[parts[-1]])
+        module = sys.modules.get(parts[0])
+        if module is None:
+            return None
         return getattr(module, parts[-1])
 
 
@@ -85,8 +88,9 @@ def isinstance_lazy(value, types):
         types = [types]
     types = [import_item(t) if isinstance(t, str) else t for t in types]
     for type in types:
-        if isinstance(value, type):
+        if type is not None and isinstance(value, type):
             return True
+    return False
 
 
 def dataframe_fingerprint(df):

{reacton-1.2.0 → reacton-1.2.2}/reacton/utils_test.py

@@ -1,8 +1,10 @@
+import sys
+
 import pytest
 
 import reacton.ipywidgets as w
 
-from .utils import equals
+from .utils import equals, import_item, isinstance_lazy
 
 
 class NeverEquals:
@@ -82,3 +84,25 @@ def test_equals():
     assert equals(el1.kwargs, el2.kwargs)
     assert equals(el1, el2)
     assert not equals(el1, el3)
+
+
+def test_import_item():
+    assert import_item("sys.modules") is sys.modules
+    assert import_item("sys") is sys
+    assert import_item("doesnotexist") is None
+    assert import_item("doesnotexist.a") is None
+    assert import_item("doesnotexist.a.b") is None
+
+
+def test_isinstance_lazy():
+    assert isinstance_lazy(1, int)
+    assert isinstance_lazy(1, (int, "does.not.exist"))
+    assert not isinstance_lazy(1, "does.not.exist")
+    import pandas
+
+    sys.modules.pop("pandas", None)
+    assert not isinstance_lazy(1, "pandas.DataFrame")
+    import pandas as pd
+
+    df = pd.DataFrame()
+    assert isinstance_lazy(df, "pandas.DataFrame")

reacton-1.2.0/reacton/_version.py

@@ -1 +0,0 @@
-__version__ = "1.2.0"