rara-tools 0.7.11__tar.gz → 0.7.12__tar.gz

{rara_tools-0.7.11/rara_tools.egg-info → rara_tools-0.7.12}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rara-tools
-Version: 0.7.11
+Version: 0.7.12
 Summary: Tools to support Kata's work.
 Classifier: Programming Language :: Python :: 3
 Classifier: Programming Language :: Python :: 3.10

rara_tools-0.7.12/VERSION

@@ -0,0 +1 @@
+0.7.12

{rara_tools-0.7.11 → rara_tools-0.7.12}/rara_tools/normalizers/authorities.py

@@ -59,6 +59,9 @@ class AuthoritiesRecordNormalizer(RecordNormalizer):
             record, "046", "f", formatted_birth_date)
         death_date = self.get_subfield(
             record, "046", "g", formatted_death_date)
+        
+        if not birth_date and not death_date:
+            return
 
         subfields_046 = [
             Subfield("f", birth_date),

{rara_tools-0.7.11 → rara_tools-0.7.12}/rara_tools/normalizers/base.py

@@ -213,13 +213,33 @@ class RecordNormalizer:
         )
 
     def _add_fields_to_record(self, record: Record, fields: List[Field]) -> Record:
-        # filter out subfields that are empty, or 0, as VIAF returns 0 for unknown dates
+        cleaned_fields = []
+        
         for field in fields:
-            field.subfields = [sub for sub in field.subfields if sub.value and sub.value not in ["0", 0]]
             
-        self._handle_repeatable_fields(record, *fields)
-        self._handle_editable_fields(record, *fields)
-        self._handle_default_fields(record, *fields)
+            # Always assume control fields cleaned
+            if field.tag < "010" and field.tag.isdigit():
+                cleaned_fields.append(field)
+                continue
+            
+            # filter out subfields that are empty or 0 (VIAF returns 0 for unknown dates)
+            field.subfields = [
+                sub for sub in field.subfields 
+                if sub.value and sub.value not in ["0", 0]
+            ]
+            
+            # only keep the field if it still has subfields left
+            if field.subfields:
+                cleaned_fields.append(field)
+
+        if not cleaned_fields:
+            return record
+        
+        self._handle_repeatable_fields(record, *cleaned_fields)
+        self._handle_editable_fields(record, *cleaned_fields)
+        self._handle_default_fields(record, *cleaned_fields)
+        
+        return record
 
     def _add_author(self, record: Record, viaf_record: VIAFRecord) -> Optional[Field]:
 

{rara_tools-0.7.11 → rara_tools-0.7.12/rara_tools.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: rara-tools
-Version: 0.7.11
+Version: 0.7.12
 Summary: Tools to support Kata's work.
 Classifier: Programming Language :: Python :: 3
 Classifier: Programming Language :: Python :: 3.10

{rara_tools-0.7.11 → rara_tools-0.7.12}/tests/test_normalization.py

@@ -404,6 +404,17 @@ def test_add_birth_and_death_dates():
     # empty indicators represented with \
     assert field_046 == "=046  \\\\$f19700817"
     
+    # Case 3 - viaf record has no birth or death date
+    viaf_record = normalizer._get_viaf_record(
+        record,
+        entity="Eesti Interlingvistika Selts"      
+    )
+    record = Record()
+    normalizer._add_birth_and_death_dates(record, viaf_record)
+    # should not add 046 field
+    fields_046 = record.get_fields("046")
+    assert len(fields_046) == 0
+    
 def test_add_nationality():
     """ Test adding nationality from VIAF record to 043 field """
     

rara_tools-0.7.11/VERSION

@@ -1 +0,0 @@
-0.7.11