quality-loop 0.2.0__tar.gz → 0.2.1__tar.gz

{quality_loop-0.2.0/quality_loop.egg-info → quality_loop-0.2.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: quality-loop
-Version: 0.2.0
+Version: 0.2.1
 Summary: Measure what a product teaches - its skill, tools or manual - with isolated agent runs of real tasks, reported by an operator agent
 Author: craftware
 License-Expression: MIT
@@ -121,9 +121,12 @@ under a policy the person sets. See [Running the loop](https://github.com/crftwr
 
 ## Status
 
-0.x, early. It has been run end to end on macOS against the two examples and
-against Keyhac. The Windows screen and key backends are unit-tested but have
-not yet been run on a Windows machine. The design discussion is
+0.x, early. It has been run end to end on macOS against the two examples,
+Keyhac and XeFM (including XeFM's terminal UI in a live check), and on
+Windows (11, ARM64) against the toy, Keyhac and XeFM, with real page and
+terminal screens. Not yet run anywhere for real: synthetic keys and
+screenshots of a desktop app (`drive.DesktopApp`); a terminal app is not
+driven on Windows yet. The design discussion is
 [crftwr/keyhac#205](https://github.com/crftwr/keyhac/issues/205) and this
 repository's issues.
 

{quality_loop-0.2.0 → quality_loop-0.2.1}/README.md

@@ -90,9 +90,12 @@ under a policy the person sets. See [Running the loop](https://github.com/crftwr
 
 ## Status
 
-0.x, early. It has been run end to end on macOS against the two examples and
-against Keyhac. The Windows screen and key backends are unit-tested but have
-not yet been run on a Windows machine. The design discussion is
+0.x, early. It has been run end to end on macOS against the two examples,
+Keyhac and XeFM (including XeFM's terminal UI in a live check), and on
+Windows (11, ARM64) against the toy, Keyhac and XeFM, with real page and
+terminal screens. Not yet run anywhere for real: synthetic keys and
+screenshots of a desktop app (`drive.DesktopApp`); a terminal app is not
+driven on Windows yet. The design discussion is
 [crftwr/keyhac#205](https://github.com/crftwr/keyhac/issues/205) and this
 repository's issues.
 

{quality_loop-0.2.0 → quality_loop-0.2.1}/quality_loop/__init__.py

@@ -12,4 +12,4 @@ room is handed, putting the user's machine back - is code here, not an
 agent's discretion.
 """
 
-__version__ = "0.2.0"
+__version__ = "0.2.1"

{quality_loop-0.2.0 → quality_loop-0.2.1}/quality_loop/drive/terminal.py

@@ -31,6 +31,14 @@ class TerminalError(Exception):
     pass
 
 
+#: Seconds after a lone Esc before the next key. A terminal app cannot tell
+#: Esc followed quickly by a key from Alt+that key: it waits a moment (PuiKit
+#: 0.1s, ncurses ESCDELAY) for the rest of a sequence. The first XeFM live
+#: check sent Esc then Ctrl-T 20ms apart, and the command palette never
+#: opened - it had arrived as Alt-Ctrl-T.
+ESC_SETTLE = 0.3
+
+
 def _pyte():
     try:
         import pyte
@@ -68,8 +76,11 @@ class PtyApp:
         # The app's answers to queries (cursor position, device attributes)
         # go back down the pty, or a curses app that asks waits forever.
         self.screen.write_process_input = lambda data: self._write(data.encode("utf-8"))
-        environment = dict(os.environ, **(env or {}), TERM="xterm-256color",
-                           LINES=str(rows), COLUMNS=str(cols))
+        # ESCDELAY: how long ncurses waits after an ESC to see whether a
+        # sequence follows - a second by default. Short, so a lone Esc is an
+        # Esc soon enough for ESC_SETTLE below to cover it.
+        environment = {"ESCDELAY": "25", **os.environ, **(env or {}),
+                       "TERM": "xterm-256color", "LINES": str(rows), "COLUMNS": str(cols)}
         self.process = subprocess.Popen(
             argv, stdin=slave, stdout=slave, stderr=slave, cwd=cwd, env=environment,
             start_new_session=True, close_fds=True)
@@ -108,6 +119,8 @@ class PtyApp:
                 self._write(item.text.encode("utf-8"))
             else:
                 self._write(keynames.terminal_bytes(item))
+                if item.name == "Esc" and not item.mods:
+                    time.sleep(ESC_SETTLE)
             time.sleep(0.02)
         self._sent = time.monotonic()
 

{quality_loop-0.2.0 → quality_loop-0.2.1}/quality_loop/report.py

@@ -103,6 +103,10 @@ def parse(text: str, room: str = "") -> tuple[list[Problem], list[str]]:
     problems: list[Problem] = []
     current: Problem | None = None
     detail: list[str] = []
+    #: The field the indented lines below it continue. The first Windows runs
+    #: had operators write `- **Evidence:**` with the evidence as a nested
+    #: list under it, and five findings came out "no evidence" that had it.
+    field_key: str | None = None
 
     def close():
         if current is not None:
@@ -115,6 +119,7 @@ def parse(text: str, room: str = "") -> tuple[list[Problem], list[str]]:
             current = Problem(severity=heading["severity"].strip().lower(),
                               title=heading["title"], room=room)
             detail = []
+            field_key = None
         elif current is not None and (field := _FIELD.match(line)) \
                 and field["label"].strip().lower() in by_label:
             value = field["value"].strip()
@@ -124,7 +129,12 @@ def parse(text: str, room: str = "") -> tuple[list[Problem], list[str]]:
             if key == "kind":
                 value = value.lower()
             setattr(current, key, value)
+            field_key = key
+        elif current is not None and field_key and line[:1].isspace() and line.strip():
+            before = getattr(current, field_key)
+            setattr(current, field_key, f"{before}\n{line.strip()}".strip())
         elif current is not None:
+            field_key = None
             detail.append(line)
     close()
     malformed = [f"{p.title}: {issue}" for p in problems for issue in p.problems()]

{quality_loop-0.2.0 → quality_loop-0.2.1/quality_loop.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: quality-loop
-Version: 0.2.0
+Version: 0.2.1
 Summary: Measure what a product teaches - its skill, tools or manual - with isolated agent runs of real tasks, reported by an operator agent
 Author: craftware
 License-Expression: MIT
@@ -121,9 +121,12 @@ under a policy the person sets. See [Running the loop](https://github.com/crftwr
 
 ## Status
 
-0.x, early. It has been run end to end on macOS against the two examples and
-against Keyhac. The Windows screen and key backends are unit-tested but have
-not yet been run on a Windows machine. The design discussion is
+0.x, early. It has been run end to end on macOS against the two examples,
+Keyhac and XeFM (including XeFM's terminal UI in a live check), and on
+Windows (11, ARM64) against the toy, Keyhac and XeFM, with real page and
+terminal screens. Not yet run anywhere for real: synthetic keys and
+screenshots of a desktop app (`drive.DesktopApp`); a terminal app is not
+driven on Windows yet. The design discussion is
 [crftwr/keyhac#205](https://github.com/crftwr/keyhac/issues/205) and this
 repository's issues.
 

{quality_loop-0.2.0 → quality_loop-0.2.1}/tests/test_drive.py

@@ -190,3 +190,34 @@ def test_mac_key_codes():
     assert _mac.keycode(keys.parse("Shift-G")) == (5, _mac.FLAGS["shift"])
     assert _mac.keycode(keys.parse("G")) == (5, 0), "a letter names the key"
     assert _mac.keycode(keys.parse("F1"))[0] == 122
+
+
+@posix_only
+def test_a_lone_esc_is_not_glued_to_the_next_key(tmp_path):
+    """Esc then Ctrl-T, sent 20ms apart, reached XeFM as Alt-Ctrl-T."""
+    pytest.importorskip("pyte")
+    from quality_loop.drive import terminal
+    script = tmp_path / "gaps.py"
+    script.write_text(textwrap.dedent('''
+        import os, sys, time, tty
+        tty.setraw(0)
+        last, out = time.monotonic(), []
+        while len(out) < 2:
+            data = os.read(0, 16)
+            now = time.monotonic()
+            out.append((data.hex(), round(now - last, 2)))
+            last = now
+        sys.stdout.write(repr(out) + "\\r\\n")
+        sys.stdout.flush()
+        time.sleep(5)
+    '''))
+    app = terminal.PtyApp([sys.executable, str(script)], rows=5, cols=60)
+    try:
+        app.wait_quiet(patience=5)
+        app.send(keys.sequence(["Esc", "Ctrl-T"]))
+        app.wait_quiet(patience=5)
+        seen = eval(app.text().strip().splitlines()[-1])
+    finally:
+        app.stop()
+    assert [hex_ for hex_, _gap in seen] == ["1b", "14"], "two reads, not one ESC+key burst"
+    assert seen[1][1] >= terminal.ESC_SETTLE - 0.05

{quality_loop-0.2.0 → quality_loop-0.2.1}/tests/test_loop.py

@@ -401,12 +401,14 @@ def test_an_upgrade_leaves_a_hand_edited_skill_alone(tmp_path):
 
 
 def test_the_command_found_is_relative_inside_the_checkout(tmp_path, monkeypatch):
-    bin_dir = tmp_path / ".venv" / "bin"
+    # The venv's own layout: Scripts/quality-loop.exe on Windows.
+    bin_dir = tmp_path / ".venv" / ("Scripts" if os.name == "nt" else "bin")
     bin_dir.mkdir(parents=True)
-    (bin_dir / "quality-loop").write_text("")
+    script = "quality-loop.exe" if os.name == "nt" else "quality-loop"
+    (bin_dir / script).write_text("")
     monkeypatch.setattr(sys, "executable", str(bin_dir / "python"))
     monkeypatch.setattr(install.shutil, "which", lambda _name: None)
-    assert install.command_for(tmp_path) == ".venv/bin/quality-loop"
+    assert install.command_for(tmp_path) == (bin_dir / script).relative_to(tmp_path).as_posix()
     assert install.commands_for(tmp_path) == {
         "command": ".venv/bin/quality-loop",
         "command_windows": ".venv/Scripts/quality-loop.exe"}

{quality_loop-0.2.0 → quality_loop-0.2.1}/tests/test_operator.py

@@ -41,8 +41,8 @@ def test_the_operator_has_no_shell_and_only_quality_loop_s_server(op):
     assert "Write" not in allow and "Edit" not in allow
     assert "mcp__quality-loop" in allow
     writes = [rule for rule in allow if rule.startswith(("Write(", "Edit("))]
-    assert writes == [f"Edit(/{op.directory.resolve().as_posix()}/**)",
-                      f"Edit(/{(op.room.resolve() / 'REPORT.md').as_posix()})"]
+    assert writes == [f"Edit({operator.absolute(op.directory)}/**)",
+                      f"Edit({operator.absolute(op.room / 'REPORT.md')})"]
     assert all(rule.startswith("Edit(//") for rule in writes), "absolute: //"
     assert _value(command, "--permission-mode") == "dontAsk"
 

{quality_loop-0.2.0 → quality_loop-0.2.1}/tests/test_scenario_report.py

@@ -128,6 +128,24 @@ def test_a_report_is_read_the_way_a_loop_needs_it():
     assert any("no id" in m for m in malformed) and any("no evidence" in m for m in malformed)
 
 
+def test_a_field_continued_as_a_nested_list_is_kept():
+    problems, malformed = report.parse(
+        "### [medium] Defaults pasted in\n"
+        "- **Id:** `extend-default`\n"
+        "- **Kind:** product\n"
+        "- **Evidence:**\n"
+        "  - 66 new lines in a 14-line file\n"
+        "  - config.md says to copy the defaults\n"
+        "- **Where it would be fixed:** config.md\n"
+        "\n"
+        "  An indented paragraph after a blank line is free text.\n")
+    assert not malformed
+    assert problems[0].evidence == ("- 66 new lines in a 14-line file\n"
+                                    "- config.md says to copy the defaults")
+    assert problems[0].where == "config.md"
+    assert "indented paragraph" in problems[0].detail
+
+
 def test_findings_concatenate_and_count_most_severe_first(tmp_path):
     path = report.write_findings(tmp_path, [
         ("11_f1", "F1 off", REPORT),