quack-kernels 0.1.6__tar.gz → 0.1.7__tar.gz

{quack_kernels-0.1.6/quack_kernels.egg-info → quack_kernels-0.1.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: quack-kernels
-Version: 0.1.6
+Version: 0.1.7
 Requires-Python: >=3.9
 License-File: LICENSE
 Requires-Dist: nvidia-cutlass-dsl==4.1.0.dev0

{quack_kernels-0.1.6 → quack_kernels-0.1.7}/README.md

@@ -16,13 +16,12 @@ pip install quack-kernels
 
 ## Kernels 🐥
 
-- 🦆 RMSNorm forward
+- 🦆 RMSNorm forward + backward
 - 🦆 Softmax forward + backward
 - 🦆 Cross entropy forward + backward
 - 🦆 Layernorm forward
 
 Upcoming:
-- 🦆 RMSNorm backward
 - 🦆 Rotary forward + backward
 
 ## Usage

{quack_kernels-0.1.6 → quack_kernels-0.1.7}/quack/__init__.py

@@ -1,4 +1,4 @@
-__version__ = "0.1.6"
+__version__ = "0.1.7"
 
 from quack.rmsnorm import rmsnorm
 from quack.softmax import softmax

{quack_kernels-0.1.6 → quack_kernels-0.1.7}/quack/reduction_base.py

@@ -68,7 +68,7 @@ class ReductionBase:
         )
 
     def _allocate_reduction_buffer_and_mbar(
-        self, smem: cutlass.utils.SmemAllocator, tv_layout: cute.Layout
+        self, smem: cutlass.utils.SmemAllocator, tv_layout: cute.Layout, is_persistent: bool = False
     ) -> Tuple[cute.Tensor, Optional[cute.Pointer]]:
         reduction_buffer = smem.allocate_tensor(
             self.reduction_dtype,
@@ -76,20 +76,28 @@ class ReductionBase:
             byte_alignment=4,
         )
         if cutlass.const_expr(self.cluster_n > 1):
-            mbar_ptr = smem.allocate_array(cutlass.Int64, num_elems=self.stage)
+            mbar_ptr = smem.allocate_array(
+                cutlass.Int64, num_elems=self.stage if not is_persistent else self.stage * 2
+            )
         else:
             mbar_ptr = None
         return reduction_buffer, mbar_ptr
 
     @cute.jit
-    def _initialize_cluster(self, tidx: cutlass.Int32, mbar_ptr: cute.Pointer, num_warps: int):
+    def _initialize_cluster(
+        self,
+        tidx: cutlass.Int32,
+        mbar_ptr: cute.Pointer,
+        num_warps: int,
+        is_persistent: bool = False,
+    ):
         if cutlass.const_expr(self.cluster_n > 1):
-            if tidx < self.stage:
+            if tidx < self.stage:  # Initialize full barrier
                 cute.arch.mbarrier_init(mbar_ptr + tidx, 1)
+                if cutlass.const_expr(is_persistent):  # Initialize empty barrier
+                    cute.arch.mbarrier_init(
+                        mbar_ptr + self.stage + tidx, num_warps * self.cluster_n
+                    )
             cute.arch.mbarrier_init_fence()
-            if tidx < self.stage:
-                cute.arch.mbarrier_arrive_and_expect_tx(
-                    mbar_ptr + tidx, num_warps * self.cluster_n * self.reduction_dtype.width // 8
-                )
             # Cluster arrive after barrier init
             cute.arch.cluster_arrive_relaxed()

{quack_kernels-0.1.6 → quack_kernels-0.1.7}/quack/rmsnorm.py

@@ -1,6 +1,5 @@
 # Copyright (c) 2025, Wentao Guo, Ted Zadouri, Tri Dao.
 
-
 import torch
 from typing import Optional
 
@@ -157,6 +156,7 @@ class RMSNorm(ReductionBase):
 
         # allocate fragments for gmem->rmem
         tWrW = cute.make_fragment_like(tWgW)
+        tWrW.fill(0.0)
         tXrW = thr_copy_X.retile(tWrW)
         tXrX, tXrO = [cute.make_fragment_like(thr) for thr in (tXgX, tXgO)]
 
@@ -300,8 +300,14 @@ def rmsnorm_bwd_ref(x, w, dout, rstd, eps=1e-6):
 
 class RMSNormBackward(ReductionBase):
     def __init__(self, dtype: cutlass.Numeric, N: int):
-        # 1 stage for computing mean of x_hat * wdy
-        super().__init__(dtype, N, stage=1, reduction_dtype=cutlass.Float32)
+        # 2 stages for double buffering when computing mean of x_hat * wdy
+        super().__init__(dtype, N, stage=2, reduction_dtype=cutlass.Float32)
+        if self.N > 128 * 1024 and self.dtype.width >= 32:
+            # Not enough smem
+            raise ValueError("RMSNormBackward does not support N > 128k with dtype >= 32 bits")
+
+    def _get_num_threads(self):
+        return 128 if self.N <= 4096 else 256
 
     def _calculate_threads_per_row(self):
         N = self.N
@@ -311,44 +317,38 @@ class RMSNormBackward(ReductionBase):
             else (
                 16
                 if N <= 128
-                else (32 if N <= 3072 else (64 if N <= 6144 else (128 if N <= 16384 else 256)))
+                else (32 if N <= 256 else (64 if N <= 512 else (128 if N <= 4096 else 256)))
             )
         )
 
     def _set_cluster_n(self):
         N = self.N
-        if cutlass.const_expr(self.dtype.width == 16):
-            cluster_n = (
-                1
-                if N <= 16 * 1024
-                else (
-                    2
-                    if N <= 32 * 1024
-                    else (4 if N <= 64 * 1024 else (8 if N <= 128 * 1024 else 16))
-                )
-            )
-        else:  # fp32
-            cluster_n = (
-                1
-                if N <= 32 * 1024
-                else (
-                    2
-                    if N <= 64 * 1024
-                    else (4 if N <= 128 * 1024 else (8 if N <= 256 * 1024 else 16))
-                )
-            )
+        cluster_n = (
+            1
+            if N <= 8 * 1024
+            else (2 if N <= 16 * 1024 else (4 if N <= 32 * 1024 else (8 if N <= 64 * 1024 else 16)))
+        )
         self.cluster_n = cluster_n
 
+    def _smem_size_in_bytes(self, tiler_mn, num_warps):
+        return (
+            # Multiply by 2 since we need space for X and dOut,
+            # and multiply by another 2 due to double buffering
+            cute.size_in_bytes(self.dtype, cute.make_layout(tiler_mn)) * 2 * 2
+            + self.stage * num_warps * self.cluster_n * (self.reduction_dtype.width // 8)
+            + self.stage * (cutlass.Int64.width // 8) * 2  # mult 2 as we need 2 mbar per stage
+        )
+
     @cute.jit
     def __call__(
         self,
         mX: cute.Tensor,
         mW: cute.Tensor,
-        mDout: cute.Tensor,
+        mdOut: cute.Tensor,
         mRstd: cute.Tensor,
-        mDx: cute.Tensor,
-        mDw: cute.Tensor,
-        sm_count: cutlass.Constexpr,
+        mdX: cute.Tensor,
+        mdW: cute.Tensor,
+        sm_count: cutlass.Int32,
         stream: cuda.CUstream,
     ):
         self._set_cluster_n()
@@ -359,14 +359,8 @@ class RMSNormBackward(ReductionBase):
         mW_expanded_layout = cute.prepend(mW.layout, cute.make_layout((tiler_mn[0],), stride=(0,)))
         mW = cute.make_tensor(mW.iterator, mW_expanded_layout)
 
-        mRstd_expanded_layout = cute.append(mRstd.layout, cute.make_layout((self.N,), stride=(0,)))
-        mRstd = cute.make_tensor(mRstd.iterator, mRstd_expanded_layout)
-
-        num_blocks = (
-            sm_count if tiler_mn[0] == 1 else min(sm_count, cute.ceil_div(1024, tiler_mn[0]))
-        )
-
-        self.kernel(mX, mW, mDout, mRstd, mDx, mDw, sm_count, tv_layout, tiler_mn).launch(
+        num_blocks = sm_count
+        self.kernel(mX, mW, mdOut, mRstd, mdX, mdW, tv_layout, tiler_mn).launch(
             grid=[num_blocks, self.cluster_n, 1],
             block=[num_threads, 1, 1],
             cluster=[1, self.cluster_n, 1] if self.cluster_n > 1 else None,
@@ -379,177 +373,244 @@ class RMSNormBackward(ReductionBase):
         self,
         mX: cute.Tensor,
         mW: cute.Tensor,
-        mDout: cute.Tensor,
+        mdOut: cute.Tensor,
         mRstd: cute.Tensor,
-        mDx: cute.Tensor,
-        mDw: cute.Tensor,
-        sm_count: cutlass.Constexpr,
+        mdX: cute.Tensor,
+        mdW: cute.Tensor,
         tv_layout: cute.Layout,
         tiler_mn: cute.Shape,
     ):
         tidx, _, _ = cute.arch.thread_idx()
-        bidx, cluster_y, _ = cute.arch.block_idx()
+        bidx_start, _, _ = cute.arch.block_idx()
         gdim, _, _ = cute.arch.grid_dim()
+        if cutlass.const_expr(self.cluster_n > 1):
+            cluster_y = cute.arch.block_idx()[1]
+        else:
+            cluster_y = cutlass.const_expr(0)
 
         shape = mX.shape
         M, N = shape[0], shape[1]
+        is_even_N = cutlass.const_expr(shape[1] == tiler_mn[1] * self.cluster_n)
 
         idX = cute.make_identity_tensor(shape)
 
         smem = cutlass.utils.SmemAllocator()
-        reduction_buffer, mbar_ptr = self._allocate_reduction_buffer_and_mbar(smem, tv_layout)
+        smem_layout = cute.make_ordered_layout((tiler_mn[0], tiler_mn[1], 2), order=(1, 0, 2))
+        sX = smem.allocate_tensor(mX.element_type, smem_layout, byte_alignment=16)
+        sdOut = smem.allocate_tensor(mdOut.element_type, smem_layout, byte_alignment=16)
+        reduction_buffer, mbar_ptr = self._allocate_reduction_buffer_and_mbar(
+            smem, tv_layout, is_persistent=True
+        )
+        if cutlass.const_expr(mbar_ptr is not None):
+            mbar_full_ptr, mbar_empty_ptr = mbar_ptr, mbar_ptr + 2
+        else:
+            mbar_full_ptr, mbar_empty_ptr = None, None
 
         copy_atom_load_X = cute.make_copy_atom(
             cute.nvgpu.CopyUniversalOp(), mX.element_type, num_bits_per_copy=128
         )
-
+        copy_atom_load_X_async = cute.make_copy_atom(
+            cute.nvgpu.cpasync.CopyG2SOp(), mX.element_type, num_bits_per_copy=128
+        )
         copy_atom_load_W = cute.make_copy_atom(
             cute.nvgpu.CopyUniversalOp(), mW.element_type, num_bits_per_copy=128
         )
-
         copy_atom_store_dX = cute.make_copy_atom(
-            cute.nvgpu.CopyUniversalOp(), mDx.element_type, num_bits_per_copy=128
+            cute.nvgpu.CopyUniversalOp(), mdX.element_type, num_bits_per_copy=128
         )
-
-        copy_atom_dw = cute.make_copy_atom(
-            cute.nvgpu.CopyUniversalOp(), mDw.element_type, num_bits_per_copy=128
+        copy_atom_store_dW = cute.make_copy_atom(
+            cute.nvgpu.CopyUniversalOp(), mdW.element_type, num_bits_per_copy=128
         )
 
         thr_copy_X = cute.make_tiled_copy(copy_atom_load_X, tv_layout, tiler_mn).get_slice(tidx)
+        thr_copy_X_async = cute.make_tiled_copy(
+            copy_atom_load_X_async, tv_layout, tiler_mn
+        ).get_slice(tidx)
         thr_copy_W = cute.make_tiled_copy(copy_atom_load_W, tv_layout, tiler_mn).get_slice(tidx)
-        thr_copy_dw = cute.make_tiled_copy(copy_atom_dw, tv_layout, tiler_mn).get_slice(tidx)
-        thr_store_dx = cute.make_tiled_copy(copy_atom_store_dX, tv_layout, tiler_mn).get_slice(tidx)
+        thr_copy_dW = cute.make_tiled_copy(copy_atom_store_dW, tv_layout, tiler_mn).get_slice(tidx)
+        thr_store_dX = cute.make_tiled_copy(copy_atom_store_dX, tv_layout, tiler_mn).get_slice(tidx)
 
-        gW = cute.local_tile(mW, tiler_mn, (bidx, 0 if self.cluster_n == 1 else cluster_y))
+        gW = cute.local_tile(mW, tiler_mn, (0, cluster_y))
         tWgW = thr_copy_W.partition_S(gW)
         tWrW = cute.make_fragment_like(tWgW)
+        # Need this, otherwise rW can have arbitrary values that changes the reduction
+        if not is_even_N:
+            tWrW.fill(0.0)
         tXrW = thr_copy_X.retile(tWrW)
 
-        gW_coord = cute.local_tile(idX, tiler_mn, (0, 0 if self.cluster_n == 1 else cluster_y))
-
-        tWpW = utils.predicate_k(thr_copy_W.partition_S(gW_coord), limit=shape[1])
+        gW_coord = cute.local_tile(idX, tiler_mn, (0, cluster_y))
+        tWpW = (
+            utils.predicate_k(thr_copy_W.partition_S(gW_coord), limit=shape[1])
+            if not is_even_N
+            else None
+        )
         cute.copy(copy_atom_load_W, tWgW, tWrW, pred=tWpW)
         weight = tXrW.load().to(cute.Float32)
 
         num_warps = cute.size(tv_layout, mode=[0]) // cute.arch.WARP_SIZE
 
-        self._initialize_cluster(tidx, mbar_ptr, num_warps)
-
-        dw_coord = cute.local_tile(idX, tiler_mn, (0, 0 if self.cluster_n == 1 else cluster_y))
-        tDwpDw = utils.predicate_k(thr_copy_dw.partition_S(dw_coord), limit=shape[1])
+        self._initialize_cluster(tidx, mbar_ptr, num_warps, is_persistent=True)
 
-        gDw = cute.local_tile(mDw, tiler_mn, (bidx, 0 if self.cluster_n == 1 else cluster_y))
-        tDwgDw = thr_copy_dw.partition_D(gDw)
-        tDwrDw = cute.make_fragment_like(tDwgDw)
-        dw_accumulator = thr_copy_X.retile(tDwrDw)
-        dw_accumulator.fill(0.0)
-
-        M_pad = ((M + sm_count - 1) // sm_count) * sm_count
+        dw_coord = cute.local_tile(idX, tiler_mn, (0, cluster_y))
+        tdWpdW = (
+            utils.predicate_k(thr_copy_dW.partition_S(dw_coord), limit=shape[1])
+            if not is_even_N
+            else None
+        )
 
-        jump = sm_count if tiler_mn[0] == 1 else min(sm_count, cute.ceil_div(1024, tiler_mn[0]))
+        gdW = cute.local_tile(mdW, (1, tiler_mn[1]), (bidx_start, cluster_y))
+        tdWgdW = thr_copy_dW.partition_D(gdW)
+        tdWrdW = cute.make_fragment_like(tdWgdW, cutlass.Float32)
+        tXrdW = thr_copy_X.retile(tdWrdW)
 
-        if cutlass.const_expr(self.cluster_n > 1):
-            cute.arch.cluster_arrive()
-            cute.arch.cluster_wait()
+        gX = cute.local_tile(mX, tiler_mn, (None, cluster_y))
+        gdOut = cute.local_tile(mdOut, tiler_mn, (None, cluster_y))
+        gdX = cute.local_tile(mdX, tiler_mn, (None, cluster_y))
+        cX = cute.local_tile(idX, tiler_mn, (None, cluster_y))
+        tXgX = thr_copy_X.partition_S(gX)
+        tXsX = thr_copy_X.partition_D(sX)
+        tXgdOut = thr_copy_X.partition_S(gdOut)
+        tXsdOut = thr_copy_X.partition_D(sdOut)
+        tXgdX = thr_store_dX.partition_D(gdX)
+        tXcX = thr_copy_X.partition_S(cX)[(0, None), None, None, None]
+        # This doesn't change across iterations
+        tXpX = (
+            utils.predicate_k(thr_copy_X.partition_S(cX[None, None, 0]), limit=shape[1])
+            if not is_even_N
+            else None
+        )
 
-        ## need to update range_dynamic since it will be deprecated soon
-        for row_offset in cutlass.range_dynamic(bidx, M_pad, jump):
-            gX = cute.local_tile(
-                mX, tiler_mn, (row_offset, 0 if self.cluster_n == 1 else cluster_y)
+        tXrX, tXrdOut, tXrdX = [
+            cute.make_fragment_like(thr[None, None, None, 0]) for thr in (tXgX, tXgdOut, tXgdX)
+        ]
+
+        # Prefetch the first batch
+        row = tXcX[None, None, None, bidx_start][0][0]
+        if row < M:
+            tXgX_cur = utils.coord_offset_i64(bidx_start, tXgX, dim=3)[None, None, None, 0]
+            tXgdOut_cur = utils.coord_offset_i64(bidx_start, tXgdOut, dim=3)[None, None, None, 0]
+            cute.copy(
+                copy_atom_load_X_async,
+                tXgX_cur,
+                tXsX[None, None, None, 0],
+                pred=tXpX,
             )
-            gDout = cute.local_tile(
-                mDout, tiler_mn, (row_offset, 0 if self.cluster_n == 1 else cluster_y)
+            cute.copy(
+                copy_atom_load_X_async,
+                tXgdOut_cur,
+                tXsdOut[None, None, None, 0],
+                pred=tXpX,
             )
-            gRstd = cute.local_tile(
-                mRstd, tiler_mn, (row_offset, 0 if self.cluster_n == 1 else cluster_y)
-            )
-            gDx = cute.local_tile(
-                mDx, tiler_mn, (row_offset, 0 if self.cluster_n == 1 else cluster_y)
-            )
-            cX = cute.local_tile(
-                idX, tiler_mn, (row_offset, 0 if self.cluster_n == 1 else cluster_y)
-            )
-
-            tXgX = thr_copy_X.partition_S(gX)
-            thrDout = thr_copy_X.partition_S(gDout)
-            tXrRstd = thr_copy_W.partition_S(gRstd)
-            thrDx = thr_store_dx.partition_D(gDx)
-            tXcX = thr_copy_X.partition_S(cX)[(0, None), None, None]
-
-            tXrX, frgDout, frgDx = [cute.make_fragment_like(thr) for thr in (tXgX, thrDout, thrDx)]
-
-            tXpX = utils.predicate_k(thr_copy_X.partition_S(cX), limit=shape[1])
+        elif tiler_mn[0] > 1:
+            # Fill with zero, otherwise smem will be uninitialized, and we could read this back
+            # later into registers, causing wrong dW.
+            utils.fill_oob(tXsX[None, None, None, 0], None, fill_value=mX.element_type.zero)
+            utils.fill_oob(tXsdOut[None, None, None, 0], None, fill_value=mdOut.element_type.zero)
+        cute.arch.cp_async_commit_group()
 
-            if tXcX[0][0] < shape[0]:
-                cute.copy(copy_atom_load_X, tXgX, tXrX, pred=tXpX)
-                cute.copy(copy_atom_load_X, thrDout, frgDout, pred=tXpX)
+        if cutlass.const_expr(self.cluster_n > 1):
+            cute.arch.cluster_wait()
 
+        threads_per_row = tv_layout.shape[0][0]
+        tXrdW.fill(0.0)
+        stage = cutlass.Int32(0)
+        producer_phase = cutlass.Int32(1)
+        consumer_phase = cutlass.Int32(0)
+        for bidx in cutlass.range(bidx_start, cute.ceil_div(M, tiler_mn[0]), gdim):
+            row = tXcX[None, None, None, bidx][0][0]
+            rstd = cutlass.Float.zero
+            if row + gdim * tiler_mn[0] < M:  # Prefetch the next batch
+                tXgX_cur = utils.coord_offset_i64(bidx + gdim, tXgX, dim=3)[None, None, None, 0]
+                tXgdOut_cur = utils.coord_offset_i64(bidx + gdim, tXgdOut, dim=3)[
+                    None, None, None, 0
+                ]
+                cute.copy(
+                    copy_atom_load_X_async,
+                    tXgX_cur,
+                    tXsX[None, None, None, stage ^ 1],
+                    pred=tXpX,
+                )
+                cute.copy(
+                    copy_atom_load_X_async,
+                    tXgdOut_cur,
+                    tXsdOut[None, None, None, stage ^ 1],
+                    pred=tXpX,
+                )
+            elif tiler_mn[0] > 1:
+                utils.fill_oob(
+                    tXsX[None, None, None, stage ^ 1], None, fill_value=mX.element_type.zero
+                )
+                utils.fill_oob(
+                    tXsdOut[None, None, None, stage ^ 1], None, fill_value=mdOut.element_type.zero
+                )
+            cute.arch.cp_async_commit_group()
+            if row < M or tiler_mn[0] == 1:
+                rstd = mRstd[row]
+            cute.arch.cp_async_wait_group(1)
+            cute.autovec_copy(tXsX[None, None, None, stage], tXrX)
             x = tXrX.load().to(cute.Float32)
-            dout = frgDout.load().to(cute.Float32)
-
-            rstd = tXrRstd[0]
+            cute.autovec_copy(tXsdOut[None, None, None, stage], tXrdOut)
+            dout = tXrdOut.load().to(cute.Float32)
             x_hat = x * rstd
             wdy = dout * weight
-
-            threads_per_row = tv_layout.shape[0][0]
-
-            row = tXcX[0][0]
             if cutlass.const_expr(self.cluster_n > 1):
-                cute.arch.cluster_arrive()
-                cute.arch.cluster_wait()
-            else:
-                cute.arch.barrier()
-
+                cute.arch.mbarrier_wait(mbar_empty_ptr + stage, producer_phase)
             mean_xhat_wdy = (
                 utils.row_reduce(
                     x_hat * wdy,
                     cute.ReductionOp.ADD,
                     threads_per_row,
-                    reduction_buffer[None, None, 0],
-                    mbar_ptr + 0 if cutlass.const_expr(self.cluster_n > 1) else None,
+                    reduction_buffer[None, None, stage],
+                    mbar_full_ptr + stage if cutlass.const_expr(self.cluster_n > 1) else None,
+                    phase=consumer_phase,
                     init_val=0.0,
-                    hook_fn=cute.arch.cluster_wait
-                    if cutlass.const_expr(self.cluster_n > 1)
-                    else None,
                 )
                 / shape[1]
             )
-
-            dx = (wdy - x_hat * mean_xhat_wdy) * rstd
-            frgDx.store(dx.to(frgDout.element_type))
-
-            if row < M:
-                cute.copy(copy_atom_store_dX, frgDx, thrDx, pred=tXpX)
-
             if cutlass.const_expr(self.cluster_n > 1):
-                cute.arch.cluster_arrive()
-                cute.arch.cluster_wait()
-            else:
-                cute.arch.barrier()
-
-            if row < M:
-                dw_row = dout * x_hat
-                current_dw = dw_accumulator.load().to(cute.Float32)
-                updated_dw = current_dw + dw_row
-                dw_accumulator.store(updated_dw.to(dw_accumulator.element_type))
-
-            """ 
-            if cutlass.const_expr(self.cluster_n > 1):
-                cute.arch.cluster_arrive()
-                cute.arch.cluster_wait()
-            else:
-                cute.arch.barrier()
-            """
-        """ 
-        if cutlass.const_expr(self.cluster_n > 1):
-            cute.arch.cluster_arrive()
-            cute.arch.cluster_wait()
-        else:
+                # It's faster to have 1 lane per warp to signal the mbar, rather than all lanes
+                # Requires adjusting the thread_count when initializing the mbar
+                cute.arch.sync_warp()
+                lane_idx = cute.arch.lane_idx()
+                if lane_idx < self.cluster_n:
+                    cute.arch.mbarrier_arrive(
+                        mbar_empty_ptr + stage, peer_cta_rank_in_cluster=lane_idx
+                    )
+            dx = (wdy - x_hat * mean_xhat_wdy) * rstd
+            tXrdX.store(dx.to(tXrdOut.element_type))
+            if row < M or tiler_mn[0] == 1:
+                tXgdX_cur = utils.coord_offset_i64(bidx, tXgdX, dim=3)[None, None, None, 0]
+                cute.copy(copy_atom_store_dX, tXrdX, tXgdX_cur, pred=tXpX)
+            tXrdW.store(tXrdW.load() + dout * x_hat)
+            stage ^= 1
+            if stage == 0:
+                consumer_phase ^= 1
+                producer_phase ^= 1
+
+        if cutlass.const_expr(self.cluster_n > 1):  # Prevent cluster from exiting early
+            cute.arch.mbarrier_wait(mbar_empty_ptr + stage, producer_phase)
+
+        if cutlass.const_expr(tiler_mn[0] > 1):
+            # reduction of dw_partial within the same threadblock
+            sdW = cute.make_tensor(
+                cute.recast_ptr(sX.iterator, dtype=cute.Float32),
+                cute.make_ordered_layout(tiler_mn, order=(1, 0)),
+            )
+            tXsdW = thr_copy_X.partition_D(sdW)
             cute.arch.barrier()
-        """
-
-        cute.autovec_copy(dw_accumulator, tDwrDw)
-        cute.copy(copy_atom_dw, tDwrDw, tDwgDw, pred=tDwpDw)
+            row = tXcX[None, None, None, 0][0][0]
+            if row > 0:
+                cute.autovec_copy(tXrdW, tXsdW)
+            cute.arch.barrier()
+            if row == 0:
+                for i in cutlass.range_constexpr(1, cutlass.const_expr(tiler_mn[0])):
+                    tXrdW_other = cute.make_fragment_like(tXrdW)
+                    tXsdW_other = cute.make_tensor(tXsdW.iterator + i * sdW.stride[0], tXsdW.layout)
+                    cute.autovec_copy(tXsdW_other, tXrdW_other)
+                    tXrdW.store(tXrdW.load() + tXrdW_other.load())
+                cute.copy(copy_atom_store_dW, tdWrdW, tdWgdW, pred=tdWpdW)
+        else:
+            cute.copy(copy_atom_store_dW, tdWrdW, tdWgdW, pred=tdWpdW)
 
 
 def _rmsnorm_backward(
@@ -581,8 +642,19 @@ def _rmsnorm_backward(
 
     device = x.device
 
-    sm_count = torch.cuda.get_device_properties(device).multi_processor_count * 8
-    dw_partial = torch.zeros((sm_count, N), device=device, dtype=weight.dtype)
+    # This should be tuned on how many CTAs can be launched on each SM
+    sm_count_multiple = (
+        16 if N <= 256 else (8 if N <= 1024 else (4 if N <= 2048 else (2 if N <= 4096 else 1)))
+    )
+    sm_count = torch.cuda.get_device_properties(device).multi_processor_count
+    # By right, if we're using cluster, this should be cluster_count not sm_count.
+    # But for cluster >= 4, due to quantization we would need to query active max cluster.
+    # Instead we just do sm_count * 2, which is reasonably larger than active_cluster_count to
+    # avoid wave quantization.
+    sm_count = (
+        sm_count * sm_count_multiple if N <= 8192 else sm_count // 2 if N <= 16384 else sm_count * 2
+    )
+    dw_partial = torch.empty(sm_count, N, device=device, dtype=weight.dtype)
 
     dtype = torch2cute_dtype_map[x.dtype]
 
@@ -625,6 +697,7 @@ def _rmsnorm_backward(
         rstd_tensor,
         dx_tensor,
         dw_partial_tensor,
+        sm_count,
         current_stream,
     )
 

{quack_kernels-0.1.6 → quack_kernels-0.1.7}/quack/softmax.py

@@ -133,9 +133,7 @@ class Softmax(ReductionBase):
 
         is_even_N = cutlass.const_expr(shape[1] == tiler_mn[1] * self.cluster_n)
         tXpX = (
-            utils.predicate_k(thr_copy_X.partition_S(cX), limit=shape[1])
-            if cutlass.const_expr(not is_even_N)
-            else None
+            utils.predicate_k(thr_copy_X.partition_S(cX), limit=shape[1]) if not is_even_N else None
         )
         if tXcX[0][0] < shape[0]:
             cute.copy(copy_atom_load_X, tXgX, tXsX, pred=tXpX)

{quack_kernels-0.1.6 → quack_kernels-0.1.7}/quack/utils.py

@@ -120,12 +120,20 @@ def cluster_reduce(
     reduction_buffer: cute.Tensor,
     mbar_ptr: cute.Pointer,
     init_val: cute.Numeric = 0.0,
+    phase: Optional[cutlass.Int32] = None,
 ) -> cute.Numeric:
     """reduction_buffer has shape (num_warps / warps_per_row, (warps_per_row, cluster_n))"""
     cta_rank_in_cluster = cute.arch.block_idx_in_cluster()
     lane_idx, warp_idx = cute.arch.lane_idx(), cute.arch.warp_idx()
-    warps_per_row, cluster_n = reduction_buffer.shape[1]
+    rows_per_block, (warps_per_row, cluster_n) = reduction_buffer.shape
     row_idx, col_idx = warp_idx // warps_per_row, warp_idx % warps_per_row
+    if warp_idx == 0:
+        with cute.arch.elect_one():
+            num_warps = rows_per_block * warps_per_row
+            cute.arch.mbarrier_arrive_and_expect_tx(
+                mbar_ptr,
+                num_warps * cluster_n * reduction_buffer.element_type.width // 8,
+            )
     if lane_idx < cluster_n:
         store_shared_remote(
             val,
@@ -133,7 +141,7 @@ def cluster_reduce(
             mbar_ptr,
             peer_cta_rank_in_cluster=lane_idx,
         )
-    cute.arch.mbarrier_wait(mbar_ptr, phase=0)
+    cute.arch.mbarrier_wait(mbar_ptr, phase=phase if phase is not None else 0)
     block_reduce_val = init_val
     num_iter = cute.ceil_div(warps_per_row * cluster_n, cute.arch.WARP_SIZE)
     for i in cutlass.range_constexpr(num_iter):
@@ -149,13 +157,14 @@ def block_or_cluster_reduce(
     op: Callable,
     reduction_buffer: cute.Tensor,
     mbar_ptr: Optional[cute.Pointer],
+    phase: Optional[cutlass.Int32] = None,
     init_val: cute.Numeric = 0.0,
 ) -> cute.Numeric:
     """Perform either block or cluster reduction based on whether mbar_ptr is provided."""
     if cutlass.const_expr(mbar_ptr is None):
         return block_reduce(val, op, reduction_buffer, init_val=init_val)
     else:
-        return cluster_reduce(val, op, reduction_buffer, mbar_ptr, init_val=init_val)
+        return cluster_reduce(val, op, reduction_buffer, mbar_ptr, phase=phase, init_val=init_val)
 
 
 @cute.jit
@@ -165,6 +174,7 @@ def row_reduce(
     threads_per_row: cutlass.Constexpr[int],
     reduction_buffer: Optional[cute.Tensor] = None,
     mbar_ptr: Optional[cute.Pointer] = None,
+    phase: Optional[cutlass.Int32] = None,
     init_val: cute.Numeric = 0.0,
     hook_fn: Optional[Callable] = None,
 ) -> cute.Numeric:
@@ -193,7 +203,7 @@ def row_reduce(
         ), "mbar_ptr must be provided for cluster reduction"
         if cutlass.const_expr(warps_per_row > 1 or cluster_n > 1):
             val = block_or_cluster_reduce(
-                val, warp_op, reduction_buffer, mbar_ptr, init_val=init_val
+                val, warp_op, reduction_buffer, mbar_ptr, phase=phase, init_val=init_val
             )
     return val
 
@@ -205,6 +215,7 @@ def online_softmax_reduce(
     reduction_buffer: Optional[cute.Tensor] = None,
     mbar_ptr: Optional[cute.Pointer] = None,
     hook_fn: Optional[Callable] = None,
+    phase: Optional[cutlass.Int32] = None,
     return_exp_x: bool = False,
 ) -> [Float32, Float32, Optional[cute.TensorSSA]]:
     assert x.dtype == Float32, "x must be of type Float32"
@@ -225,7 +236,7 @@ def online_softmax_reduce(
     if cutlass.const_expr(hook_fn is not None):
         hook_fn()
     if cutlass.const_expr(reduction_buffer is not None):
-        warps_per_row, cluster_n = reduction_buffer.shape[1]
+        rows_per_block, (warps_per_row, cluster_n) = reduction_buffer.shape
         assert (
             cluster_n == 1 or mbar_ptr is not None
         ), "mbar_ptr must be provided for cluster reduction"
@@ -251,6 +262,13 @@ def online_softmax_reduce(
                 max_x = max_x_final
             else:
                 cta_rank_in_cluster = cute.arch.block_idx_in_cluster()
+                if warp_idx == 0:
+                    with cute.arch.elect_one():
+                        num_warps = rows_per_block * warps_per_row
+                        cute.arch.mbarrier_arrive_and_expect_tx(
+                            mbar_ptr,
+                            num_warps * cluster_n * reduction_buffer.element_type.width // 8,
+                        )
                 if lane_idx < cluster_n:
                     store_shared_remote(
                         f32x2_to_i64(max_x, sum_exp_x),
@@ -258,7 +276,7 @@ def online_softmax_reduce(
                         mbar_ptr,
                         peer_cta_rank_in_cluster=lane_idx,
                     )
-                cute.arch.mbarrier_wait(mbar_ptr, phase=0)
+                cute.arch.mbarrier_wait(mbar_ptr, phase=phase if phase is not None else 0)
                 num_iter = cute.ceil_div(warps_per_row * cluster_n, cute.arch.WARP_SIZE)
                 max_x_single_warp = cute.make_fragment(num_iter, Float32)
                 max_x_single_warp.fill(-Float32.inf)
@@ -351,7 +369,7 @@ def predicate_k(tAcA: cute.Tensor, limit: cutlass.Int32) -> cute.Tensor:
 
 
 @cute.jit
-def fill_oob(tXsX: cute.Tensor, tXpX: cute.Tensor, fill_value: cute.Numeric) -> None:
+def fill_oob(tXsX: cute.Tensor, tXpX: Optional[cute.Tensor], fill_value: cute.Numeric) -> None:
     """Fill out-of-bounds values in shared memory tensor.
 
     Args:
@@ -361,9 +379,12 @@ def fill_oob(tXsX: cute.Tensor, tXpX: cute.Tensor, fill_value: cute.Numeric) ->
     """
     tXrX_fill = cute.make_fragment_like(tXsX[(None, 0), 0, 0])
     tXrX_fill.fill(fill_value)
-    for rest_v in cutlass.range_constexpr(tXpX.shape[0]):
-        for rest_k in cutlass.range_constexpr(tXpX.shape[2]):
-            if not tXpX[rest_v, 0, rest_k]:
+    for rest_v in cutlass.range_constexpr(tXsX.shape[0][1]):
+        for rest_k in cutlass.range_constexpr(tXsX.shape[2]):
+            if cutlass.const_expr(tXpX is not None):
+                if not tXpX[rest_v, 0, rest_k]:
+                    cute.autovec_copy(tXrX_fill, tXsX[(None, rest_v), None, rest_k])
+            else:
                 cute.autovec_copy(tXrX_fill, tXsX[(None, rest_v), None, rest_k])
 
 
@@ -396,6 +417,9 @@ def i64_to_f32x2(c: cutlass.Int64, *, loc=None, ip=None) -> Tuple[Float32, Float
 def domain_offset_i64(coord: cute.Coord, tensor: cute.Tensor, *, loc=None, ip=None) -> cute.Tensor:
     flat_coord_i64 = tuple(cutlass.Int64(c) for c in cute.flatten(coord))
     flat_stride = cute.flatten_to_tuple(tensor.stride)
+    assert len(flat_coord_i64) == len(
+        flat_stride
+    ), "Coordinate and stride must have the same length"
     offset = sum(c * s for c, s in zip(flat_coord_i64, flat_stride))
     assert isinstance(tensor.iterator, cute.Pointer)
     # HACK: we assume that applying the offset does not change the pointer alignment
@@ -406,3 +430,19 @@ def domain_offset_i64(coord: cute.Coord, tensor: cute.Tensor, *, loc=None, ip=No
         assumed_align=tensor.iterator.max_alignment,
     )
     return cute.make_tensor(new_ptr, tensor.layout)
+
+
+@dsl_user_op
+def coord_offset_i64(
+    idx: cute.typing.Int, tensor: cute.Tensor, dim: int, *, loc=None, ip=None
+) -> cute.Tensor:
+    offset = cutlass.Int64(idx) * cute.size(tensor.stride[dim])
+    assert isinstance(tensor.iterator, cute.Pointer)
+    # HACK: we assume that applying the offset does not change the pointer alignment
+    new_ptr = cute.make_ptr(
+        tensor.element_type,
+        tensor.iterator.toint() + offset * tensor.element_type.width // 8,
+        tensor.memspace,
+        assumed_align=tensor.iterator.max_alignment,
+    )
+    return cute.make_tensor(new_ptr, tensor.layout)

{quack_kernels-0.1.6 → quack_kernels-0.1.7/quack_kernels.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: quack-kernels
-Version: 0.1.6
+Version: 0.1.7
 Requires-Python: >=3.9
 License-File: LICENSE
 Requires-Dist: nvidia-cutlass-dsl==4.1.0.dev0

{quack_kernels-0.1.6 → quack_kernels-0.1.7}/tests/test_rmsnorm.py

@@ -9,20 +9,22 @@ from quack.rmsnorm import rmsnorm, rmsnorm_ref, rstd_ref
 @pytest.mark.parametrize("eps", [1e-5, 1e-6])
 # @pytest.mark.parametrize("eps", [1e-5])
 @pytest.mark.parametrize("input_dtype", [torch.bfloat16, torch.float16, torch.float32])
-# @pytest.mark.parametrize("input_dtype", [torch.bfloat16])
+# @pytest.mark.parametrize("input_dtype", [torch.float16])
 @pytest.mark.parametrize(
     "N",
     [192, 256, 512, 760, 1024, 1128, 2048, 4096, 8192, 16384, 32768, 65536, 131072, 262144]
-    # [192]
+    # [262144]
 )
-@pytest.mark.parametrize("M", [1, 37, 199])
+@pytest.mark.parametrize("M", [1, 37, 199, 8 * 1024])
 # @pytest.mark.parametrize("M", [1])
-def test_rmsnorm_forward(M, N, input_dtype, eps):
+def test_rmsnorm_forward_backward(M, N, input_dtype, eps):
     """Test RMSNorm forward pass against reference implementation."""
+    if N >= 256 * 1024 and input_dtype == torch.float32 and M >= 8 * 1024:
+        pytest.skip("Skipping large tensor test for float32 to avoid OOM")
     device = "cuda"
     # Set tolerance based on dtype
     if input_dtype == torch.bfloat16:
-        atol = 5e-2
+        atol = 1e-1
     elif input_dtype == torch.float16:
         atol = 1e-2
     else:
@@ -35,55 +37,20 @@ def test_rmsnorm_forward(M, N, input_dtype, eps):
     out = rmsnorm(x, weight, eps=eps)
     out_ref = rmsnorm_ref(x_ref, weight_ref, eps=eps)
     # rstd_ref_val = rstd_ref(x_ref, eps=eps)
-
-    # Check output shape and dtype
     assert out.shape == x.shape
     assert out.dtype == input_dtype
-
-    # Check accuracy
     torch.testing.assert_close(out, out_ref, atol=atol, rtol=1e-3)
     # torch.testing.assert_close(rstd, rstd_ref_val, atol=atol, rtol=1e-3)
-
-
-# @pytest.mark.parametrize("eps", [1e-5, 1e-6])
-# @pytest.mark.parametrize("input_dtype", [torch.float16, torch.bfloat16, torch.float32])
-# @pytest.mark.parametrize("N", [1024, 4096, 16384])
-# def test_rmsnorm_backward(N, input_dtype, eps):
-#     """Test RMSNorm backward pass against reference implementation."""
-#     device = "cuda"
-#     M = 32
-
-#     # Set tolerance based on dtype
-#     if input_dtype == torch.bfloat16:
-#         atol = 5e-2
-#     elif input_dtype == torch.float16:
-#         atol = 1e-2
-#     else:
-#         atol = 1e-4
-
-#     # Set seed for reproducibility
-#     torch.random.manual_seed(0)
-
-#     # Create input tensors
-#     x = torch.randn(M, N, device=device, dtype=input_dtype, requires_grad=True)
-#     weight = torch.randn(N, device=device, dtype=torch.float32, requires_grad=True)
-
-#     # Clone for reference
-#     x_ref = x.detach().clone().requires_grad_()
-#     weight_ref = weight.detach().clone().requires_grad_()
-
-#     # Forward pass
-#     out = rmsnorm(x, weight, eps=eps)
-#     out_ref = rmsnorm_ref(x_ref, weight_ref, eps=eps)
-
-#     # Backward pass
-#     grad_out = torch.randn_like(out)
-#     out.backward(grad_out)
-#     out_ref.backward(grad_out)
-
-#     # Check gradients
-#     torch.testing.assert_close(x.grad, x_ref.grad, atol=atol, rtol=1e-3)
-#     torch.testing.assert_close(weight.grad, weight_ref.grad, atol=atol, rtol=1e-3)
+    # Backward pass
+    if N > 128 * 1024 and input_dtype == torch.float32:
+        # Skip backward pass for due to not enough smem
+        return
+    grad_out = torch.randn_like(out)
+    torch.cuda.synchronize()
+    out_ref.backward(grad_out)
+    out.backward(grad_out)
+    torch.testing.assert_close(x.grad, x_ref.grad, atol=atol, rtol=1e-3)
+    torch.testing.assert_close(weight.grad, weight_ref.grad, atol=atol, rtol=1e-3)
 
 
 @pytest.mark.parametrize("eps", [1e-5])