qontract-reconcile 0.10.2.dev50__tar.gz → 0.10.2.dev51__tar.gz

{qontract_reconcile-0.10.2.dev50 → qontract_reconcile-0.10.2.dev51}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: qontract-reconcile
-Version: 0.10.2.dev50
+Version: 0.10.2.dev51
 Summary: Collection of tools to reconcile services with their desired state as defined in the app-interface DB.
 Project-URL: homepage, https://github.com/app-sre/qontract-reconcile
 Project-URL: repository, https://github.com/app-sre/qontract-reconcile

{qontract_reconcile-0.10.2.dev50 → qontract_reconcile-0.10.2.dev51}/pyproject.toml

@@ -379,10 +379,6 @@ module = [
     "reconcile.utils.vault",
     "reconcile.utils.vaultsecretref",
     "reconcile.vpc_peerings_validator",
-    "tools.app_interface_reporter",
-    "tools.cli_commands.gpg_encrypt",
-    "tools.cli_commands.test.test_gpg_encrypt",
-    "tools.qontract_cli",
     "tools.sre_checkpoints.util",
     # untyped tests
     "reconcile.test.cna.test_integration",
@@ -522,9 +518,6 @@ module = [
     "reconcile.test.utils.test_terrascript_aws_client",
     "reconcile.test.utils.test_terrascript_cloudflare_client",
     "reconcile.test.utils.test_terrascript_cloudflare_resources",
-    "tools.test.test_qontract_cli",
-    "tools.test.test_sd_app_sre_alert_report",
-    "tools.test.test_sre_checkpoints",
 ]
 check_untyped_defs = false
 disallow_untyped_defs = false

{qontract_reconcile-0.10.2.dev50 → qontract_reconcile-0.10.2.dev51}/reconcile/utils/output.py

@@ -1,9 +1,6 @@
 import json
 import re
-from collections.abc import (
-    Iterable,
-    Mapping,
-)
+from collections.abc import Iterable, Mapping
 
 import yaml
 from tabulate import tabulate
@@ -11,11 +8,11 @@ from tabulate import tabulate
 
 def print_output(
     options: Mapping[str, str | bool],
-    content: list[dict],
+    content: Iterable[dict],
     columns: Iterable[str] = (),
 ) -> str | None:
     if options["sort"]:
-        content.sort(key=lambda c: tuple(c.values()))
+        content = sorted(content, key=lambda c: tuple(c.values()))
     if options.get("to_string"):
         for c in content:
             for k, v in c.items():

{qontract_reconcile-0.10.2.dev50 → qontract_reconcile-0.10.2.dev51}/tools/app_interface_reporter.py

@@ -2,6 +2,7 @@ import contextlib
 import logging
 import os
 import textwrap
+from collections.abc import Mapping, MutableMapping
 from datetime import (
     UTC,
     datetime,
@@ -38,50 +39,14 @@ DASHDOTDB_SECRET = os.environ.get(
 )
 
 
-def promql(url, query, auth=None):
-    """
-    Run an instant-query on the prometheus instance.
-
-    The returned structure is documented here:
-    https://prometheus.io/docs/prometheus/latest/querying/api/#instant-queries
-
-    :param url: base prometheus url (not the API endpoint).
-    :type url: string
-    :param query: this is a second value
-    :type query: string
-    :param auth: auth object
-    :type auth: requests.auth
-    :return: structure with the metrics
-    :rtype: dictionary
-    """
-
-    url = os.path.join(url, "api/v1/query")
-
-    if auth is None:
-        auth = {}
-
-    params = {"query": query}
-
-    response = requests.get(url, params=params, auth=auth, timeout=60)
-
-    response.raise_for_status()
-    response = response.json()
-
-    # TODO ensure len response == 1
-    return response["data"]["result"]
-
-
 class Report:
-    def __init__(self, app, date):
+    def __init__(self, app: Mapping, date: datetime) -> None:
         settings = queries.get_app_interface_settings()
         self.secret_reader = SecretReader(settings=settings)
-        # standard date format
-        if hasattr(date, "strftime"):
-            date = date.strftime("%Y-%m-%d")
-
         self.app = app
-        self.date = date
-        self.report_sections = {}
+        # standard date format
+        self.date = date.strftime("%Y-%m-%d")
+        self.report_sections: dict = {}
 
         # promotions
         self.add_report_section("promotions", self.app.get("promotions"))
@@ -108,10 +73,10 @@ class Report:
         )
 
     @property
-    def path(self):
-        return "data/reports/{}/{}.yml".format(self.app["name"], self.date)
+    def path(self) -> str:
+        return f"data/reports/{self.app['name']}/{self.date}.yml"
 
-    def content(self):
+    def content(self) -> dict:
         return {
             "$schema": "/app-sre/report-1.yml",
             "labels": {"app": self.app["name"]},
@@ -122,21 +87,20 @@ class Report:
             "content": yaml.safe_dump(self.report_sections, sort_keys=False),
         }
 
-    def to_yaml(self):
+    def to_yaml(self) -> str:
         return yaml.safe_dump(self.content(), sort_keys=False)
 
-    def to_message(self):
+    def to_message(self) -> dict:
         return {"file_path": self.path, "content": self.to_yaml()}
 
-    def add_report_section(self, header, content):
-        if not content:
-            content = None
-
-        self.report_sections[header] = content
+    def add_report_section(self, header: str, content: list[dict] | None) -> None:
+        self.report_sections[header] = content or None
 
     @staticmethod
-    def get_vulnerability_content(container_vulnerabilities):
-        parsed_metrics = []
+    def get_vulnerability_content(
+        container_vulnerabilities: Mapping | None,
+    ) -> list[dict]:
+        parsed_metrics: list[dict] = []
         if not container_vulnerabilities:
             return parsed_metrics
 
@@ -150,8 +114,8 @@ class Report:
         return parsed_metrics
 
     @staticmethod
-    def get_post_deploy_jobs_content(post_deploy_jobs):
-        results = []
+    def get_post_deploy_jobs_content(post_deploy_jobs: Mapping | None) -> list[dict]:
+        results: list[dict] = []
         if not post_deploy_jobs:
             return results
 
@@ -165,8 +129,8 @@ class Report:
         return results
 
     @staticmethod
-    def get_validations_content(deployment_validations):
-        parsed_metrics = []
+    def get_validations_content(deployment_validations: Mapping | None) -> list[dict]:
+        parsed_metrics: list[dict] = []
         if not deployment_validations:
             return parsed_metrics
 
@@ -180,8 +144,8 @@ class Report:
         return parsed_metrics
 
     @staticmethod
-    def get_slo_content(service_slo):
-        parsed_metrics = []
+    def get_slo_content(service_slo: Mapping | None) -> list[dict]:
+        parsed_metrics: list[dict] = []
         if not service_slo:
             return parsed_metrics
 
@@ -200,7 +164,7 @@ class Report:
         return parsed_metrics
 
     @staticmethod
-    def get_activity_content(activity):
+    def get_activity_content(activity: Mapping) -> list[dict]:
         if not activity:
             return []
 
@@ -214,7 +178,9 @@ class Report:
         ]
 
 
-def get_apps_data(date, month_delta=1, thread_pool_size=10):
+def get_apps_data(
+    date: datetime, month_delta: int = 1, thread_pool_size: int = 10
+) -> list[dict]:
     settings = queries.get_app_interface_settings()
     secret_reader = SecretReader(settings)
 
@@ -297,9 +263,9 @@ def get_apps_data(date, month_delta=1, thread_pool_size=10):
             if namespace["app"]["name"] != app["name"]:
                 continue
             app_namespaces.append(namespace)
-        vuln_mx = {}
-        validt_mx = {}
-        slo_mx = {}
+        vuln_mx: dict = {}
+        validt_mx: dict = {}
+        slo_mx: dict = {}
         for family in text_string_to_metric_families(vuln_metrics):
             for sample in family.samples:
                 if sample.name == "imagemanifestvuln_total":
@@ -375,7 +341,7 @@ def get_apps_data(date, month_delta=1, thread_pool_size=10):
     return apps
 
 
-def get_build_history(job):
+def get_build_history(job: MutableMapping) -> MutableMapping:
     try:
         logging.info(f"getting build history for {job['name']}")
         job["build_history"] = job["jenkins"].get_build_history(
@@ -386,7 +352,9 @@ def get_build_history(job):
     return job
 
 
-def get_build_history_pool(jenkins_map, jobs, timestamp_limit, thread_pool_size):
+def get_build_history_pool(
+    jenkins_map: Mapping, jobs: Mapping, timestamp_limit: int, thread_pool_size: int
+) -> dict:
     history_to_get = []
     for instance, _jobs in jobs.items():
         jenkins = jenkins_map[instance]
@@ -411,7 +379,7 @@ def get_build_history_pool(jenkins_map, jobs, timestamp_limit, thread_pool_size)
     return history
 
 
-def get_repo_url(job):
+def get_repo_url(job: Mapping) -> str:
     repo_url_raw = job["properties"][0]["github"]["url"]
     return repo_url_raw.strip("/").replace(".git", "")
 
@@ -424,8 +392,13 @@ def get_repo_url(job):
 @gitlab_project_id
 @click.option("--reports-path", help="path to write reports")
 def main(
-    configfile, dry_run, log_level, gitlab_project_id, reports_path, thread_pool_size
-):
+    configfile: str,
+    dry_run: bool,
+    log_level: str,
+    gitlab_project_id: str,
+    reports_path: str,
+    thread_pool_size: int,
+) -> None:
     init_env(log_level=log_level, config_file=configfile)
 
     now = datetime.now()
@@ -476,8 +449,9 @@ def main(
             gitlab_project_id=gitlab_project_id, sqs_or_gitlab="gitlab"
         ) as mr_cli:
             result = mr.submit(cli=mr_cli)
-        logging.info(["created_mr", result.web_url])
+        if result:
+            logging.info(["created_mr", result.web_url])
 
 
 if __name__ == "__main__":
-    main()  # pylint: disable=no-value-for-parameter
+    main()

{qontract_reconcile-0.10.2.dev50 → qontract_reconcile-0.10.2.dev51}/tools/cli_commands/gpg_encrypt.py

@@ -132,7 +132,7 @@ class GPGEncryptCommand:
 
         return user["public_gpg_key"]
 
-    def _output(self, content: str):
+    def _output(self, content: str) -> None:
         output = self._command_data.output
         if not output:
             print(content)
@@ -140,7 +140,7 @@ class GPGEncryptCommand:
         with open(output, "w", encoding="locale") as f:
             f.write(content)
 
-    def execute(self):
+    def execute(self) -> None:
         secret = self._fetch_secret()
         gpg_key = self._get_gpg_key()
         encrypted_content = gpg.gpg_encrypt(