qodev-apollo-api 0.2.0__tar.gz → 0.2.2__tar.gz

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.1] - 2026-07-01
+
+### Fixed
+- `normalize_linkedin_url()` normalized to `https://` and never added `www`, but Apollo stores and **exact-matches** LinkedIn URLs as `http://www.linkedin.com/in/<slug>`. As a result `find_contact_by_linkedin_url()`'s URL tier always missed (silently falling through to name search), and any `search_contacts(linkedin_url=...)` filter built from it returned zero. It now produces Apollo's `http://www` form, so URL lookups actually match.
+
 ## [0.2.0] - 2026-06-02
 
 ### Fixed

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: qodev-apollo-api
-Version: 0.2.0
+Version: 0.2.2
 Summary: Async Python client for Apollo.io CRM API
 Project-URL: Homepage, https://github.com/qodevai/apollo-api
 Project-URL: Repository, https://github.com/qodevai/apollo-api

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "qodev-apollo-api"
-version = "0.2.0"
+version = "0.2.2"
 description = "Async Python client for Apollo.io CRM API"
 readme = "README.md"
 authors = [

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/src/qodev_apollo_api/__init__.py

@@ -151,4 +151,4 @@ __all__ = [
     "resolve_task",
 ]
 
-__version__ = "0.2.0"
+__version__ = "0.2.2"

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/src/qodev_apollo_api/client.py

@@ -3,12 +3,14 @@
 Type-safe async wrapper for Apollo.io API.
 """
 
+import logging
 import os
 from datetime import datetime
 from types import TracebackType
 from typing import Any
 
 import httpx
+from pydantic import ValidationError
 
 from .exceptions import APIError, AuthenticationError, RateLimitError
 from .models import (
@@ -40,6 +42,8 @@ from .models import (
 )
 from .utils import markdown_to_prosemirror, normalize_linkedin_url, prosemirror_to_markdown
 
+logger = logging.getLogger(__name__)
+
 
 class ApolloClient:
     """Async Apollo.io API client with context manager support."""
@@ -709,7 +713,14 @@ class ApolloClient:
             data["multi_sort"] = [{field: {"order": order}} for field, order in sort]
         result = await self._post("/tasks/search", data)
 
-        tasks = [resolve_task(t) for t in result.get("tasks", [])]
+        tasks: list[Task] = []
+        for raw in result.get("tasks", []):
+            try:
+                tasks.append(resolve_task(raw))
+            except ValidationError:
+                # A single structurally-invalid row (e.g. missing id) must not sink the whole
+                # page — skip it so the rest of the results stay usable.
+                logger.warning("Skipping unparseable task id=%s", raw.get("id"), exc_info=True)
         pagination = result.get("pagination", {})
 
         return PaginatedResponse[Task](

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/src/qodev_apollo_api/models.py

@@ -823,8 +823,14 @@ class BaseTask(ApolloModel):
     title: str | None = None
     subject: str | None = None
     type: TaskType | None = None
-    priority: TaskPriority | None = None
-    status: TaskStatus | None = None
+    # Kept as raw strings, not the TaskStatus/TaskPriority enums: Apollo returns values the
+    # library doesn't model (status: skipped/archived/…; priority occasionally outside
+    # high/medium/low). A strict enum here broke deserialization — a task with e.g.
+    # status="skipped" failed the discriminated union AND resolve_task's OtherTask fallback
+    # (which inherits these fields), so a single such row raised for the *whole* search page.
+    # Compare against TaskStatus.* / TaskPriority.* — StrEnum equality still holds.
+    priority: str | None = None
+    status: str | None = None
     due_at: datetime | None = None
     note: str | None = None
     answered: bool | None = None

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/src/qodev_apollo_api/utils.py

@@ -167,20 +167,25 @@ def markdown_to_prosemirror(content: str, title: str | None = None) -> str:
 
 
 def normalize_linkedin_url(url: str) -> str:
-    """Normalize LinkedIn URL for comparison.
+    """Normalize a LinkedIn URL to Apollo's stored, exact-match form.
+
+    Apollo stores and exact-matches LinkedIn URLs as ``http://www.linkedin.com/in/<slug>``
+    — **http** scheme (not https), ``www`` host, no trailing slash, lowercase. Producing
+    that exact form is what lets a ``linkedin_url`` search actually match; a ``https://``
+    or ``www``-less form silently returns zero results. It also doubles as a stable key for
+    comparing two URLs.
 
     Args:
-        url: LinkedIn profile URL
+        url: LinkedIn profile URL (any common shape).
 
     Returns:
-        Normalized URL (lowercase, stripped, trailing slash removed)
+        The URL as ``http://www.linkedin.com/...`` (or ``""`` for a falsy input).
     """
     if not url:
         return ""
     url = url.lower().strip().rstrip("/")
-    # Normalize scheme to https://
-    if url.startswith("http://"):
-        url = "https://" + url[7:]
-    elif not url.startswith("https://"):
-        url = f"https://{url}"
-    return url
+    # Rebuild to Apollo's stored form: strip the scheme, force the www host, force http.
+    url = re.sub(r"^https?://", "", url)
+    if url.startswith("linkedin.com/"):
+        url = "www." + url
+    return f"http://{url}"

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/tests/test_client.py

@@ -305,6 +305,38 @@ async def test_search_tasks(client: ApolloClient):
     assert client._client.request.call_args[0] == ("POST", "/tasks/search")
 
 
+async def test_search_tasks_returns_task_with_unmodelled_status(client: ApolloClient):
+    """Regression: a task whose status Apollo returns but the library doesn't model
+    (skipped/archived/…) is returned with the raw status — not dropped, not raised. This
+    is what broke the LinkedIn connect batch: a single skipped task sank the whole page."""
+    client._client.request.return_value = _make_response(
+        {
+            "tasks": [{"id": "t1", "type": "linkedin_step_connect", "status": "skipped"}],
+            "pagination": {"total_entries": 1},
+        }
+    )
+
+    result = await client.search_tasks()
+
+    assert len(result.items) == 1
+    assert result.items[0].status == "skipped"
+
+
+async def test_search_tasks_skips_unparseable_row(client: ApolloClient):
+    """A structurally-invalid row (missing id) is skipped, not fatal — the rest of the page
+    is still returned."""
+    client._client.request.return_value = _make_response(
+        {
+            "tasks": [{"type": "call"}, {"id": "t2", "type": "call"}],
+            "pagination": {"total_entries": 2},
+        }
+    )
+
+    result = await client.search_tasks()
+
+    assert [t.id for t in result.items] == ["t2"]
+
+
 async def test_search_tasks_with_sort(client: ApolloClient):
     """Test search_tasks with sort parameter generates multi_sort payload."""
     client._client.request.return_value = _make_response(

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/tests/test_models.py

@@ -60,6 +60,7 @@ from qodev_apollo_api.models import (
     PhoneEntry,
     Pipeline,
     Stage,
+    TaskStatus,
     TaskType,
     Technology,
     TranscriptSegment,
@@ -890,6 +891,22 @@ def test_resolve_task_unknown_type_falls_back_to_other_task():
     assert result.id == "1"
 
 
+def test_resolve_task_preserves_unmodelled_status():
+    """A status Apollo returns but the library doesn't model (skipped/archived/…) must
+    deserialize as the raw string rather than raise — otherwise a single such task sinks a
+    whole tasks/search page (it fails the union AND the OtherTask fallback)."""
+    result = resolve_task({"id": "1", "type": "linkedin_step_connect", "status": "skipped"})
+    assert result.status == "skipped"
+    # comparison against the known-value enum still works via StrEnum equality
+    assert result.status != TaskStatus.SCHEDULED
+
+
+def test_resolve_task_preserves_unmodelled_priority():
+    """Same guarantee for priority (values outside high/medium/low)."""
+    result = resolve_task({"id": "1", "type": "linkedin_step_connect", "priority": "none"})
+    assert result.priority == "none"
+
+
 def test_task_with_full_emailer_message():
     """Test EmailTask with complete emailer_message including scheduling fields."""
     task = EmailTask.model_validate(

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/tests/test_utils.py

@@ -82,32 +82,38 @@ def test_prosemirror_empty_doc():
 
 
 def test_normalize_linkedin_url():
-    """Test LinkedIn URL normalization."""
-    # Test basic normalization
+    """Normalizes to Apollo's stored, exact-match form: http://www.linkedin.com/..."""
+    # https is rewritten to Apollo's http, and www is added
     assert (
         normalize_linkedin_url("https://linkedin.com/in/johndoe")
-        == "https://linkedin.com/in/johndoe"
+        == "http://www.linkedin.com/in/johndoe"
     )
 
-    # Test lowercase conversion
+    # Lowercase conversion
     assert (
         normalize_linkedin_url("HTTPS://LinkedIn.com/in/JohnDoe")
-        == "https://linkedin.com/in/johndoe"
+        == "http://www.linkedin.com/in/johndoe"
     )
 
-    # Test trailing slash removal
+    # Trailing slash removal
     assert (
         normalize_linkedin_url("https://linkedin.com/in/johndoe/")
-        == "https://linkedin.com/in/johndoe"
+        == "http://www.linkedin.com/in/johndoe"
     )
 
-    # Test protocol addition
-    assert normalize_linkedin_url("linkedin.com/in/johndoe") == "https://linkedin.com/in/johndoe"
+    # Protocol addition
+    assert normalize_linkedin_url("linkedin.com/in/johndoe") == "http://www.linkedin.com/in/johndoe"
 
-    # Test whitespace handling
+    # An already-www URL keeps a single www (no www.www)
+    assert (
+        normalize_linkedin_url("https://www.linkedin.com/in/johndoe")
+        == "http://www.linkedin.com/in/johndoe"
+    )
+
+    # Whitespace handling
     assert (
         normalize_linkedin_url("  https://linkedin.com/in/johndoe  ")
-        == "https://linkedin.com/in/johndoe"
+        == "http://www.linkedin.com/in/johndoe"
     )
 
 

{qodev_apollo_api-0.2.0 → qodev_apollo_api-0.2.2}/uv.lock

@@ -407,7 +407,7 @@ wheels = [
 
 [[package]]
 name = "qodev-apollo-api"
-version = "0.1.3"
+version = "0.2.2"
 source = { editable = "." }
 dependencies = [
     { name = "httpx" },