pywebview-htmx 0.4.0__tar.gz → 0.4.1__tar.gz

{pywebview_htmx-0.4.0 → pywebview_htmx-0.4.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: pywebview-htmx
-Version: 0.4.0
+Version: 0.4.1
 Summary: HTMX-style declarative UI bindings for PyWebview apps
 Author-Email: "B.T. Franklin" <brandon.franklin@gmail.com>
 License: MIT License
@@ -319,6 +319,10 @@ newer request had already been issued in the same request scope when the error
 was emitted. Errors from stale requests remain observable even though stale
 successful responses do not update the DOM.
 
+`event.detail.element` identifies the original control. If that control has
+been removed, the runtime dispatches the error on `document.body` so application
+listeners can still receive it.
+
 Example:
 
 ```js

{pywebview_htmx-0.4.0 → pywebview_htmx-0.4.1}/README.md

@@ -279,6 +279,10 @@ newer request had already been issued in the same request scope when the error
 was emitted. Errors from stale requests remain observable even though stale
 successful responses do not update the DOM.
 
+`event.detail.element` identifies the original control. If that control has
+been removed, the runtime dispatches the error on `document.body` so application
+listeners can still receive it.
+
 Example:
 
 ```js

{pywebview_htmx-0.4.0 → pywebview_htmx-0.4.1}/pyproject.toml

@@ -21,7 +21,7 @@ classifiers = [
     "Topic :: Software Development :: Libraries :: Python Modules",
     "Topic :: Internet :: WWW/HTTP",
 ]
-version = "0.4.0"
+version = "0.4.1"
 
 [project.license]
 file = "LICENSE"

{pywebview_htmx-0.4.0 → pywebview_htmx-0.4.1}/src/pywebview_htmx/static/runtime.js

@@ -10,6 +10,7 @@
   const selfRequestState = new WeakMap();
   const targetedRequestState = new Map();
   const waitState = new WeakMap();
+  const boundElements = new WeakSet();
 
   function $(selector, root = document) {
     if (!selector) return null;
@@ -206,10 +207,9 @@
     elements.push(...root.querySelectorAll("[py-call]"));
 
     elements.forEach((element) => {
-      if (element.getAttribute("data-pywebview-bound") === "true") {
+      if (boundElements.has(element)) {
         return;
       }
-      element.setAttribute("data-pywebview-bound", "true");
 
       const functionName = element.getAttribute("py-call");
       const eventName = element.getAttribute("py-trigger") || "click";
@@ -219,6 +219,7 @@
         console.warn("PyWebview HTMX: py-call is empty", element);
         return;
       }
+      boundElements.add(element);
 
       element.addEventListener(eventName, async (event) => {
         if (shouldPreventDefault(element, eventName) && event.cancelable) {
@@ -257,7 +258,7 @@
             throw new Error("PyWebview HTMX: Python API methods must return an HTML string");
           }
 
-          const target = targetSelector ? $(targetSelector) : element;
+          let target = targetSelector ? $(targetSelector) : element;
           if (!target) {
             console.warn("PyWebview HTMX: target element not found", targetSelector);
             return;
@@ -271,6 +272,12 @@
             return;
           }
 
+          target = targetSelector ? $(targetSelector) : element;
+          if (!target || !target.isConnected) {
+            console.warn("PyWebview HTMX: target element not found", targetSelector);
+            return;
+          }
+
           const processRoot = pySwap(target, response, swapStyle);
           const afterSwapTarget =
             swapStyle === "outerHTML"
@@ -284,7 +291,9 @@
           }
         } catch (error) {
           console.error("PyWebview HTMX: error calling Python function", error);
-          triggerEvent(element, "py:error", {
+          const errorTarget = element.isConnected ? element : document.body || document;
+          triggerEvent(errorTarget, "py:error", {
+            element,
             error,
             requestId,
             stale: requestId !== state.lastIssued,

{pywebview_htmx-0.4.0 → pywebview_htmx-0.4.1}/tests/conftest.py

@@ -1,7 +1,5 @@
 from __future__ import annotations
 
-import re
-
 import pytest
 
 from pywebview_htmx import get_runtime_script
@@ -10,8 +8,3 @@ from pywebview_htmx import get_runtime_script
 @pytest.fixture(scope="session")
 def js_source() -> str:
     return get_runtime_script()
-
-
-@pytest.fixture(scope="session")
-def js_compact(js_source: str) -> str:
-    return re.sub(r"\s+", " ", js_source).strip()

{pywebview_htmx-0.4.0 → pywebview_htmx-0.4.1}/tests/test_js_runtime.py

@@ -640,3 +640,135 @@ def test_invalid_params_and_selectors_degrade_safely(
     assert not page.locator("#invalid-wait").evaluate(
         "node => node.classList.contains('py-waiting')"
     )
+
+
+@pytest.mark.parametrize("remove_target", [False, True], ids=["replace", "remove"])
+def test_target_is_resolved_again_after_swap_delay(
+    runtime_browser: RuntimeBrowser, js_source: str, remove_target: bool,
+) -> None:
+    runtime_browser.load(
+        '<button id="load" py-call="load" py-target="#result">Load</button>'
+        '<div id="result">original</div>',
+        js_source,
+    )
+    page = runtime_browser.page
+    install_pending_bridge(page)
+    runtime_browser.process()
+    page.evaluate(
+        """() => {
+          const originalTimeout = window.setTimeout;
+          window.setTimeout = (callback, ms, ...args) => {
+            if (ms === 1234) {
+              window.finishSwapDelay = callback;
+              return 0;
+            }
+            return originalTimeout(callback, ms, ...args);
+          };
+          pywebviewHtmx.config.swapDelay = 1234;
+          window.oldTarget = document.querySelector('#result');
+          window.afterSwaps = 0;
+          document.body.addEventListener('py:afterSwap', () => afterSwaps++);
+        }"""
+    )
+    page.locator("#load").click()
+    resolve_request(page, 0, "response")
+    page.wait_for_function("typeof window.finishSwapDelay === 'function'")
+    page.evaluate(
+        """remove => {
+          if (remove) oldTarget.remove();
+          else oldTarget.outerHTML = '<div id="result">replacement</div>';
+          finishSwapDelay();
+        }""",
+        remove_target,
+    )
+    page.wait_for_function(
+        "!document.querySelector('#load').classList.contains('py-waiting')"
+    )
+    assert page.evaluate("oldTarget.textContent") == "original"
+    assert page.evaluate("afterSwaps") == (0 if remove_target else 1)
+    if not remove_target:
+        assert page.locator("#result").inner_text() == "response"
+
+
+def test_detached_control_error_reaches_body_listener(
+    runtime_browser: RuntimeBrowser, js_source: str,
+) -> None:
+    runtime_browser.load(
+        '<section id="host"><button id="load" py-call="load" '
+        'py-target="#host" py-swap="outerHTML">Load</button></section>',
+        js_source,
+    )
+    page = runtime_browser.page
+    install_pending_bridge(page)
+    runtime_browser.process()
+    page.evaluate(
+        """() => {
+          window.originalControl = document.querySelector('#load');
+          window.errors = [];
+          document.body.addEventListener('py:error', event => errors.push({
+            stale: event.detail.stale,
+            original: event.detail.element === originalControl,
+            message: event.detail.error.message,
+          }));
+        }"""
+    )
+    page.locator("#load").click()
+    page.locator("#load").click()
+    resolve_request(page, 1, '<section id="host">replaced</section>')
+    page.locator("#host").get_by_text("replaced").wait_for()
+    runtime_browser.expect_console_error("older failure")
+    reject_request(page, 0, "older failure")
+    page.wait_for_function("errors.length === 1")
+    assert page.evaluate("errors") == [
+        {"stale": True, "original": True, "message": "older failure"}
+    ]
+    assert page.evaluate("originalControl.classList.contains('py-waiting')") is False
+
+
+def test_cloned_controls_bind_once_when_processed_repeatedly(
+    runtime_browser: RuntimeBrowser, js_source: str,
+) -> None:
+    runtime_browser.load(
+        '<button id="load" py-call="load" py-target="#result">Load</button>'
+        '<div id="result"></div>',
+        js_source,
+    )
+    page = runtime_browser.page
+    install_pending_bridge(page)
+    runtime_browser.process()
+    page.evaluate(
+        """() => {
+          const clone = document.querySelector('#load').cloneNode(true);
+          clone.id = 'clone';
+          document.body.append(clone);
+          pywebviewHtmx.process(clone);
+          pywebviewHtmx.process(document.body);
+          pywebviewHtmx.process(document.body);
+        }"""
+    )
+    page.locator("#clone").click()
+    assert page.evaluate("bridgeCalls.length") == 1
+    resolve_request(page, 0, "cloned")
+    page.locator("#result").get_by_text("cloned").wait_for()
+    page.locator("#load").click()
+    assert page.evaluate("bridgeCalls.length") == 2
+    resolve_request(page, 1, "original")
+    page.locator("#result").get_by_text("original").wait_for()
+
+
+def test_injected_runtime_binds_controls_on_document_load(
+    runtime_browser: RuntimeBrowser,
+) -> None:
+    from pywebview_htmx import inject_runtime
+
+    page = runtime_browser.page
+    page.set_content(inject_runtime(
+        '<!doctype html><html><body>'
+        '<button id="load" py-call="load" py-target="#result">Load</button>'
+        '<div id="result"></div></body></html>'
+    ))
+    install_pending_bridge(page)
+    page.locator("#load").click()
+    assert page.evaluate("bridgeCalls") == [{}]
+    resolve_request(page, 0, "ready")
+    page.locator("#result").get_by_text("ready").wait_for()

pywebview_htmx-0.4.1/tests/test_repo_legibility.py

@@ -0,0 +1,125 @@
+from __future__ import annotations
+
+import re
+import subprocess
+import tomllib
+import zipfile
+from pathlib import Path
+
+
+REPO_ROOT = Path(__file__).resolve().parents[1]
+REQUIRED_DOCS = [
+    "AGENTS.md",
+    "docs/index.md",
+    "docs/architecture.md",
+    "docs/development.md",
+    "docs/releasing.md",
+]
+AGENT_REQUIRED_LINK_TARGETS = {
+    "README.md",
+    "docs/index.md",
+    "src/pywebview_htmx/runtime.py",
+    "src/pywebview_htmx/static/runtime.js",
+    "app.py",
+    "pyproject.toml",
+    "docs/releasing.md",
+    "tests",
+    "skills/use-pywebview-htmx",
+}
+REQUIRED_WHEEL_FILES = {
+    "pywebview_htmx/__init__.py",
+    "pywebview_htmx/py.typed",
+    "pywebview_htmx/runtime.py",
+    "pywebview_htmx/static/runtime.js",
+    "pywebview_htmx/static/themes/aurora.css",
+    "pywebview_htmx/static/themes/base.css",
+    "pywebview_htmx/static/themes/cybermind.css",
+    "pywebview_htmx/static/themes/paper.css",
+}
+LOCAL_MARKDOWN_LINK_RE = re.compile(r"(?<!!)\[[^\]]+\]\(([^)]+)\)")
+
+
+def _iter_local_links(markdown_path: Path) -> list[str]:
+    links: list[str] = []
+    for raw_link in LOCAL_MARKDOWN_LINK_RE.findall(
+        markdown_path.read_text(encoding="utf-8"),
+    ):
+        target = raw_link.split("#", 1)[0].strip()
+        if not target or re.match(r"^[a-z][a-z0-9+.-]*:", target):
+            continue
+        links.append(target)
+    return links
+
+
+def _repo_relative_link_targets(markdown_path: Path) -> set[str]:
+    targets: set[str] = set()
+    for target in _iter_local_links(markdown_path):
+        resolved = (markdown_path.parent / target).resolve()
+        try:
+            relative_target = resolved.relative_to(REPO_ROOT)
+        except ValueError:
+            continue
+        targets.add(relative_target.as_posix())
+    return targets
+
+
+def _load_pyproject() -> dict:
+    with (REPO_ROOT / "pyproject.toml").open("rb") as pyproject_file:
+        return tomllib.load(pyproject_file)
+
+
+def test_required_agent_legibility_docs_exist() -> None:
+    missing = [path for path in REQUIRED_DOCS if not (REPO_ROOT / path).exists()]
+    assert not missing, f"Missing agent-legibility docs: {missing}"
+
+
+def test_required_docs_have_resolvable_local_markdown_links() -> None:
+    checked_paths = [REPO_ROOT / path for path in REQUIRED_DOCS]
+    broken_links: list[str] = []
+
+    for markdown_path in checked_paths:
+        for target in _iter_local_links(markdown_path):
+            resolved = (markdown_path.parent / target).resolve()
+            link_description = f"{markdown_path.relative_to(REPO_ROOT)} -> {target}"
+            try:
+                resolved.relative_to(REPO_ROOT)
+            except ValueError:
+                broken_links.append(link_description)
+                continue
+            if not resolved.exists():
+                broken_links.append(link_description)
+
+    assert not broken_links, f"Broken local Markdown links: {broken_links}"
+
+
+def test_agents_md_links_to_core_repo_surfaces() -> None:
+    link_targets = _repo_relative_link_targets(REPO_ROOT / "AGENTS.md")
+    missing_targets = sorted(AGENT_REQUIRED_LINK_TARGETS - link_targets)
+    assert not missing_targets, (
+        f"AGENTS.md is missing link target(s): {missing_targets}"
+    )
+
+
+def test_parsed_project_metadata_declares_pep_561_typing() -> None:
+    project_metadata = _load_pyproject()["project"]
+    assert project_metadata["name"] == "pywebview-htmx"
+    assert "Typing :: Typed" in project_metadata["classifiers"]
+    assert (REPO_ROOT / "src/pywebview_htmx/py.typed").is_file()
+
+
+def test_wheel_contains_runtime_assets_and_typing_marker(tmp_path: Path) -> None:
+    subprocess.run(
+        ["pdm", "build", "--dest", str(tmp_path)],
+        cwd=REPO_ROOT,
+        check=True,
+        capture_output=True,
+        text=True,
+    )
+    wheels = list(tmp_path.glob("*.whl"))
+    assert len(wheels) == 1, f"Expected one wheel, found: {wheels}"
+
+    with zipfile.ZipFile(wheels[0]) as wheel:
+        wheel_files = set(wheel.namelist())
+
+    missing_files = sorted(REQUIRED_WHEEL_FILES - wheel_files)
+    assert not missing_files, f"Wheel is missing package file(s): {missing_files}"

pywebview_htmx-0.4.0/tests/test_repo_legibility.py

@@ -1,125 +0,0 @@
-from __future__ import annotations
-
-import re
-from pathlib import Path
-
-
-REPO_ROOT = Path(__file__).resolve().parents[1]
-REQUIRED_DOCS = [
-    "AGENTS.md",
-    "docs/index.md",
-    "docs/architecture.md",
-    "docs/development.md",
-    "docs/releasing.md",
-]
-AGENT_REQUIRED_ROUTES = [
-    "README.md",
-    "docs/index.md",
-    "src/pywebview_htmx/runtime.py",
-    "src/pywebview_htmx/static/runtime.js",
-    "app.py",
-    "pyproject.toml",
-    "docs/releasing.md",
-    "tests/",
-    "skills/use-pywebview-htmx/",
-]
-LOCAL_MARKDOWN_LINK_RE = re.compile(r"(?<!!)\[[^\]]+\]\(([^)]+)\)")
-
-
-def _read_repo_file(path: str) -> str:
-    return (REPO_ROOT / path).read_text(encoding="utf-8")
-
-
-def _iter_local_links(markdown_path: Path) -> list[str]:
-    links: list[str] = []
-    for raw_link in LOCAL_MARKDOWN_LINK_RE.findall(
-        markdown_path.read_text(encoding="utf-8"),
-    ):
-        target = raw_link.split("#", 1)[0].strip()
-        if not target or re.match(r"^[a-z][a-z0-9+.-]*:", target):
-            continue
-        links.append(target)
-    return links
-
-
-def test_required_agent_legibility_docs_exist() -> None:
-    missing = [path for path in REQUIRED_DOCS if not (REPO_ROOT / path).exists()]
-    assert not missing, f"Missing agent-legibility docs: {missing}"
-
-
-def test_new_docs_have_resolvable_local_markdown_links() -> None:
-    checked_paths = [REPO_ROOT / path for path in REQUIRED_DOCS]
-    broken_links: list[str] = []
-
-    for markdown_path in checked_paths:
-        for target in _iter_local_links(markdown_path):
-            resolved = (markdown_path.parent / target).resolve()
-            link_description = f"{markdown_path.relative_to(REPO_ROOT)} -> {target}"
-            try:
-                resolved.relative_to(REPO_ROOT)
-            except ValueError:
-                broken_links.append(link_description)
-                continue
-            if not resolved.exists():
-                broken_links.append(link_description)
-
-    assert not broken_links, f"Broken local Markdown links: {broken_links}"
-
-
-def test_agents_md_routes_to_core_repo_surfaces() -> None:
-    agents_md = _read_repo_file("AGENTS.md")
-    missing_routes = [
-        route for route in AGENT_REQUIRED_ROUTES if route not in agents_md
-    ]
-    assert not missing_routes, f"AGENTS.md is missing route(s): {missing_routes}"
-
-
-def test_development_guidance_captures_package_policy() -> None:
-    combined_guidance = "\n".join(
-        _read_repo_file(path) for path in ("AGENTS.md", "docs/development.md")
-    ).lower()
-
-    required_fragments = [
-        "pdm install",
-        "pdm run lint",
-        "pdm run test",
-        "pdm run python app.py",
-        "do not use pip to add",
-        ">=",
-        "latest version",
-    ]
-    missing_fragments = [
-        fragment for fragment in required_fragments if fragment not in combined_guidance
-    ]
-    assert not missing_fragments, (
-        "Development guidance is missing durable instruction(s): "
-        f"{missing_fragments}"
-    )
-
-
-def test_release_guidance_captures_tag_first_release_notes_flow() -> None:
-    release_guidance = _read_repo_file("docs/releasing.md")
-
-    required_fragments = [
-        "release-notes-scribe",
-        "Draft Release Notes",
-        "git tag",
-        "git push origin",
-        ".github/workflows/create-draft-release.yml",
-        ".github/workflows/python-publish.yml",
-        "PyPI",
-    ]
-    missing_fragments = [
-        fragment for fragment in required_fragments if fragment not in release_guidance
-    ]
-
-    assert not missing_fragments, (
-        "Release guidance must preserve the tag-first release notes process. "
-        f"Missing: {missing_fragments}"
-    )
-
-
-def test_typed_classifier_has_pep_561_marker() -> None:
-    pyproject = _read_repo_file("pyproject.toml")
-    assert "Typing :: Typed" in pyproject
-    assert (REPO_ROOT / "src/pywebview_htmx/py.typed").is_file()