pyuvdata 2.4.2__tar.gz → 2.4.3__tar.gz

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/.circleci/config.yml

@@ -125,10 +125,6 @@ workflows:
   version: 2
   build_and_test:
     jobs:
-      - pyuvdata:
-          name: pyuvdata_3.9
-          python_version: "3.9"
-          env_name: "pyuvdata_tests"
       - pyuvdata:
           name: pyuvdata_3.10
           python_version: "3.10"
@@ -147,7 +143,7 @@ workflows:
           env_name: "pyuvdata_min_deps_tests"
       - pyuvdata:
           name: pyuvdata_min_versions
-          python_version: "3.9"
+          python_version: "3.10"
           env_name: "pyuvdata_min_versions_tests"
       - doctest:
           python_version: "3.11"

pyuvdata-2.4.3/.codecov.yml

@@ -0,0 +1,3 @@
+codecov:
+  ci:
+    - "!azure-pipelines"  # ignore CI builds by azure pipelines

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/.github/workflows/macosx_windows_ci.yaml

@@ -26,7 +26,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-latest, windows-latest]
-        python-version: [3.9, "3.10", "3.11", "3.12"]
+        python-version: ["3.10", "3.11", "3.12"]
     steps:
       - uses: actions/checkout@main
         with:
@@ -42,7 +42,7 @@ jobs:
         id: env_name
 
       - name: Setup Minimamba
-        uses: conda-incubator/setup-miniconda@v2
+        uses: conda-incubator/setup-miniconda@v3
         with:
           miniforge-variant: Mambaforge
           miniforge-version: latest
@@ -72,7 +72,7 @@ jobs:
           pytest --pyargs pyuvdata -n auto --dist=loadfile --cov=pyuvdata --cov-config=../.coveragerc --cov-report xml:../coverage.xml
           cd ..
 
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v4
         if: success()
         with:
           token: ${{secrets.CODECOV_TOKEN}} #required

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/.github/workflows/publish-to-test-pypi.yaml

@@ -22,7 +22,7 @@ jobs:
           - [macos-12, macosx, x86_64]
           - [macos-12, macosx, arm64]
           - [windows-2019, win, AMD64]
-        python: ["cp39", "cp310", "cp311", "cp312"]
+        python: ["cp310", "cp311", "cp312"]
     steps:
       - uses: actions/checkout@main
         with:

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/.github/workflows/warning_test.yaml

@@ -44,7 +44,7 @@ jobs:
         run: |
           pytest -W error --pyargs pyuvdata --cov=pyuvdata --cov-config=.coveragerc --cov-report xml:coverage.xml
 
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v4
         if: success()
         with:
           token: ${{secrets.CODECOV_TOKEN}} #required

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/.pre-commit-config.yaml

@@ -30,12 +30,12 @@ repos:
           - pep8-naming>=0.13.3
 
   - repo: https://github.com/psf/black
-    rev: 24.2.0
+    rev: 24.3.0
     hooks:
       - id: black
 
   - repo: https://github.com/PyCQA/bandit
-    rev: 1.7.7
+    rev: 1.7.8
     hooks:
       - id: bandit
         args: [--skip, "B101", --recursive, pyuvdata]

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/CHANGELOG.md

@@ -3,6 +3,26 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+## [2.4.3] - 2024-3-25
+
+### Added
+- Support for new lunar ellipsoids in `lunarsky` version 0.2.2.
+- Added new keyword handling for v.6 of the MIR data format within `MirParser`.
+
+### Changed
+- Updated minimum dependency versions: astropy>=6.0, h5py>=3.4, numpy>=1.23,
+pyerfa>=2.0.1.1, scipy>=1.7.3, python>=3.10
+- Updated minimum optional dependency versions: hdf5plugin>=3.2.0, pytest>=6.2.5,
+python-casacore>=3.5.2, pyyaml>=5.4.1, lunarsky>=0.2.2
+- Speed up for reading MWA correlator FITS files into `UVData`.
+- Now compatible with pytest>=8.0 but require pytest-cases>=3.8.3.
+
+### Fixed
+- Fixed a bug where SMA-based coordinates were recorded as FK5 for sidereal sources
+(should be ICRS).
+- Bug in which passing 'ee' or 'nn' pols to UVData.new() would error, even if
+`x_orientation` was passed.
+
 ## [2.4.2] - 2024-2-22
 
 ### Added

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: pyuvdata
-Version: 2.4.2
+Version: 2.4.3
 Summary: an interface for astronomical interferometeric datasets in python
 Home-page: https://github.com/RadioAstronomySoftwareGroup/pyuvdata
 Author: Radio Astronomy Software Group
@@ -9,57 +9,56 @@ Keywords: radio astronomy interferometry
 Classifier: Development Status :: 5 - Production/Stable
 Classifier: Intended Audience :: Science/Research
 Classifier: License :: OSI Approved :: BSD License
-Classifier: Programming Language :: Python :: 3.9
 Classifier: Programming Language :: Python :: 3.10
 Classifier: Programming Language :: Python :: 3.11
 Classifier: Programming Language :: Python :: 3.12
 Classifier: Topic :: Scientific/Engineering :: Astronomy
 Description-Content-Type: text/markdown
 License-File: LICENSE
-Requires-Dist: astropy>=5.0.4
+Requires-Dist: astropy>=6.0
 Requires-Dist: docstring-parser>=0.15
-Requires-Dist: h5py>=3.1
-Requires-Dist: numpy>=1.20
-Requires-Dist: pyerfa>=2.0
-Requires-Dist: scipy>=1.5
+Requires-Dist: h5py>=3.4
+Requires-Dist: numpy>=1.23
+Requires-Dist: pyerfa>=2.0.1.1
+Requires-Dist: scipy>=1.7.3
 Requires-Dist: setuptools>=61
 Requires-Dist: setuptools_scm!=7.0.0,!=7.0.1,!=7.0.2
 Provides-Extra: astroquery
 Requires-Dist: astroquery>=0.4.4; extra == "astroquery"
 Provides-Extra: casa
-Requires-Dist: python-casacore>=3.3.1; extra == "casa"
+Requires-Dist: python-casacore>=3.5.2; extra == "casa"
 Provides-Extra: cst
-Requires-Dist: pyyaml>=5.3; extra == "cst"
+Requires-Dist: pyyaml>=5.4.1; extra == "cst"
 Provides-Extra: hdf5-compression
-Requires-Dist: hdf5plugin>=3.1.0; extra == "hdf5-compression"
+Requires-Dist: hdf5plugin>=3.2.0; extra == "hdf5-compression"
 Provides-Extra: healpix
 Requires-Dist: astropy_healpix>=0.6; extra == "healpix"
 Provides-Extra: lunar
-Requires-Dist: lunarsky>=0.2.1; extra == "lunar"
+Requires-Dist: lunarsky>=0.2.2; extra == "lunar"
 Provides-Extra: novas
 Requires-Dist: novas; extra == "novas"
 Requires-Dist: novas_de405; extra == "novas"
 Provides-Extra: all
 Requires-Dist: astroquery>=0.4.4; extra == "all"
-Requires-Dist: python-casacore>=3.3.1; extra == "all"
-Requires-Dist: pyyaml>=5.3; extra == "all"
-Requires-Dist: hdf5plugin>=3.1.0; extra == "all"
+Requires-Dist: python-casacore>=3.5.2; extra == "all"
+Requires-Dist: pyyaml>=5.4.1; extra == "all"
+Requires-Dist: hdf5plugin>=3.2.0; extra == "all"
 Requires-Dist: astropy_healpix>=0.6; extra == "all"
-Requires-Dist: lunarsky>=0.2.1; extra == "all"
+Requires-Dist: lunarsky>=0.2.2; extra == "all"
 Requires-Dist: novas; extra == "all"
 Requires-Dist: novas_de405; extra == "all"
 Provides-Extra: test
 Requires-Dist: astroquery>=0.4.4; extra == "test"
-Requires-Dist: python-casacore>=3.3.1; extra == "test"
-Requires-Dist: pyyaml>=5.3; extra == "test"
-Requires-Dist: hdf5plugin>=3.1.0; extra == "test"
+Requires-Dist: python-casacore>=3.5.2; extra == "test"
+Requires-Dist: pyyaml>=5.4.1; extra == "test"
+Requires-Dist: hdf5plugin>=3.2.0; extra == "test"
 Requires-Dist: astropy_healpix>=0.6; extra == "test"
-Requires-Dist: lunarsky>=0.2.1; extra == "test"
+Requires-Dist: lunarsky>=0.2.2; extra == "test"
 Requires-Dist: novas; extra == "test"
 Requires-Dist: novas_de405; extra == "test"
-Requires-Dist: pytest<8.0,>=6.2; extra == "test"
+Requires-Dist: pytest>=6.2.5; extra == "test"
 Requires-Dist: pytest-xdist; extra == "test"
-Requires-Dist: pytest-cases>=3.6.9; extra == "test"
+Requires-Dist: pytest-cases>=3.8.3; extra == "test"
 Requires-Dist: pytest-cov; extra == "test"
 Requires-Dist: cython; extra == "test"
 Requires-Dist: coverage; extra == "test"
@@ -70,16 +69,16 @@ Requires-Dist: sphinx; extra == "doc"
 Requires-Dist: pypandoc; extra == "doc"
 Provides-Extra: dev
 Requires-Dist: astroquery>=0.4.4; extra == "dev"
-Requires-Dist: python-casacore>=3.3.1; extra == "dev"
-Requires-Dist: pyyaml>=5.3; extra == "dev"
-Requires-Dist: hdf5plugin>=3.1.0; extra == "dev"
+Requires-Dist: python-casacore>=3.5.2; extra == "dev"
+Requires-Dist: pyyaml>=5.4.1; extra == "dev"
+Requires-Dist: hdf5plugin>=3.2.0; extra == "dev"
 Requires-Dist: astropy_healpix>=0.6; extra == "dev"
-Requires-Dist: lunarsky>=0.2.1; extra == "dev"
+Requires-Dist: lunarsky>=0.2.2; extra == "dev"
 Requires-Dist: novas; extra == "dev"
 Requires-Dist: novas_de405; extra == "dev"
-Requires-Dist: pytest<8.0,>=6.2; extra == "dev"
+Requires-Dist: pytest>=6.2.5; extra == "dev"
 Requires-Dist: pytest-xdist; extra == "dev"
-Requires-Dist: pytest-cases>=3.6.9; extra == "dev"
+Requires-Dist: pytest-cases>=3.8.3; extra == "dev"
 Requires-Dist: pytest-cov; extra == "dev"
 Requires-Dist: cython; extra == "dev"
 Requires-Dist: coverage; extra == "dev"
@@ -225,29 +224,28 @@ There are some optional dependencies that are required for specific functionalit
 which will not be installed automatically by conda or pip.
 See [Dependencies](#dependencies) for details on installing optional dependencies.
 
-Note that as of v2.2, `pyuvdata` is only supported on python 3.7+.
-
 ## Dependencies
 
 Required:
 
-* astropy >= 5.0.4
+* astropy >= 6.0
 * docstring_parser>=0.15
-* h5py >= 3.1
-* numpy >= 1.20
-* pyerfa >= 2.0
-* scipy >= 1.5
+* h5py >= 3.4
+* numpy >= 1.23
+* pyerfa >= 2.0.1.1
+* python >= 3.10
+* scipy >= 1.7.3
 * setuptools_scm <7.0|>=7.0.3
 
 Optional:
 
 * astropy-healpix >= 0.6 (for working with beams in HEALPix formats)
 * astroquery >= 0.4.4 (for enabling phasing to ephemeris objects using JPL-Horizons)
-* hdf5plugin >= 3.1.0 (for enabling bitshuffle and other hdf5 compression filters in uvh5 files)
-* lunarsky >=0.2.1 (for working with simulated datasets for lunar telescopes)
+* hdf5plugin >= 3.2.0 (for enabling bitshuffle and other hdf5 compression filters in uvh5 files)
+* lunarsky >=0.2.2 (for working with simulated datasets for lunar telescopes)
 * novas and novas_de405 (for using the NOVAS library for astrometry)
-* python-casacore >= 3.3.1 (for working with CASA measurement sets)
-* pyyaml >= 5.3 (for working with settings files for CST beam files)
+* python-casacore >= 3.5.2 (for working with CASA measurement sets)
+* pyyaml >= 5.4.1 (for working with settings files for CST beam files)
 
 
 The numpy and astropy versions are important, so make sure these are up to date.
@@ -298,7 +296,7 @@ If you want to do development on pyuvdata, in addition to the other dependencies
 you will need the following packages:
 
 * pytest >= 6.2
-* pytest-cases >= 3.6.9
+* pytest-cases >= 3.8.3
 * pytest-cov
 * cython >=0.23
 * coverage

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/README.md

@@ -135,29 +135,28 @@ There are some optional dependencies that are required for specific functionalit
 which will not be installed automatically by conda or pip.
 See [Dependencies](#dependencies) for details on installing optional dependencies.
 
-Note that as of v2.2, `pyuvdata` is only supported on python 3.7+.
-
 ## Dependencies
 
 Required:
 
-* astropy >= 5.0.4
+* astropy >= 6.0
 * docstring_parser>=0.15
-* h5py >= 3.1
-* numpy >= 1.20
-* pyerfa >= 2.0
-* scipy >= 1.5
+* h5py >= 3.4
+* numpy >= 1.23
+* pyerfa >= 2.0.1.1
+* python >= 3.10
+* scipy >= 1.7.3
 * setuptools_scm <7.0|>=7.0.3
 
 Optional:
 
 * astropy-healpix >= 0.6 (for working with beams in HEALPix formats)
 * astroquery >= 0.4.4 (for enabling phasing to ephemeris objects using JPL-Horizons)
-* hdf5plugin >= 3.1.0 (for enabling bitshuffle and other hdf5 compression filters in uvh5 files)
-* lunarsky >=0.2.1 (for working with simulated datasets for lunar telescopes)
+* hdf5plugin >= 3.2.0 (for enabling bitshuffle and other hdf5 compression filters in uvh5 files)
+* lunarsky >=0.2.2 (for working with simulated datasets for lunar telescopes)
 * novas and novas_de405 (for using the NOVAS library for astrometry)
-* python-casacore >= 3.3.1 (for working with CASA measurement sets)
-* pyyaml >= 5.3 (for working with settings files for CST beam files)
+* python-casacore >= 3.5.2 (for working with CASA measurement sets)
+* pyyaml >= 5.4.1 (for working with settings files for CST beam files)
 
 
 The numpy and astropy versions are important, so make sure these are up to date.
@@ -208,7 +207,7 @@ If you want to do development on pyuvdata, in addition to the other dependencies
 you will need the following packages:
 
 * pytest >= 6.2
-* pytest-cases >= 3.6.9
+* pytest-cases >= 3.8.3
 * pytest-cov
 * cython >=0.23
 * coverage

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/ci/azure-piplines.yml

@@ -8,7 +8,7 @@ jobs:
   steps:
   - task: UsePythonVersion@0
     inputs:
-      versionSpec: "3.10"
+      versionSpec: "3.12"
 
   - bash: |
       cd ../
@@ -17,7 +17,7 @@ jobs:
     displayName: clone hera_cal
 
   - bash: |
-      pip install .[dev]
+      pip install .
     displayName: install pyuvdata
 
   - bash: |
@@ -30,7 +30,7 @@ jobs:
     displayName: Environment Info
 
   - bash: |
-      pytest -n auto --pyargs hera_cal -W "ignore" -W "default:::pyuvdata"
+      pytest -n auto --pyargs hera_cal
     displayName: run hera_cal tests
 
 - job: hera_qm
@@ -127,7 +127,7 @@ jobs:
     vmImage: "ubuntu-latest"
   variables:
     PYTHON: "3.10"
-    ENV_NAME: pyuvsim_tests
+    ENV_NAME: pyuvsim_tests_openmpi
     WITH_SUDO: true
 
   steps:

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/ci/pyuvdata_min_deps_tests.yml

@@ -2,15 +2,15 @@ name: pyuvdata_min_deps_tests
 channels:
   - conda-forge
 dependencies:
-  - astropy>=5.0.4
+  - astropy>=6.0
   - docstring_parser>=0.15
   - h5py>=3.1
   - scipy>=1.5
-  - numpy>=1.20.*
+  - numpy>=1.23
   - pyerfa>=2.0
   - coverage
-  - pytest>=6.2.0,<8.0
-  - pytest-cases>=3.6.9
+  - pytest>=6.2.0
+  - pytest-cases>=3.8.3
   - pytest-cov
   - pytest-xdist
   - cython

pyuvdata-2.4.3/ci/pyuvdata_min_versions_tests.yml

@@ -0,0 +1,28 @@
+name: pyuvdata_min_versions_tests
+channels:
+  - conda-forge
+dependencies:
+  - astropy==6.0.0
+  - astropy-healpix==0.6
+  - astroquery==0.4.4
+  - docstring_parser==0.15
+  - h5py==3.4.0
+  - hdf5plugin==3.2.0
+  - numpy==1.23
+  - pyerfa==2.0.1.1
+  - python-casacore==3.5.0
+  - pyyaml==5.4.1
+  - scipy==1.7.3
+  - coverage
+  - pytest==6.2.5
+  - pytest-cases==3.8.3
+  - pytest-cov
+  - pytest-xdist
+  - cython
+  - setuptools==61
+  - setuptools_scm==7.0.3
+  - pip
+  - pip:
+      - lunarsky==0.2.2
+      - novas
+      - novas_de405

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/ci/pyuvdata_tests.yml

@@ -2,27 +2,27 @@ name: pyuvdata_tests
 channels:
   - conda-forge
 dependencies:
-  - astropy>=5.0.4
+  - astropy>=6.0
   - astropy-healpix>=0.6
   - astroquery>=0.4.4
   - docstring_parser>=0.15
-  - h5py>=3.1
-  - hdf5plugin>=3.1.0
+  - h5py>=3.4
+  - hdf5plugin>=3.2.0
   - matplotlib  # this is just for the doctests.
-  - numpy>=1.20.*
-  - pyerfa>=2.0
-  - python-casacore>=3.3.1
-  - pyyaml>=5.3
-  - scipy>=1.5
+  - numpy>=1.23
+  - pyerfa>=2.0.1.1
+  - python-casacore>=3.5.2
+  - pyyaml>=5.4.1
+  - scipy>=1.7.3
   - coverage
-  - pytest>=6.2.0,<8.0
-  - pytest-cases>=3.6.9
+  - pytest>=6.2.5
+  - pytest-cases>=3.8.3
   - pytest-cov
   - pytest-xdist
   - cython
   - setuptools_scm<7.0|>=7.0.3
   - pip
   - pip:
-      - lunarsky>=0.2.1
+      - lunarsky>=0.2.2
       - novas
       - novas_de405

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/ci/pyuvdata_tests_windows.yml

@@ -2,24 +2,24 @@ name: pyuvdata_tests_windows
 channels:
   - conda-forge
 dependencies:
-  - astropy>=5.0.4
+  - astropy>=6.0
   - astropy-healpix>=0.6
   - astroquery>=0.4.4
   - docstring_parser>=0.15
-  - h5py>=3.1
+  - h5py>=3.4
   - hdf5>=1.12.0
-  - hdf5plugin>=3.1.0
-  - numpy>=1.20.*
-  - pyerfa>=2.0
-  - pyyaml>=5.3
-  - scipy>=1.5
+  - hdf5plugin>=3.2.0
+  - numpy>=1.23
+  - pyerfa>=2.0.1.1
+  - pyyaml>=5.4.1
+  - scipy>=1.7.3
   - coverage
-  - pytest>=6.2.0,<8.0
-  - pytest-cases>=3.6.9
+  - pytest>=6.2.5
+  - pytest-cases>=3.8.3
   - pytest-cov
   - pytest-xdist
   - cython
   - setuptools_scm<7.0|>=7.0.3
   - pip
   - pip:
-      - lunarsky>=0.2.1
+      - lunarsky>=0.2.2

pyuvdata-2.4.3/ci/test_requirements.txt

@@ -0,0 +1,5 @@
+coverage
+packaging
+pytest>=6.2.5
+pytest-cov
+pytest-cases>=3.8.3

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/docs/conftest.py

@@ -7,8 +7,11 @@ import os
 import shutil
 from pathlib import Path
 
+import matplotlib
 import pytest
 
+matplotlib.use("Agg")  # Must be before importing matplotlib.pyplot or pylab!
+
 
 @pytest.fixture(autouse=True, scope="session")
 def setup_and_teardown_package(tmp_path_factory):

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/environment.yaml

@@ -2,30 +2,30 @@ name: pyuvdata
 channels:
   - conda-forge
 dependencies:
-  - astropy>=5.0.4
+  - astropy>=6.0
   - astropy-healpix>=0.6
   - astroquery>=0.4.4
   - coverage
   - cython>=0.23
   - docstring_parser>=0.15
-  - h5py>=3.1
-  - hdf5plugin>=3.1.0
+  - h5py>=3.4
+  - hdf5plugin>=3.2.0
   - matplotlib
-  - numpy>=1.20
+  - numpy>=1.23
   - pip
   - pre-commit
-  - pyerfa>=2.0
+  - pyerfa>=2.0.1.1
   - pypandoc
-  - pytest>=6.2.0,<8.0
-  - pytest-cases>=3.6.9
+  - pytest>=6.2.5
+  - pytest-cases>=3.8.3
   - pytest-cov
   - pytest-xdist
-  - python-casacore>=3.3.1
-  - pyyaml>=5.3
-  - scipy>=1.5
+  - python-casacore>=3.5.2
+  - pyyaml>=5.4.1
+  - scipy>=1.7.3
   - setuptools_scm<7.0|>=7.0.3
   - sphinx
   - pip:
-      - lunarsky>=0.2.1
+      - lunarsky>=0.2.2
       - novas
       - novas_de405

{pyuvdata-2.4.2 → pyuvdata-2.4.3}/pyuvdata/parameter.py

@@ -846,6 +846,10 @@ class LocationParameter(UVParameter):
         Description of the data or metadata in the object.
     frame : str, optional
         Coordinate frame. Valid options are "itrs" (default) or "mcmf".
+    ellipsoid : str, optional
+        Ellipsoid to use for lunar coordinates. Must be one of "SPHERE",
+        "GSFC", "GRAIL23", "CE-1-LAM-GEO" (see lunarsky package for details).
+        Default is "SPHERE". Only used if frame is "mcmf".
     acceptable_vals : list, optional
         List giving allowed values for elements of value.
     acceptable_range: 2-tuple, optional
@@ -879,6 +883,10 @@ class LocationParameter(UVParameter):
         Description of the data or metadata in the object.
     frame : str, optional
         Coordinate frame. Valid options are "itrs" (default) or "mcmf".
+    ellipsoid : str, optional
+        Ellipsoid to use for lunar coordinates. Must be one of "SPHERE",
+        "GSFC", "GRAIL23", "CE-1-LAM-GEO" (see lunarsky package for details). Default
+        is "SPHERE". Only used if frame is "mcmf".
     expected_type
         Always set to float.
     acceptable_vals : list, optional
@@ -903,6 +911,7 @@ class LocationParameter(UVParameter):
         spoof_val=None,
         description="",
         frame="itrs",
+        ellipsoid=None,
         acceptable_range=None,
         tols=1e-3,
     ):
@@ -919,6 +928,11 @@ class LocationParameter(UVParameter):
         )
         self.frame = frame
 
+        if frame == "mcmf" and ellipsoid is None:
+            ellipsoid = "SPHERE"
+
+        self.ellipsoid = ellipsoid
+
     def lat_lon_alt(self):
         """Get value in (latitude, longitude, altitude) tuple in radians."""
         if self.value is None:
@@ -926,7 +940,10 @@ class LocationParameter(UVParameter):
         else:
             # check defaults to False b/c exposed check kwarg exists in UVData
             return utils.LatLonAlt_from_XYZ(
-                self.value, check_acceptability=False, frame=self.frame
+                self.value,
+                check_acceptability=False,
+                frame=self.frame,
+                ellipsoid=self.ellipsoid,
             )
 
     def set_lat_lon_alt(self, lat_lon_alt):
@@ -943,7 +960,11 @@ class LocationParameter(UVParameter):
             self.value = None
         else:
             self.value = utils.XYZ_from_LatLonAlt(
-                lat_lon_alt[0], lat_lon_alt[1], lat_lon_alt[2], frame=self.frame
+                lat_lon_alt[0],
+                lat_lon_alt[1],
+                lat_lon_alt[2],
+                frame=self.frame,
+                ellipsoid=self.ellipsoid,
             )
 
     def lat_lon_alt_degrees(self):
@@ -974,10 +995,14 @@ class LocationParameter(UVParameter):
                 longitude * np.pi / 180.0,
                 altitude,
                 frame=self.frame,
+                ellipsoid=self.ellipsoid,
             )
 
     def check_acceptability(self):
         """Check that vector magnitudes are in range."""
+        if self.frame not in utils._range_dict.keys():
+            return False, f"Frame must be one of {utils._range_dict.keys()}"
+
         if self.acceptable_range is None:
             return True, "No acceptability check"
         else: