pytrilogy 0.0.2.5__tar.gz → 0.0.2.7__tar.gz

{pytrilogy-0.0.2.5/pytrilogy.egg-info → pytrilogy-0.0.2.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: pytrilogy
-Version: 0.0.2.5
+Version: 0.0.2.7
 Summary: Declarative, typed query language that compiles to SQL.
 Home-page: 
 Author: 

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7/pytrilogy.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: pytrilogy
-Version: 0.0.2.5
+Version: 0.0.2.7
 Summary: Declarative, typed query language that compiles to SQL.
 Home-page: 
 Author: 

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/tests/test_environment.py

@@ -59,6 +59,13 @@ key  order_id int;
 
     assert env1.concepts["order_id"] == env1.concepts["replacements.order_id"]
 
-    order_id = env1.datasources["replacements.replacements"].columns[0]
-    assert order_id.concept == env1.concepts["order_id"]
-    assert order_id.modifiers == [Modifier.PARTIAL]
+    found = False
+    for x in env1.datasources["replacements.replacements"].columns:
+        if (
+            x.alias == "order_id"
+            and x.concept.address == env1.concepts["order_id"].address
+        ):
+            assert x.concept == env1.concepts["order_id"]
+            assert x.modifiers == [Modifier.PARTIAL]
+            found = True
+    assert found

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/tests/test_models.py

@@ -10,6 +10,8 @@ from trilogy.core.models import (
     UndefinedConcept,
     BaseJoin,
     Comparison,
+    Join,
+    JoinKey,
 )
 
 
@@ -54,6 +56,8 @@ def test_cte_merge(test_environment, test_environment_graph):
     merged = a + b
     assert merged.output_columns == outputs
 
+    assert "Target: Grain<Abstract>." in merged.comment
+
 
 def test_concept(test_environment, test_environment_graph):
     test_concept = list(test_environment.concepts.values())[0]
@@ -191,3 +195,54 @@ def test_comparison():
         Comparison(left=1, right="abc", operator=ComparisonOperator.EQ)
     except Exception as exc:
         assert isinstance(exc, SyntaxError)
+
+
+def test_join(test_environment: Environment):
+    datasource = list(test_environment.datasources.values())[0]
+    outputs = [c.concept for c in datasource.columns]
+    output_map = {
+        c.address: {
+            datasource,
+        }
+        for c in outputs
+    }
+    a = CTE(
+        name="test",
+        output_columns=[outputs[0]],
+        grain=Grain(),
+        source=QueryDatasource(
+            input_concepts=[outputs[0]],
+            output_concepts=[outputs[0]],
+            datasources=[datasource],
+            grain=Grain(),
+            joins=[],
+            source_map={outputs[0].address: {datasource}},
+        ),
+        source_map={c.address: [datasource.identifier] for c in outputs},
+    )
+
+    b = CTE(
+        name="testb",
+        output_columns=outputs,
+        grain=Grain(),
+        source=QueryDatasource(
+            input_concepts=outputs,
+            output_concepts=outputs,
+            datasources=[datasource],
+            grain=Grain(),
+            joins=[],
+            source_map=output_map,
+        ),
+        source_map={c.address: [datasource.identifier] for c in outputs},
+    )
+    test = Join(
+        left_cte=a,
+        right_cte=b,
+        joinkeys=[JoinKey(concept=x) for x in outputs],
+        jointype=JoinType.RIGHT_OUTER,
+    )
+
+    assert (
+        str(test)
+        == "right outer JOIN test and testb on local.product_id<local.product_id>,local.category_id<local.category_id>"
+    ), str(test)

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/tests/test_parsing.py

@@ -160,7 +160,8 @@ address `preqldata.analytics_411641820.events_*`
 ;"""
     )
     query = parsed[-1]
-    assert query.address.location == "`preqldata.analytics_411641820.events_*`"
+    assert query.address.quoted is True
+    assert query.address.location == "preqldata.analytics_411641820.events_*"
 
 
 def test_purpose_and_keys():
@@ -448,3 +449,46 @@ select
         {"a": 1, "b": 2, "c": 3},
         1,
     )
+
+
+def test_datasource_colon():
+
+    text = """
+key x int;
+key y int;
+
+datasource test (
+x:x,
+y:y)
+grain(x)
+address `abc:def`
+;
+
+
+select x;
+"""
+    env, parsed = parse_text(text)
+
+    results = Dialects.DUCK_DB.default_executor().generate_sql(text)[0]
+
+    assert '"abc:def" as test' in results
+
+    text = """
+key x int;
+key y int;
+
+datasource test (
+x:x,
+y:y)
+grain(x)
+address abcdef
+;
+
+
+select x;
+"""
+    env, parsed = parse_text(text)
+
+    results = Dialects.DUCK_DB.default_executor().generate_sql(text)[0]
+
+    assert "abcdef as test" in results, results

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/__init__.py

@@ -4,6 +4,6 @@ from trilogy.executor import Executor
 from trilogy.parser import parse
 from trilogy.constants import CONFIG
 
-__version__ = "0.0.2.5"
+__version__ = "0.0.2.7"
 
 __all__ = ["parse", "Executor", "Dialects", "Environment", "CONFIG"]

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/constants.py

@@ -33,6 +33,7 @@ class Config:
     strict_mode: bool = True
     human_identifiers: bool = True
     validate_missing: bool = True
+    show_comments: bool = False
     optimizations: Optimizations = field(default_factory=Optimizations)
 
     def set_random_seed(self, seed: int):
@@ -42,5 +43,3 @@ class Config:
 CONFIG = Config()
 
 CONFIG.set_random_seed(42)
-
-CONFIG.strict_mode = True

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/enums.py

@@ -7,6 +7,7 @@ class UnnestMode(Enum):
     DIRECT = "direct"
     CROSS_APPLY = "cross_apply"
     CROSS_JOIN = "cross_join"
+    CROSS_JOIN_ALIAS = "cross_join_alias"
 
 
 class ConceptSource(Enum):

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/models.py

@@ -945,12 +945,14 @@ class ColumnAssignment(BaseModel):
         )
 
     def with_merge(
-        self, concept: Concept, modifiers: List[Modifier]
+        self, source: Concept, target: Concept, modifiers: List[Modifier]
     ) -> "ColumnAssignment":
         return ColumnAssignment(
             alias=self.alias,
-            concept=concept,
-            modifiers=modifiers,
+            concept=self.concept.with_merge(source, target, modifiers),
+            modifiers=(
+                modifiers if self.concept.address == source.address else self.modifiers
+            ),
         )
 
 
@@ -1817,6 +1819,7 @@ class MultiSelectStatement(SelectTypeMixin, Mergeable, Namespaced, BaseModel):
 class Address(BaseModel):
     location: str
     is_query: bool = False
+    quoted: bool = False
 
 
 class Query(BaseModel):
@@ -1889,20 +1892,22 @@ class Datasource(Namespaced, BaseModel):
         self, source: Concept, target: Concept, modifiers: List[Modifier]
     ):
         original = [c for c in self.columns if c.concept.address == source.address]
+        if len(original) != 1:
+            raise ValueError(
+                f"Expected exactly one column to merge, got {len(original)} for {source.address}, {[x.alias for x in original]}"
+            )
         # map to the alias with the modifier, and the original
         self.columns = [
-            (
-                c.with_merge(target, modifiers)
-                if c.concept.address == source.address
-                else c
-            )
+            c.with_merge(source, target, modifiers)
             for c in self.columns
+            if c.concept.address != source.address
         ] + original
         self.grain = self.grain.with_merge(source, target, modifiers)
         self.where = (
             self.where.with_merge(source, target, modifiers) if self.where else None
         )
-        del self.output_lcl
+
+        self.add_column(target, original[0].alias, modifiers)
 
     @property
     def env_label(self) -> str:
@@ -1914,7 +1919,7 @@ class Datasource(Namespaced, BaseModel):
     def condition(self):
         return None
 
-    @cached_property
+    @property
     def output_lcl(self) -> LooseConceptList:
         return LooseConceptList(concepts=self.output_concepts)
 
@@ -1922,9 +1927,9 @@ class Datasource(Namespaced, BaseModel):
     def can_be_inlined(self) -> bool:
         if isinstance(self.address, Address) and self.address.is_query:
             return False
-        for x in self.columns:
-            if not isinstance(x.alias, str):
-                return False
+        # for x in self.columns:
+        #     if not isinstance(x.alias, str):
+        #         return False
         return True
 
     @property
@@ -1959,12 +1964,15 @@ class Datasource(Namespaced, BaseModel):
             )
         return grain
 
-    def add_column(self, concept: Concept, alias: str, modifiers=None):
+    def add_column(
+        self,
+        concept: Concept,
+        alias: str | RawColumnExpr | Function,
+        modifiers: List[Modifier] | None = None,
+    ):
         self.columns.append(
-            ColumnAssignment(alias=alias, concept=concept, modifiers=modifiers)
+            ColumnAssignment(alias=alias, concept=concept, modifiers=modifiers or [])
         )
-        # force refresh
-        del self.output_lcl
 
     def __add__(self, other):
         if not other == self:
@@ -1997,7 +2005,7 @@ class Datasource(Namespaced, BaseModel):
             where=self.where.with_namespace(namespace) if self.where else None,
         )
 
-    @cached_property
+    @property
     def concepts(self) -> List[Concept]:
         return [c.concept for c in self.columns]
 
@@ -2148,6 +2156,12 @@ class BaseJoin(BaseModel):
         )
 
     def __str__(self):
+        if self.concept_pairs:
+            return (
+                f"{self.join_type.value} JOIN {self.left_datasource.identifier} and"
+                f" {self.right_datasource.identifier} on"
+                f" {','.join([str(k[0])+'='+str(k[1]) for k in self.concept_pairs])}"
+            )
         return (
             f"{self.join_type.value} JOIN {self.left_datasource.identifier} and"
             f" {self.right_datasource.identifier} on"
@@ -2459,6 +2473,19 @@ class CTE(BaseModel):
                     self.base_alias_override = candidates[0] if candidates else None
         return True
 
+    @property
+    def comment(self) -> str:
+        base = f"Target: {str(self.grain)}."
+        if self.parent_ctes:
+            base += f" References: {', '.join([x.name for x in self.parent_ctes])}."
+        if self.joins:
+            base += f"\n-- Joins: {', '.join([str(x) for x in self.joins])}."
+        if self.partial_concepts:
+            base += (
+                f"\n-- Partials: {', '.join([str(x) for x in self.partial_concepts])}."
+            )
+        return base
+
     def inline_parent_datasource(self, parent: CTE, force_group: bool = False) -> bool:
         qds_being_inlined = parent.source
         ds_being_inlined = qds_being_inlined.datasources[0]
@@ -2549,6 +2576,10 @@ class CTE(BaseModel):
         self.hidden_concepts = unique(
             self.hidden_concepts + other.hidden_concepts, "address"
         )
+        self.existence_source_map = {
+            **self.existence_source_map,
+            **other.existence_source_map,
+        }
         return self
 
     @property
@@ -2579,6 +2610,16 @@ class CTE(BaseModel):
             return self.relevant_base_ctes[0].name
         return self.source.name
 
+    @property
+    def quote_address(self) -> bool:
+        if self.is_root_datasource:
+            candidate = self.source.datasources[0]
+            if isinstance(candidate, Datasource) and isinstance(
+                candidate.address, Address
+            ):
+                return candidate.address.quoted
+        return False
+
     @property
     def base_alias(self) -> str:
         if self.base_alias_override:
@@ -2730,6 +2771,12 @@ class Join(BaseModel):
         return self.left_name + self.right_name + self.jointype.value
 
     def __str__(self):
+        if self.joinkey_pairs:
+            return (
+                f"{self.jointype.value} JOIN {self.left_name} and"
+                f" {self.right_name} on"
+                f" {','.join([str(k[0])+'='+str(k[1]) for k in self.joinkey_pairs])}"
+            )
         return (
             f"{self.jointype.value} JOIN {self.left_name} and"
             f" {self.right_name} on {','.join([str(k) for k in self.joinkeys])}"
@@ -2991,6 +3038,7 @@ class Environment(BaseModel):
 
     materialized_concepts: List[Concept] = Field(default_factory=list)
     alias_origin_lookup: Dict[str, Concept] = Field(default_factory=dict)
+    canonical_map: Dict[str, str] = Field(default_factory=dict)
     _parse_count: int = 0
 
     @classmethod
@@ -3039,7 +3087,7 @@ class Environment(BaseModel):
             if x.address not in current_mat
         ]
         if new:
-            logger.info(f"Environment added new materialized concepts {new}")
+            logger.debug(f"Environment added new materialized concepts {new}")
 
     def validate_concept(self, lookup: str, meta: Meta | None = None):
         existing: Concept = self.concepts.get(lookup)  # type: ignore
@@ -3202,13 +3250,22 @@ class Environment(BaseModel):
         self, source: Concept, target: Concept, modifiers: List[Modifier]
     ):
         replacements = {}
+        # exit early if we've run this
+        if source.address in self.alias_origin_lookup:
+            if self.concepts[source.address] == target:
+                return
         self.alias_origin_lookup[source.address] = source
         for k, v in self.concepts.items():
+
             if v.address == target.address:
                 v.pseudonyms[source.address] = source
             if v.address == source.address:
                 replacements[k] = target
+                self.canonical_map[k] = target.address
                 v.pseudonyms[target.address] = target
+            # we need to update keys and grains of all concepts
+            else:
+                replacements[k] = v.with_merge(source, target, modifiers)
         self.concepts.update(replacements)
 
         for k, ds in self.datasources.items():

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/optimizations/inline_datasource.py

@@ -42,19 +42,18 @@ class InlineDatasource(OptimizationRule):
                 self.log(f"parent {parent_cte.name} datasource is not inlineable")
                 continue
             root_outputs = {x.address for x in root.output_concepts}
-            cte_outputs = {x.address for x in cte.output_columns}
-            inherited = {x for x, v in cte.source_map.items() if v}
-            # cte_inherited_outputs = {x.address for x in parent_cte.output_columns if parent_cte.source_map.get(x.address)}
-            grain_components = {x.address for x in root.grain.components}
+            inherited = {
+                x for x, v in cte.source_map.items() if v and parent_cte.name in v
+            }
             if not inherited.issubset(root_outputs):
                 cte_missing = inherited - root_outputs
                 self.log(
                     f"Not all {parent_cte.name} require inputs are found on datasource, missing {cte_missing}"
                 )
                 continue
-            if not grain_components.issubset(cte_outputs):
-                self.log("Not all datasource components in cte outputs, forcing group")
-                force_group = True
+            if not root.grain.issubset(parent_cte.grain):
+                self.log(f"Not all {parent_cte.name} is at wrong grain to inline")
+                continue
             to_inline.append(parent_cte)
 
         optimized = False
@@ -68,6 +67,11 @@ class InlineDatasource(OptimizationRule):
                     f"Skipping inlining raw datasource {replaceable.source.name} ({replaceable.name}) due to multiple references"
                 )
                 continue
+            if not replaceable.source.datasources[0].grain.issubset(replaceable.grain):
+                self.log(
+                    f"Forcing group ({parent_cte.grain} being replaced by inlined source {root.grain})"
+                )
+                force_group = True
             result = cte.inline_parent_datasource(replaceable, force_group=force_group)
             if result:
                 self.log(

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/concept_strategies_v3.py

@@ -612,9 +612,19 @@ def _search_concepts(
         )
 
         if expanded:
-            expanded.resolve()
+            # we don't need to return the entire list; just the ones we needed pre-expansion
+            ex_resolve = expanded.resolve()
+            extra = [
+                x
+                for x in ex_resolve.output_concepts
+                if x.address not in [y.address for y in mandatory_list]
+                and x not in ex_resolve.grain.components
+            ]
+            expanded.output_concepts = mandatory_list
+            expanded.rebuild_cache()
+
             logger.info(
-                f"{depth_to_prefix(depth)}{LOGGER_PREFIX} Found connections for {[c.address for c in mandatory_list]} via concept addition;"
+                f"{depth_to_prefix(depth)}{LOGGER_PREFIX} Found connections for {[c.address for c in mandatory_list]} via concept addition; removing extra {[c.address for c in extra]}"
             )
             return expanded
     # if we can't find it after expanding to a merge, then

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/node_generators/common.py

@@ -209,6 +209,7 @@ def gen_enrichment_node(
         environment=environment,
         g=g,
         parents=[enrich_node, base_node],
+        force_group=False,
         node_joins=[
             NodeJoin(
                 left_node=enrich_node,

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/node_generators/filter_node.py

@@ -105,10 +105,29 @@ def gen_filter_node(
         environment=environment,
         g=g,
         parents=core_parents,
+        grain=Grain(
+            components=[immediate_parent] + parent_row_concepts,
+        ),
+    )
+
+    assert filter_node.resolve().grain == Grain(
+        components=[immediate_parent] + parent_row_concepts,
     )
     if not local_optional or all(
         [x.address in [y.address for y in parent_row_concepts] for x in local_optional]
     ):
+        outputs = [
+            x
+            for x in filter_node.output_concepts
+            if x.address in [y.address for y in local_optional]
+        ]
+        logger.info(
+            f"{padding(depth)}{LOGGER_PREFIX} no extra enrichment needed for filter node"
+        )
+        filter_node.output_concepts = [
+            concept,
+        ] + outputs
+        filter_node.rebuild_cache()
         return filter_node
     enrich_node = source_concepts(  # this fetches the parent + join keys
         # to then connect to the rest of the query

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/node_generators/group_node.py

@@ -29,7 +29,7 @@ def gen_group_node(
         resolve_function_parent_concepts(concept), "address"
     )
     logger.info(
-        f"{padding(depth)}{LOGGER_PREFIX} parent_concepts are {[x.address for x in parent_concepts]} from group grain {concept.grain}"
+        f"{padding(depth)}{LOGGER_PREFIX} parent concepts are {[x.address for x in parent_concepts]} from group grain {concept.grain}"
     )
 
     # if the aggregation has a grain, we need to ensure these are the ONLY optional in the output of the select

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/node_generators/group_to_node.py

@@ -95,5 +95,4 @@ def gen_group_to_node(
         ],
         whole_grain=True,
         depth=depth,
-        partial_concepts=group_node.partial_concepts,
     )

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/node_generators/node_merge_node.py

@@ -260,6 +260,7 @@ def subgraphs_to_merge_node(
     source_concepts,
     history,
     conditions,
+    enable_early_exit: bool = True,
 ):
     parents: List[StrategyNode] = []
     logger.info(
@@ -290,6 +291,8 @@ def subgraphs_to_merge_node(
     for x in parents:
         for y in x.output_concepts:
             input_c.append(y)
+    if len(parents) == 1 and enable_early_exit:
+        return parents[0]
 
     return MergeNode(
         input_concepts=unique(input_c, "address"),
@@ -350,6 +353,7 @@ def gen_merge_node(
                 source_concepts=source_concepts,
                 history=history,
                 conditions=conditions,
+                enable_early_exit=False,
             )
             if test:
                 return test

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/node_generators/rowset_node.py

@@ -74,8 +74,9 @@ def gen_rowset_node(
     if existence_parents:
         node.parents += existence_parents
         # we don't need to join to any existence parents
-        if isinstance(node, MergeNode):
-            node.node_joins = []
+        # if isinstance(node, MergeNode) and node.node_joins is None:
+        #     # set it explicitly to empty to avoid inference
+        #     node.node_joins = []
         for parent in existence_parents:
             for x in parent.output_concepts:
                 if x.address not in node.output_lcl:

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/nodes/base_node.py

@@ -192,7 +192,7 @@ class StrategyNode:
             p.resolve() for p in self.parents
         ]
 
-        grain = Grain(components=self.output_concepts)
+        grain = self.grain if self.grain else Grain(components=self.output_concepts)
         source_map = resolve_concept_map(
             parent_sources,
             self.output_concepts,

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/nodes/filter_node.py

@@ -63,4 +63,5 @@ class FilterNode(StrategyNode):
             conditions=self.conditions,
             partial_concepts=list(self.partial_concepts),
             force_group=self.force_group,
+            grain=self.grain,
         )

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/processing/nodes/merge_node.py

@@ -78,7 +78,7 @@ def deduplicate_nodes_and_joins(
         duplicates = False
         duplicates, merged, removed = deduplicate_nodes(merged, logging_prefix)
         # filter out any removed joins
-        if joins:
+        if joins is not None:
             joins = [
                 j
                 for j in joins
@@ -138,6 +138,16 @@ class MergeNode(StrategyNode):
                     continue
                 final_joins.append(join)
             self.node_joins = final_joins
+        partial_lookup: list[Concept] = []
+        non_partial: List[Concept] = []
+        for node in parents or []:
+            partial_lookup += node.partial_concepts
+            non_partial += [
+                x for x in node.output_concepts if x not in node.partial_concepts
+            ]
+
+        final_partial = [x for x in partial_lookup if x not in non_partial]
+        self.partial_concepts = final_partial
 
     def translate_node_joins(self, node_joins: List[NodeJoin]) -> List[BaseJoin]:
         joins = []
@@ -219,12 +229,13 @@ class MergeNode(StrategyNode):
             )
             joins = self.translate_node_joins(final_joins)
         else:
+            logger.info(
+                f"{self.logging_prefix}{LOGGER_PREFIX} Final joins is not null {final_joins} but is empty, skipping join generation"
+            )
             return []
 
         for join in joins:
-            logger.info(
-                f"{self.logging_prefix}{LOGGER_PREFIX} final join {join.join_type} {[str(c) for c in join.concepts]}"
-            )
+            logger.info(f"{self.logging_prefix}{LOGGER_PREFIX} final join {str(join)}")
         return joins
 
     def _resolve(self) -> QueryDatasource:
@@ -249,6 +260,12 @@ class MergeNode(StrategyNode):
         # early exit if we can just return the parent
         final_datasets: List[QueryDatasource | Datasource] = list(merged.values())
 
+        existence_final = [
+            x
+            for x in final_datasets
+            if all([y in self.existence_concepts for y in x.output_concepts])
+        ]
+
         if len(merged.keys()) == 1:
             final: QueryDatasource | Datasource = list(merged.values())[0]
             if (
@@ -288,34 +305,25 @@ class MergeNode(StrategyNode):
         for source in final_datasets:
             pregrain += source.grain
 
-        grain = (
-            self.grain
-            if self.grain
-            else Grain(
-                components=[
-                    c
-                    for c in pregrain.components
-                    if c.address in [x.address for x in self.output_concepts]
-                ]
-            )
-        )
+        grain = self.grain if self.grain else pregrain
 
         logger.info(
             f"{self.logging_prefix}{LOGGER_PREFIX} has pre grain {pregrain} and final merge node grain {grain}"
         )
-
-        if len(final_datasets) > 1:
+        join_candidates = [x for x in final_datasets if x not in existence_final]
+        if len(join_candidates) > 1:
             joins = self.generate_joins(
-                final_datasets, final_joins, pregrain, grain, self.environment
+                join_candidates, final_joins, pregrain, grain, self.environment
             )
         else:
             joins = []
-
+        logger.info(
+            f"{self.logging_prefix}{LOGGER_PREFIX} Final join count for CTE parent count {len(join_candidates)} is {len(joins)}"
+        )
         full_join_concepts = []
         for join in joins:
             if join.join_type == JoinType.FULL:
                 full_join_concepts += join.concepts
-
         if self.whole_grain:
             force_group = False
         elif self.force_group is False:
@@ -337,9 +345,6 @@ class MergeNode(StrategyNode):
             inherited_inputs=self.input_concepts + self.existence_concepts,
             full_joins=full_join_concepts,
         )
-        logger.info(
-            f"{self.logging_prefix}{LOGGER_PREFIX} source_map {str(source_map)}"
-        )
         qds = QueryDatasource(
             input_concepts=unique(self.input_concepts, "address"),
             output_concepts=unique(self.output_concepts, "address"),

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/core/query_processor.py

@@ -183,49 +183,42 @@ def generate_cte_name(full_name: str, name_map: dict[str, str]) -> str:
         return full_name.replace("<", "").replace(">", "").replace(",", "_")
 
 
-def resolve_cte_base_name_and_alias(
+def resolve_cte_base_name_and_alias_v2(
     name: str,
     source: QueryDatasource,
-    parents: List[CTE],
-    joins: List[Join | InstantiatedUnnestJoin],
+    source_map: Dict[str, list[str]],
+    raw_joins: List[Join | InstantiatedUnnestJoin],
 ) -> Tuple[str | None, str | None]:
-
-    valid_joins: List[Join] = [join for join in joins if isinstance(join, Join)]
-    relevant_parent_sources = set()
-    for k, v in source.source_map.items():
-        if v:
-            relevant_parent_sources.update(v)
-    eligible = [x for x in source.datasources if x in relevant_parent_sources]
+    joins: List[Join] = [join for join in raw_joins if isinstance(join, Join)]
     if (
-        len(eligible) == 1
-        and isinstance(eligible[0], Datasource)
-        and not eligible[0].name == CONSTANT_DATASET
+        len(source.datasources) == 1
+        and isinstance(source.datasources[0], Datasource)
+        and not source.datasources[0].name == CONSTANT_DATASET
     ):
-        ds = eligible[0]
+        ds = source.datasources[0]
         return ds.safe_location, ds.identifier
 
-    # if we have multiple joined CTEs, pick the base
-    # as the root
-    elif len(eligible) == 1 and len(parents) == 1:
-        return parents[0].name, parents[0].name
-    elif valid_joins and len(valid_joins) > 0:
-        candidates = [x.left_cte.name for x in valid_joins]
-        disallowed = [x.right_cte.name for x in valid_joins]
+    if joins and len(joins) > 0:
+        candidates = [x.left_cte.name for x in joins]
+        disallowed = [x.right_cte.name for x in joins]
         try:
             cte = [y for y in candidates if y not in disallowed][0]
             return cte, cte
         except IndexError:
             raise SyntaxError(
-                f"Invalid join configuration {candidates} {disallowed} with all parents {[x.base_name for x in parents]}"
+                f"Invalid join configuration {candidates} {disallowed} for {name}",
             )
-    elif eligible:
-        matched = [x for x in parents if x.source.name == eligible[0].name]
-        if matched:
-            return matched[0].name, matched[0].name
 
-    logger.info(
-        f"Could not determine CTE base name for {name} with relevant sources {relevant_parent_sources}"
-    )
+    counts: dict[str, int] = defaultdict(lambda: 0)
+    output_addresses = [x.address for x in source.output_concepts]
+    for k, v in source_map.items():
+        for vx in v:
+            if k in output_addresses:
+                counts[vx] = counts[vx] + 1
+            else:
+                counts[vx] = counts[vx]
+    if counts:
+        return max(counts, key=counts.get), max(counts, key=counts.get)  # type: ignore
     return None, None
 
 
@@ -274,8 +267,8 @@ def datasource_to_ctes(
         for x in [base_join_to_join(join, parents) for join in query_datasource.joins]
         if x
     ]
-    base_name, base_alias = resolve_cte_base_name_and_alias(
-        human_id, query_datasource, parents, final_joins
+    base_name, base_alias = resolve_cte_base_name_and_alias_v2(
+        human_id, query_datasource, source_map, final_joins
     )
     cte = CTE(
         name=human_id,

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/dialect/base.py

@@ -499,10 +499,12 @@ class BaseDialect:
                 for c in cte.output_columns
                 if c.address not in [y.address for y in cte.hidden_concepts]
             ]
-        if cte.base_name == cte.base_alias:
-            source = cte.base_name
+        if cte.quote_address:
+            source = f"{self.QUOTE_CHARACTER}{cte.base_name}{self.QUOTE_CHARACTER}"
         else:
-            source = f"{cte.base_name} as {cte.base_alias}"
+            source = cte.base_name
+        if cte.base_name != cte.base_alias:
+            source = f"{source} as {cte.base_alias}"
         return CompiledCTE(
             name=cte.name,
             statement=self.SQL_TEMPLATE.render(
@@ -511,6 +513,7 @@ class BaseDialect:
                 grain=cte.grain,
                 limit=cte.limit,
                 # some joins may not need to be rendered
+                comment=cte.comment if CONFIG.show_comments else None,
                 joins=[
                     j
                     for j in [

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/dialect/common.py

@@ -26,7 +26,8 @@ def render_join(
             raise ValueError("must provide a cte to build an unnest joins")
         if unnest_mode == UnnestMode.CROSS_JOIN:
             return f"CROSS JOIN {render_func(join.concept, cte, False)} as {quote_character}{join.concept.safe_address}{quote_character}"
-
+        if unnest_mode == UnnestMode.CROSS_JOIN_ALIAS:
+            return f"CROSS JOIN {render_func(join.concept, cte, False)} as array_unnest ({quote_character}{join.concept.safe_address}{quote_character})"
         return f"FULL JOIN {render_func(join.concept, cte, False)} as unnest_wrapper({quote_character}{join.concept.safe_address}{quote_character})"
     left_name = join.left_name
     right_name = join.right_name

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/dialect/duckdb.py

@@ -47,8 +47,9 @@ CREATE OR REPLACE TABLE {{ output.address.location }} AS
 {% endif %}{%- if ctes %}
 WITH {% for cte in ctes %}
 {{cte.name}} as ({{cte.statement}}){% if not loop.last %},{% endif %}{% endfor %}{% endif %}
-{% if full_select -%}{{full_select}}
-{% else -%}
+{%- if full_select -%}{{full_select}}
+{%- else -%}{%- if comment %}
+-- {{ comment }}{% endif %}
 SELECT
 {%- for select in select_columns %}
     {{ select }}{% if not loop.last %},{% endif %}{% endfor %}
@@ -56,7 +57,8 @@ SELECT
     {{ base }}{% endif %}{% if joins %}
 {%- for join in joins %}
     {{ join }}{% endfor %}{% endif %}
-{% if where %}WHERE
+{%- if where %}
+WHERE
     {{ where }}
 {% endif -%}{%- if group_by %}
 GROUP BY {% for group in group_by %}

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/dialect/presto.py

@@ -5,7 +5,7 @@ from jinja2 import Template
 from trilogy.core.enums import FunctionType, WindowType
 from trilogy.dialect.base import BaseDialect
 from trilogy.core.models import DataType
-
+from trilogy.core.enums import UnnestMode
 
 WINDOW_FUNCTION_MAP: Mapping[WindowType, Callable[[Any, Any, Any], str]] = {}
 
@@ -86,6 +86,7 @@ class PrestoDialect(BaseDialect):
     QUOTE_CHARACTER = '"'
     SQL_TEMPLATE = SQL_TEMPLATE
     DATATYPE_MAP = {**BaseDialect.DATATYPE_MAP, DataType.NUMERIC: "DECIMAL"}
+    UNNEST_MODE = UnnestMode.CROSS_JOIN
 
 
 class TrinoDialect(PrestoDialect):

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/parsing/common.py

@@ -112,12 +112,16 @@ def filter_item_to_concept(
     return Concept(
         name=name,
         datatype=parent.content.datatype,
-        purpose=parent.content.purpose,
+        purpose=Purpose.PROPERTY,
         lineage=parent,
         metadata=fmetadata,
         namespace=namespace,
         # filtered copies cannot inherit keys
-        keys=None,
+        keys=(
+            parent.content.keys
+            if parent.content.purpose == Purpose.PROPERTY
+            else (parent.content,)
+        ),
         grain=(
             parent.content.grain
             if parent.content.purpose == Purpose.PROPERTY

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/parsing/parse_engine.py

@@ -297,8 +297,11 @@ class ParseToObjects(Transformer):
     def concept_lit(self, args) -> Concept:
         return self.environment.concepts.__getitem__(args[0])
 
-    def ADDRESS(self, args) -> str:
-        return args.value
+    def ADDRESS(self, args) -> Address:
+        return Address(location=args.value, quoted=False)
+
+    def QUOTED_ADDRESS(self, args) -> Address:
+        return Address(location=args.value[1:-1], quoted=True)
 
     def STRING_CHARS(self, args) -> str:
         return args.value
@@ -1010,7 +1013,7 @@ class ParseToObjects(Transformer):
 
     @v_args(meta=True)
     def address(self, meta: Meta, args):
-        return Address(location=args[0])
+        return args[0]
 
     @v_args(meta=True)
     def query(self, meta: Meta, args):

{pytrilogy-0.0.2.5 → pytrilogy-0.0.2.7}/trilogy/parsing/trilogy.lark

@@ -39,7 +39,7 @@
     
     grain_clause: "grain" "(" column_list ")"
     
-    address: "address" ADDRESS
+    address: "address" (QUOTED_ADDRESS | ADDRESS)
     
     query: "query" MULTILINE_STRING
     
@@ -258,7 +258,8 @@
     // base language constructs
     concept_lit: IDENTIFIER
     IDENTIFIER: /[a-zA-Z\_][a-zA-Z0-9\_\-\.\-]*/
-    ADDRESS: IDENTIFIER | /`[a-zA-Z\_][a-zA-Z0-9\_\-\.\-\*]*`/
+    QUOTED_ADDRESS:  /`[a-zA-Z\_][a-zA-Z0-9\_\-\.\-\*\:]*`/
+    ADDRESS: IDENTIFIER
 
     MULTILINE_STRING: /\'{3}(.*?)\'{3}/s