python-qube-heatpump 1.16.0__tar.gz → 1.16.1__tar.gz

{python_qube_heatpump-1.16.0 → python_qube_heatpump-1.16.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: python-qube-heatpump
-Version: 1.16.0
+Version: 1.16.1
 Summary: Async Modbus client for Qube Heat Pumps
 Project-URL: Homepage, https://github.com/MattieGit/python-qube-heatpump
 Project-URL: Bug Tracker, https://github.com/MattieGit/python-qube-heatpump/issues

{python_qube_heatpump-1.16.0 → python_qube_heatpump-1.16.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "python-qube-heatpump"
-version = "1.16.0"
+version = "1.16.1"
 authors = [
   { name="MattieGit", email="6250046+MattieGit@users.noreply.github.com" },
 ]

{python_qube_heatpump-1.16.0 → python_qube_heatpump-1.16.1}/src/python_qube_heatpump/client.py

@@ -394,10 +394,12 @@ class QubeClient:
         Reads InputRegister 77 (GeneralMng.Softversion).
 
         Returns:
-            Version as string (e.g., "2.15"), or None on error.
+            Version as string (e.g., "2.15"), or None on error or when the
+            register reads 0 (it is not populated on some firmware, e.g.
+            4.1.00; use ``async_get_device_info`` for the panel version).
         """
         value = await self.read_value(const.SOFTWARE_VERSION)
-        if value is None:
+        if not value:
             return None
         return f"{value:.2f}"
 

{python_qube_heatpump-1.16.0 → python_qube_heatpump-1.16.1}/tests/test_client.py

@@ -246,6 +246,23 @@ async def test_get_software_version(mock_modbus_client):
     assert isinstance(result, str)
 
 
+@pytest.mark.asyncio
+async def test_get_software_version_zero(mock_modbus_client):
+    """Test an unpopulated register (reads 0) returns None, not "0.00"."""
+    client = QubeClient("1.2.3.4", 502)
+    mock_instance = mock_modbus_client.return_value
+
+    mock_resp = MagicMock()
+    mock_resp.isError.return_value = False
+    mock_resp.registers = [0, 0]
+
+    mock_instance.read_input_registers = AsyncMock(return_value=mock_resp)
+    client._client = mock_instance
+
+    result = await client.async_get_software_version()
+    assert result is None
+
+
 @pytest.mark.asyncio
 async def test_get_software_version_error(mock_modbus_client):
     """Test software version returns None on error."""