python-pooldose 0.8.0__tar.gz → 0.8.2__tar.gz

{python_pooldose-0.8.0 → python_pooldose-0.8.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-pooldose
-Version: 0.8.0
+Version: 0.8.2
 Summary: Unoffical async Python client for SEKO PoolDose devices
 Author-email: Lukas Maertin <pypi@lukas-maertin.de>
 License-Expression: MIT
@@ -918,6 +918,7 @@ This package is **PEP-561 compliant** and fully typed for use in Home Assistant
 
 **PEP-561 Compliance**: Package includes `py.typed` file marking it as fully typed  
 **Comprehensive Type Annotations**: All public API methods have complete type hints  
+**Type Constants**: Centralized `VALUE_TYPE_*` constants eliminate string literals for entity types  
 **mypy Support**: Built-in mypy configuration for static type checking  
 **Home Assistant Ready**: Compatible with Home Assistant's strict typing requirements  
 
@@ -985,6 +986,6 @@ Data Classification:
 
 For detailed release notes and version history, please see [CHANGELOG.md](CHANGELOG.md).
 
-### Latest Release (0.8.0)
+### Latest Release (0.8.2)
 
-- **Entity Type Refinement**: `flow_rate_value` renamed to `flow_rate`
+- **Type Constants**: centralized runtime constants for platform types

{python_pooldose-0.8.0 → python_pooldose-0.8.2}/README.md

@@ -899,6 +899,7 @@ This package is **PEP-561 compliant** and fully typed for use in Home Assistant
 
 **PEP-561 Compliance**: Package includes `py.typed` file marking it as fully typed  
 **Comprehensive Type Annotations**: All public API methods have complete type hints  
+**Type Constants**: Centralized `VALUE_TYPE_*` constants eliminate string literals for entity types  
 **mypy Support**: Built-in mypy configuration for static type checking  
 **Home Assistant Ready**: Compatible with Home Assistant's strict typing requirements  
 
@@ -966,6 +967,6 @@ Data Classification:
 
 For detailed release notes and version history, please see [CHANGELOG.md](CHANGELOG.md).
 
-### Latest Release (0.8.0)
+### Latest Release (0.8.2)
 
-- **Entity Type Refinement**: `flow_rate_value` renamed to `flow_rate`
+- **Type Constants**: centralized runtime constants for platform types

{python_pooldose-0.8.0 → python_pooldose-0.8.2}/src/pooldose/__init__.py

@@ -1,5 +1,5 @@
 """Async API client for SEKO Pooldose."""
 from .client import PooldoseClient
 
-__version__ = "0.8.0"
+__version__ = "0.8.2"
 __all__ = ["PooldoseClient"]

{python_pooldose-0.8.0 → python_pooldose-0.8.2}/src/pooldose/mappings/mapping_info.py

@@ -9,6 +9,13 @@ from typing import Any, Dict, List, Optional
 import aiofiles
 
 from pooldose.request_handler import RequestStatus
+from pooldose.type_definitions import (
+    VALUE_TYPE_SENSOR,
+    VALUE_TYPE_BINARY_SENSOR,
+    VALUE_TYPE_NUMBER,
+    VALUE_TYPE_SWITCH,
+    VALUE_TYPE_SELECT,
+)
 
 # pylint: disable=line-too-long
 
@@ -139,7 +146,7 @@ class MappingInfo:
             return {}
         result = {}
         for name, entry in self.mapping.items():
-            if entry.get("type") == "sensor":
+            if entry.get("type") == VALUE_TYPE_SENSOR:
                 result[name] = SensorMapping(
                     key=entry["key"],
                     type=entry["type"],
@@ -158,7 +165,7 @@ class MappingInfo:
             return {}
         result = {}
         for name, entry in self.mapping.items():
-            if entry.get("type") == "binary_sensor":
+            if entry.get("type") == VALUE_TYPE_BINARY_SENSOR:
                 result[name] = BinarySensorMapping(
                     key=entry["key"],
                     type=entry["type"],
@@ -176,7 +183,7 @@ class MappingInfo:
             return {}
         result = {}
         for name, entry in self.mapping.items():
-            if entry.get("type") == "number":
+            if entry.get("type") == VALUE_TYPE_NUMBER:
                 result[name] = NumberMapping(
                     key=entry["key"],
                     type=entry["type"],
@@ -194,7 +201,7 @@ class MappingInfo:
             return {}
         result = {}
         for name, entry in self.mapping.items():
-            if entry.get("type") == "switch":
+            if entry.get("type") == VALUE_TYPE_SWITCH:
                 result[name] = SwitchMapping(
                     key=entry["key"],
                     type=entry["type"],
@@ -214,7 +221,7 @@ class MappingInfo:
             return {}
         result = {}
         for name, entry in self.mapping.items():
-            if entry.get("type") == "select":
+            if entry.get("type") == VALUE_TYPE_SELECT:
                 result[name] = SelectMapping(
                     key=entry["key"],
                     type=entry["type"],

{python_pooldose-0.8.0 → python_pooldose-0.8.2}/src/pooldose/mappings/model_PDHC1H1HAR1V1_FW539224.json

@@ -119,22 +119,22 @@
     "type": "number",
     "field": "maxT"
   },
-  "orp_ph_lower": {
+  "ofa_orp_lower": {
     "key": "w_1g1l13bkn",
     "type": "number",
     "field": "minT"
   },
-  "orp_ph_upper": {
+  "ofa_orp_upper": {
     "key": "w_1g1l13bkn",
     "type": "number",
     "field": "maxT"
   },
-  "cl_ph_lower": {
+  "ofa_cl_lower": {
     "key": "w_1g1l13dke",
     "type": "number",
     "field": "minT"
   },
-  "cl_ph_upper": {
+  "ofa_cl_upper": {
     "key": "w_1g1l13dke",
     "type": "number",
     "field": "maxT"

{python_pooldose-0.8.0 → python_pooldose-0.8.2}/src/pooldose/type_definitions.py

@@ -1,6 +1,6 @@
 """Type definitions for the pooldose package."""
 
-from typing import Any, Dict, Final, List, Literal, Optional, TypedDict
+from typing import Any, Dict, Final, List, Optional, TypedDict
 
 # Device information types
 class DeviceInfoDict(TypedDict, total=False):
@@ -39,14 +39,14 @@ class MappingDict(TypedDict):
 class ValueDict(TypedDict, total=False):
     """Type definition for a value entry."""
     type: str
-    value: Any
+    value: float | int | str
     unit: str
-    raw_value: Any
+    raw_value: float | int | str
     status: str
     timestamp: int
-    min: Any
-    max: Any
-    step: Any
+    min: float | int
+    max: float | int
+    step: float | int
 
 # Structured values by type
 class StructuredValuesDict(TypedDict, total=False):
@@ -93,5 +93,9 @@ class NetworkInfoDict(TypedDict, total=False):
     OWNERID: str
     GROUPNAME: str
 
-# Constants
-SUPPORTED_VALUE_TYPES: Final = Literal["sensor", "switch", "number", "binary_sensor", "select"]  # pylint: disable=invalid-name
+# Platform type constants
+VALUE_TYPE_SENSOR: Final[str] = "sensor"
+VALUE_TYPE_SWITCH: Final[str] = "switch"
+VALUE_TYPE_NUMBER: Final[str] = "number"
+VALUE_TYPE_BINARY_SENSOR: Final[str] = "binary_sensor"
+VALUE_TYPE_SELECT: Final[str] = "select"

{python_pooldose-0.8.0 → python_pooldose-0.8.2}/src/pooldose/values/instant_values.py

@@ -3,7 +3,14 @@
 import logging
 from typing import Any, Dict, Tuple, Union
 
-from pooldose.type_definitions import StructuredValuesDict
+from pooldose.type_definitions import (
+    StructuredValuesDict,
+    VALUE_TYPE_SENSOR,
+    VALUE_TYPE_SWITCH,
+    VALUE_TYPE_NUMBER,
+    VALUE_TYPE_BINARY_SENSOR,
+    VALUE_TYPE_SELECT,
+)
 
 
 # pylint: disable=line-too-long,too-many-arguments,too-many-positional-arguments,too-many-locals,too-many-return-statements,too-many-branches,no-else-return,too-many-public-methods
@@ -109,19 +116,19 @@ class InstantValues:
                 continue
 
             # Initialize type section if needed - use string literals for TypedDict
-            if entry_type == "sensor":
+            if entry_type == VALUE_TYPE_SENSOR:
                 if "sensor" not in structured_data:
                     structured_data["sensor"] = {}
-            elif entry_type == "switch":
+            elif entry_type == VALUE_TYPE_SWITCH:
                 if "switch" not in structured_data:
                     structured_data["switch"] = {}
-            elif entry_type == "number":
+            elif entry_type == VALUE_TYPE_NUMBER:
                 if "number" not in structured_data:
                     structured_data["number"] = {}
-            elif entry_type == "binary_sensor":
+            elif entry_type == VALUE_TYPE_BINARY_SENSOR:
                 if "binary_sensor" not in structured_data:
                     structured_data["binary_sensor"] = {}
-            elif entry_type == "select":
+            elif entry_type == VALUE_TYPE_SELECT:
                 if "select" not in structured_data:
                     structured_data["select"] = {}
 
@@ -132,24 +139,24 @@ class InstantValues:
                     continue
 
                 # Structure the data based on type - use string literals for TypedDict
-                if entry_type == "sensor":
+                if entry_type == VALUE_TYPE_SENSOR:
                     if isinstance(value_data, tuple) and len(value_data) >= 2:
                         structured_data["sensor"][mapping_key] = {
                             "value": value_data[0],
                             "unit": value_data[1]
                         }
 
-                elif entry_type == "binary_sensor":
+                elif entry_type == VALUE_TYPE_BINARY_SENSOR:
                     structured_data["binary_sensor"][mapping_key] = {
                         "value": value_data
                     }
 
-                elif entry_type == "switch":
+                elif entry_type == VALUE_TYPE_SWITCH:
                     structured_data["switch"][mapping_key] = {
                         "value": value_data
                     }
 
-                elif entry_type == "number":
+                elif entry_type == VALUE_TYPE_NUMBER:
                     if isinstance(value_data, tuple) and len(value_data) >= 5:
                         structured_data["number"][mapping_key] = {
                             "value": value_data[0],
@@ -159,7 +166,7 @@ class InstantValues:
                             "step": value_data[4]
                         }
 
-                elif entry_type == "select":
+                elif entry_type == VALUE_TYPE_SELECT:
                     structured_data["select"][mapping_key] = {
                         "value": value_data
                     }
@@ -216,15 +223,15 @@ class InstantValues:
                 return None
 
             # Process based on entry type
-            if entry_type == "sensor":
+            if entry_type == VALUE_TYPE_SENSOR:
                 return self._process_sensor_value(raw_entry, attributes, name)
-            elif entry_type == "binary_sensor":
+            elif entry_type == VALUE_TYPE_BINARY_SENSOR:
                 return self._process_binary_sensor_value(raw_entry, attributes, name)
-            elif entry_type == "switch":
+            elif entry_type == VALUE_TYPE_SWITCH:
                 return self._process_switch_value(raw_entry, name)
-            elif entry_type == "number":
+            elif entry_type == VALUE_TYPE_NUMBER:
                 return self._process_number_value(raw_entry, name)
-            elif entry_type == "select":
+            elif entry_type == VALUE_TYPE_SELECT:
                 return self._process_select_value(raw_entry, attributes)
             else:
                 _LOGGER.warning("Unknown type '%s' for key '%s'", entry_type, name)
@@ -251,6 +258,9 @@ class InstantValues:
         # Get unit
         units = raw_entry.get("magnitude", [""])
         unit = units[0] if units and units[0].lower() not in ("undefined", "ph") else None
+        # Convert CL2/Chlorine to ppm
+        if unit and unit.lower() in ("cl2", "chlorine"):
+            unit = "ppm"
 
         return (value, unit)
 
@@ -318,6 +328,9 @@ class InstantValues:
         # Get unit
         units = raw_entry.get("magnitude", [""])
         unit = units[0] if isinstance(units, (list, tuple)) and units and str(units[0]).lower() not in ("undefined", "ph") else None
+        # Convert CL2/Chlorine to ppm
+        if unit and str(unit).lower() in ("cl2", "chlorine"):
+            unit = "ppm"
 
         return (value, unit, abs_min, abs_max, resolution)
 
@@ -351,7 +364,7 @@ class InstantValues:
 
     async def set_number(self, key: str, value: Any) -> bool:
         """Set number value with validation and device update."""
-        if key not in self._mapping or self._mapping[key].get("type") != "number":
+        if key not in self._mapping or self._mapping[key].get("type") != VALUE_TYPE_NUMBER:
             _LOGGER.warning("Key '%s' is not a valid number", key)
             return False
 
@@ -399,7 +412,7 @@ class InstantValues:
 
     async def set_switch(self, key: str, value: bool) -> bool:
         """Set switch value with validation and device update."""
-        if key not in self._mapping or self._mapping[key].get("type") != "switch":
+        if key not in self._mapping or self._mapping[key].get("type") != VALUE_TYPE_SWITCH:
             _LOGGER.warning("Key '%s' is not a valid switch", key)
             return False
         try:
@@ -420,7 +433,7 @@ class InstantValues:
 
     async def set_select(self, key: str, value: Any) -> bool:
         """Set select value with validation and device update."""
-        if key not in self._mapping or self._mapping[key].get("type") != "select":
+        if key not in self._mapping or self._mapping[key].get("type") != VALUE_TYPE_SELECT:
             _LOGGER.warning("Key '%s' is not a valid select", key)
             return False
         try:
@@ -462,7 +475,7 @@ class InstantValues:
         corresponding_field = "maxT" if field == "minT" else "minT"
         # Search for the mapping entry with the corresponding field
         for k, v in self._mapping.items():
-            if v.get("type") == "number" and v.get("field") == corresponding_field and v.get("key") == attributes.get("key"):
+            if v.get("type") == VALUE_TYPE_NUMBER and v.get("field") == corresponding_field and v.get("key") == attributes.get("key"):
                 val = self[k]
                 return val[0] if isinstance(val, tuple) else val
         # Fallback: get from raw device entry if not found in mapping

{python_pooldose-0.8.0 → python_pooldose-0.8.2}/src/python_pooldose.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-pooldose
-Version: 0.8.0
+Version: 0.8.2
 Summary: Unoffical async Python client for SEKO PoolDose devices
 Author-email: Lukas Maertin <pypi@lukas-maertin.de>
 License-Expression: MIT
@@ -918,6 +918,7 @@ This package is **PEP-561 compliant** and fully typed for use in Home Assistant
 
 **PEP-561 Compliance**: Package includes `py.typed` file marking it as fully typed  
 **Comprehensive Type Annotations**: All public API methods have complete type hints  
+**Type Constants**: Centralized `VALUE_TYPE_*` constants eliminate string literals for entity types  
 **mypy Support**: Built-in mypy configuration for static type checking  
 **Home Assistant Ready**: Compatible with Home Assistant's strict typing requirements  
 
@@ -985,6 +986,6 @@ Data Classification:
 
 For detailed release notes and version history, please see [CHANGELOG.md](CHANGELOG.md).
 
-### Latest Release (0.8.0)
+### Latest Release (0.8.2)
 
-- **Entity Type Refinement**: `flow_rate_value` renamed to `flow_rate`
+- **Type Constants**: centralized runtime constants for platform types

{python_pooldose-0.8.0 → python_pooldose-0.8.2}/tests/test_instant_values.py

@@ -20,6 +20,12 @@ class TestInstantValues:  # pylint: disable=too-many-public-methods
         assert value == 25.5
         assert unit == "°C"
 
+    def test_getitem_sensor_chlorine_unit(self, instant_values_fixture):
+        """Test getting chlorine sensor values with ppm unit conversion."""
+        value, unit = instant_values_fixture["chlorine"]
+        assert value == 0.5
+        assert unit == "ppm"
+
     def test_getitem_sensor_with_conversion(self, instant_values_fixture):
         """Test getting sensor values with string conversion."""
         value, unit = instant_values_fixture["ph_type_dosing"]
@@ -35,6 +41,15 @@ class TestInstantValues:  # pylint: disable=too-many-public-methods
         assert max_val == 8.0
         assert step == 0.1
 
+    def test_getitem_number_chlorine_unit(self, instant_values_fixture):
+        """Test getting chlorine number values with ppm unit conversion."""
+        value, unit, min_val, max_val, step = instant_values_fixture["chlorine_target"]
+        assert value == 0.6
+        assert unit == "ppm"
+        assert min_val == 0.3
+        assert max_val == 3.0
+        assert step == 0.1
+
     def test_getitem_switch(self, instant_values_fixture):
         """Test getting switch values."""
         value = instant_values_fixture["pump_switch"]