python-openstackclient 6.2.0__tar.gz → 6.2.1__tar.gz

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1}/.zuul.yaml

@@ -1,42 +1,4 @@
 ---
-- job:
-    name: osc-tox-unit-tips
-    parent: openstack-tox
-    description: |
-      Run unit tests for OpenStackClient with master branch of important libs.
-
-      Takes advantage of the base tox job's install-siblings feature.
-    required-projects:
-      - openstack/cliff
-      - openstack/keystoneauth
-      - openstack/openstacksdk
-      - openstack/osc-lib
-      - openstack/python-openstackclient
-    vars:
-      # Set work dir to openstackclient so that if it's triggered by one of the
-      # other repos the tests will run in the same place
-      zuul_work_dir: src/opendev.org/openstack/python-openstackclient
-
-- job:
-    name: osc-tox-py38-tips
-    parent: openstack-tox-py38
-    description: |
-      Run unit tests for OpenStackClient with master branch of important libs.
-
-      Takes advantage of the base tox job's install-siblings feature.
-    # The job only tests the latest and shouldn't be run on the stable branches
-    branches: ^(?!stable)
-    required-projects:
-      - openstack/cliff
-      - openstack/keystoneauth
-      - openstack/openstacksdk
-      - openstack/osc-lib
-      - openstack/python-openstackclient
-    vars:
-      # Set work dir to openstackclient so that if it's triggered by one of the
-      # other repos the tests will run in the same place
-      zuul_work_dir: src/opendev.org/openstack/python-openstackclient
-
 - job:
     name: osc-functional-devstack
     parent: devstack-tox-functional
@@ -99,26 +61,6 @@
       tox_envlist: functional
       zuul_work_dir: src/opendev.org/openstack/python-openstackclient
 
-- job:
-    name: osc-functional-devstack-tips
-    parent: osc-functional-devstack
-    description: |
-      Run functional tests for OpenStackClient with master branch of important libs.
-
-      Takes advantage of the base tox job's install-siblings feature.
-    timeout: 7800
-    required-projects:
-      - openstack/cliff
-      - openstack/keystoneauth
-      - openstack/openstacksdk
-      - openstack/osc-lib
-      - openstack/python-openstackclient
-    vars:
-      devstack_localrc:
-        LIBS_FROM_GIT: python-openstackclient,openstacksdk,osc-lib,cliff
-      tox_envlist: functional
-      tox_install_siblings: true
-
 - secret:
     name: osc-dockerhub
     data:
@@ -177,19 +119,9 @@
       nodes: []
     vars: *osc_image_vars
 
-- project-template:
-    name: osc-tox-unit-tips
-    check:
-      jobs:
-        - osc-tox-py38-tips
-    gate:
-      jobs:
-        - osc-tox-py38-tips
-
 - project:
     templates:
       - openstackclient-plugin-jobs
-      - osc-tox-unit-tips
       - openstack-cover-jobs
       - openstack-python3-jobs
       - publish-openstack-docs-pti
@@ -199,10 +131,6 @@
       jobs:
         - osc-build-image
         - osc-functional-devstack
-        - osc-functional-devstack-tips:
-            # The functional-tips job only tests the latest and shouldn't be run
-            # on the stable branches
-            branches: ^(?!stable)
     gate:
       jobs:
         - osc-upload-image

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1}/AUTHORS

@@ -110,6 +110,7 @@ Doug Hellmann <doug.hellmann@dreamhost.com>
 Doug Hellmann <doug@doughellmann.com>
 Doug Wiegley <dwiegley@salesforce.com>
 Dougal Matthews <dougal@redhat.com>
+Douglas Mendizábal <dmendiza@redhat.com>
 Dr. Jens Harbott <harbott@osism.tech>
 Einst Crazy <yu.changcai@99cloud.net>
 Elena Ezhova <eezhova@mirantis.com>

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1}/ChangeLog

@@ -1,6 +1,15 @@
 CHANGES
 =======
 
+6.2.1
+-----
+
+* [stable-only] CI: Drop all tips jobs
+* Fix "access rule" commands to only use ID
+* Fix pep issue in the network service provider
+* Update TOX\_CONSTRAINTS\_FILE for stable/2023.1
+* Update .gitreview for stable/2023.1
+
 6.2.0
 -----
 

{python-openstackclient-6.2.0/python_openstackclient.egg-info → python-openstackclient-6.2.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 1.2
 Name: python-openstackclient
-Version: 6.2.0
+Version: 6.2.1
 Summary: OpenStack Command-line Client
 Home-page: https://docs.openstack.org/python-openstackclient/latest/
 Author: OpenStack

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1}/openstackclient/identity/common.py

@@ -87,6 +87,18 @@ def get_resource(manager, name_type_or_id):
         raise exceptions.CommandError(msg % name_type_or_id)
 
 
+def get_resource_by_id(manager, resource_id):
+    """Get resource by ID
+
+    Raises CommandError if the resource is not found
+    """
+    try:
+        return manager.get(resource_id)
+    except identity_exc.NotFound:
+        msg = _("Resource with id {} not found")
+        raise exceptions.CommandError(msg.format(resource_id))
+
+
 def _get_token_resource(client, resource, parsed_name, parsed_domain=None):
     """Peek into the user's auth token to get resource IDs
 

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1}/openstackclient/identity/v3/access_rule.py

@@ -37,7 +37,7 @@ class DeleteAccessRule(command.Command):
             'access_rule',
             metavar='<access-rule>',
             nargs="+",
-            help=_('Access rule(s) to delete (name or ID)'),
+            help=_('Access rule ID(s) to delete'),
         )
         return parser
 
@@ -47,8 +47,9 @@ class DeleteAccessRule(command.Command):
         errors = 0
         for ac in parsed_args.access_rule:
             try:
-                access_rule = utils.find_resource(
-                    identity_client.access_rules, ac)
+                access_rule = common.get_resource_by_id(
+                    identity_client.access_rules, ac
+                )
                 identity_client.access_rules.delete(access_rule.id)
             except Exception as e:
                 errors += 1
@@ -103,14 +104,15 @@ class ShowAccessRule(command.ShowOne):
         parser.add_argument(
             'access_rule',
             metavar='<access-rule>',
-            help=_('Access rule to display (name or ID)'),
+            help=_('Access rule ID to display'),
         )
         return parser
 
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
-        access_rule = utils.find_resource(identity_client.access_rules,
-                                          parsed_args.access_rule)
+        access_rule = common.get_resource_by_id(
+            identity_client.access_rules, parsed_args.access_rule
+        )
 
         access_rule._info.pop('links', None)
 

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1}/openstackclient/network/v2/network_service_provider.py

@@ -26,18 +26,24 @@ class ListNetworkServiceProvider(command.Lister):
         client = self.app.client_manager.network
 
         columns = (
-            'service_type',
-            'name',
-            'is_default',
+            "service_type",
+            "name",
+            "is_default",
         )
         column_headers = (
-            'Service Type',
-            'Name',
-            'Default',
+            "Service Type",
+            "Name",
+            "Default",
         )
 
         data = client.service_providers()
-        return(column_headers,
-               (utils.get_item_properties(
-                   s, columns,
-               ) for s in data))
+        return (
+            column_headers,
+            (
+                utils.get_item_properties(
+                    s,
+                    columns,
+                )
+                for s in data
+            ),
+        )

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1}/openstackclient/tests/unit/identity/v3/test_access_rule.py

@@ -14,10 +14,9 @@
 #
 
 import copy
-from unittest import mock
 
+from keystoneclient import exceptions as identity_exc
 from osc_lib import exceptions
-from osc_lib import utils
 
 from openstackclient.identity.v3 import access_rule
 from openstackclient.tests.unit import fakes
@@ -69,10 +68,13 @@ class TestAccessRuleDelete(TestAccessRule):
         )
         self.assertIsNone(result)
 
-    @mock.patch.object(utils, 'find_resource')
-    def test_delete_multi_access_rules_with_exception(self, find_mock):
-        find_mock.side_effect = [self.access_rules_mock.get.return_value,
-                                 exceptions.CommandError]
+    def test_delete_multi_access_rules_with_exception(self):
+        # mock returns for common.get_resource_by_id
+        mock_get = self.access_rules_mock.get
+        mock_get.side_effect = [
+            mock_get.return_value,
+            identity_exc.NotFound,
+        ]
         arglist = [
             identity_fakes.access_rule_id,
             'nonexistent_access_rule',
@@ -89,12 +91,10 @@ class TestAccessRuleDelete(TestAccessRule):
             self.assertEqual('1 of 2 access rules failed to'
                              ' delete.', str(e))
 
-        find_mock.assert_any_call(self.access_rules_mock,
-                                  identity_fakes.access_rule_id)
-        find_mock.assert_any_call(self.access_rules_mock,
-                                  'nonexistent_access_rule')
+        mock_get.assert_any_call(identity_fakes.access_rule_id)
+        mock_get.assert_any_call('nonexistent_access_rule')
 
-        self.assertEqual(2, find_mock.call_count)
+        self.assertEqual(2, mock_get.call_count)
         self.access_rules_mock.delete.assert_called_once_with(
             identity_fakes.access_rule_id)
 

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1/python_openstackclient.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 1.2
 Name: python-openstackclient
-Version: 6.2.0
+Version: 6.2.1
 Summary: OpenStack Command-line Client
 Home-page: https://docs.openstack.org/python-openstackclient/latest/
 Author: OpenStack

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1}/python_openstackclient.egg-info/SOURCES.txt

@@ -1125,6 +1125,7 @@ releasenotes/notes/fix-image-create-from-volume-c573e553161605c4.yaml
 releasenotes/notes/fix-network-rbac-create-d1f4de77ad2dd421.yaml
 releasenotes/notes/fix-openstak-image-save-sdk-port-eb160e8ffc92e514.yaml
 releasenotes/notes/fix-story-2007890-0974f3e69f26801e.yaml
+releasenotes/notes/fix-story-2010775-953dbdf03b2b6746.yaml
 releasenotes/notes/flavor-add-description-b618abd4a7fb6545.yaml
 releasenotes/notes/flavor-create-with-project-19d41bfa93e3c6d0.yaml
 releasenotes/notes/flavor-list-min-disk-min-ram-65ba35e7acc24134.yaml

python-openstackclient-6.2.1/python_openstackclient.egg-info/pbr.json

@@ -0,0 +1 @@
+{"git_version": "02172959", "is_release": true}

python-openstackclient-6.2.1/releasenotes/notes/fix-story-2010775-953dbdf03b2b6746.yaml

@@ -0,0 +1,8 @@
+---
+fixes:
+  - |
+    Fixed a bug in "access rule" subcommands where the client logic incorrectly
+    assumed that access rules have a "name" property which resulted in
+    unpredictable behaviors.  e.g. "access rule delete {non-existent-id}" now
+    results in a not-found error instead of sometimes deleting an unrelated
+    rule.

{python-openstackclient-6.2.0 → python-openstackclient-6.2.1}/tox.ini

@@ -15,7 +15,7 @@ setenv =
     OS_STDERR_CAPTURE=1
     OS_TEST_TIMEOUT=60
 deps =
-    -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
+    -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/2023.1}
     -r{toxinidir}/test-requirements.txt
     -r{toxinidir}/requirements.txt
 commands = stestr run {posargs}
@@ -98,7 +98,7 @@ commands =
 
 [testenv:venv]
 deps =
-  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
+  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/2023.1}
   -r{toxinidir}/requirements.txt
   -r{toxinidir}/doc/requirements.txt
 commands = {posargs}
@@ -121,7 +121,7 @@ commands =
 
 [testenv:docs]
 deps =
-  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
+  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/2023.1}
   -r{toxinidir}/doc/requirements.txt
 commands =
   sphinx-build -a -E -W -d doc/build/doctrees -b html doc/source doc/build/html
@@ -131,7 +131,7 @@ commands =
 
 [testenv:releasenotes]
 deps =
-  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
+  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/2023.1}
   -r{toxinidir}/doc/requirements.txt
 commands =
   sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html

python-openstackclient-6.2.0/python_openstackclient.egg-info/pbr.json

@@ -1 +0,0 @@
-{"git_version": "05d34ffc", "is_release": true}