python-openpublictransport 0.1.10__tar.gz → 0.1.11__tar.gz

{python_openpublictransport-0.1.10 → python_openpublictransport-0.1.11}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-openpublictransport
-Version: 0.1.10
+Version: 0.1.11
 Summary: Python library for public transport APIs (EFA, OTP2, TRIAS, FPTF, HAFAS, GTFS-RT)
 License: MIT
 Requires-Python: >=3.11

{python_openpublictransport-0.1.10 → python_openpublictransport-0.1.11}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "python-openpublictransport"
-version = "0.1.10"
+version = "0.1.11"
 description = "Python library for public transport APIs (EFA, OTP2, TRIAS, FPTF, HAFAS, GTFS-RT)"
 readme = "README.md"
 license = { text = "MIT" }

{python_openpublictransport-0.1.10 → python_openpublictransport-0.1.11}/src/openpublictransport/providers/national_rail.py

@@ -320,8 +320,11 @@ class NationalRailProvider(BaseProvider):
         """Find UK railway stations with their CRS codes.
 
         The live Overpass API (OpenStreetMap) is the source of truth. Only if it
-        is unreachable, rate-limited, or returns nothing do we fall back to a
-        bundled offline snapshot — see :func:`_load_static_stations`.
+        is unreachable or rate-limited (a *failure*, not a successful empty
+        result) do we fall back to a bundled offline snapshot — see
+        :func:`_load_static_stations`. When Overpass succeeds and legitimately
+        finds nothing, we return that empty result rather than serving
+        potentially out-of-date snapshot data.
 
         A search term that looks like a 3-letter CRS code (e.g. "WIN", "RDG")
         is matched directly against the CRS code; anything else is matched
@@ -332,14 +335,15 @@ class NationalRailProvider(BaseProvider):
             return []
 
         results = await self._search_overpass(term)
-        if results:
+        if results is not None:
+            # Overpass answered authoritatively (possibly with zero matches).
             return results
 
-        # Overpass down / throttled / empty → use the offline snapshot.
+        # Overpass failed (unreachable / throttled) → use the offline snapshot.
         fallback = self._search_static(term)
         if fallback:
             _LOGGER.info(
-                "%s: Overpass returned nothing for %r — served %d result(s) from the "
+                "%s: Overpass unavailable for %r — served %d result(s) from the "
                 "bundled station snapshot (may be out of date)",
                 self.provider_name,
                 term,
@@ -369,8 +373,13 @@ class NationalRailProvider(BaseProvider):
                         break
         return results[:10]
 
-    async def _search_overpass(self, term: str) -> List[Dict[str, Any]]:
-        """Query the live Overpass API for UK stations matching ``term``."""
+    async def _search_overpass(self, term: str) -> Optional[List[Dict[str, Any]]]:
+        """Query the live Overpass API for UK stations matching ``term``.
+
+        Returns a (possibly empty) list on a successful query, or ``None`` if
+        the request failed (non-200 / exception) so the caller can decide
+        whether to fall back to the offline snapshot.
+        """
         if re.fullmatch(r"[A-Za-z]{3}", term):
             # Direct CRS code lookup (ref:crs is stored uppercase in OSM)
             query = f"""[out:json][timeout:15];
@@ -397,11 +406,11 @@ out 10;"""
             ) as resp:
                 if resp.status != 200:
                     _LOGGER.warning("%s: Overpass HTTP %s", self.provider_name, resp.status)
-                    return []
+                    return None
                 data = await resp.json(content_type=None)
         except Exception as exc:
             _LOGGER.warning("%s: stop search failed: %s", self.provider_name, exc)
-            return []
+            return None
 
         results = []
         for element in data.get("elements", []):

{python_openpublictransport-0.1.10 → python_openpublictransport-0.1.11}/src/python_openpublictransport.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-openpublictransport
-Version: 0.1.10
+Version: 0.1.11
 Summary: Python library for public transport APIs (EFA, OTP2, TRIAS, FPTF, HAFAS, GTFS-RT)
 License: MIT
 Requires-Python: >=3.11

{python_openpublictransport-0.1.10 → python_openpublictransport-0.1.11}/tests/test_national_rail_static.py

@@ -34,6 +34,8 @@ class _Session:
         self.calls += 1
         if self.mode == "down":
             return _Resp(429, None)
+        if self.mode == "empty":
+            return _Resp(200, {"elements": []})
         payload = {
             "elements": [
                 {"tags": {"railway": "station", "ref:crs": "WIN",
@@ -45,7 +47,7 @@ class _Session:
 
 def test_snapshot_loads_and_has_known_stations():
     stations = nr._load_static_stations()
-    assert len(stations) > 2000
+    assert stations  # loads and is non-empty
     by_crs = {s["crs"]: s for s in stations}
     assert by_crs["WIN"]["name"] == "Winchester"
     assert by_crs["RDG"]["name"] == "Reading"
@@ -73,6 +75,15 @@ async def test_overpass_success_does_not_use_fallback():
     assert results[0]["name"] == "Winchester Overpass"
 
 
+async def test_overpass_empty_result_does_not_fall_back():
+    """A successful but empty Overpass result must NOT serve stale snapshot data."""
+    session = _Session("empty")
+    provider = NationalRailProvider(session)
+    results = await provider.search_stops("WIN")
+    assert session.calls == 1  # Overpass was queried
+    assert results == []  # authoritative "no match" — snapshot not consulted
+
+
 async def test_falls_back_to_snapshot_when_overpass_down():
     session = _Session("down")
     provider = NationalRailProvider(session)