python-mobius 0.8.3__tar.gz → 0.8.4__tar.gz

{python_mobius-0.8.3 → python_mobius-0.8.4}/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.8.4
+
+- Added `LightPollResult.lunar_enabled`/`lunar_phase_day`: the device's
+  own actual LunarPhasesEnabled setting and current lunar-cycle phase,
+  correct at any time of day. Not the same as
+  `intensities.diagnostics`'s own `lunar_enabled`/`lunar_date` keys,
+  which are only meaningful at night.
+
 ## 0.8.3
 
 - Added `set_lunar_enabled(enabled)`. Confirmed byte-for-byte against

{python_mobius-0.8.3 → python_mobius-0.8.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: python-mobius
-Version: 0.8.3
+Version: 0.8.4
 Summary: Reverse-engineered Python client for the Mobius BLE protocol (EcoTech Marine VorTech/Radion, AquaIllumination, Neptune Systems, NYOS)
 Project-URL: Homepage, https://code.r3pek.org/r3pek/python-mobius
 Project-URL: Documentation, https://code.r3pek.org/r3pek/python-mobius/src/branch/main/documentation

{python_mobius-0.8.3 → python_mobius-0.8.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "python-mobius"
-version = "0.8.3"
+version = "0.8.4"
 description = "Reverse-engineered Python client for the Mobius BLE protocol (EcoTech Marine VorTech/Radion, AquaIllumination, Neptune Systems, NYOS)"
 readme = "README.md"
 license = { text = "GPL-2.0-only" }

{python_mobius-0.8.3 → python_mobius-0.8.4}/src/mobius/__init__.py

@@ -82,7 +82,7 @@ from .mob import (
     MAX_PUMP_PRIMITIVE_SIZE,
 )
 
-__version__ = "0.8.3"
+__version__ = "0.8.4"
 
 __all__ = [
     "__version__",

{python_mobius-0.8.3 → python_mobius-0.8.4}/src/mobius/device.py

@@ -47,7 +47,7 @@ from .schedule import (
 )
 from .scenes import Scene, ActiveScene, decode_configured_scenes, decode_active_scene
 from .modifiers import (
-    AcclimationInfo, is_night_segment, lunar_percent_reduction,
+    AcclimationInfo, is_night_segment, lunar_percent_reduction, lunar_days_into_phase,
 )
 from .power import ChannelPowerInfo, channel_percent_value
 from .pump_status import PumpFlowRange, BatteryBackupInfo, BoostedBatteryInfo
@@ -163,6 +163,35 @@ class LightPollResult:
     # failed and decode_schedule_intensity() had truly nothing to fall
     # back to.
     schedule_intensity: Optional[float] = None
+    # The device's own raw LunarPhasesEnabled (907) setting -- confirmed
+    # against the app's own "Lunar" chip, whose on/off state this
+    # matches exactly, at any time of day.
+    #
+    # A second, real, confirmed bug lived here before this field
+    # existed, same shape as schedule_intensity's own bug above:
+    # intensities.diagnostics["lunar_enabled"] is NOT this. Read
+    # process_light_intensities()'s own source: outside the night
+    # segment, it unconditionally sets lunar_enabled = None ("not
+    # checked/relevant outside the night segment" -- true for ITS OWN
+    # calculation, since the toggle only affects anything during the
+    # night segment, but not true for a caller that wants to know the
+    # device's own current setting regardless of time of day). A
+    # caller reading diagnostics["lunar_enabled"] during the day always
+    # gets None, even when the device's own toggle is genuinely on --
+    # this field is the one that's always correct, any time of day.
+    lunar_enabled: Optional[bool] = None
+    # The current lunar-cycle phase day (0-29, lunar_days_into_phase()'s
+    # own "days since new moon" convention), for a caller that wants to
+    # display the current moon phase -- not the same thing as the raw
+    # date this is computed from (which is only useful internally, for
+    # the schedule's own night-segment reduction calculation, and isn't
+    # exposed here at all). Falls back to today's local date when the
+    # device itself didn't provide one (Epoch/LocalTime unavailable),
+    # matching process_light_intensities()'s own "local_fallback"
+    # philosophy, so this is populated whenever `now` itself is valid --
+    # which it always is, since callers of get_light_poll_batch() are
+    # required to supply it.
+    lunar_phase_day: Optional[int] = None
 
 
 @dataclass
@@ -565,6 +594,7 @@ def decode_light_poll_from_batch(
     )
     return LightPollResult(
         schedule_points=points, intensities=intensities, used_batch=True, schedule_intensity=schedule_intensity,
+        lunar_enabled=lunar_enabled, lunar_phase_day=lunar_days_into_phase(lunar_date or now.date()),
     )
 
 
@@ -3840,9 +3870,12 @@ class MobiusDevice:
         points = await self.get_light_schedule(which)
         intensities = await self.get_current_light_intensities(which, minute_of_day, now)
         schedule_intensity = await self.get_schedule_intensity(which)
+        lunar_enabled = await self.get_lunar_enabled(which)
+        lunar_date = await self.get_app_lunar_date()
         return LightPollResult(
             schedule_points=points, intensities=intensities, used_batch=False,
-            schedule_intensity=schedule_intensity,
+            schedule_intensity=schedule_intensity, lunar_enabled=lunar_enabled,
+            lunar_phase_day=lunar_days_into_phase(lunar_date or now.date()),
         )
 
     async def get_full_poll_batch(

{python_mobius-0.8.3 → python_mobius-0.8.4}/tests/test_light_poll_batch.py

@@ -11,12 +11,14 @@ invented data.
 """
 
 import datetime
+import struct
 
 import pytest
 from bleak.backends.device import BLEDevice
 
 from mobius import C2Attribute, AttributeValue, SupportedAttribute, VisualID, SchedulePoint
-from mobius.device import MobiusDevice
+from mobius.device import MobiusDevice, compute_app_lunar_date
+from mobius.modifiers import lunar_days_into_phase
 
 
 def _fake_ble_device():
@@ -137,26 +139,55 @@ async def test_night_segment_with_lunar_matches_individual_path_scenario():
     # must never be conflated.
     assert result.schedule_intensity == pytest.approx(0.897)
     assert result.schedule_intensity != intensities.diagnostics["scalar"]
+    # Same fields as the daytime test's own regression check -- here,
+    # where lunar reduction genuinely is in effect, they happen to
+    # agree with diagnostics, but they're still their own, independent
+    # fields (not simply forwarding diagnostics's own value).
+    assert result.lunar_enabled is True
+    # Epoch/LocalTime are deliberately absent in this scenario (see the
+    # comment above), so lunar_phase_day falls back to today's local
+    # date (matching process_light_intensities()'s own internal
+    # "local_fallback" philosophy) rather than being left unpopulated.
+    assert result.lunar_phase_day == lunar_days_into_phase(now.date())
 
 
 @pytest.mark.asyncio
 async def test_daytime_matches_individual_path_scenario():
     """Mirrors test_daytime_without_acclimation_uses_schedule_scalar_only
     in test_light_intensity_branching.py -- daytime, no acclimation
-    data supported, schedule_intensity present."""
+    data supported, schedule_intensity present.
+
+    Also the exact regression scenario for a second, real, confirmed
+    production bug (same shape as schedule_intensity's own above):
+    the device's own LunarPhasesEnabled toggle is genuinely on here
+    (matching a real user's own report -- the app's "Lunar" chip shows
+    enabled at all times of day, not just at night), but
+    process_light_intensities() itself unconditionally wipes
+    diagnostics["lunar_enabled"]/["lunar_date"] to None outside the
+    night segment (true for its own reduction-factor calculation,
+    since the toggle only affects anything during the night segment --
+    not true for a caller wanting the device's own current setting
+    regardless of time of day). result.lunar_enabled/lunar_date are
+    the fields that stay correct at any time of day."""
     device = MobiusDevice(_fake_ble_device())
 
     async def fake_get_attributes_batch(requests):
         return [
             _av(C2Attribute.Schedule1, 0, *_day_schedule()),
             _av(C2Attribute.Schedule1Intensity, 0, bytes.fromhex("2803")),  # 0x0328 = 808 -> 0.808
+            _av(C2Attribute.LunarPhasesEnabled, 0, bytes([1])),
+            _av(C2Attribute.Epoch, 0, struct.pack("<I", 1750000000)),
+            _av(C2Attribute.LocalTime, 0, struct.pack("<I", 1750000000)),
         ]
 
     device.get_attributes_batch = fake_get_attributes_batch
     now = datetime.datetime(2026, 6, 15, 12, 0)
     result = await device.get_light_poll_batch(
         minute_of_day=720, now=now,
-        supported_attribute_ids={C2Attribute.Schedule1, C2Attribute.Schedule1Intensity},
+        supported_attribute_ids={
+            C2Attribute.Schedule1, C2Attribute.Schedule1Intensity, C2Attribute.LunarPhasesEnabled,
+            C2Attribute.Epoch, C2Attribute.LocalTime,
+        },
     )
 
     assert result.used_batch is True
@@ -167,6 +198,13 @@ async def test_daytime_matches_individual_path_scenario():
     assert result.schedule_intensity == pytest.approx(0.808)
     # RoyalBlue=500 raw * 0.808 scalar
     assert intensities[VisualID.RoyalBlue] == pytest.approx(500 * 0.808)
+    # The actual regression: the device's own toggle is genuinely on,
+    # but diagnostics unconditionally wipes it to None outside the
+    # night segment -- these must never be conflated.
+    assert intensities.diagnostics["lunar_enabled"] is None
+    assert result.lunar_enabled is True
+    assert intensities.diagnostics["lunar_date"] is None
+    assert result.lunar_phase_day == lunar_days_into_phase(compute_app_lunar_date(1750000000, 1750000000))
 
 
 # --------------------------------------------------------------------------