python-mobius 0.1.0__tar.gz → 0.1.2__tar.gz

python_mobius-0.1.2/CHANGELOG.md

@@ -0,0 +1,69 @@
+# Changelog
+
+## 0.1.2
+
+- Added `manufacturer_for_model()` / `MODEL_MANUFACTURER` (ported from
+  `M.Model.getManufacturer()`) — surfaces "EcoTech Marine" /
+  "AquaIllumination" / "Neptune Systems" / "NYOS" per device model. Now
+  included automatically in `get_device_info()`'s `"manufacturer"` field.
+  Added while building a Home Assistant integration on top of this library,
+  which needs a manufacturer string for its device registry.
+- `get_device_info()`'s `"serial"` field is now decoded as ASCII text
+  instead of hex-encoded raw bytes (e.g. `"7V4Z00F143RBED"` instead of
+  `"3756345a30304631343352424544"`). Confirmed printable ASCII on every
+  device tested, via cross-validation against the same serial parsed from
+  BLE advertisement manufacturer data. Falls back to hex for any
+  non-printable-ASCII edge case not yet observed. Found while building the
+  Home Assistant integration on top of this library -- the hex-encoded
+  serial was producing unnecessarily long/ugly entity IDs.
+- `get_pump_telemetry()` now includes a confirmed `"speed_percent"` field
+  alongside the existing raw `"speed"`. `MotorSpeed` is confirmed (via the
+  decompiled app's own display code) to be a percentage of max pump power
+  in tenths of a percent, NOT RPM -- `String.format("%.0f%%",
+  Math.abs(currentSpeed / 10.0f))` is literally what the app does to this
+  exact value. `speed_percent` is that same `abs(speed)/10` conversion;
+  `speed` is still returned raw since its sign encodes rotation direction
+  (reverse), which `speed_percent` discards.
+- Fixed a real connection leak in `MobiusDevice.connect()`: if
+  `start_notify()` failed after the BLE connection was already
+  established (a known common flaky point right after a fresh connection),
+  the exception propagated out of `connect()` (`__aenter__`) -- and per the
+  async context manager protocol, a raising `__aenter__` means `__aexit__`
+  (and therefore `disconnect()`) is never called by the caller's `async
+  with` block. The already-open connection was left orphaned on the
+  adapter. Since callers like Home Assistant coordinators retry
+  periodically, this leak compounded over repeated failures, plausibly
+  exhausting a real adapter's connection-slot pool over time even with no
+  other integration competing for it and without any range/signal issue.
+  `connect()` now cleans up (disconnects) before re-raising if anything
+  fails after the connection is established. Added regression tests
+  confirming both the cleanup-on-failure and no-spurious-disconnect-on-
+  success behavior.
+
+## 0.1.0 — initial release
+
+- Core FSCI/C2CI wire protocol: framing, CRC16, Get/Set-attribute codec.
+  Verified byte-for-byte against real captured packets.
+- Scene control (`start_scene`, `start_feed_mode`, `resume_schedule`).
+- Pump telemetry (speed, estimated GPH) — verified live against real
+  VorTech MP40QD pumps.
+- Pump schedule reading (mode + parameters per time block) — verified live.
+- Light schedule reading + client-side interpolation, matching the app's
+  own behavior — verified live against real Radion XR15 G6 Pro lights.
+- Device discovery, identity (`get_device_info`), and a unified
+  `get_device_summary()` with explicit support tiers
+  (light / pump / pump-experimental / unsupported).
+- Advertisement-only discovery: model, serial, and `pan_id` (tank/mesh
+  grouping) with no GATT connection required — verified against 4 real
+  devices sharing one `pan_id`.
+- `mobius-scan` CLI.
+
+### Known gaps
+
+- `DoseV1` and `HotSauceV1` primitive types have no parser (see
+  `documentation/10-known-gaps-and-open-questions.md`).
+- `CoffeeV1` (NYOS Quantum) pump-primitive support is structurally
+  plausible but unverified against real hardware.
+- Thread/CoAP device-to-device relay (used by the official app to reach
+  devices without a direct BLE connection) is not implemented — this
+  library always connects directly to each device instead.

{python_mobius-0.1.0 → python_mobius-0.1.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-mobius
-Version: 0.1.0
+Version: 0.1.2
 Summary: Reverse-engineered Python client for the Mobius BLE protocol (EcoTech Marine VorTech/Radion, AquaIllumination, Neptune Systems, NYOS)
 Project-URL: Homepage, https://code.r3pek.org/r3pek/python-mobius
 Project-URL: Documentation, https://code.r3pek.org/r3pek/python-mobius/src/branch/main/documentation
@@ -24,6 +24,7 @@ Requires-Python: >=3.9
 Requires-Dist: bleak>=0.21
 Provides-Extra: dev
 Requires-Dist: bleak-retry-connector>=3.0; extra == 'dev'
+Requires-Dist: pytest-asyncio>=0.23; extra == 'dev'
 Requires-Dist: pytest>=7.0; extra == 'dev'
 Provides-Extra: retry
 Requires-Dist: bleak-retry-connector>=3.0; extra == 'retry'

{python_mobius-0.1.0 → python_mobius-0.1.2}/documentation/03-attributes-and-opcodes.md

@@ -87,7 +87,7 @@ against real pumps and lights returned correctly-structured, sane data.
 | `ErrorState` | 107 | See [04-device-identity.md](./04-device-identity.md) |
 | `CurrentScene` | 401 | Set to `sceneId(u16 LE) + durationMinutes(u16 LE)` to start a scene |
 | `Schedule1` / `Schedule2` | 500 / 503 | The programmed point-schedule — see 06/07 |
-| `MotorSpeed` | 700 | Live pump speed (int16) |
+| `MotorSpeed` | 700 | Live pump speed (int16). Confirmed NOT RPM -- percentage of max power in tenths of a percent (abs(value)/10 = %); sign encodes rotation direction. Confirmed via the app's own display code, `String.format("%.0f%%", Math.abs(currentSpeed / 10.0f))`. |
 | `SupportedColorChannels` | 901 | Static list of a light's channels |
 
 See `src/mobius/constants.py` for the complete implemented list.

{python_mobius-0.1.0 → python_mobius-0.1.2}/documentation/10-known-gaps-and-open-questions.md

@@ -34,6 +34,16 @@ included as a starting point.
 - **`MACAddress`** (attribute 103): returned empty/unpopulated on every
   device tested. Might be Thread/legacy-radio-only and simply not set on
   BLE-only-provisioned devices, or might need a different query context.
+- **The unit of `PhysicalValueID.GallonsPerHour`**: high confidence it's
+  genuinely US gallons per hour, not empirically flow-metered. Basis: (1)
+  the decompiled source's own attribute name is literally
+  `GallonsPerHour`, EcoTech's own naming, not an inference; (2) EcoTech is
+  a US company that markets VorTech flow exclusively in GPH; (3) real
+  captured values (2,272 and 2,877 GPH, both from the same partial-power
+  speed setting) land at roughly 45-65% of the MP40wQD's own published
+  4,500-5,000+ GPH max rating -- exactly the proportion expected for a
+  pump running below full power. No independent flow-meter verification
+  has been done against real hardware.
 
 ## Deliberately not implemented
 

{python_mobius-0.1.0 → python_mobius-0.1.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "python-mobius"
-version = "0.1.0"
+version = "0.1.2"
 description = "Reverse-engineered Python client for the Mobius BLE protocol (EcoTech Marine VorTech/Radion, AquaIllumination, Neptune Systems, NYOS)"
 readme = "README.md"
 license = { text = "GPL-2.0-only" }
@@ -35,7 +35,7 @@ dependencies = [
 
 [project.optional-dependencies]
 retry = ["bleak-retry-connector>=3.0"]
-dev = ["pytest>=7.0", "bleak-retry-connector>=3.0"]
+dev = ["pytest>=7.0", "pytest-asyncio>=0.23", "bleak-retry-connector>=3.0"]
 
 [project.scripts]
 mobius-scan = "mobius.cli:main"
@@ -50,3 +50,4 @@ packages = ["src/mobius"]
 
 [tool.pytest.ini_options]
 testpaths = ["tests"]
+asyncio_mode = "auto"

{python_mobius-0.1.0 → python_mobius-0.1.2}/src/mobius/__init__.py

@@ -23,7 +23,8 @@ from .frame import (
 from .constants import (
     PrimitiveType, PRIMITIVE_SIZE, LIGHT_PRIMITIVES,
     PUMP_PRIMITIVES_VERIFIED, PUMP_PRIMITIVES_EXPERIMENTAL,
-    Model, ErrorState, C2Attribute, PhysicalValueID, VisualID,
+    Model, MODEL_MANUFACTURER, manufacturer_for_model,
+    ErrorState, C2Attribute, PhysicalValueID, VisualID,
     SceneID, OperationState, FsciStatus,
     PumpMode, RampType, PumpParam, PUMP_PARAM_SIZE, PUMP_MODE_PARAMS,
 )
@@ -40,7 +41,7 @@ from .discovery import (
     scan_for_mobius_devices, scan_for_mobius_devices_with_info, group_by_pan_id,
 )
 
-__version__ = "0.1.0"
+__version__ = "0.1.2"
 
 __all__ = [
     "__version__",
@@ -57,7 +58,8 @@ __all__ = [
     # constants
     "PrimitiveType", "PRIMITIVE_SIZE", "LIGHT_PRIMITIVES",
     "PUMP_PRIMITIVES_VERIFIED", "PUMP_PRIMITIVES_EXPERIMENTAL",
-    "Model", "ErrorState", "C2Attribute", "PhysicalValueID", "VisualID",
+    "Model", "MODEL_MANUFACTURER", "manufacturer_for_model",
+    "ErrorState", "C2Attribute", "PhysicalValueID", "VisualID",
     "SceneID", "OperationState", "FsciStatus",
     "PumpMode", "RampType", "PumpParam", "PUMP_PARAM_SIZE", "PUMP_MODE_PARAMS",
     # schedule

{python_mobius-0.1.0 → python_mobius-0.1.2}/src/mobius/constants.py

@@ -11,6 +11,7 @@ See documentation/ for the full derivation of each table.
 from __future__ import annotations
 
 from enum import IntEnum
+from typing import Optional
 
 
 # --------------------------------------------------------------------------
@@ -107,6 +108,65 @@ class Model(IntEnum):
     Coffee2 = 397            # "Quantum 220/300" (NYOS)
 
 
+# Ported from M.Model.getManufacturer(). The decompiled version branches on
+# enum *ordinal* against a hardcoded position list (the full ~100-entry
+# Model enum's index 1-37 range, plus a few extras, all map to "EcoTech
+# Marine"); since this library only implements a curated subset of Model,
+# this is re-derived by name pattern against that same logic instead of by
+# ordinal position -- functionally equivalent for every Model value defined
+# above, but if you add more Model entries, add their manufacturer here too.
+MODEL_MANUFACTURER: dict[Model, str] = {
+    Model.Unknown: "Unknown",
+    Model.VorTechMP10wES: "EcoTech Marine",
+    Model.VorTechMP10wQD: "EcoTech Marine",
+    Model.VorTechMP40wES: "EcoTech Marine",
+    Model.VorTechMP40wQD: "EcoTech Marine",
+    Model.VorTechMP40wG3QD: "EcoTech Marine",
+    Model.VorTechMP60wES: "EcoTech Marine",
+    Model.VorTechMP60wQD: "EcoTech Marine",
+    Model.RadionXR30w: "EcoTech Marine",
+    Model.RadionXR30wG2: "EcoTech Marine",
+    Model.RadionXR30wPro: "EcoTech Marine",
+    Model.RadionXR30wG3: "EcoTech Marine",
+    Model.RadionXR30wG3Pro: "EcoTech Marine",
+    Model.RadionXR30wG4: "EcoTech Marine",
+    Model.RadionXR30wG4Pro: "EcoTech Marine",
+    Model.RadionXR30wFWPro: "EcoTech Marine",
+    Model.RadionXR30wPrototype: "EcoTech Marine",
+    Model.RadionXR15wG3Pro: "EcoTech Marine",
+    Model.RadionXR15wFW: "EcoTech Marine",
+    Model.RadionXR15wG4Pro: "EcoTech Marine",
+    Model.RadionXR15wFWPro: "EcoTech Marine",
+    Model.RadionXR15wPrototype: "EcoTech Marine",
+    Model.RadionXR15G5Pro: "EcoTech Marine",
+    Model.RadionXR15wG5Blue: "EcoTech Marine",
+    Model.RadionXR15wG5FW: "EcoTech Marine",
+    Model.RadionXR15wG6Pro: "EcoTech Marine",
+    Model.RadionXR15wG6Blue: "EcoTech Marine",
+    Model.RadionXR30wG5Pro: "EcoTech Marine",
+    Model.RadionXR30wG5Blue: "EcoTech Marine",
+    Model.VectraM1: "EcoTech Marine",
+    Model.VectraL1: "EcoTech Marine",
+    Model.VectraS1: "EcoTech Marine",
+    Model.VectraS2: "EcoTech Marine",
+    Model.VectraM2: "EcoTech Marine",
+    Model.VectraL2: "EcoTech Marine",
+    Model.Nero5: "AquaIllumination",
+    Model.Nero3: "AquaIllumination",
+    Model.DosingPump: "AquaIllumination",
+    Model.Muffler: "Neptune Systems",   # confirmed explicitly in the decompile's manufacturer list
+    Model.Coffee1: "NYOS",               # confirmed explicitly (CoffeeV1 branch)
+    Model.Coffee2: "NYOS",
+}
+
+
+def manufacturer_for_model(model: Optional[Model]) -> Optional[str]:
+    """Returns the manufacturer name for a Model, or None if unknown/unmapped."""
+    if model is None:
+        return None
+    return MODEL_MANUFACTURER.get(model)
+
+
 class ErrorState(IntEnum):
     """Confirmed literal values from M.ErrorState (subset covering common
     pump/light fault codes -- the full enum also has dosing-pump-specific codes)."""

{python_mobius-0.1.0 → python_mobius-0.1.2}/src/mobius/device.py

@@ -29,7 +29,7 @@ from .frame import (
 )
 from .constants import (
     C2Attribute, PrimitiveType, Model, ErrorState, SceneID, OperationState,
-    FsciStatus, PhysicalValueID, VisualID,
+    FsciStatus, PhysicalValueID, VisualID, manufacturer_for_model,
     PRIMITIVE_SIZE, LIGHT_PRIMITIVES, PUMP_PRIMITIVES_VERIFIED, PUMP_PRIMITIVES_EXPERIMENTAL,
 )
 from .schedule import (
@@ -48,6 +48,25 @@ CHAR_TX_DATA = "01ff0103-ba5e-f4ee-5ca1-eb1e5e4b1ce0"   # write: app -> device,
 CHAR_TX_FINAL = "01ff0104-ba5e-f4ee-5ca1-eb1e5e4b1ce0"  # write: app -> device, last fragment
 
 
+def _decode_serial(raw: bytes) -> str:
+    """
+    Serial numbers are printable ASCII on every device tested (confirmed by
+    cross-validating the GATT-read serial against the same serial parsed
+    from BLE advertisement manufacturer data -- see manufacturer.py and
+    documentation/08-manufacturer-data.md), so decode as text rather than
+    hex-encoding raw bytes. Falls back to hex for any non-printable-ASCII
+    edge case not yet observed, rather than raising.
+    """
+    text = raw.rstrip(b"\x00")
+    try:
+        decoded = text.decode("ascii")
+    except UnicodeDecodeError:
+        return raw.hex()
+    if decoded and all(32 <= ord(c) < 127 for c in decoded):
+        return decoded
+    return raw.hex()
+
+
 class MobiusDevice:
     """
     High-level async client for a single Mobius-protocol BLE device.
@@ -112,8 +131,29 @@ class MobiusDevice:
                     if attempt == 2:
                         raise
                     await asyncio.sleep(2.0)
-        await self._client.start_notify(CHAR_RX_DATA, self._on_rx_data)
-        await self._client.start_notify(CHAR_RX_FINAL, self._on_rx_final)
+
+        # IMPORTANT: from here on, self._client holds a real, already-open
+        # BLE connection. If anything below fails, connect() (== __aenter__)
+        # raises -- and per the async context manager protocol, a raising
+        # __aenter__ means __aexit__/disconnect() is NEVER called by the
+        # caller's `async with` block. Without this try/except, a failure
+        # here would leak an orphaned open connection on the adapter every
+        # single time it happens -- and since coordinators retry on a timer,
+        # that leak compounds over repeated failures until the adapter's
+        # real connection-slot pool is exhausted, independent of range or
+        # any other integration. Confirmed as the likely cause of "no
+        # available connection slot" errors appearing over time rather than
+        # immediately, reported against real hardware.
+        try:
+            await self._client.start_notify(CHAR_RX_DATA, self._on_rx_data)
+            await self._client.start_notify(CHAR_RX_FINAL, self._on_rx_final)
+        except Exception:
+            try:
+                if self._client.is_connected:
+                    await self._client.disconnect()
+            except Exception:
+                pass  # best-effort cleanup; the original error is what matters
+            raise
 
     async def disconnect(self):
         if self._client and self._client.is_connected:
@@ -252,8 +292,9 @@ class MobiusDevice:
         return {
             "model_raw": model_val,
             "model": model.name if model is not None else (f"unknown({model_val})" if model_val is not None else None),
+            "manufacturer": manufacturer_for_model(model),
             "name": name_raw.decode("utf-8", errors="replace").rstrip("\x00") if name_raw else None,
-            "serial": serial_raw.hex() if serial_raw else None,
+            "serial": _decode_serial(serial_raw) if serial_raw else None,
             "primitive_type": PrimitiveType(primitive_raw[0]).name if primitive_raw else None,
             "error_state": error.name if error is not None else (f"unknown({error_val})" if error_val is not None else None),
             "mac_address": ":".join(f"{b:02X}" for b in mac_raw) if mac_raw else None,
@@ -325,12 +366,24 @@ class MobiusDevice:
 
     async def get_pump_telemetry(self) -> dict:
         """
-        Returns {"speed": int, "gph": int}. Both are genuinely read live from
-        the device -- confirmed via FlowRange.java, which is what the app's
-        dashboard actually queries for the pump gauge widget.
+        Returns {"speed": int, "speed_percent": float, "gph": int}. speed
+        and gph are genuinely read live from the device -- confirmed via
+        FlowRange.java, which is what the app's dashboard actually queries
+        for the pump gauge widget.
 
         "gph" comes from PhysicalValues/GallonsPerHour (int32 LE).
-        "speed" comes from MotorSpeed directly (int16).
+
+        "speed" comes from MotorSpeed directly (int16). CONFIRMED (not
+        inferred) to be a percentage of max pump power in tenths of a
+        percent, not RPM: the app's own display code does
+        `String.format("%.0f%%", Math.abs(currentSpeed / 10.0f))` on this
+        exact value (FlowFragment.java/WidgetViewCell.java). "speed_percent"
+        is that same abs(speed)/10 conversion, provided as a convenience --
+        the sign of the raw "speed" value encodes rotation direction
+        (reverse), matching the same convention as the schedule's MaxSpeed
+        parameter (see PumpPrimitiveValue), so check the sign of "speed"
+        yourself if direction matters; speed_percent is always non-negative.
+
         MotorRPM is defined in the protocol but never queried anywhere in the
         app -- not included here since it's unconfirmed whether firmware
         actually populates it.
@@ -341,7 +394,8 @@ class MobiusDevice:
         )
         speed = struct.unpack("<h", speed_raw[0])[0] if speed_raw else None
         gph = struct.unpack("<i", gph_raw[0])[0] if gph_raw else None
-        return {"speed": speed, "gph": gph}
+        speed_percent = abs(speed) / 10 if speed is not None else None
+        return {"speed": speed, "speed_percent": speed_percent, "gph": gph}
 
     # ---- light schedule (Radion/XR15 etc.) --------------------------------
 

python_mobius-0.1.2/tests/test_connection_cleanup.py

@@ -0,0 +1,107 @@
+"""
+Regression test for a real leak: if start_notify() fails after the BLE
+connection is already established, connect() (== __aenter__) must clean up
+the connection before re-raising -- otherwise a raising __aenter__ means
+__aexit__/disconnect() is never called by the caller's `async with` block,
+leaking an orphaned open connection on the adapter every time it happens.
+"""
+
+from unittest.mock import AsyncMock, MagicMock, patch
+
+import pytest
+from bleak.backends.device import BLEDevice
+
+from mobius.device import MobiusDevice
+
+
+def _fake_ble_device():
+    return BLEDevice("AA:BB:CC:DD:EE:FF", "MOBIUS", {})
+
+
+@pytest.mark.asyncio
+async def test_failed_start_notify_disconnects_before_raising():
+    fake_client = MagicMock()
+    fake_client.is_connected = True
+    fake_client.disconnect = AsyncMock()
+    fake_client.start_notify = AsyncMock(side_effect=RuntimeError("GATT notify setup failed"))
+
+    async def fake_establish_connection(*args, **kwargs):
+        return fake_client
+
+    with patch("mobius.device.establish_connection", side_effect=fake_establish_connection), \
+         patch("mobius.device._HAVE_RETRY_CONNECTOR", True):
+        device = MobiusDevice(_fake_ble_device())
+        with pytest.raises(RuntimeError, match="GATT notify setup failed"):
+            await device.connect()
+
+    # The key assertion: even though connect() raised, the already-open
+    # connection was cleaned up rather than left orphaned.
+    fake_client.disconnect.assert_awaited_once()
+
+
+@pytest.mark.asyncio
+async def test_successful_connect_does_not_disconnect():
+    fake_client = MagicMock()
+    fake_client.is_connected = True
+    fake_client.disconnect = AsyncMock()
+    fake_client.start_notify = AsyncMock(return_value=None)
+
+    async def fake_establish_connection(*args, **kwargs):
+        return fake_client
+
+    with patch("mobius.device.establish_connection", side_effect=fake_establish_connection), \
+         patch("mobius.device._HAVE_RETRY_CONNECTOR", True):
+        device = MobiusDevice(_fake_ble_device())
+        await device.connect()
+
+    fake_client.disconnect.assert_not_awaited()
+    assert device._client is fake_client
+
+
+@pytest.mark.asyncio
+async def test_pump_telemetry_speed_percent_matches_app_formula():
+    """
+    Confirmed (not inferred) against the decompiled app's own display code:
+    FlowFragment.java / WidgetViewCell.java format MotorSpeed as
+    String.format("%.0f%%", Math.abs(currentSpeed / 10.0f)) -- i.e. speed is
+    a percentage of max power in tenths of a percent, not RPM, with sign
+    encoding rotation direction. Uses real captured values from a live
+    VorTech pump (speed=447 -> 44.7%).
+    """
+    fake_client = MagicMock()
+    fake_client.is_connected = True
+    fake_client.disconnect = AsyncMock()
+    fake_client.start_notify = AsyncMock(return_value=None)
+
+    device = MobiusDevice(_fake_ble_device())
+    device._client = fake_client
+
+    async def fake_get_attribute(attr_id, index=0, count=1):
+        if attr_id == 700:  # MotorSpeed
+            return [(447).to_bytes(2, "little", signed=True)]
+        return [(2272).to_bytes(4, "little", signed=True)]  # GallonsPerHour
+
+    device.get_attribute = fake_get_attribute
+    telemetry = await device.get_pump_telemetry()
+
+    assert telemetry["speed"] == 447
+    assert telemetry["speed_percent"] == 44.7
+    assert telemetry["gph"] == 2272
+
+
+@pytest.mark.asyncio
+async def test_pump_telemetry_speed_percent_is_always_nonnegative():
+    """A negative raw speed (reverse rotation) should still give a
+    non-negative speed_percent."""
+    device = MobiusDevice(_fake_ble_device())
+
+    async def fake_get_attribute(attr_id, index=0, count=1):
+        if attr_id == 700:
+            return [(-447).to_bytes(2, "little", signed=True)]
+        return [(2272).to_bytes(4, "little", signed=True)]
+
+    device.get_attribute = fake_get_attribute
+    telemetry = await device.get_pump_telemetry()
+
+    assert telemetry["speed"] == -447
+    assert telemetry["speed_percent"] == 44.7

python_mobius-0.1.2/tests/test_manufacturer_lookup.py

@@ -0,0 +1,26 @@
+from mobius import Model, manufacturer_for_model
+
+
+def test_vortech_is_ecotech_marine():
+    assert manufacturer_for_model(Model.VorTechMP40wG3QD) == "EcoTech Marine"
+
+
+def test_radion_is_ecotech_marine():
+    assert manufacturer_for_model(Model.RadionXR15wG6Pro) == "EcoTech Marine"
+
+
+def test_nero_is_aquaillumination():
+    assert manufacturer_for_model(Model.Nero5) == "AquaIllumination"
+
+
+def test_coffee_is_nyos():
+    assert manufacturer_for_model(Model.Coffee1) == "NYOS"
+    assert manufacturer_for_model(Model.Coffee2) == "NYOS"
+
+
+def test_muffler_is_neptune_systems():
+    assert manufacturer_for_model(Model.Muffler) == "Neptune Systems"
+
+
+def test_none_model_returns_none():
+    assert manufacturer_for_model(None) is None

python_mobius-0.1.2/tests/test_serial_decoding.py

@@ -0,0 +1,20 @@
+from mobius.device import _decode_serial
+
+
+def test_decodes_real_pump_serial_as_ascii():
+    # Real captured serial from a VorTech MP40QD pump.
+    assert _decode_serial(bytes.fromhex("3736343935323231303539303139")) == "76495221059019"
+
+
+def test_decodes_real_light_serial_as_ascii():
+    # Real captured serial from a Radion XR15 G6 Pro.
+    assert _decode_serial(bytes.fromhex("3756345a30304631343352424544")) == "7V4Z00F143RBED"
+
+
+def test_strips_trailing_nulls():
+    assert _decode_serial(b"ABC123\x00\x00\x00") == "ABC123"
+
+
+def test_falls_back_to_hex_for_non_ascii():
+    raw = bytes([0, 1, 2, 3])
+    assert _decode_serial(raw) == raw.hex()

python_mobius-0.1.0/CHANGELOG.md

@@ -1,29 +0,0 @@
-# Changelog
-
-## 0.1.0 — initial release
-
-- Core FSCI/C2CI wire protocol: framing, CRC16, Get/Set-attribute codec.
-  Verified byte-for-byte against real captured packets.
-- Scene control (`start_scene`, `start_feed_mode`, `resume_schedule`).
-- Pump telemetry (speed, estimated GPH) — verified live against real
-  VorTech MP40QD pumps.
-- Pump schedule reading (mode + parameters per time block) — verified live.
-- Light schedule reading + client-side interpolation, matching the app's
-  own behavior — verified live against real Radion XR15 G6 Pro lights.
-- Device discovery, identity (`get_device_info`), and a unified
-  `get_device_summary()` with explicit support tiers
-  (light / pump / pump-experimental / unsupported).
-- Advertisement-only discovery: model, serial, and `pan_id` (tank/mesh
-  grouping) with no GATT connection required — verified against 4 real
-  devices sharing one `pan_id`.
-- `mobius-scan` CLI.
-
-### Known gaps
-
-- `DoseV1` and `HotSauceV1` primitive types have no parser (see
-  `documentation/10-known-gaps-and-open-questions.md`).
-- `CoffeeV1` (NYOS Quantum) pump-primitive support is structurally
-  plausible but unverified against real hardware.
-- Thread/CoAP device-to-device relay (used by the official app to reach
-  devices without a direct BLE connection) is not implemented — this
-  library always connects directly to each device instead.