python-izone 1.3.7__tar.gz → 1.3.8__tar.gz

{python_izone-1.3.7 → python_izone-1.3.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-izone
-Version: 1.3.7
+Version: 1.3.8
 Summary: A python interface to the iZone airconditioner controller
 Project-URL: Homepage, https://github.com/Swamp-Ig/pizone
 Author-email: Penny Wood <pypl@ninjateaparty.com>

python_izone-1.3.8/docs/release-notes/v1.3.8.md

@@ -0,0 +1,9 @@
+# Release notes — v1.3.8
+
+**Compare range:** https://github.com/Swamp-Ig/pizone/compare/v1.3.7...v1.3.8
+
+## Since v1.3.7
+
+- `discover_all` skips controllers that become claimed mid-scan (`ControllerAlreadyClaimedError`) instead of failing the scan
+- Expected UDP `sendto` failures (blocked broadcast / interface down) log at debug instead of warning with a traceback
+- Drop dead `RuntimeError` suppress around UDP `_cache_endpoint` (claimed endpoints already return earlier; that path raises `ControllerAlreadyClaimedError`)

{python_izone-1.3.7 → python_izone-1.3.8}/pizone/discovery.py

@@ -549,7 +549,7 @@ class DiscoveryService:
                     continue
                 try:
                     self._cache_endpoint(endpoint)
-                except RuntimeError:
+                except ControllerAlreadyClaimedError:
                     continue
                 verified.append(endpoint)
                 if endpoint.uid not in notified:
@@ -799,8 +799,13 @@ class DiscoveryService:
         """Return the aiohttp session used for HTTP requests."""
         return self._session
 
-    def _on_error_received(self, _: Exception) -> None:
-        _LOG.warning("Error passed and ignored to error_received", exc_info=True)
+    def _on_error_received(self, exc: Exception) -> None:
+        # Expected when broadcast is blocked (firewall / no permission) or the
+        # interface is down; scan just finds nothing. Keep unexpected errors loud.
+        if isinstance(exc, OSError):
+            _LOG.debug("UDP error ignored: %s", exc)
+            return
+        _LOG.warning("Error passed and ignored to error_received: %s", exc)
 
     def _find_by_addr(self, addr: tuple[str, int]) -> Controller | None:
         for ctrl in self._controllers.values():
@@ -923,8 +928,7 @@ class DiscoveryService:
         previous = self._known_endpoints.get(endpoint.uid)
         newly_seen = previous is None
         host_changed = previous is not None and previous.host != endpoint.host
-        with suppress(RuntimeError):
-            self._cache_endpoint(endpoint)
+        self._cache_endpoint(endpoint)
         if newly_seen or host_changed:
             self._emit_endpoint_discovered(endpoint)
 

{python_izone-1.3.7 → python_izone-1.3.8}/pizone/version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '1.3.7'
-__version_tuple__ = version_tuple = (1, 3, 7)
+__version__ = version = '1.3.8'
+__version_tuple__ = version_tuple = (1, 3, 8)
 
 __commit_id__ = commit_id = None

{python_izone-1.3.7 → python_izone-1.3.8}/tests/test_discovery_api.py

@@ -588,9 +588,14 @@ async def test_discover_all_excludes_created_controllers() -> None:
         FakeHttpSession(get_response=_system_settings_response("000025841")),
     )
     await service.create_controller("000025841", "10.0.0.90")
+
+    async def _scan_reports_claimed() -> None:
+        assert service._scan_collector is not None
+        service._scan_collector["000025841"] = "10.0.0.90"
+
     with (
         patch("pizone.discovery.asyncio.sleep", AsyncMock()),
-        patch.object(service, "scan", AsyncMock()),
+        patch.object(service, "scan", side_effect=_scan_reports_claimed),
     ):
         endpoints = await service.discover_all()
     assert endpoints == []