python-engineio 4.9.1__tar.gz → 4.10.1__tar.gz

{python_engineio-4.9.1/src/python_engineio.egg-info → python_engineio-4.10.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: python-engineio
-Version: 4.9.1
+Version: 4.10.1
 Summary: Engine.IO server and client for Python
 Author-email: Miguel Grinberg <miguel.grinberg@gmail.com>
 Project-URL: Homepage, https://github.com/miguelgrinberg/python-engineio

{python_engineio-4.9.1 → python_engineio-4.10.1}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "python-engineio"
-version = "4.9.1"
+version = "4.10.1"
 authors = [{name = "Miguel Grinberg", email = "miguel.grinberg@gmail.com"}]
 description = "Engine.IO server and client for Python"
 classifiers = [

{python_engineio-4.9.1 → python_engineio-4.10.1}/src/engineio/async_client.py

@@ -62,7 +62,7 @@ class AsyncClient(base_client.BaseClient):
     :param http_session: an initialized ``aiohttp.ClientSession`` object to be
                          used when sending requests to the server. Use it if
                          you need to add special client options such as proxy
-                         servers, SSL certificates, etc.
+                         servers, SSL certificates, custom CA bundle, etc.
     :param ssl_verify: ``True`` to verify SSL certificates, or ``False`` to
                        skip SSL certificate verification, allowing
                        connections to servers with self signed certificates.

{python_engineio-4.9.1 → python_engineio-4.10.1}/src/engineio/async_drivers/asgi.py

@@ -63,7 +63,8 @@ class ASGIApp:
             await self.lifespan(scope, receive, send)
         elif scope['type'] in ['http', 'websocket'] and (
                 self.engineio_path is None
-                or scope['path'].startswith(self.engineio_path)):
+                or self._ensure_trailing_slash(scope['path']).startswith(
+                    self.engineio_path)):
             await self.engineio_server.handle_request(scope, receive, send)
         else:
             static_file = get_static_file(scope['path'], self.static_files) \
@@ -127,6 +128,11 @@ class ASGIApp:
         await send({'type': 'http.response.body',
                     'body': b'Not Found'})
 
+    def _ensure_trailing_slash(self, path):
+        if not path.endswith('/'):
+            path += '/'
+        return path
+
 
 async def translate_request(scope, receive, send):
     class AwaitablePayload(object):  # pragma: no cover

{python_engineio-4.9.1 → python_engineio-4.10.1}/src/engineio/async_drivers/eventlet.py

@@ -25,7 +25,7 @@ class EventletThread:  # pragma: no cover
             return self.g.wait()
 
 
-class WebSocketWSGI(_WebSocketWSGI):
+class WebSocketWSGI(_WebSocketWSGI):  # pragma: no cover
     def __init__(self, handler, server):
         try:
             super().__init__(

{python_engineio-4.9.1 → python_engineio-4.10.1}/src/engineio/async_server.py

@@ -70,6 +70,10 @@ class AsyncServer(base_server.BaseServer):
     :param async_handlers: If set to ``True``, run message event handlers in
                            non-blocking threads. To run handlers synchronously,
                            set to ``False``. The default is ``True``.
+    :param monitor_clients: If set to ``True``, a background task will ensure
+                            inactive clients are closed. Set to ``False`` to
+                            disable the monitoring task (not recommended). The
+                            default is ``True``.
     :param transports: The list of allowed transports. Valid transports
                        are ``'polling'`` and ``'websocket'``. Defaults to
                        ``['polling', 'websocket']``.
@@ -265,11 +269,11 @@ class AsyncServer(base_server.BaseServer):
                                  'bad-jsonp-index')
             r = self._bad_request('Invalid JSONP index number')
         elif method == 'GET':
+            upgrade_header = environ.get('HTTP_UPGRADE').lower() \
+                if 'HTTP_UPGRADE' in environ else None
             if sid is None:
                 # transport must be one of 'polling' or 'websocket'.
                 # if 'websocket', the HTTP_UPGRADE header must match.
-                upgrade_header = environ.get('HTTP_UPGRADE').lower() \
-                    if 'HTTP_UPGRADE' in environ else None
                 if transport == 'polling' \
                         or transport == upgrade_header == 'websocket':
                     r = await self._handle_connect(environ, transport,
@@ -284,18 +288,25 @@ class AsyncServer(base_server.BaseServer):
                     r = self._bad_request('Invalid session ' + sid)
                 else:
                     socket = self._get_socket(sid)
-                    try:
-                        packets = await socket.handle_get_request(environ)
-                        if isinstance(packets, list):
-                            r = self._ok(packets, jsonp_index=jsonp_index)
-                        else:
-                            r = packets
-                    except exceptions.EngineIOError:
-                        if sid in self.sockets:  # pragma: no cover
-                            await self.disconnect(sid)
-                        r = self._bad_request()
-                    if sid in self.sockets and self.sockets[sid].closed:
-                        del self.sockets[sid]
+                    if self.transport(sid) != transport and \
+                            transport != upgrade_header:
+                        self._log_error_once(
+                            'Invalid transport for session ' + sid,
+                            'bad-transport')
+                        r = self._bad_request('Invalid transport')
+                    else:
+                        try:
+                            packets = await socket.handle_get_request(environ)
+                            if isinstance(packets, list):
+                                r = self._ok(packets, jsonp_index=jsonp_index)
+                            else:
+                                r = packets
+                        except exceptions.EngineIOError:
+                            if sid in self.sockets:  # pragma: no cover
+                                await self.disconnect(sid)
+                            r = self._bad_request()
+                        if sid in self.sockets and self.sockets[sid].closed:
+                            del self.sockets[sid]
         elif method == 'POST':
             if sid is None or sid not in self.sockets:
                 self._log_error_once('Invalid session ' + sid, 'bad-sid')

{python_engineio-4.9.1 → python_engineio-4.10.1}/src/engineio/client.py

@@ -510,8 +510,7 @@ class Client(base_client.BaseClient):
             except Exception as e:  # pragma: no cover
                 if type(e) is OSError and e.errno == 9:
                     self.logger.info(
-                        'WebSocket connection is closing, aborting',
-                        str(e))
+                        'WebSocket connection is closing, aborting')
                 else:
                     self.logger.info(
                         'Unexpected error receiving packet: "%s", aborting',

{python_engineio-4.9.1 → python_engineio-4.10.1}/src/engineio/server.py

@@ -180,7 +180,7 @@ class Server(base_server.BaseServer):
                 if sid in self.sockets:  # pragma: no cover
                     del self.sockets[sid]
         else:
-            for client in self.sockets.values():
+            for client in self.sockets.copy().values():
                 client.close()
             self.sockets = {}
 
@@ -251,11 +251,11 @@ class Server(base_server.BaseServer):
                                  'bad-jsonp-index')
             r = self._bad_request('Invalid JSONP index number')
         elif method == 'GET':
+            upgrade_header = environ.get('HTTP_UPGRADE').lower() \
+                if 'HTTP_UPGRADE' in environ else None
             if sid is None:
                 # transport must be one of 'polling' or 'websocket'.
                 # if 'websocket', the HTTP_UPGRADE header must match.
-                upgrade_header = environ.get('HTTP_UPGRADE').lower() \
-                    if 'HTTP_UPGRADE' in environ else None
                 if transport == 'polling' \
                         or transport == upgrade_header == 'websocket':
                     r = self._handle_connect(environ, start_response,
@@ -270,19 +270,26 @@ class Server(base_server.BaseServer):
                     r = self._bad_request('Invalid session')
                 else:
                     socket = self._get_socket(sid)
-                    try:
-                        packets = socket.handle_get_request(
-                            environ, start_response)
-                        if isinstance(packets, list):
-                            r = self._ok(packets, jsonp_index=jsonp_index)
-                        else:
-                            r = packets
-                    except exceptions.EngineIOError:
-                        if sid in self.sockets:  # pragma: no cover
-                            self.disconnect(sid)
-                        r = self._bad_request()
-                    if sid in self.sockets and self.sockets[sid].closed:
-                        del self.sockets[sid]
+                    if self.transport(sid) != transport and \
+                            transport != upgrade_header:
+                        self._log_error_once(
+                            'Invalid transport for session ' + sid,
+                            'bad-transport')
+                        r = self._bad_request('Invalid transport')
+                    else:
+                        try:
+                            packets = socket.handle_get_request(
+                                environ, start_response)
+                            if isinstance(packets, list):
+                                r = self._ok(packets, jsonp_index=jsonp_index)
+                            else:
+                                r = packets
+                        except exceptions.EngineIOError:
+                            if sid in self.sockets:  # pragma: no cover
+                                self.disconnect(sid)
+                            r = self._bad_request()
+                        if sid in self.sockets and self.sockets[sid].closed:
+                            del self.sockets[sid]
         elif method == 'POST':
             if sid is None or sid not in self.sockets:
                 self._log_error_once(

{python_engineio-4.9.1 → python_engineio-4.10.1/src/python_engineio.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: python-engineio
-Version: 4.9.1
+Version: 4.10.1
 Summary: Engine.IO server and client for Python
 Author-email: Miguel Grinberg <miguel.grinberg@gmail.com>
 Project-URL: Homepage, https://github.com/miguelgrinberg/python-engineio

{python_engineio-4.9.1 → python_engineio-4.10.1}/src/python_engineio.egg-info/SOURCES.txt

@@ -56,7 +56,6 @@ tests/async/test_socket.py
 tests/async/test_tornado.py
 tests/common/__init__.py
 tests/common/index.html
-tests/common/test_async_eventlet.py
 tests/common/test_client.py
 tests/common/test_middleware.py
 tests/common/test_packet.py

{python_engineio-4.9.1 → python_engineio-4.10.1}/tests/async/test_asgi.py

@@ -38,12 +38,55 @@ class AsgiTests(unittest.TestCase):
     def test_engineio_routing(self):
         mock_server = mock.MagicMock()
         mock_server.handle_request = AsyncMock()
+
         app = async_asgi.ASGIApp(mock_server)
         scope = {'type': 'http', 'path': '/engine.io/'}
         _run(app(scope, 'receive', 'send'))
         mock_server.handle_request.mock.assert_called_once_with(
             scope, 'receive', 'send'
         )
+        mock_server.handle_request.mock.reset_mock()
+        scope = {'type': 'http', 'path': '/engine.io/'}
+        _run(app(scope, 'receive', 'send'))
+        mock_server.handle_request.mock.assert_called_once_with(
+            scope, 'receive', 'send'
+        )
+        mock_server.handle_request.mock.reset_mock()
+        scope = {'type': 'http', 'path': '/engine.iofoo/'}
+        _run(app(scope, 'receive', AsyncMock()))
+        mock_server.handle_request.mock.assert_not_called()
+
+        app = async_asgi.ASGIApp(mock_server, engineio_path=None)
+        mock_server.handle_request.mock.reset_mock()
+        scope = {'type': 'http', 'path': '/foo'}
+        _run(app(scope, 'receive', 'send'))
+        mock_server.handle_request.mock.assert_called_once_with(
+            scope, 'receive', 'send'
+        )
+
+        app = async_asgi.ASGIApp(mock_server, engineio_path='mysocket.io')
+        mock_server.handle_request.mock.reset_mock()
+        scope = {'type': 'http', 'path': '/mysocket.io'}
+        _run(app(scope, 'receive', 'send'))
+        mock_server.handle_request.mock.assert_called_once_with(
+            scope, 'receive', 'send'
+        )
+        mock_server.handle_request.mock.reset_mock()
+        scope = {'type': 'http', 'path': '/mysocket.io/'}
+        _run(app(scope, 'receive', 'send'))
+        mock_server.handle_request.mock.assert_called_once_with(
+            scope, 'receive', 'send'
+        )
+        mock_server.handle_request.mock.reset_mock()
+        scope = {'type': 'http', 'path': '/mysocket.io/foo'}
+        _run(app(scope, 'receive', 'send'))
+        mock_server.handle_request.mock.assert_called_once_with(
+            scope, 'receive', 'send'
+        )
+        mock_server.handle_request.mock.reset_mock()
+        scope = {'type': 'http', 'path': '/mysocket.iofoo'}
+        _run(app(scope, 'receive', AsyncMock()))
+        mock_server.handle_request.mock.assert_not_called()
 
     def test_other_app_routing(self):
         other_app = AsyncMock()

{python_engineio-4.9.1 → python_engineio-4.10.1}/tests/async/test_server.py

@@ -659,6 +659,32 @@ class TestAsyncServer(unittest.TestCase):
         assert len(s.sockets) == 0
         assert a._async['make_response'].call_args[0][0] == '400 BAD REQUEST'
 
+    @mock.patch('importlib.import_module')
+    def test_get_request_bad_websocket_transport(self, import_module):
+        a = self.get_async_mock(
+            {'REQUEST_METHOD': 'GET',
+             'QUERY_STRING': 'EIO=4&transport=websocket&sid=foo'}
+        )
+        import_module.side_effect = [a]
+        s = async_server.AsyncServer()
+        s.sockets['foo'] = mock_socket = self._get_mock_socket()
+        mock_socket.upgraded = False
+        _run(s.handle_request('request'))
+        assert a._async['make_response'].call_args[0][0] == '400 BAD REQUEST'
+
+    @mock.patch('importlib.import_module')
+    def test_get_request_bad_polling_transport(self, import_module):
+        a = self.get_async_mock(
+            {'REQUEST_METHOD': 'GET',
+             'QUERY_STRING': 'EIO=4&transport=polling&sid=foo'}
+        )
+        import_module.side_effect = [a]
+        s = async_server.AsyncServer()
+        s.sockets['foo'] = mock_socket = self._get_mock_socket()
+        mock_socket.upgraded = True
+        _run(s.handle_request('request'))
+        assert a._async['make_response'].call_args[0][0] == '400 BAD REQUEST'
+
     @mock.patch('importlib.import_module')
     def test_post_request_with_bad_sid(self, import_module):
         a = self.get_async_mock(

{python_engineio-4.9.1 → python_engineio-4.10.1}/tests/common/test_server.py

@@ -111,6 +111,14 @@ class TestServer(unittest.TestCase):
         del sys.modules['engineio.async_drivers.threading']
 
     def test_async_mode_eventlet(self):
+        sys.modules['eventlet'] = mock.MagicMock()
+        sys.modules['eventlet'].green = mock.MagicMock()
+        sys.modules['eventlet.green'] = sys.modules['eventlet'].green
+        sys.modules['eventlet.green'].threading = mock.MagicMock()
+        sys.modules['eventlet.green.threading'] = \
+            sys.modules['eventlet.green'].threading
+        sys.modules['eventlet'].websocket = mock.MagicMock()
+        sys.modules['eventlet.websocket'] = sys.modules['eventlet'].websocket
         s = server.Server(async_mode='eventlet')
         assert s.async_mode == 'eventlet'
 
@@ -120,6 +128,11 @@ class TestServer(unittest.TestCase):
         assert s._async['thread'] == async_eventlet.EventletThread
         assert s._async['queue'] == queue.Queue
         assert s._async['websocket'] == async_eventlet.WebSocketWSGI
+        del sys.modules['eventlet']
+        del sys.modules['eventlet.green']
+        del sys.modules['eventlet.green.threading']
+        del sys.modules['eventlet.websocket']
+        del sys.modules['engineio.async_drivers.eventlet']
 
     @mock.patch('importlib.import_module', side_effect=_mock_import)
     def test_async_mode_gevent_uwsgi(self, import_module):
@@ -228,7 +241,10 @@ class TestServer(unittest.TestCase):
         with pytest.raises(ValueError):
             server.Server(async_mode='foo')
 
-    @mock.patch('importlib.import_module', side_effect=[_mock_async])
+    @mock.patch(
+        'importlib.import_module',
+        side_effect=[_mock_async],
+    )
     def test_async_mode_auto_eventlet(self, import_module):
         s = server.Server()
         assert s.async_mode == 'eventlet'
@@ -867,6 +883,28 @@ class TestServer(unittest.TestCase):
         assert start_response.call_args[0][0] == '400 BAD REQUEST'
         assert len(s.sockets) == 0
 
+    def test_get_request_bad_websocket_transport(self):
+        s = server.Server()
+        mock_socket = self._get_mock_socket()
+        mock_socket.upgraded = False
+        s.sockets['foo'] = mock_socket
+        environ = {'REQUEST_METHOD': 'GET',
+                   'QUERY_STRING': 'EIO=4&transport=websocket&sid=foo'}
+        start_response = mock.MagicMock()
+        s.handle_request(environ, start_response)
+        assert start_response.call_args[0][0] == '400 BAD REQUEST'
+
+    def test_get_request_bad_polling_transport(self):
+        s = server.Server()
+        mock_socket = self._get_mock_socket()
+        mock_socket.upgraded = True
+        s.sockets['foo'] = mock_socket
+        environ = {'REQUEST_METHOD': 'GET',
+                   'QUERY_STRING': 'EIO=4&transport=polling&sid=foo'}
+        start_response = mock.MagicMock()
+        s.handle_request(environ, start_response)
+        assert start_response.call_args[0][0] == '400 BAD REQUEST'
+
     def test_post_request(self):
         s = server.Server()
         mock_socket = self._get_mock_socket()

{python_engineio-4.9.1 → python_engineio-4.10.1}/tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist=flake8,py38,py39,py310,py311,py312,pypy3,docs
+envlist=flake8,py38,py39,py310,py311,py312,py313,pypy3,docs
 skip_missing_interpreters=True
 
 [gh-actions]
@@ -9,6 +9,7 @@ python =
     3.10: py310
     3.11: py311
     3.12: py312
+    3.13: py313
     pypy-3: pypy3
 
 [testenv]
@@ -18,7 +19,6 @@ commands=
 deps=
     pytest
     pytest-cov
-    eventlet
     aiohttp
     tornado
     requests

python_engineio-4.9.1/tests/common/test_async_eventlet.py

@@ -1,29 +0,0 @@
-import logging
-import unittest
-from unittest import mock
-
-from engineio.async_drivers import eventlet as async_eventlet
-import pytest
-
-
-class TestAsyncEventlet(unittest.TestCase):
-    def setUp(self):
-        logging.getLogger('engineio').setLevel(logging.NOTSET)
-
-    def test_bad_environ(self):
-        wsgi = async_eventlet.WebSocketWSGI(None, mock.MagicMock())
-        environ = {'foo': 'bar'}
-        start_response = 'bar'
-        with pytest.raises(RuntimeError):
-            wsgi(environ, start_response)
-
-    @mock.patch(
-        'engineio.async_drivers.eventlet._WebSocketWSGI.__call__',
-        return_value='data',
-    )
-    def test_wsgi_call(self, _WebSocketWSGI):
-        _WebSocketWSGI.__call__ = lambda e, s: 'data'
-        environ = {'eventlet.input': mock.MagicMock()}
-        start_response = 'bar'
-        wsgi = async_eventlet.WebSocketWSGI(None, mock.MagicMock())
-        assert wsgi(environ, start_response) == 'data'