python-duco-connectivity 0.3.0__tar.gz → 0.4.0__tar.gz

{python_duco_connectivity-0.3.0 → python_duco_connectivity-0.4.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-duco-connectivity
-Version: 0.3.0
+Version: 0.4.0
 Summary: Async HTTP client for the local Duco Connectivity API
 Author: Ronald van der Meer
 License-Expression: MIT

{python_duco_connectivity-0.3.0 → python_duco_connectivity-0.4.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "python-duco-connectivity"
-version = "0.3.0"
+version = "0.4.0"
 description = "Async HTTP client for the local Duco Connectivity API"
 readme = "README.md"
 license = "MIT"

{python_duco_connectivity-0.3.0 → python_duco_connectivity-0.4.0}/src/duco_connectivity/__init__.py

@@ -7,6 +7,7 @@ from .exceptions import (
     DucoConnectionError,
     DucoError,
     DucoRateLimitError,
+    DucoResponseError,
     DucoWriteLimitError,
 )
 from .models import (
@@ -93,6 +94,7 @@ __all__ = [
     "DucoConnectionError",
     "DucoError",
     "DucoRateLimitError",
+    "DucoResponseError",
     "DucoWriteLimitError",
     "DiagComponent",
     "DiagStatus",

{python_duco_connectivity-0.3.0 → python_duco_connectivity-0.4.0}/src/duco_connectivity/client.py

@@ -9,7 +9,12 @@ from urllib.parse import urlsplit
 
 import aiohttp
 
-from .exceptions import DucoConnectionError, DucoError, DucoWriteLimitError
+from .exceptions import (
+    DucoConnectionError,
+    DucoError,
+    DucoResponseError,
+    DucoWriteLimitError,
+)
 from .models import (
     ActionItem,
     ActionItemList,
@@ -215,18 +220,18 @@ class DucoClient:
                     path,
                 )
                 if response.status == 429:
+                    body = await response.text()
                     _LOGGER.debug(
                         "Write limit reached for %s %s%s",
                         method,
                         self._base_url,
                         path,
                     )
-                    raise DucoWriteLimitError()
+                    raise DucoWriteLimitError(path=path, body=body)
 
                 if response.status >= 400:
                     body = await response.text()
-                    msg = f"Unexpected response {response.status} for {path}: {body}"
-                    raise DucoError(msg)
+                    raise DucoResponseError(response.status, path, body)
 
                 try:
                     return await response.json(content_type=None)

python_duco_connectivity-0.4.0/src/duco_connectivity/exceptions.py

@@ -0,0 +1,53 @@
+"""Exceptions raised by the Duco client."""
+
+
+class DucoError(Exception):
+    """Base class for client errors."""
+
+
+class DucoConnectionError(DucoError):
+    """Raised when the client cannot reach the box."""
+
+
+class DucoResponseError(DucoError):
+    """Raised when the box responds with an HTTP error status."""
+
+    def __init__(
+        self,
+        status: int,
+        path: str,
+        body: str = "",
+        *,
+        message: str | None = None,
+    ) -> None:
+        self.status = status
+        self.path = path
+        self.body = body
+        if message is None:
+            detail = f"Unexpected response {status} for {path}"
+            if body.strip():
+                detail = f"{detail}: {body}"
+        else:
+            detail = message
+        super().__init__(detail)
+
+
+class DucoWriteLimitError(DucoResponseError):
+    """Raised when the box rejects writes because its budget is exhausted."""
+
+    def __init__(
+        self,
+        remaining: int | None = None,
+        *,
+        path: str = "",
+        body: str = "",
+    ) -> None:
+        self.remaining = remaining
+        detail = "Duco write capacity exhausted"
+        if remaining is not None:
+            detail = f"{detail} ({remaining} writes remaining)"
+        super().__init__(429, path, body, message=detail)
+
+
+# Backward-compatible alias for the old python-duco-client exception name.
+DucoRateLimitError = DucoWriteLimitError

{python_duco_connectivity-0.3.0 → python_duco_connectivity-0.4.0}/src/python_duco_connectivity.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-duco-connectivity
-Version: 0.3.0
+Version: 0.4.0
 Summary: Async HTTP client for the local Duco Connectivity API
 Author: Ronald van der Meer
 License-Expression: MIT

{python_duco_connectivity-0.3.0 → python_duco_connectivity-0.4.0}/tests/test_client.py

@@ -27,6 +27,7 @@ from duco_connectivity import (
     DucoClient,
     DucoConnectionError,
     DucoError,
+    DucoResponseError,
     DucoWriteLimitError,
     InfoGroup,
     InfoZone,
@@ -3320,16 +3321,25 @@ async def test_timeout_raises_duco_connection_error() -> None:
                 await client.async_get_api_info()
 
 
-async def test_http_error_raises_duco_error() -> None:
-    """HTTP >= 400 should raise DucoError."""
+async def test_http_error_raises_duco_response_error() -> None:
+    """HTTP >= 400 should raise DucoResponseError with HTTP metadata."""
     mock_response = _response(status=500, json_payload={}, text_payload="boom")
 
     async with aiohttp.ClientSession() as session:
         client = DucoClient(session=session, host="192.0.2.94")
         with patch.object(session, "request", _request(mock_response)):
-            with pytest.raises(DucoError, match="Unexpected response 500"):
+            with pytest.raises(
+                DucoResponseError,
+                match="Unexpected response 500 for /api: boom",
+            ) as err_info:
                 await client.async_get_api_info()
 
+    err = err_info.value
+    assert isinstance(err, DucoError)
+    assert err.status == 500
+    assert err.path == "/api"
+    assert err.body == "boom"
+
 
 async def test_invalid_json_raises_duco_error(api_info_data: dict[str, object]) -> None:
     """Non-JSON responses should raise DucoError."""
@@ -3355,10 +3365,18 @@ async def test_write_limit_error_is_raised() -> None:
     async with aiohttp.ClientSession() as session:
         client = DucoClient(session=session, host="192.0.2.94")
         with patch.object(session, "request", MagicMock(return_value=request_context)):
-            with pytest.raises(DucoWriteLimitError, match="Duco write capacity exhausted"):
+            with pytest.raises(
+                DucoWriteLimitError,
+                match="Duco write capacity exhausted",
+            ) as err_info:
                 await client.async_set_ventilation_state(1, "MAN2")
 
     request_context.__aexit__.assert_awaited_once()
+    err = err_info.value
+    assert isinstance(err, DucoError)
+    assert err.status == 429
+    assert err.path == "/action/nodes/1"
+    assert err.body == ""
 
 
 async def test_get_actions_returns_typed_items(

{python_duco_connectivity-0.3.0 → python_duco_connectivity-0.4.0}/tests/test_exceptions.py

@@ -1,9 +1,12 @@
 """Tests for the public exceptions."""
 
+import pytest
+
 from duco_connectivity import (
     DucoConnectionError,
     DucoError,
     DucoRateLimitError,
+    DucoResponseError,
     DucoWriteLimitError,
 )
 
@@ -20,6 +23,24 @@ def test_write_limit_error_inherits_from_base_error() -> None:
     assert isinstance(err, DucoError)
 
 
+def test_response_error_stores_http_metadata() -> None:
+    """DucoResponseError should expose status, path, and body."""
+    err = DucoResponseError(404, "/info", "missing")
+    assert err.status == 404
+    assert err.path == "/info"
+    assert err.body == "missing"
+    assert str(err) == "Unexpected response 404 for /info: missing"
+    assert isinstance(err, DucoError)
+
+
+@pytest.mark.parametrize("body", ["", "   "])
+def test_response_error_omits_empty_body_from_default_message(body: str) -> None:
+    """DucoResponseError should omit the body suffix when no body content exists."""
+    err = DucoResponseError(404, "/info", body)
+
+    assert str(err) == "Unexpected response 404 for /info"
+
+
 def test_write_limit_error_stores_remaining_count() -> None:
     """DucoWriteLimitError should expose the remaining count when present."""
     err = DucoWriteLimitError(remaining=10)
@@ -33,3 +54,11 @@ def test_rate_limit_error_alias_points_to_write_limit_error() -> None:
     err = DucoRateLimitError(remaining=3)
     assert isinstance(err, DucoWriteLimitError)
     assert err.remaining == 3
+
+
+def test_write_limit_error_exposes_http_metadata() -> None:
+    """DucoWriteLimitError should expose HTTP metadata for 429 responses."""
+    err = DucoWriteLimitError(path="/config", body="rate limited")
+    assert err.status == 429
+    assert err.path == "/config"
+    assert err.body == "rate limited"

python_duco_connectivity-0.3.0/src/duco_connectivity/exceptions.py

@@ -1,24 +0,0 @@
-"""Exceptions raised by the Duco client."""
-
-
-class DucoError(Exception):
-    """Base class for client errors."""
-
-
-class DucoConnectionError(DucoError):
-    """Raised when the client cannot reach the box."""
-
-
-class DucoWriteLimitError(DucoError):
-    """Raised when the box rejects writes because its budget is exhausted."""
-
-    def __init__(self, remaining: int | None = None) -> None:
-        self.remaining = remaining
-        detail = "Duco write capacity exhausted"
-        if remaining is not None:
-            detail = f"{detail} ({remaining} writes remaining)"
-        super().__init__(detail)
-
-
-# Backward-compatible alias for the old python-duco-client exception name.
-DucoRateLimitError = DucoWriteLimitError