python-dali 0.15__tar.gz → 0.16__tar.gz

{python_dali-0.15/python_dali.egg-info → python_dali-0.16}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-dali
-Version: 0.15
+Version: 0.16
 Summary: Interface to DALI lighting systems
 Home-page: https://github.com/sde1000/python-dali
 Author: Stephen Early

{python_dali-0.15 → python_dali-0.16}/dali/driver/serial.py

@@ -1329,7 +1329,13 @@ class DriverLubaRs232(DriverSerialBase):
         self._transport: Optional[serialx.SerialTransport] = None
         self._protocol: Optional[DriverLubaRs232.LubaProtocol] = None
 
-    async def connect(self, *, scan_dev_inst: bool = False) -> None:
+    async def connect(
+        self, *, scan_dev_inst: bool = False, apply_settings: bool = True
+    ) -> None:
+        # ``apply_settings=False`` connects without writing the device settings,
+        # leaving the interface's hardware configuration (including its bus-power
+        # state) untouched. Use it to probe a discovered interface read-only so
+        # the probe cannot depower a bus the integrated supply is already driving.
         if self.is_connected:
             _LOG.warning(
                 f"'connect()' called but luba232 driver already connected"
@@ -1358,8 +1364,9 @@ class DriverLubaRs232(DriverSerialBase):
         for attempt in range(1, DriverLubaRs232.handshake_attempts + 1):
             try:
                 await self._protocol.send_device_info_query()
-                self._protocol.bus_power = self.bus_power
-                await self._protocol.send_device_settings()
+                if apply_settings:
+                    self._protocol.bus_power = self.bus_power
+                    await self._protocol.send_device_settings()
                 break
             except (asyncio.TimeoutError, TimeoutError):
                 if attempt >= DriverLubaRs232.handshake_attempts:
@@ -1378,8 +1385,9 @@ class DriverLubaRs232(DriverSerialBase):
 
         # After switching on the integrated power supply the bus voltage takes
         # a moment to rise; sending DALI frames before then fails, so wait for
-        # the bus to be powered before scanning.
-        if self.bus_power:
+        # the bus to be powered before scanning. Skipped when the settings were
+        # not applied, as the bus-power state was then left untouched.
+        if apply_settings and self.bus_power:
             await self._wait_for_bus_power()
 
         # Scan the bus for control devices, and create a mapping of addresses

{python_dali-0.15 → python_dali-0.16}/dali/tests/test_serial_driver.py

@@ -94,6 +94,25 @@ async def test_connect_retries_handshake_on_timeout(monkeypatch):
     assert protocol.reset_luba_response.call_count == 2
 
 
+@pytest.mark.asyncio
+async def test_connect_without_applying_settings_leaves_hardware_untouched(
+    monkeypatch,
+):
+    """connect(apply_settings=False) must not write the device settings.
+
+    A read-only probe of a discovered interface must not overwrite the
+    hardware configuration, otherwise it could depower a bus the integrated
+    supply is already driving.
+    """
+    driver, protocol = _connecting_driver(monkeypatch, [None])
+
+    await driver.connect(apply_settings=False)
+
+    assert driver.is_connected
+    assert protocol.send_device_info_query.await_count == 1
+    assert protocol.send_device_settings.await_count == 0
+
+
 @pytest.mark.asyncio
 async def test_connect_raises_after_exhausting_handshake_attempts(monkeypatch):
     """When every handshake attempt times out, connect must give up and raise."""

{python_dali-0.15 → python_dali-0.16/python_dali.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-dali
-Version: 0.15
+Version: 0.16
 Summary: Interface to DALI lighting systems
 Home-page: https://github.com/sde1000/python-dali
 Author: Stephen Early

{python_dali-0.15 → python_dali-0.16}/setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = python-dali
-version = 0.15
+version = 0.16
 description = Interface to DALI lighting systems
 long_description = file: README.rst
 long_description_content_type = text/x-rst