python-cad-tools 0.1.20__tar.gz → 0.1.21__tar.gz

{python_cad_tools-0.1.20 → python_cad_tools-0.1.21}/CHANGELOG.md

@@ -7,6 +7,20 @@ stable release is published.
 
 ## [Unreleased]
 
+## [0.1.21] - 2026-10-27
+
+### Added
+
+- `validate` (and so `build`) now fails a model whose parts were never moved
+  into place:
+  - `placement-unapplied`: a physical solid whose non-zero
+    `Placement.translation_mm` lies outside its own bounds. `Placement`
+    records a position and never moves geometry, so the part would export
+    where it was built. Build the solid in place instead, for example with
+    `box(..., origin=...)` or `shape.moved(Location((x, y, z)))`.
+  - `stacked-elements`: three or more physical solids with exactly the same
+    bounds, which is almost always parts left at the origin.
+
 ## [0.1.20] - 2026-10-21
 
 ### Added

{python_cad_tools-0.1.20/src/python_cad_tools.egg-info → python_cad_tools-0.1.21}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-cad-tools
-Version: 0.1.20
+Version: 0.1.21
 Summary: Typed, headless Python tooling for CAD/BIM models and artifacts
 Author: Brandon Benge
 License: AGPL-3.0-only

{python_cad_tools-0.1.20 → python_cad_tools-0.1.21}/docs/neutral-model.md

@@ -16,7 +16,7 @@ dimensions), and the validator invocation model. See
 | `category` | `str` | Free-text classification, exported as `ObjectType` in IFC. |
 | `geometry` | `Any` | A build123d-compatible solid, shell, wire, or edge. Required and opaque — the framework does not restrict how it was built. May be `None` when `recipe` is present; the framework materializes it. |
 | `geometry_kind` | `"solid" \| "shell" \| "wire" \| "edge" \| "reference"` | Declares the geometry's topological kind. Physical elements must be `"solid"`. |
-| `placement` | `Placement` | Translation (mm) and rotation (degrees, XYZ) applied on top of `geometry`'s own coordinates. |
+| `placement` | `Placement` | The element's recorded position: translation (mm) and rotation (degrees, XYZ). It does **not** move `geometry`, which must already be built in place (for example `box(..., origin=...)`); `validate` fails a solid whose non-zero translation lies outside its own bounds (`placement-unapplied`). |
 | `dimensions` | `Dimensions` | Declared, author-stated extents. Independent of the geometry's actual bounds; exported into `Pset_PythonCadDesign`. |
 | `material` | `MaterialSpec \| None` | Required for physical elements. Drives IFC material association and quantity mass calculation (`density_kg_m3`). |
 | `color_rgb` | `Color \| None` | Overrides the material color for this element's rendering/styling. |

{python_cad_tools-0.1.20 → python_cad_tools-0.1.21}/src/python_cad_tools/validation.py

@@ -73,6 +73,7 @@ def validate_model(model: DesignModel) -> list[ValidationIssue]:
     seen_instances: set[int] = set()
     for element in walked:
         issues.extend(_validate_element(element, seen_ids, seen_instances, known))
+    issues.extend(_validate_stacked(walked))
     for validator in model.validators:
         issues.extend(validator(model))
     return sorted(issues, key=lambda issue: (issue.severity, issue.code, issue.source_path or "", issue.element_id or ""))
@@ -137,6 +138,7 @@ def _validate_element(
         issues.append(
             ValidationIssue("dimensions", "error", "Declared dimensions must be finite and positive", element_id=element.id)
         )
+    issues.extend(_validate_placement_applied(element))
     if element.physical and element.material is None:
         issues.append(ValidationIssue("material", "error", "Physical elements require a material", element_id=element.id))
     if element.material is not None:
@@ -165,6 +167,64 @@ def _validate_element(
     return issues
 
 
+#: Slack (mm) around a solid's bounds within which its recorded placement counts as applied.
+_PLACEMENT_TOLERANCE_MM = 1.0
+#: This many physical solids with the same bounds means parts were left where they were built.
+_STACKED_MINIMUM = 3
+
+
+def _validate_placement_applied(element: DesignElement) -> list[ValidationIssue]:
+    """``Placement`` records a position but never moves geometry. A physical
+    solid whose non-zero placement lies outside its own bounds was almost
+    certainly meant to be moved there and never was, so every exporter would
+    draw it at the wrong place."""
+    if not element.physical or element.geometry is None or not is_valid_solid(element.geometry):
+        return []
+    point = element.placement.translation_mm
+    if not all(isfinite(value) for value in point) or not any(point):
+        return []
+    extent = bounds(element.geometry)
+    low, high = extent[:3], extent[3:]
+    slack = _PLACEMENT_TOLERANCE_MM
+    if all(lo - slack <= value <= hi + slack for value, lo, hi in zip(point, low, high, strict=True)):
+        return []
+    return [
+        ValidationIssue(
+            "placement-unapplied",
+            "error",
+            f"Placement translation {tuple(round(value, 1) for value in point)} lies outside the geometry's bounds "
+            f"{tuple(round(value, 1) for value in extent)}; Placement does not move geometry, so build the solid "
+            "in place (for example box(..., origin=...) or shape.moved(Location((x, y, z))))",
+            element_id=element.id,
+        )
+    ]
+
+
+def _validate_stacked(elements: list[DesignElement]) -> list[ValidationIssue]:
+    """Several physical solids with identical bounds sit on top of each other:
+    almost always parts that were built at the origin and never moved."""
+    groups: dict[tuple[float, ...], list[str]] = {}
+    for element in elements:
+        if element.physical and element.geometry is not None and is_valid_solid(element.geometry):
+            key = tuple(round(value, 1) for value in bounds(element.geometry))
+            groups.setdefault(key, []).append(element.id)
+    issues: list[ValidationIssue] = []
+    for key, ids in groups.items():
+        if len(ids) < _STACKED_MINIMUM:
+            continue
+        named = ", ".join(ids[:5]) + (f" and {len(ids) - 5} more" if len(ids) > 5 else "")
+        issues.append(
+            ValidationIssue(
+                "stacked-elements",
+                "error",
+                f"{len(ids)} physical elements occupy exactly the same bounds {key} ({named}); "
+                "move each solid to its own position",
+                element_id=ids[0],
+            )
+        )
+    return issues
+
+
 def _exported_to_ifc(element: DesignElement) -> bool:
     return (
         element.visible

{python_cad_tools-0.1.20 → python_cad_tools-0.1.21/src/python_cad_tools.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-cad-tools
-Version: 0.1.20
+Version: 0.1.21
 Summary: Typed, headless Python tooling for CAD/BIM models and artifacts
 Author: Brandon Benge
 License: AGPL-3.0-only

python_cad_tools-0.1.21/src/python_cad_tools.egg-info/scm_version.json

@@ -0,0 +1,8 @@
+{
+  "tag": "0.1.21",
+  "distance": 0,
+  "node": "g9515aec6eea3d761681fbb33b7ecdb4b2b65625a",
+  "dirty": false,
+  "branch": "HEAD",
+  "node_date": "2026-10-27"
+}

python_cad_tools-0.1.20/src/python_cad_tools.egg-info/scm_version.json

@@ -1,8 +0,0 @@
-{
-  "tag": "0.1.20",
-  "distance": 0,
-  "node": "g046b2866e1daf8a34ec5a982d0c30d56f8545483",
-  "dirty": false,
-  "branch": "HEAD",
-  "node_date": "2026-10-21"
-}