python-aidot-cameras 0.7.22__tar.gz → 0.7.24__tar.gz

{python_aidot_cameras-0.7.22/src/python_aidot_cameras.egg-info → python_aidot_cameras-0.7.24}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-aidot-cameras
-Version: 0.7.22
+Version: 0.7.24
 Summary: Control AiDot/Leedarson WiFi lights and cameras (WebRTC streaming, two-way audio, PTZ, controls)
 Author-email: cbrightly <chris.brightly@gmail.com>
 License-Expression: MIT

{python_aidot_cameras-0.7.22 → python_aidot_cameras-0.7.24}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "python-aidot-cameras"
-version = "0.7.22"
+version = "0.7.24"
 description = "Control AiDot/Leedarson WiFi lights and cameras (WebRTC streaming, two-way audio, PTZ, controls)"
 readme = "README.md"
 license = "MIT"

{python_aidot_cameras-0.7.22 → python_aidot_cameras-0.7.24}/src/aidot/camera/client.py

@@ -543,6 +543,14 @@ class CameraMixin(_CameraControlsMixin):
     # data-channel-less; it's parked on the SDES/TUTK side anyway.
     _NO_DATACHANNEL_MODELS: frozenset = frozenset({"LK.IPC.A001064"})
 
+    # A001064's role-reversal handshake (the camera echoes our offer back as its
+    # own webrtcReq before doing ICE, and won't stream until it gets our
+    # webrtcResp) needs the camera armed BEFORE our webrtcReq.  sdes_fast_liveplay
+    # sends webrtcReq ~4.5 s earlier, which degrades A001064 media reliability
+    # (2/2 -> 1/2 media in a live A/B; the flag was soak-validated only on the
+    # A001513 battery cameras).  Exclude role-reversal models from the flag.
+    _NO_FAST_LIVEPLAY_MODELS: frozenset = frozenset({"LK.IPC.A001064"})
+
     @property
     def _offer_should_include_datachannel(self) -> bool:
         model = getattr(getattr(self, "info", None), "model_id", None)
@@ -2532,11 +2540,19 @@ class CameraMixin(_CameraControlsMixin):
             return 120.0
 
     def _resolve_sdes_fast_liveplay(self) -> bool:
-        """Whether to skip the ~2 s livePlayResp wait for SDES (P5, EXPERIMENTAL).
+        """Whether to use SDES fast-liveplay (shorten the always-timing-out
+        echo/livePlayResp signaling) - validated in soak, opt-in, default off.
 
         Per-camera ``sdes_fast_liveplay`` (set via start_keepalive) wins; else the
         ``AIDOT_SDES_FAST_LIVEPLAY`` env (truthy = 1/true/yes/on), default off.
-        Only consulted for SDES cameras (the caller gates on is_sdes_camera)."""
+        Only consulted for SDES cameras (the caller gates on is_sdes_camera).
+
+        Role-reversal models (``_NO_FAST_LIVEPLAY_MODELS``, e.g. A001064) are always
+        excluded - their handshake needs the camera armed before our webrtcReq, so
+        the flag's early webrtcReq degrades their media reliability."""
+        model = getattr(getattr(self, "info", None), "model_id", None)
+        if model in self._NO_FAST_LIVEPLAY_MODELS:
+            return False
         opt = getattr(self, "_sdes_fast_liveplay_opt", None)
         if opt is not None:
             return bool(opt)
@@ -7047,13 +7063,16 @@ class CameraMixin(_CameraControlsMixin):
         # webrtcReq.  The echo confirms the MQTT pipeline to this device is live
         # and the broker session is registered.  Fall through after 5 s if it
         # never arrives (same safety as the old fixed 0.5 s sleep, but adaptive).
-        # P5 (experimental, opt-in via sdes_fast_liveplay): instrumentation showed
+        # SDES fast-liveplay (opt-in via sdes_fast_liveplay): instrumentation showed
         # the echo and livePlayResp waits BOTH always time out for the SDES cameras
         # measured (echo/resp never arrive) yet streaming succeeds - i.e. ~6 s of
         # dead padding.  When the flag is on, cap the echo wait short and skip the
         # livePlayResp wait; the full ICE/TURN/SCTP handshake is untouched.  This
         # is the SDES path's OWN livePlay waits (the DTLS gate above never runs for
-        # SDES: use_sdes is True there).
+        # SDES: use_sdes is True there).  VALIDATED in a 3 h live soak (15 SDES
+        # opens across battery cameras, flag engaged on all, 0 churn / 0 fail,
+        # ~4.5 s signaling saved); kept off by default pending broader multi-day
+        # use (per-open + near-term stability proven, long-haul not yet).
         _skip_lp = self._resolve_sdes_fast_liveplay()
         _echo_timeout = 1.5 if _skip_lp else 5.0
         _echo_t0 = time.monotonic()

{python_aidot_cameras-0.7.22 → python_aidot_cameras-0.7.24/src/python_aidot_cameras.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-aidot-cameras
-Version: 0.7.22
+Version: 0.7.24
 Summary: Control AiDot/Leedarson WiFi lights and cameras (WebRTC streaming, two-way audio, PTZ, controls)
 Author-email: cbrightly <chris.brightly@gmail.com>
 License-Expression: MIT

{python_aidot_cameras-0.7.22 → python_aidot_cameras-0.7.24}/tests/test_sdes_fast_liveplay.py

@@ -38,6 +38,22 @@ def test_env_falsey_values(monkeypatch):
         assert _cam()._resolve_sdes_fast_liveplay() is False, val
 
 
+def test_role_reversal_model_always_excluded(monkeypatch):
+    # A001064 (role-reversal) must NOT use the flag even when opt/env force it on -
+    # the early webrtcReq degrades its media reliability.
+    from types import SimpleNamespace
+    monkeypatch.setenv("AIDOT_SDES_FAST_LIVEPLAY", "1")
+    cam = _cam()
+    cam.info = SimpleNamespace(model_id="LK.IPC.A001064")
+    cam._sdes_fast_liveplay_opt = True
+    assert cam._resolve_sdes_fast_liveplay() is False
+    # a non-excluded SDES model still honours the flag
+    cam2 = _cam()
+    cam2.info = SimpleNamespace(model_id="LK.IPC.A001513")
+    cam2._sdes_fast_liveplay_opt = True
+    assert cam2._resolve_sdes_fast_liveplay() is True
+
+
 def test_kwarg_option_wins_over_env(monkeypatch):
     monkeypatch.setenv("AIDOT_SDES_FAST_LIVEPLAY", "1")
     cam = _cam()