python-aidot-cameras 0.15.6__tar.gz → 0.15.7__tar.gz

{python_aidot_cameras-0.15.6/python_aidot_cameras.egg-info → python_aidot_cameras-0.15.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-aidot-cameras
-Version: 0.15.6
+Version: 0.15.7
 Summary: Control AiDot/Leedarson WiFi lights and cameras (WebRTC streaming, two-way audio, PTZ, controls)
 Author-email: cbrightly <chris.brightly@gmail.com>
 License-Expression: MIT

{python_aidot_cameras-0.15.6 → python_aidot_cameras-0.15.7}/aidot_cameras/camera/sdes_open.py

@@ -3637,7 +3637,16 @@ class _SdesOpenMixin:
                                 if not _sdes_probe_received:
                                     _sdes_probe_received = True
                                     _last_hb_ts = _time_br.time()  # HB fires in 10s
-                                if not hasattr(_bridge_fn, '_tutk_seq'):
+                                # Guard on a counter that is actually assigned.
+                                # This used to test `_tutk_seq`, a name nothing
+                                # ever set, so hasattr was False on EVERY packet
+                                # and both counters were reset to 0 each time -
+                                # every synthesized packet went out with
+                                # sequence number 1.  ffmpeg reads a constant
+                                # sequence as a stream of discontinuities and
+                                # reports `RTP: missed N packets` for loss that
+                                # never happened.
+                                if not hasattr(_bridge_fn, '_tutk_seq_v'):
                                     _bridge_fn._tutk_seq_a = 0
                                     _bridge_fn._tutk_seq_v = 0
                                 if _tk_audio:

{python_aidot_cameras-0.15.6 → python_aidot_cameras-0.15.7}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "python-aidot-cameras"
-version = "0.15.6"
+version = "0.15.7"
 description = "Control AiDot/Leedarson WiFi lights and cameras (WebRTC streaming, two-way audio, PTZ, controls)"
 readme = "README.md"
 license = "MIT"

{python_aidot_cameras-0.15.6 → python_aidot_cameras-0.15.7/python_aidot_cameras.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-aidot-cameras
-Version: 0.15.6
+Version: 0.15.7
 Summary: Control AiDot/Leedarson WiFi lights and cameras (WebRTC streaming, two-way audio, PTZ, controls)
 Author-email: cbrightly <chris.brightly@gmail.com>
 License-Expression: MIT

{python_aidot_cameras-0.15.6 → python_aidot_cameras-0.15.7}/python_aidot_cameras.egg-info/SOURCES.txt

@@ -78,6 +78,7 @@ tests/test_battery_detection.py
 tests/test_battery_evidence_corroboration.py
 tests/test_battery_skip_turn.py
 tests/test_ble_gateway.py
+tests/test_bridge_state_sentinels.py
 tests/test_constants_imports_resolve.py
 tests/test_deferred_hardening.py
 tests/test_device_login_guard.py

python_aidot_cameras-0.15.7/tests/test_bridge_state_sentinels.py

@@ -0,0 +1,68 @@
+"""Lazy-init guards on the bridge must name a variable something actually sets.
+
+The bridge keeps its per-session state as attributes on its own function object
+and initialises them with `if not hasattr(_bridge_fn, 'X')`. That idiom fails
+silently when `X` is not the attribute the block goes on to assign: the guard is
+true on every packet, so the state resets every packet, and nothing raises.
+
+It happened. The TUTK-to-RTP synthesis guarded on `_tutk_seq` while assigning
+`_tutk_seq_a` and `_tutk_seq_v`, so both sequence counters reset on every packet
+and every synthesized RTP packet carried sequence number 1. ffmpeg reads a
+constant sequence as a stream of discontinuities and logs `RTP: missed N
+packets` - loss that never happened, on a hop where the kernel counters showed
+zero drops. Measured on the box: 0 drops on every socket in the path while
+ffmpeg reported 21 new missed-packet lines in one window.
+
+These tests read the source because the bridge is one long closure that cannot
+be called in isolation.
+"""
+import inspect
+import re
+
+from aidot_cameras.camera import sdes_open
+
+_SRC = inspect.getsource(sdes_open)
+
+
+def _assigned_attrs() -> set:
+    """Every `_bridge_fn.X = ...` attribute assigned anywhere in the module."""
+    return set(re.findall(r"_bridge_fn\.([A-Za-z_][A-Za-z0-9_]*)\s*=[^=]", _SRC))
+
+
+def test_every_hasattr_sentinel_is_a_name_something_assigns():
+    guarded = set(re.findall(r"hasattr\(_bridge_fn,\s*'([^']+)'\)", _SRC))
+    assigned = _assigned_attrs()
+    orphans = sorted(guarded - assigned)
+    assert not orphans, (
+        "these hasattr guards name attributes nothing ever assigns, so they are "
+        f"true on every packet and reset their state each time: {orphans}"
+    )
+
+
+def test_the_tutk_sequence_counters_survive_between_packets():
+    """The specific regression: a constant RTP sequence number.
+
+    Pin the guard to a counter the block assigns, so a reset-per-packet cannot
+    come back by renaming one side of the pair.
+    """
+    block = re.search(
+        r"if not hasattr\(_bridge_fn,\s*'([^']+)'\):\s*\n"
+        r"\s*_bridge_fn\._tutk_seq_a = 0\s*\n"
+        r"\s*_bridge_fn\._tutk_seq_v = 0",
+        _SRC,
+    )
+    assert block, "the TUTK sequence init block moved - re-point this test"
+    sentinel = block.group(1)
+    assert sentinel in ("_tutk_seq_a", "_tutk_seq_v"), (
+        f"the guard tests {sentinel!r}, which is not one of the counters it "
+        "initialises - the counters will reset on every packet and every "
+        "synthesized packet will carry the same sequence number"
+    )
+
+
+def test_the_counters_increment_rather_than_being_reassigned():
+    """Both counters must advance from their previous value, not restart."""
+    for name in ("_tutk_seq_a", "_tutk_seq_v"):
+        assert re.search(
+            rf"_bridge_fn\.{name} = \(_bridge_fn\.{name} \+ 1\) & 0xFFFF", _SRC
+        ), f"{name} no longer advances from its own previous value"