pythia-plsql 0.3.0__tar.gz → 0.3.2__tar.gz

{pythia_plsql-0.3.0/scripts/pythia_plsql.egg-info → pythia_plsql-0.3.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pythia-plsql
-Version: 0.3.0
+Version: 0.3.2
 Summary: PL/SQL development for AI agents on Oracle Database - expert data-dictionary queries, impact analysis, and a snapshot-verified write path with honest rollback.
 License: MIT
 Project-URL: Homepage, https://github.com/thaildhe172591/pythia

{pythia_plsql-0.3.0 → pythia_plsql-0.3.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "pythia-plsql"
-version = "0.3.0"
+version = "0.3.2"
 description = "PL/SQL development for AI agents on Oracle Database - expert data-dictionary queries, impact analysis, and a snapshot-verified write path with honest rollback."
 readme = "README.md"
 license = { text = "MIT" }

{pythia_plsql-0.3.0 → pythia_plsql-0.3.2}/scripts/pythia.py

@@ -201,17 +201,38 @@ def invocation():
     return pathlib.Path(prog).name
 
 
+HEADLESS_YES_MSG = (
+    "--yes is the developer's flag, and no terminal is attached to this "
+    "session.\nAgents preview, relay the diff and the impact verbatim, "
+    "STOP, and pass --confirm <token> only after the developer's explicit "
+    "approval in chat.\n(Real pipelines set PYTHIA_CI=1.)")
+
+
 def human_at_the_keyboard():
-    """True only when a person is typing: stdin is a TTY. An agent driving
-    the CLI through a subprocess has no TTY and cannot fake one — which is
-    exactly why the loosening actions below key on this. PYTHIA_CI=1 is the
-    documented escape for real pipelines."""
+    """True only when a person is typing at a real console.
+
+    isatty() alone is not enough on Windows: NUL is a character device, so
+    a subprocess launched with stdin=DEVNULL reports isatty() == True and
+    would sail straight through this gate. Only a real console answers
+    GetConsoleMode, so ask that too. PYTHIA_CI=1 is the documented escape
+    for real pipelines."""
     if os.environ.get("PYTHIA_CI"):
         return True
     try:
-        return sys.stdin.isatty()
+        if not sys.stdin.isatty():
+            return False
     except (AttributeError, ValueError):
         return False
+    if os.name == "nt":
+        try:
+            import ctypes
+            handle = ctypes.windll.kernel32.GetStdHandle(-10)  # STD_INPUT
+            mode = ctypes.c_ulong()
+            return bool(ctypes.windll.kernel32.GetConsoleMode(
+                handle, ctypes.byref(mode)))
+        except Exception:   # noqa: BLE001 — any failure means "not a console"
+            return False
+    return True
 
 
 def forbid_write_flag(argv):
@@ -610,6 +631,12 @@ def load_settings(root):
         sys.exit(f"Cannot parse {path}: {e}")
 
 
+def undo_group_action(ns):
+    """Undoing a CREATE is a DROP, which is `structural` — so the policy on
+    that group decides whether the restore command we print can run."""
+    return load_policy(ns.project_root)["structural"][0]
+
+
 def journal_root(root):
     return pathlib.Path(root) / CONFIG_DIR / "journal"
 
@@ -1124,11 +1151,7 @@ def run_apply(conn, schema, ns, file_text, origin=None):
         db_source = "".join(cell(r[0]) for r in rows)
     token = apply_token(otype, name, file_text, db_source)
     if ns.yes and not human_at_the_keyboard():
-        sys.exit("--yes is the developer's flag, and no terminal is attached "
-                 "to this session.\nAgents preview, relay the diff and the "
-                 "impact verbatim, STOP, and pass --confirm <token> only "
-                 "after the developer's explicit approval in chat.\n"
-                 "(Real pipelines set PYTHIA_CI=1.)")
+        sys.exit(HEADLESS_YES_MSG)
     confirmed = bool(ns.yes) or ns.confirm == token
     if ns.confirm and ns.confirm != token:
         sys.exit("The confirmation token does not match: the file or the "
@@ -1234,6 +1257,9 @@ def run_apply(conn, schema, ns, file_text, origin=None):
                           "type": otype, "errors": [list(r) for r in own_errors],
                           "newly_invalid": [list(x) for x in broke],
                           "restore": f"{invocation()} journal restore {entry}",
+                          "restore_is_drop": created,
+                          "restore_blocked_by_policy": (
+                              created and undo_group_action(ns) == "deny"),
                           "exit": 0 if ok else 3}))
     else:
         en = getattr(ns, "color", False)
@@ -1254,9 +1280,21 @@ def run_apply(conn, schema, ns, file_text, origin=None):
                 print(f"  {len(broke)} objects were VALID before and are INVALID now:")
                 for n2, t2 in broke:
                     print(paint(f"    {n2} ({t2})", "red", en))
-        undo = "dropping it (it did not exist before)" if created else None
-        print(f"\n  To undo{' — note: undo means ' + undo if undo else ''}:")
-        print("    " + paint(f"{invocation()} journal restore {entry}", "cyan", en))
+        if created:
+            print("\n  To undo — note: undo means DROPPING it "
+                  "(it did not exist before):")
+        else:
+            print("\n  To undo:")
+        print("    " + paint(f"{invocation()} journal restore {entry}",
+                             "cyan", en))
+        if created and undo_group_action(ns) == "deny":
+            # the honest half: that restore is a DROP, DROP is structural,
+            # and structural is deny — so the line above would be refused
+            print(paint("  ...but that restore is a DROP, and structural is "
+                        "set to deny, so it will be refused.", "yellow", en))
+            print(paint("  The developer decides: "
+                        f"{invocation()} policy set structural confirm",
+                        "yellow", en))
     return 0 if ok else 3
 
 
@@ -1842,6 +1880,15 @@ def main(argv=None):
         except AttributeError:
             pass
     ns = build_parser().parse_args(argv)
+    # refusals that need no database come first — an unreachable or locked
+    # connection must never mask them
+    if ns.command == "sql" and not is_readonly_sql(
+            " ".join(ns.statement).strip().rstrip(";")):
+        sys.exit("Only SELECT/WITH statements are allowed; sql is read-only."
+                 f"\nThe write path is `{invocation()} apply <file>` — "
+                 "snapshot, preview and verify included.")
+    if getattr(ns, "yes", False) and not human_at_the_keyboard():
+        sys.exit(HEADLESS_YES_MSG)
     ns.color = color_enabled() and not ns.json
     if ns.color and os.name == "nt":
         # Constant empty string, never user input — safe from injection. This

{pythia_plsql-0.3.0 → pythia_plsql-0.3.2/scripts/pythia_plsql.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pythia-plsql
-Version: 0.3.0
+Version: 0.3.2
 Summary: PL/SQL development for AI agents on Oracle Database - expert data-dictionary queries, impact analysis, and a snapshot-verified write path with honest rollback.
 License: MIT
 Project-URL: Homepage, https://github.com/thaildhe172591/pythia

{pythia_plsql-0.3.0 → pythia_plsql-0.3.2}/tests/test_install.py

@@ -122,6 +122,29 @@ def test_agent_user_json_saves_the_same_password_it_prints():
             os.chdir(cwd)
 
 
+def test_devnull_stdin_is_not_a_human():
+    """The gate must hold for a real subprocess, not just in theory. On
+    Windows NUL is a character device and isatty() says True for it, so a
+    stdin=DEVNULL child would otherwise self-approve writes."""
+    import os
+    import subprocess
+    env = {k: v for k, v in os.environ.items() if k != "PYTHIA_CI"}
+    with tempfile.TemporaryDirectory() as td:
+        (pathlib.Path(td) / ".pythia").mkdir()
+        (pathlib.Path(td) / ".pythia" / "connections.json").write_text(
+            json.dumps({"dev": {"host": "h", "user": "U", "password": "p",
+                                "schema": "U"}}), encoding="utf-8")
+        env["PYTHONPATH"] = str(ROOT / "scripts")   # -m pythia from the repo
+        r = subprocess.run(
+            [sys.executable, "-m", "pythia", "policy", "set", "structural",
+             "allow"],
+            cwd=td, env=env, stdin=subprocess.DEVNULL, text=True,
+            capture_output=True)
+        assert r.returncode != 0, r.stdout + r.stderr
+        assert "developer" in (r.stdout + r.stderr).lower()
+        assert not (pathlib.Path(td) / ".pythia" / "policy.json").is_file()
+
+
 def test_one_version_across_every_manifest():
     """pyproject, plugin.json, marketplace.json and npm/package.json must all
     carry the same version — the release workflow publishes from one tag."""

{pythia_plsql-0.3.0 → pythia_plsql-0.3.2}/tests/test_phase3.py

@@ -658,6 +658,35 @@ def test_headless_policy_loosening_is_refused_tightening_allowed():
         assert pythia.load_policy(td)["plsql_source"][0] == "deny"
 
 
+def test_report_admits_a_created_objects_undo_is_blocked():
+    """pythia exists so nothing lies about rollback. Undoing a CREATE is a
+    DROP, DROP is structural, and structural is deny by default — so the
+    printed restore command would be refused. Say so, in the same breath."""
+    import contextlib
+    import io
+    with tempfile.TemporaryDirectory() as td:
+        conn = FakeConn(base_script(db_source=""))     # object did not exist
+        buf = io.StringIO()
+        with contextlib.redirect_stdout(buf):
+            pythia.run_apply(conn, "APP", apply_ns(td, file="f.sql", yes=True),
+                             NEW_FILE)
+        out = buf.getvalue().lower()
+        assert "dropping it" in out
+        assert "will be refused" in out, out[-400:]
+        assert "policy set structural confirm" in out
+    # and once the developer has loosened it, the warning goes away
+    with tempfile.TemporaryDirectory() as td:
+        pathlib.Path(td, ".pythia").mkdir()
+        pathlib.Path(td, ".pythia", "policy.json").write_text(
+            '{"structural": "confirm"}', encoding="utf-8")
+        conn = FakeConn(base_script(db_source=""))
+        buf = io.StringIO()
+        with contextlib.redirect_stdout(buf):
+            pythia.run_apply(conn, "APP", apply_ns(td, file="f.sql", yes=True),
+                             NEW_FILE)
+        assert "will be refused" not in buf.getvalue().lower()
+
+
 def main():
     failed = 0
     for name, fn in sorted(globals().items()):