pyrefly 0.29.0__tar.gz → 0.29.2__tar.gz

{pyrefly-0.29.0 → pyrefly-0.29.2}/Cargo.lock

@@ -2058,7 +2058,7 @@ dependencies = [
 
 [[package]]
 name = "pyrefly"
-version = "0.29.0"
+version = "0.29.2"
 dependencies = [
  "anstream",
  "anyhow",
@@ -2106,7 +2106,7 @@ dependencies = [
 
 [[package]]
 name = "pyrefly_bundled"
-version = "0.29.0"
+version = "0.29.2"
 dependencies = [
  "anyhow",
  "starlark_map",
@@ -2116,7 +2116,7 @@ dependencies = [
 
 [[package]]
 name = "pyrefly_config"
-version = "0.29.0"
+version = "0.29.2"
 dependencies = [
  "anyhow",
  "clap",
@@ -2149,7 +2149,7 @@ dependencies = [
 
 [[package]]
 name = "pyrefly_derive"
-version = "0.29.0"
+version = "0.29.2"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -2158,7 +2158,7 @@ dependencies = [
 
 [[package]]
 name = "pyrefly_python"
-version = "0.29.0"
+version = "0.29.2"
 dependencies = [
  "anyhow",
  "dupe",
@@ -2180,7 +2180,7 @@ dependencies = [
 
 [[package]]
 name = "pyrefly_types"
-version = "0.29.0"
+version = "0.29.2"
 dependencies = [
  "compact_str 0.8.0",
  "dupe",
@@ -2200,7 +2200,7 @@ dependencies = [
 
 [[package]]
 name = "pyrefly_util"
-version = "0.29.0"
+version = "0.29.2"
 dependencies = [
  "anstream",
  "anyhow",
@@ -2538,15 +2538,15 @@ dependencies = [
 
 [[package]]
 name = "rustix"
-version = "1.0.7"
+version = "1.0.8"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c71e83d6afe7ff64890ec6b71d6a69bb8a610ab78ce364b3352876bb4c801266"
+checksum = "11181fbabf243db407ef8df94a6ce0b2f9a733bd8be4ad02b4eda9602296cac8"
 dependencies = [
  "bitflags 2.9.0",
  "errno",
  "libc",
  "linux-raw-sys 0.9.4",
- "windows-sys 0.59.0",
+ "windows-sys 0.60.2",
 ]
 
 [[package]]
@@ -2906,7 +2906,7 @@ dependencies = [
  "fastrand",
  "getrandom 0.3.3",
  "once_cell",
- "rustix 1.0.7",
+ "rustix 1.0.8",
  "windows-sys 0.59.0",
 ]
 
@@ -2925,7 +2925,7 @@ version = "0.4.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "45c6481c4829e4cc63825e62c49186a34538b7b2750b73b266581ffb612fb5ed"
 dependencies = [
- "rustix 1.0.7",
+ "rustix 1.0.8",
  "windows-sys 0.59.0",
 ]
 
@@ -3558,6 +3558,15 @@ dependencies = [
  "windows-targets 0.52.6",
 ]
 
+[[package]]
+name = "windows-sys"
+version = "0.60.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "f2f500e4d28234f72040990ec9d39e3a6b950f9f22d3dba18416c35882612bcb"
+dependencies = [
+ "windows-targets 0.53.2",
+]
+
 [[package]]
 name = "windows-targets"
 version = "0.42.1"
@@ -3597,13 +3606,29 @@ dependencies = [
  "windows_aarch64_gnullvm 0.52.6",
  "windows_aarch64_msvc 0.52.6",
  "windows_i686_gnu 0.52.6",
- "windows_i686_gnullvm",
+ "windows_i686_gnullvm 0.52.6",
  "windows_i686_msvc 0.52.6",
  "windows_x86_64_gnu 0.52.6",
  "windows_x86_64_gnullvm 0.52.6",
  "windows_x86_64_msvc 0.52.6",
 ]
 
+[[package]]
+name = "windows-targets"
+version = "0.53.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c66f69fcc9ce11da9966ddb31a40968cad001c5bedeb5c2b82ede4253ab48aef"
+dependencies = [
+ "windows_aarch64_gnullvm 0.53.0",
+ "windows_aarch64_msvc 0.53.0",
+ "windows_i686_gnu 0.53.0",
+ "windows_i686_gnullvm 0.53.0",
+ "windows_i686_msvc 0.53.0",
+ "windows_x86_64_gnu 0.53.0",
+ "windows_x86_64_gnullvm 0.53.0",
+ "windows_x86_64_msvc 0.53.0",
+]
+
 [[package]]
 name = "windows_aarch64_gnullvm"
 version = "0.42.1"
@@ -3622,6 +3647,12 @@ version = "0.52.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "32a4622180e7a0ec044bb555404c800bc9fd9ec262ec147edd5989ccd0c02cd3"
 
+[[package]]
+name = "windows_aarch64_gnullvm"
+version = "0.53.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "86b8d5f90ddd19cb4a147a5fa63ca848db3df085e25fee3cc10b39b6eebae764"
+
 [[package]]
 name = "windows_aarch64_msvc"
 version = "0.42.1"
@@ -3640,6 +3671,12 @@ version = "0.52.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "09ec2a7bb152e2252b53fa7803150007879548bc709c039df7627cabbd05d469"
 
+[[package]]
+name = "windows_aarch64_msvc"
+version = "0.53.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c7651a1f62a11b8cbd5e0d42526e55f2c99886c77e007179efff86c2b137e66c"
+
 [[package]]
 name = "windows_i686_gnu"
 version = "0.42.1"
@@ -3658,12 +3695,24 @@ version = "0.52.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "8e9b5ad5ab802e97eb8e295ac6720e509ee4c243f69d781394014ebfe8bbfa0b"
 
+[[package]]
+name = "windows_i686_gnu"
+version = "0.53.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c1dc67659d35f387f5f6c479dc4e28f1d4bb90ddd1a5d3da2e5d97b42d6272c3"
+
 [[package]]
 name = "windows_i686_gnullvm"
 version = "0.52.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "0eee52d38c090b3caa76c563b86c3a4bd71ef1a819287c19d586d7334ae8ed66"
 
+[[package]]
+name = "windows_i686_gnullvm"
+version = "0.53.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "9ce6ccbdedbf6d6354471319e781c0dfef054c81fbc7cf83f338a4296c0cae11"
+
 [[package]]
 name = "windows_i686_msvc"
 version = "0.42.1"
@@ -3682,6 +3731,12 @@ version = "0.52.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "240948bc05c5e7c6dabba28bf89d89ffce3e303022809e73deaefe4f6ec56c66"
 
+[[package]]
+name = "windows_i686_msvc"
+version = "0.53.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "581fee95406bb13382d2f65cd4a908ca7b1e4c2f1917f143ba16efe98a589b5d"
+
 [[package]]
 name = "windows_x86_64_gnu"
 version = "0.42.1"
@@ -3700,6 +3755,12 @@ version = "0.52.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "147a5c80aabfbf0c7d901cb5895d1de30ef2907eb21fbbab29ca94c5b08b1a78"
 
+[[package]]
+name = "windows_x86_64_gnu"
+version = "0.53.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "2e55b5ac9ea33f2fc1716d1742db15574fd6fc8dadc51caab1c16a3d3b4190ba"
+
 [[package]]
 name = "windows_x86_64_gnullvm"
 version = "0.42.1"
@@ -3718,6 +3779,12 @@ version = "0.52.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "24d5b23dc417412679681396f2b49f3de8c1473deb516bd34410872eff51ed0d"
 
+[[package]]
+name = "windows_x86_64_gnullvm"
+version = "0.53.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "0a6e035dd0599267ce1ee132e51c27dd29437f63325753051e71dd9e42406c57"
+
 [[package]]
 name = "windows_x86_64_msvc"
 version = "0.42.1"
@@ -3736,6 +3803,12 @@ version = "0.52.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "589f6da84c646204747d1270a2a5661ea66ed1cced2631d546fdfb155959f9ec"
 
+[[package]]
+name = "windows_x86_64_msvc"
+version = "0.53.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "271414315aff87387382ec3d271b52d7ae78726f5d44ac98b4f4030c91880486"
+
 [[package]]
 name = "winnow"
 version = "0.7.10"
@@ -3773,7 +3846,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "0d65cbf2f12c15564212d48f4e3dfb87923d25d611f2aed18f4cb23f0413d89e"
 dependencies = [
  "libc",
- "rustix 1.0.7",
+ "rustix 1.0.8",
 ]
 
 [[package]]

{pyrefly-0.29.0 → pyrefly-0.29.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pyrefly
-Version: 0.29.0
+Version: 0.29.2
 Classifier: Development Status :: 3 - Alpha
 Classifier: Programming Language :: Python
 Classifier: Programming Language :: Python :: 3

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_bundled/Cargo.toml

@@ -2,7 +2,7 @@
 
 [package]
 name = "pyrefly_bundled"
-version = "0.29.0"
+version = "0.29.2"
 authors = ["Meta"]
 edition = "2024"
 repository = "https://github.com/facebook/pyrefly"

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_config/Cargo.toml

@@ -2,7 +2,7 @@
 
 [package]
 name = "pyrefly_config"
-version = "0.29.0"
+version = "0.29.2"
 authors = ["Meta"]
 edition = "2024"
 repository = "https://github.com/facebook/pyrefly"

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_config/src/args.rs

@@ -92,6 +92,12 @@ pub struct ConfigOverrideArgs {
     /// Whether to ignore type errors in generated code.
     #[arg(long)]
     ignore_errors_in_generated_code: Option<bool>,
+    /// If this is true, infer type variables not determined by a call or constructor based on their first usage.
+    /// For example, the type of an empty container would be determined by the first thing you put into it.
+    /// If this is false, any unsolved type variables at the end of a call or constructor will be replaced with `Any`.
+    /// Defaults to true.
+    #[arg(long)]
+    infer_with_first_use: Option<bool>,
     /// Whether to respect ignore files (.gitignore, .ignore, .git/exclude).
     #[arg(long)]
     use_ignore_files: Option<bool>,
@@ -216,6 +222,9 @@ impl ConfigOverrideArgs {
         if let Some(x) = &self.ignore_errors_in_generated_code {
             config.root.ignore_errors_in_generated_code = Some(*x);
         }
+        if let Some(x) = &self.infer_with_first_use {
+            config.root.infer_with_first_use = Some(*x);
+        }
         let apply_error_settings = |error_config: &mut ErrorDisplayConfig| {
             for error_kind in &self.error {
                 error_config.set_error_severity(*error_kind, Severity::Error);

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_config/src/base.rs

@@ -71,6 +71,11 @@ pub struct ConfigBase {
     )]
     pub ignore_errors_in_generated_code: Option<bool>,
 
+    /// Whether to infer empty container types as Any instead of creating type variables.
+    /// By default this is enabled.
+    #[serde(default, skip_serializing_if = "Option::is_none")]
+    pub infer_with_first_use: Option<bool>,
+
     /// Any unknown config items
     #[serde(default, flatten)]
     pub(crate) extras: ExtraConfigs,
@@ -109,4 +114,8 @@ impl ConfigBase {
     pub fn get_ignore_errors_in_generated_code(base: &Self) -> Option<bool> {
         base.ignore_errors_in_generated_code
     }
+
+    pub fn get_infer_with_first_use(base: &Self) -> Option<bool> {
+        base.infer_with_first_use
+    }
 }

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_config/src/config.rs

@@ -375,6 +375,9 @@ impl ConfigFile {
     pub const PYREFLY_FILE_NAME: &str = "pyrefly.toml";
     pub const PYPROJECT_FILE_NAME: &str = "pyproject.toml";
     pub const CONFIG_FILE_NAMES: &[&str] = &[Self::PYREFLY_FILE_NAME, Self::PYPROJECT_FILE_NAME];
+    /// Files that don't contain pyrefly-specific config information but indicate that we're at the
+    /// root of a Python project, which should be added to the search path.
+    pub const ADDITIONAL_ROOT_FILE_NAMES: &[&str] = &["mypy.ini", "pyrightconfig.json"];
 
     /// Writes the configuration to a file in the specified directory.
     /// TODO(connernilsen) relative these paths to the config file's directory
@@ -387,9 +390,6 @@ impl ConfigFile {
 
         Ok(())
     }
-    /// Files that don't contain pyrefly-specific config information but indicate that we're at the
-    /// root of a Python project, which should be added to the search path.
-    pub const ADDITIONAL_ROOT_FILE_NAMES: &[&str] = &["setup.py", "mypy.ini", "pyrightconfig.json"];
 
     pub fn default_project_includes() -> Globs {
         Globs::new(vec!["**/*".to_owned()]).unwrap_or_else(|_| Globs::empty())
@@ -397,6 +397,9 @@ impl ConfigFile {
 
     pub fn default_project_excludes() -> Globs {
         Globs::new(vec![
+            // Align with https://code.visualstudio.com/docs/python/settings-reference#_pylance-language-server
+            "**/node_modules".to_owned(),
+            "**/__pycache__".to_owned(),
             // match any `.venv` or `venv` directory
             "**/*venv/**".to_owned(),
             // Note: dot files are now excluded at the Glob::files() level
@@ -443,7 +446,7 @@ impl ConfigFile {
     }
 
     /// Gets the full, ordered path used for import lookup. Used for pretty-printing.
-    pub fn structured_import_lookup_path(&self) -> Vec<ImportLookupPathPart> {
+    pub fn structured_import_lookup_path(&self) -> Vec<ImportLookupPathPart<'_>> {
         let mut result = vec![
             ImportLookupPathPart::SearchPathFromArgs(&self.search_path_from_args),
             ImportLookupPathPart::SearchPathFromFile(&self.search_path_from_file),
@@ -515,6 +518,14 @@ impl ConfigFile {
                  self.root.ignore_errors_in_generated_code.unwrap())
     }
 
+    pub fn infer_with_first_use(&self, path: &Path) -> bool {
+        self.get_from_sub_configs(ConfigBase::get_infer_with_first_use, path)
+            .unwrap_or_else(||
+                 // we can use unwrap here, because the value in the root config must
+                 // be set in `ConfigFile::configure()`.
+                 self.root.infer_with_first_use.unwrap())
+    }
+
     pub fn permissive_ignores(&self, path: &Path) -> bool {
         self.get_from_sub_configs(|x| x.permissive_ignores, path)
             .unwrap_or_else(||
@@ -523,7 +534,7 @@ impl ConfigFile {
                 self.root.permissive_ignores.unwrap())
     }
 
-    pub fn get_error_config(&self, path: &Path) -> ErrorConfig {
+    pub fn get_error_config(&self, path: &Path) -> ErrorConfig<'_> {
         ErrorConfig::new(
             self.errors(path),
             self.ignore_errors_in_generated_code(path),
@@ -591,6 +602,10 @@ impl ConfigFile {
             self.root.ignore_errors_in_generated_code = Some(Default::default());
         }
 
+        if self.root.infer_with_first_use.is_none() {
+            self.root.infer_with_first_use = Some(true);
+        }
+
         if self.root.permissive_ignores.is_none() {
             self.root.permissive_ignores = Some(false);
         }
@@ -832,6 +847,7 @@ mod tests {
              replace-imports-with-any = []
              ignore-missing-imports = []
              ignore-errors-in-generated-code = false
+             infer-with-first-use = false
              [sub-config.errors]
              assert-type = false
              invalid-yield = false
@@ -876,6 +892,7 @@ mod tests {
                         (ErrorKind::AssertType, Severity::Error),
                     ]))),
                     ignore_errors_in_generated_code: Some(true),
+                    infer_with_first_use: None,
                     replace_imports_with_any: Some(vec![ModuleWildcard::new("fibonacci").unwrap()]),
                     ignore_missing_imports: Some(vec![ModuleWildcard::new("sprout").unwrap()]),
                     untyped_def_behavior: Some(UntypedDefBehavior::CheckAndInferReturnType),
@@ -891,6 +908,7 @@ mod tests {
                             (ErrorKind::AssertType, Severity::Ignore),
                         ]))),
                         ignore_errors_in_generated_code: Some(false),
+                        infer_with_first_use: Some(false),
                         replace_imports_with_any: Some(Vec::new()),
                         ignore_missing_imports: Some(Vec::new()),
                         untyped_def_behavior: Some(UntypedDefBehavior::CheckAndInferReturnAny),
@@ -1248,6 +1266,7 @@ mod tests {
                 ignore_missing_imports: None,
                 untyped_def_behavior: Some(UntypedDefBehavior::CheckAndInferReturnType),
                 ignore_errors_in_generated_code: Some(false),
+                infer_with_first_use: Some(true),
                 extras: Default::default(),
                 permissive_ignores: Some(false),
             },
@@ -1339,16 +1358,6 @@ mod tests {
         );
     }
 
-    #[test]
-    fn test_setup_py_search_path() {
-        let root = TempDir::new().unwrap();
-        let config = create_empty_file_and_parse_config(&root, "setup.py");
-        assert_eq!(
-            config.search_path().cloned().collect::<Vec<_>>(),
-            vec![root.path().to_path_buf()]
-        );
-    }
-
     #[test]
     fn test_mypy_config_search_path() {
         let root = TempDir::new().unwrap();
@@ -1434,10 +1443,14 @@ mod tests {
             FilteredGlobs::new(
                 config.project_includes.clone(),
                 Globs::new(
-                    vec!["**/*venv/**".to_owned()]
-                        .into_iter()
-                        .chain(site_package_path.clone())
-                        .collect::<Vec<_>>()
+                    vec![
+                        "**/node_modules".to_owned(),
+                        "**/__pycache__".to_owned(),
+                        "**/*venv/**".to_owned()
+                    ]
+                    .into_iter()
+                    .chain(site_package_path.clone())
+                    .collect::<Vec<_>>()
                 )
                 .unwrap(),
                 None,

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_config/src/error.rs

@@ -36,7 +36,7 @@ impl ErrorDisplayConfig {
             .unwrap_or_else(|| kind.default_severity())
     }
 
-    pub(crate) fn set_error_severity(&mut self, kind: ErrorKind, severity: Severity) {
+    pub fn set_error_severity(&mut self, kind: ErrorKind, severity: Severity) {
         self.0.insert(kind, severity);
     }
 }

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_config/src/error_kind.rs

@@ -200,6 +200,8 @@ pub enum ErrorKind {
     ParseError,
     /// The attribute exists but cannot be modified.
     ReadOnly,
+    /// Warning when casting a value to a type it is already compatible with.
+    RedundantCast,
     /// Attempting to use value that is equivalent to True or always False in boolean context.
     RedundantCondition,
     /// Raised by a call to reveal_type().
@@ -261,6 +263,8 @@ impl ErrorKind {
         match self {
             ErrorKind::RevealType => Severity::Info,
             ErrorKind::Deprecated => Severity::Warn,
+            ErrorKind::RedundantCast => Severity::Warn,
+            ErrorKind::ImplicitlyDefinedAttribute => Severity::Ignore,
             _ => Severity::Error,
         }
     }

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_config/src/migration/pyright.rs

@@ -102,6 +102,9 @@ impl PyrightConfig {
             let _ = option.migrate_from_pyright(&self, &mut cfg);
         }
 
+        // Pyright does not infer empty container types and unsolved type variables based on their first use.
+        cfg.root.infer_with_first_use = Some(false);
+
         cfg
     }
 }
@@ -266,6 +269,10 @@ mod tests {
                         .interpreter_site_package_path
                         .clone(),
                 },
+                root: ConfigBase {
+                    infer_with_first_use: Some(false),
+                    ..Default::default()
+                },
                 ..Default::default()
             }
         );
@@ -302,6 +309,10 @@ mod tests {
                         .interpreter_site_package_path
                         .clone(),
                 },
+                root: ConfigBase {
+                    infer_with_first_use: Some(false),
+                    ..Default::default()
+                },
                 ..Default::default()
             }
         );

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_config/src/migration/run.rs

@@ -398,7 +398,7 @@ files = ["mypy.py"]
         fs_anyhow::write(&original_config_path, b"{}")?;
         config_migration(&original_config_path)?;
         let output = fs_anyhow::read_to_string(&pyrefly_config_path)?;
-        assert_eq!(output, "");
+        assert_eq!(output, "infer-with-first-use = false\n");
         Ok(())
     }
 }

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_derive/Cargo.toml

@@ -2,7 +2,7 @@
 
 [package]
 name = "pyrefly_derive"
-version = "0.29.0"
+version = "0.29.2"
 authors = ["Meta"]
 edition = "2024"
 repository = "https://github.com/facebook/pyrefly"

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_python/Cargo.toml

@@ -2,7 +2,7 @@
 
 [package]
 name = "pyrefly_python"
-version = "0.29.0"
+version = "0.29.2"
 authors = ["Meta"]
 edition = "2024"
 repository = "https://github.com/facebook/pyrefly"

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_python/src/module_name.rs

@@ -142,6 +142,10 @@ impl ModuleName {
         Self::from_str("_typeshed._type_checker_internals")
     }
 
+    pub fn collections_abc() -> Self {
+        Self::from_str("_collections_abc")
+    }
+
     pub fn pydantic() -> Self {
         Self::from_str("pydantic.main")
     }

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_types/Cargo.toml

@@ -2,7 +2,7 @@
 
 [package]
 name = "pyrefly_types"
-version = "0.29.0"
+version = "0.29.2"
 authors = ["Meta"]
 edition = "2024"
 repository = "https://github.com/facebook/pyrefly"

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_types/src/callable.rs

@@ -52,7 +52,7 @@ impl ParamList {
     }
 
     /// Prepend some required position-only parameters.
-    pub fn prepend_types(&self, pre: &[Type]) -> Cow<ParamList> {
+    pub fn prepend_types(&self, pre: &[Type]) -> Cow<'_, ParamList> {
         if pre.is_empty() {
             Cow::Borrowed(self)
         } else {
@@ -153,8 +153,10 @@ impl ParamList {
         self.0.is_empty()
     }
 
-    pub fn tail(&self) -> ParamList {
-        Self(self.0[1..].to_vec())
+    pub fn split_first(&self) -> Option<(&Type, ParamList)> {
+        self.0
+            .split_first()
+            .map(|(first, rest)| (first.as_type(), ParamList(rest.to_vec())))
     }
 
     /// Type signature that permits everything, namely `*args, **kwargs`.
@@ -392,20 +394,25 @@ impl Callable {
         }
     }
 
-    pub fn drop_first_param(&self) -> Option<Self> {
+    pub fn split_first_param(&self) -> Option<(&Type, Self)> {
         match self {
             Self {
                 params: Params::List(params),
                 ret,
-            } if !params.is_empty() => Some(Self::list(params.tail(), ret.clone())),
+            } => {
+                let (first, rest) = params.split_first()?;
+                Some((first, Self::list(rest, ret.clone())))
+            }
             Self {
                 params: Params::ParamSpec(ts, p),
                 ret,
-            } if !ts.is_empty() => Some(Self::concatenate(
-                ts.iter().skip(1).cloned().collect(),
-                p.clone(),
-                ret.clone(),
-            )),
+            } => {
+                let (first, rest) = ts.split_first()?;
+                Some((
+                    first,
+                    Self::concatenate(rest.iter().cloned().collect(), p.clone(), ret.clone()),
+                ))
+            }
             _ => None,
         }
     }

{pyrefly-0.29.0 → pyrefly-0.29.2}/crates/pyrefly_types/src/class.rs

@@ -163,6 +163,7 @@ impl ClassKind {
             ("cached_property", "cached_property") => Self::Property(name.clone()),
             ("cinder", "cached_property") => Self::Property(name.clone()),
             ("cinder", "async_cached_property") => Self::Property(name.clone()),
+            ("enum", "property") => Self::Property(name.clone()),
             ("enum", "member") => Self::EnumMember,
             ("enum", "nonmember") => Self::EnumNonmember,
             ("dataclasses", "Field") => Self::DataclassField,
@@ -333,7 +334,7 @@ impl ClassType {
         Self(self.0.dupe(), self.1.substitute_with(substitution))
     }
 
-    pub fn substitution(&self) -> Substitution {
+    pub fn substitution(&self) -> Substitution<'_> {
         self.targs().substitution()
     }