pyopensky 2.14__tar.gz → 2.15__tar.gz

{pyopensky-2.14 → pyopensky-2.15}/.github/workflows/run_tests.yml

@@ -37,7 +37,7 @@ jobs:
           fetch-depth: 0
 
       - name: Install uv
-        uses: astral-sh/setup-uv@v5
+        uses: astral-sh/setup-uv@v6
         with:
           enable-cache: true
 

{pyopensky-2.14 → pyopensky-2.15}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pyopensky
-Version: 2.14
+Version: 2.15
 Summary: A Python interface for OpenSky database
 Project-URL: Repository, https://github.com/open-aviation/pyopensky/
 Author-email: Xavier Olive <git@xoolive.org>, Junzi Sun <j.sun-1@tudelft.nl>

{pyopensky-2.14 → pyopensky-2.15}/docs/source/credentials.rst

@@ -20,9 +20,13 @@ is created, including the following content:
     [default]
     username =
     password =
+    client_id =
+    client_secret =
 
-If you use the same login for the OpenSky website (therefore the REST API) and 
-for Trino (it will be unified one day), just fill it here.
+
+The username and password is used to access the Trino database, while the
+client ID and client secret are used to access the OpenSky REST API. 
+Log in to your OpenSky account and visit the `Account <https://opensky-network.org/my-opensky/account>`_ page in order to create a new API client and retrieve your ``client_id`` and ``client_secret``.
 
 You will identify the folder where the ``settings.conf`` file is located:
 
@@ -32,26 +36,6 @@ You will identify the folder where the ``settings.conf`` file is located:
 
     print(opensky_config_dir)
 
-
-Different credentials per service
----------------------------------
-
-If you want to specify different credentials for the REST API and for the Trino 
-database, use the following sections in the configuration file.
-
-.. code::
-
-    [opensky]  # REST API
-    username =
-    password =
-
-    [trino]  # Trino database
-    username =
-    password =
-
-If these sections are commented, the library will use the credentials from the
-[default] section.
-
 Fallback configuration
 ----------------------
 
@@ -61,5 +45,5 @@ following steps are performed in order:
 - try to get the credentials from the `traffic <https://traffic-viz.github.io>`_
   configuration file;
 - get the credentials from ``$OPENSKY_USERNAME`` and ``$OPENSKY_PASSWORD``
-  environment variables;
-- open a browser and log in on a dedicated webpage.
+  environment variables (``$OPENSKY_CLIENT_ID`` and ``$OPENSKY_CLIENT_SECRET`` for the API client);
+- open a browser and log in on a dedicated webpage (for Trino).

{pyopensky-2.14 → pyopensky-2.15}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pyopensky"
-version = "2.14"
+version = "2.15"
 description = "A Python interface for OpenSky database"
 authors = [
   { name = "Xavier Olive", email = "git@xoolive.org" },

{pyopensky-2.14 → pyopensky-2.15}/src/pyopensky/config.py

@@ -19,16 +19,14 @@ DEFAULT_CONFIG = """
 [default]
 username =
 password =
+client_id =
+client_secret =
 
 # Uncomment the following if you have access to the s3 server
+# [s3]
 # secret_key =
 # access_key =
 
-# If you need a different account on Trino, uncomment the following
-# [trino]
-# username =
-# password =
-
 [cache]
 ## You may set a different cache folder here if you have a preferred space
 ## for storing possibly large files.
@@ -147,6 +145,16 @@ NAME_RESOLUTION: dict[str, Resolution] = {
         traffic_category="opensky",
         traffic_name="password",
     ),
+    "client_id": dict(
+        environment_variable="OPENSKY_CLIENT_ID",
+        opensky_category="default",
+        opensky_name="client_id",
+    ),
+    "client_secret": dict(
+        environment_variable="OPENSKY_CLIENT_SECRET",
+        opensky_category="default",
+        opensky_name="client_secret",
+    ),
     "trino_username": dict(
         environment_variable="OPENSKY_TRINO_USERNAME",
         opensky_category="trino",

{pyopensky-2.14 → pyopensky-2.15}/src/pyopensky/rest.py

@@ -1,22 +1,31 @@
 from __future__ import annotations
 
+import datetime
 import logging
 import time
 from datetime import timedelta
 from json import JSONDecodeError
-from typing import Any, cast
+from typing import Any, TypedDict, cast
 
 import httpx
 
 import pandas as pd
 
 from .api import HasBounds
-from .config import password, username
+from .config import client_id, client_secret, password, username
 from .time import timelike, to_datetime
 
 _log = logging.getLogger(__name__)
 
 
+class TokenDict(TypedDict):
+    access_token: str
+    expires_in: int
+    token_type: str
+    # Added for convenience, not in the API response
+    expiration: datetime.datetime
+
+
 class REST:
     """Wrapper to OpenSky REST API.
 
@@ -53,12 +62,54 @@ class REST:
     def __init__(self) -> None:
         self.username = username
         self.password = password
-        self.auth = cast(tuple[str, str], (username, password))
+        self.client_id = client_id
+        self.client_secret = client_secret
+        # self.auth = cast(tuple[str, str], (username, password))
+        self._token: None | TokenDict = None
 
         self.client = httpx.Client()
 
+    @property
+    def token(self) -> None | TokenDict:
+        """Returns the OpenSky token for the current user."""
+
+        if self._token is not None:
+            now = datetime.datetime.now(tz=datetime.timezone.utc)
+            if "expiration" in self._token and self._token["expiration"] > now:
+                return self._token
+
+        if self.client_id is None or self.client_secret is None:
+            return None
+
+        now = datetime.datetime.now(tz=datetime.timezone.utc)
+        url = "https://auth.opensky-network.org/auth/realms/opensky-network/protocol/openid-connect/token"
+        c = self.client.post(
+            url=url,
+            data=dict(
+                grant_type="client_credentials",
+                client_id=self.client_id,
+                client_secret=self.client_secret,
+            ),
+        )
+        c.raise_for_status()
+        self._token = c.json()
+        assert self._token is not None
+        if "access_token" not in self._token:
+            raise RuntimeError("No access token found in response")
+        self._token["expiration"] = now + timedelta(
+            seconds=self._token["expires_in"]
+        )
+        return self._token
+
+    @property
+    def headers(self) -> dict[str, str]:
+        """Returns the headers to use for OpenSky requests."""
+        if self.token is None:
+            return {}
+        return {"Authorization": f"Bearer {self.token['access_token']}"}
+
     def get(self, query: str, retry: int = 5) -> Any:
-        c = self.client.get(query, auth=self.auth)
+        c = self.client.get(query, headers=self.headers)
         try:
             if limit := c.headers.get("X-Rate-Limit-Remaining", None):
                 limit = int(limit)
@@ -95,7 +146,7 @@ class REST:
     async def async_get(
         self, client: httpx.AsyncClient, query: str, retry: int = 5
     ) -> pd.DataFrame:
-        c = await client.get(query, auth=self.auth)
+        c = await client.get(query, headers=self.headers)
         try:
             if limit := c.headers.get("X-Rate-Limit-Remaining", None):
                 limit = int(limit)
@@ -170,7 +221,7 @@ class REST:
 
         """
 
-        what = "own" if (own and self.auth is not None) else "all"
+        what = "own" if (own and self.headers != {}) else "all"
 
         if bounds is not None:
             if isinstance(bounds, str):
@@ -275,13 +326,13 @@ class REST:
 
         return df
 
-    def routes(self, callsign: str) -> tuple[str, str]:
-        """Returns the route associated to a callsign."""
-        json = self.get(
-            f"https://opensky-network.org/api/routes?callsign={callsign}"
-        )
+    # def routes(self, callsign: str) -> tuple[str, str]:
+    #     """Returns the route associated to a callsign."""
+    #     json = self.get(
+    #         f"https://opensky-network.org/api/routes?callsign={callsign}"
+    #     )
 
-        return tuple(json["route"])
+    #     return tuple(json["route"])
 
     def aircraft(
         self,

{pyopensky-2.14 → pyopensky-2.15}/src/pyopensky/schema.py

@@ -208,23 +208,40 @@ class Base(DeclarativeBase):
 class StateVectorsData4(Base):
     __tablename__ = "state_vectors_data4"
 
+    # The time at which the state vector was valid.
     time: Mapped[pd.Timestamp]
+    # The unique 24-bit transponder ID assigned to the aircraft.
     icao24: Mapped[Address]
+    # The last known latitude and longitude (WGS84 format).
     lat: Mapped[float]
     lon: Mapped[float]
+    # Speed over ground in meters per second.
     velocity: Mapped[float]
+    # The direction of movement in degrees from geographic north.
     heading: Mapped[float]
+    # Vertical speed in meters per second
+    # (positive = ascending, negative = descending).
     vertrate: Mapped[float]
+    # The flight identifier broadcast by the aircraft.
     callsign: Mapped[Callsign]
+    # Indicates if the aircraft is on the ground (true) or airborne (false).
     onground: Mapped[bool]
+    # Special ATC indicators: alert squawk.
     alert: Mapped[bool]
+    # Special ATC indicators: special position indicator.
     spi: Mapped[bool]
+    # The 4-digit octal transponder code assigned by ATC.
     squawk: Mapped[str]
+    # Barometric altitude measured by the aircraft in meters.
     baroaltitude: Mapped[float]
+    # Geometric altitude determined by GNSS (GPS).
     geoaltitude: Mapped[float]
+    # The timestamp of the last recorded position update.
     lastposupdate: Mapped[float]
+    # The last time OpenSky received a signal from the aircraft.
     lastcontact: Mapped[float]
     serials: Mapped[List[int]] = mapped_column(ARRAY(Integer))  # TODO
+    # The start of the hour this data belongs to.
     hour: Mapped[pd.Timestamp] = mapped_column(primary_key=True)
 
 

{pyopensky-2.14 → pyopensky-2.15}/src/pyopensky/trino.py

@@ -132,6 +132,7 @@ class Trino(OpenSkyDBAPI):
                 user=trino_username,
                 catalog="minio",
                 schema="osky",
+                source="pyopensky",
             ),
             connect_args=dict(
                 auth=JWTAuthentication(token)

{pyopensky-2.14 → pyopensky-2.15}/tests/test_trino.py

@@ -13,14 +13,6 @@ commercial_callsign = (
 )
 
 
-def test_alive() -> None:
-    df = trino.query(
-        "select * from state_vectors_data4 limit 5",
-        cached=False,
-    )
-    assert df.shape[0] == 5
-
-
 def test_query() -> None:
     res = trino.query(
         select(FlightsData4)