pyopenapi-gen 0.20.0__tar.gz → 0.20.1__tar.gz

{pyopenapi_gen-0.20.0 → pyopenapi_gen-0.20.1}/CHANGELOG.md

@@ -1,6 +1,53 @@
 # CHANGELOG
 
 
+## v0.20.1 (2025-10-21)
+
+### Bug Fixes
+
+- **codegen**: Resolve method naming and file handling in overloaded endpoints
+  ([`190e581`](https://github.com/mindhiveoy/pyopenapi_gen/commit/190e5819e99edf37d14722b075069851d03c4c3b))
+
+This commit fixes two critical issues in code generation for operations with multiple content types
+  (overloaded methods):
+
+1. **Method Naming**: Overloaded methods were using camelCase from OpenAPI operationId instead of
+  converting to Python's snake_case convention. - Fixed: Added NameSanitizer.sanitize_method_name()
+  in overload_generator.py - Example: updateDocument -> update_document
+
+2. **File Upload Handling**: Multipart/form-data file uploads were incorrectly being passed through
+  DataclassSerializer.serialize(), which is designed for dataclass-to-dict conversion, not file I/O.
+  - Fixed: Pass file dict directly to httpx transport in endpoint_method_generator.py - Rationale:
+  httpx expects raw IO objects, not serialized data
+
+Both issues only affected operations with multiple content types (JSON + multipart). Standard
+  single-content-type operations were unaffected.
+
+Changes: - src/pyopenapi_gen/visit/endpoint/generators/overload_generator.py: Added NameSanitizer
+  import and method name sanitisation in two locations (overload signatures and implementation
+  signatures)
+
+- src/pyopenapi_gen/visit/endpoint/generators/endpoint_method_generator.py: Removed
+  DataclassSerializer.serialize() for file parameters in multipart handling, passing files directly
+  to transport
+
+- tests/visit/endpoint/generators/test_overload_generator.py: Added unit tests for snake_case
+  conversion in overload and implementation signatures
+
+- tests/visit/endpoint/generators/test_endpoint_method_generator.py: Added test for file handling
+  without serialisation
+
+- tests/generation_issues/test_overload_naming_issues.py: Added integration tests verifying both
+  fixes in full code generation pipeline
+
+All tests pass (1348 tests) with full quality checks (format, lint, typecheck, security).
+
+### Chores
+
+- **release**: Sync __init__.py version [skip ci]
+  ([`8047e53`](https://github.com/mindhiveoy/pyopenapi_gen/commit/8047e53df11d8985d95f89dbf3b36046af1e6f1a))
+
+
 ## v0.20.0 (2025-10-19)
 
 ### Bug Fixes

{pyopenapi_gen-0.20.0 → pyopenapi_gen-0.20.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pyopenapi-gen
-Version: 0.20.0
+Version: 0.20.1
 Summary: Modern, async-first Python client generator for OpenAPI specifications with advanced cycle detection and unified type resolution
 Project-URL: Homepage, https://github.com/your-org/pyopenapi-gen
 Project-URL: Documentation, https://github.com/your-org/pyopenapi-gen/blob/main/README.md

{pyopenapi_gen-0.20.0 → pyopenapi_gen-0.20.1}/coverage.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" ?>
-<coverage version="7.10.7" timestamp="1760875420300" lines-valid="6505" lines-covered="5750" line-rate="0.8839" branches-covered="0" branches-valid="0" branch-rate="0" complexity="0">
+<coverage version="7.10.7" timestamp="1761058806878" lines-valid="6507" lines-covered="5752" line-rate="0.884" branches-covered="0" branches-valid="0" branch-rate="0" complexity="0">
 	<!-- Generated by coverage.py: https://coverage.readthedocs.io/en/7.10.7 -->
 	<!-- Based on https://raw.githubusercontent.com/cobertura/web/master/htdocs/xml/coverage-04.dtd -->
 	<sources>
@@ -6008,7 +6008,7 @@
 				</class>
 			</classes>
 		</package>
-		<package name="pyopenapi_gen.visit.endpoint.generators" line-rate="0.8881" branch-rate="0" complexity="0">
+		<package name="pyopenapi_gen.visit.endpoint.generators" line-rate="0.8884" branch-rate="0" complexity="0">
 			<classes>
 				<class name="__init__.py" filename="pyopenapi_gen/visit/endpoint/generators/__init__.py" complexity="0" line-rate="1" branch-rate="0">
 					<methods/>
@@ -6085,7 +6085,7 @@
 						<line number="123" hits="1"/>
 					</lines>
 				</class>
-				<class name="endpoint_method_generator.py" filename="pyopenapi_gen/visit/endpoint/generators/endpoint_method_generator.py" complexity="0" line-rate="0.9291" branch-rate="0">
+				<class name="endpoint_method_generator.py" filename="pyopenapi_gen/visit/endpoint/generators/endpoint_method_generator.py" complexity="0" line-rate="0.9286" branch-rate="0">
 					<methods/>
 					<lines>
 						<line number="1" hits="1"/>
@@ -6188,7 +6188,6 @@
 						<line number="181" hits="1"/>
 						<line number="182" hits="1"/>
 						<line number="183" hits="1"/>
-						<line number="184" hits="1"/>
 						<line number="185" hits="1"/>
 						<line number="186" hits="1"/>
 						<line number="187" hits="1"/>
@@ -6228,93 +6227,96 @@
 						<line number="10" hits="1"/>
 						<line number="11" hits="1"/>
 						<line number="12" hits="1"/>
-						<line number="14" hits="1"/>
-						<line number="17" hits="1"/>
-						<line number="26" hits="1"/>
+						<line number="13" hits="1"/>
+						<line number="15" hits="1"/>
+						<line number="18" hits="1"/>
 						<line number="27" hits="1"/>
 						<line number="28" hits="1"/>
 						<line number="29" hits="1"/>
 						<line number="30" hits="1"/>
-						<line number="32" hits="1"/>
-						<line number="42" hits="1"/>
+						<line number="31" hits="1"/>
+						<line number="33" hits="1"/>
 						<line number="43" hits="1"/>
 						<line number="44" hits="1"/>
-						<line number="46" hits="1"/>
-						<line number="60" hits="1"/>
+						<line number="45" hits="1"/>
+						<line number="47" hits="1"/>
 						<line number="61" hits="1"/>
-						<line number="64" hits="1"/>
+						<line number="62" hits="1"/>
 						<line number="65" hits="1"/>
 						<line number="66" hits="1"/>
 						<line number="67" hits="1"/>
-						<line number="69" hits="1"/>
-						<line number="72" hits="1"/>
-						<line number="76" hits="1"/>
+						<line number="68" hits="1"/>
+						<line number="70" hits="1"/>
+						<line number="73" hits="1"/>
 						<line number="77" hits="1"/>
 						<line number="78" hits="1"/>
-						<line number="80" hits="1"/>
-						<line number="82" hits="1"/>
-						<line number="103" hits="1"/>
-						<line number="106" hits="1"/>
-						<line number="109" hits="1"/>
-						<line number="112" hits="1"/>
-						<line number="115" hits="1"/>
+						<line number="79" hits="1"/>
+						<line number="81" hits="1"/>
+						<line number="83" hits="1"/>
+						<line number="104" hits="1"/>
+						<line number="107" hits="1"/>
+						<line number="110" hits="1"/>
+						<line number="113" hits="1"/>
 						<line number="116" hits="1"/>
-						<line number="118" hits="1"/>
-						<line number="120" hits="1"/>
+						<line number="117" hits="1"/>
+						<line number="119" hits="1"/>
 						<line number="121" hits="1"/>
 						<line number="122" hits="1"/>
 						<line number="123" hits="1"/>
-						<line number="126" hits="1"/>
-						<line number="129" hits="1"/>
-						<line number="132" hits="1"/>
-						<line number="135" hits="1"/>
-						<line number="138" hits="1"/>
+						<line number="124" hits="1"/>
+						<line number="127" hits="1"/>
+						<line number="130" hits="1"/>
+						<line number="133" hits="1"/>
+						<line number="136" hits="1"/>
 						<line number="139" hits="1"/>
-						<line number="140" hits="1"/>
-						<line number="141" hits="1"/>
 						<line number="142" hits="1"/>
 						<line number="143" hits="1"/>
+						<line number="144" hits="1"/>
 						<line number="145" hits="1"/>
+						<line number="146" hits="1"/>
 						<line number="147" hits="1"/>
-						<line number="159" hits="1"/>
-						<line number="161" hits="1"/>
-						<line number="164" hits="1"/>
-						<line number="166" hits="1"/>
-						<line number="167" hits="1"/>
-						<line number="169" hits="1"/>
+						<line number="149" hits="1"/>
+						<line number="151" hits="1"/>
+						<line number="163" hits="1"/>
+						<line number="165" hits="1"/>
+						<line number="168" hits="1"/>
+						<line number="170" hits="1"/>
 						<line number="171" hits="1"/>
 						<line number="173" hits="1"/>
 						<line number="175" hits="1"/>
+						<line number="177" hits="1"/>
 						<line number="179" hits="1"/>
-						<line number="180" hits="1"/>
-						<line number="182" hits="1"/>
-						<line number="197" hits="1"/>
-						<line number="200" hits="1"/>
-						<line number="203" hits="1"/>
+						<line number="183" hits="1"/>
+						<line number="184" hits="1"/>
+						<line number="186" hits="1"/>
+						<line number="201" hits="1"/>
 						<line number="204" hits="1"/>
-						<line number="206" hits="1"/>
+						<line number="207" hits="1"/>
 						<line number="208" hits="1"/>
-						<line number="209" hits="1"/>
 						<line number="210" hits="1"/>
-						<line number="211" hits="1"/>
+						<line number="212" hits="1"/>
+						<line number="213" hits="1"/>
 						<line number="214" hits="1"/>
-						<line number="217" hits="1"/>
+						<line number="215" hits="1"/>
 						<line number="218" hits="1"/>
-						<line number="220" hits="1"/>
 						<line number="221" hits="1"/>
+						<line number="222" hits="1"/>
 						<line number="224" hits="1"/>
 						<line number="225" hits="1"/>
-						<line number="226" hits="1"/>
-						<line number="227" hits="1"/>
+						<line number="228" hits="1"/>
+						<line number="229" hits="1"/>
 						<line number="230" hits="1"/>
-						<line number="233" hits="1"/>
-						<line number="236" hits="1"/>
+						<line number="231" hits="1"/>
+						<line number="234" hits="1"/>
 						<line number="237" hits="1"/>
-						<line number="238" hits="1"/>
-						<line number="239" hits="1"/>
 						<line number="240" hits="1"/>
-						<line number="241" hits="1"/>
 						<line number="243" hits="1"/>
+						<line number="244" hits="1"/>
+						<line number="245" hits="1"/>
+						<line number="246" hits="1"/>
+						<line number="247" hits="1"/>
+						<line number="248" hits="1"/>
+						<line number="250" hits="1"/>
 					</lines>
 				</class>
 				<class name="request_generator.py" filename="pyopenapi_gen/visit/endpoint/generators/request_generator.py" complexity="0" line-rate="0.9535" branch-rate="0">

{pyopenapi_gen-0.20.0 → pyopenapi_gen-0.20.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "pyopenapi-gen"
-version = "0.20.0"
+version = "0.20.1"
 description = "Modern, async-first Python client generator for OpenAPI specifications with advanced cycle detection and unified type resolution"
 authors = [{ name = "Mindhive Oy", email = "contact@mindhive.fi" }]
 maintainers = [{ name = "Ville Venäläinen | Mindhive Oy", email = "ville@mindhive.fi" }]
@@ -140,7 +140,7 @@ pyopenapi-gen = "pyopenapi_gen.cli:app"
 
 [tool.commitizen]
 name = "cz_conventional_commits"
-version = "0.20.0"
+version = "0.20.1"
 version_files = [
     "pyproject.toml:version",
     "src/pyopenapi_gen/__init__.py:__version__"

{pyopenapi_gen-0.20.0 → pyopenapi_gen-0.20.1}/src/pyopenapi_gen/__init__.py

@@ -50,7 +50,7 @@ __all__ = [
 ]
 
 # Semantic version of the generator core – automatically managed by semantic-release.
-__version__: str = "0.20.0"
+__version__: str = "0.20.1"
 
 # ---------------------------------------------------------------------------
 # Lazy-loading and autocompletion support (This part remains)

{pyopenapi_gen-0.20.0 → pyopenapi_gen-0.20.1}/src/pyopenapi_gen/visit/endpoint/generators/endpoint_method_generator.py

@@ -181,12 +181,12 @@ class EndpointMethodGenerator:
                 writer.dedent()
                 writer.write_line(")")
             elif content_type == "multipart/form-data":
-                writer.write_line(f"files_data = DataclassSerializer.serialize({param_info['name']})")
+                # Files dict is already in correct format for httpx - pass directly
                 writer.write_line("response = await self._transport.request(")
                 writer.indent()
                 writer.write_line(f'"{op.method.value.upper()}", url,')
                 writer.write_line("params=None,")
-                writer.write_line("files=files_data,")
+                writer.write_line(f"files={param_info['name']},")
                 writer.write_line("headers=None")
                 writer.dedent()
                 writer.write_line(")")

{pyopenapi_gen-0.20.0 → pyopenapi_gen-0.20.1}/src/pyopenapi_gen/visit/endpoint/generators/overload_generator.py

@@ -6,6 +6,7 @@ from typing import Any
 from pyopenapi_gen import IROperation
 
 from ....context.render_context import RenderContext
+from ....core.utils import NameSanitizer
 from ....core.writers.code_writer import CodeWriter
 from ..processors.parameter_processor import EndpointParameterProcessor
 from .docstring_generator import EndpointDocstringGenerator
@@ -134,9 +135,12 @@ class OverloadMethodGenerator:
         # Get return type from response strategy
         return_type = response_strategy.return_type
 
+        # Sanitize method name to snake_case
+        method_name = NameSanitizer.sanitize_method_name(op.operation_id)
+
         # Write signature
         params_str = ",\n    ".join(param_parts)
-        writer.write_line(f"async def {op.operation_id}(")
+        writer.write_line(f"async def {method_name}(")
         writer.indent()
         writer.write_line(params_str)
         writer.dedent()
@@ -232,9 +236,12 @@ class OverloadMethodGenerator:
         # Get return type
         return_type = response_strategy.return_type
 
+        # Sanitize method name to snake_case
+        method_name = NameSanitizer.sanitize_method_name(op.operation_id)
+
         # Write signature
         params_str = ",\n    ".join(param_parts)
-        writer.write_line(f"async def {op.operation_id}(")
+        writer.write_line(f"async def {method_name}(")
         writer.indent()
         writer.write_line(params_str)
         writer.dedent()

pyopenapi_gen-0.20.1/tests/generation_issues/test_overload_naming_issues.py

@@ -0,0 +1,203 @@
+"""
+Integration tests for overload method naming and file handling issues.
+
+These tests verify that:
+1. Methods with camelCase operationIds are converted to snake_case
+2. File uploads don't use incorrect DataclassSerializer.serialize()
+3. Multi-content-type operations generate correct code
+"""
+
+import json
+import tempfile
+from pathlib import Path
+
+import pytest
+
+from pyopenapi_gen.generator.client_generator import ClientGenerator
+
+
+@pytest.fixture
+def minimal_spec_with_camelcase_operations() -> dict:
+    """Minimal OpenAPI spec with camelCase operation IDs and multi-content types."""
+    return {
+        "openapi": "3.0.0",
+        "info": {"title": "Test API", "version": "1.0.0"},
+        "paths": {
+            "/documents/{id}": {
+                "put": {
+                    "operationId": "updateDocument",  # camelCase
+                    "summary": "Update a document",
+                    "tags": ["documents"],
+                    "parameters": [{"name": "id", "in": "path", "required": True, "schema": {"type": "string"}}],
+                    "requestBody": {
+                        "required": True,
+                        "content": {
+                            "application/json": {
+                                "schema": {
+                                    "type": "object",
+                                    "properties": {"title": {"type": "string"}},
+                                }
+                            },
+                            "multipart/form-data": {
+                                "schema": {
+                                    "type": "object",
+                                    "properties": {"file": {"type": "string", "format": "binary"}},
+                                }
+                            },
+                        },
+                    },
+                    "responses": {
+                        "200": {
+                            "description": "Success",
+                            "content": {
+                                "application/json": {
+                                    "schema": {
+                                        "type": "object",
+                                        "properties": {"id": {"type": "string"}},
+                                    }
+                                }
+                            },
+                        }
+                    },
+                }
+            },
+            "/documents": {
+                "post": {
+                    "operationId": "createDocument",  # camelCase
+                    "summary": "Create a document",
+                    "tags": ["documents"],
+                    "requestBody": {
+                        "required": True,
+                        "content": {
+                            "application/json": {
+                                "schema": {
+                                    "type": "object",
+                                    "properties": {"title": {"type": "string"}},
+                                }
+                            },
+                            "multipart/form-data": {
+                                "schema": {
+                                    "type": "object",
+                                    "properties": {"file": {"type": "string", "format": "binary"}},
+                                }
+                            },
+                        },
+                    },
+                    "responses": {
+                        "201": {
+                            "description": "Created",
+                            "content": {
+                                "application/json": {
+                                    "schema": {
+                                        "type": "object",
+                                        "properties": {"id": {"type": "string"}},
+                                    }
+                                }
+                            },
+                        }
+                    },
+                }
+            },
+        },
+    }
+
+
+class TestOverloadNamingIntegration:
+    """Integration tests for camelCase to snake_case conversion."""
+
+    def test_generate_client__camelcase_operations__converts_to_snake_case(
+        self, minimal_spec_with_camelcase_operations: dict
+    ) -> None:
+        """
+        Scenario: Generate client from spec with camelCase operationIds
+        Expected Outcome: Generated methods should be snake_case
+        """
+        # Arrange
+        with tempfile.TemporaryDirectory() as tmpdir:
+            spec_path = Path(tmpdir) / "spec.json"
+            with open(spec_path, "w") as f:
+                json.dump(minimal_spec_with_camelcase_operations, f)
+
+            output_path = Path(tmpdir) / "output"
+            output_path.mkdir()
+
+            generator = ClientGenerator()
+
+            # Act
+            generated_files = generator.generate(
+                spec_path=str(spec_path),
+                project_root=output_path,
+                output_package="testapi",
+                force=True,
+                no_postprocess=True,  # Skip formatting for faster test
+            )
+
+            # Assert
+            # Find the generated endpoint file (exclude __init__.py)
+            endpoint_files = [
+                f for f in generated_files if "endpoints" in str(f) and not str(f).endswith("__init__.py")
+            ]
+            assert len(endpoint_files) > 0, "No endpoint files generated"
+
+            # Collect all endpoint code
+            all_code = ""
+            for endpoint_file in endpoint_files:
+                with open(endpoint_file, "r") as f:
+                    all_code += f.read()
+
+            # Check method names are snake_case
+            assert "async def update_document(" in all_code, "updateDocument should be update_document"
+            assert "async def create_document(" in all_code, "createDocument should be create_document"
+
+            # Check they're NOT camelCase
+            assert "async def updateDocument(" not in all_code, "Method name should not be camelCase updateDocument"
+            assert "async def createDocument(" not in all_code, "Method name should not be camelCase createDocument"
+
+
+class TestFileHandlingIntegration:
+    """Integration tests for file upload handling."""
+
+    def test_generate_client__multipart_files__no_serialization(
+        self, minimal_spec_with_camelcase_operations: dict
+    ) -> None:
+        """
+        Scenario: Generate client with multipart/form-data operations
+        Expected Outcome: Files should be passed directly, not serialized
+        """
+        # Arrange
+        with tempfile.TemporaryDirectory() as tmpdir:
+            spec_path = Path(tmpdir) / "spec.json"
+            with open(spec_path, "w") as f:
+                json.dump(minimal_spec_with_camelcase_operations, f)
+
+            output_path = Path(tmpdir) / "output"
+            output_path.mkdir()
+
+            generator = ClientGenerator()
+
+            # Act
+            generated_files = generator.generate(
+                spec_path=str(spec_path),
+                project_root=output_path,
+                output_package="testapi",
+                force=True,
+                no_postprocess=True,
+            )
+
+            # Assert
+            endpoint_files = [f for f in generated_files if "endpoints" in str(f)]
+            assert len(endpoint_files) > 0
+
+            for endpoint_file in endpoint_files:
+                with open(endpoint_file, "r") as f:
+                    code = f.read()
+
+                # Files should be passed directly
+                if "multipart/form-data" in code:
+                    # Should NOT serialize files
+                    assert (
+                        "files_data = DataclassSerializer.serialize(files)" not in code
+                    ), "Files should not be serialized"
+
+                    # Should pass files directly
+                    assert "files=files," in code or "files = files" in code, "Files should be passed directly"

{pyopenapi_gen-0.20.0 → pyopenapi_gen-0.20.1}/tests/visit/endpoint/generators/test_endpoint_method_generator.py

@@ -241,3 +241,64 @@ class TestEndpointMethodGenerator:
             result_code
             == "def test_op():\n    # Docstring here\n    # Only comments or whitespace added by helpers\n    pass"
         )
+
+
+class TestGenerateImplementationMethod:
+    """Tests for _generate_implementation_method."""
+
+    def test_generate_implementation_method__multipart_files__no_serialization(
+        self, mock_render_context: RenderContext
+    ) -> None:
+        """
+        Scenario: Generating implementation method for multipart/form-data with files
+        Expected Outcome: Files parameter should be passed directly without DataclassSerializer
+        """
+        # Arrange
+        from pyopenapi_gen import IRRequestBody, IRResponse
+        from pyopenapi_gen.ir import IRSchema
+        from pyopenapi_gen.types.strategies.response_strategy import ResponseStrategy
+
+        op = IROperation(
+            path="/upload",
+            method=HTTPMethod.POST,
+            operation_id="uploadFile",
+            summary="Upload file",
+            description="Upload operation",
+            parameters=[],
+            request_body=IRRequestBody(
+                description="File upload",
+                required=True,
+                content={
+                    "application/json": IRSchema(type="object", name="UploadRequest"),
+                    "multipart/form-data": IRSchema(type="object", name="FileUpload"),
+                },
+            ),
+            responses=[
+                IRResponse(
+                    status_code="201", description="Created", content={"application/json": IRSchema(type="object")}
+                )
+            ],
+        )
+
+        response_ir = IRResponse(
+            status_code="201", description="Created", content={"application/json": IRSchema(type="object")}
+        )
+        response_strategy = ResponseStrategy(
+            return_type="UploadResponse",
+            response_schema=IRSchema(type="object", name="UploadResponse"),
+            is_streaming=False,
+            response_ir=response_ir,
+        )
+
+        generator = EndpointMethodGenerator(schemas={})
+
+        # Act
+        result = generator._generate_implementation_method(op, mock_render_context, response_strategy)
+
+        # Assert - Files should be passed directly, NOT serialized
+        # The implementation should contain: files=files (not files_data=DataclassSerializer.serialize(files))
+        assert "files=files," in result or "files={param_info['name']}" in result
+        # Should NOT contain serialization of files
+        assert "DataclassSerializer.serialize(files)" not in result
+        # The variable assignment should be for json_body, not files_data
+        assert "files_data" not in result or "files_data = files" in result