pyobs-core 2.10.2__tar.gz → 2.10.4__tar.gz

{pyobs_core-2.10.2 → pyobs_core-2.10.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: pyobs-core
-Version: 2.10.2
+Version: 2.10.4
 Summary: robotic telescope software
 Author-email: Tim-Oliver Husser <thusser@uni-goettingen.de>
 License-Expression: MIT

{pyobs_core-2.10.2 → pyobs_core-2.10.4}/pyobs/modules/image/imagewatcher.py

@@ -73,7 +73,7 @@ class ImageWatcher(Module):
         pattern: str = "*",
         flatten: bool = True,
         *,
-        error_after: int,
+        error_after: int = 1800,
         backoff_cap: int = 3600,
         **kwargs: Any,
     ):
@@ -101,11 +101,12 @@ class ImageWatcher(Module):
                 repeatedly fail and re-queue any file whose relative path needs a parent directory that doesn't
                 exist yet.
             error_after: Seconds a file may keep failing with a transient error (see below) before a single
-                ``ERROR`` is logged for it. Required -- no sane default exists, since how long a destination can
-                legitimately be unreachable (a remote archive, an NFS mount, ...) varies per deployment. Set it
-                to how long an outage has to last before it's worth paging someone. The file keeps being retried
-                (with growing backoff, capped at ``backoff_cap``) indefinitely either way; this only controls
-                when the one-time alert fires, not whether retrying continues.
+                ``ERROR`` is logged for it. Defaults to 1800 (30 minutes), a middle ground for the deployments
+                seen so far; how long a destination can legitimately be unreachable (a remote archive, an NFS
+                mount, ...) varies per deployment, so override it per config where an outage should page someone
+                sooner or later. The file keeps being retried (with growing backoff, capped at ``backoff_cap``)
+                indefinitely either way; this only controls when the one-time alert fires, not whether retrying
+                continues.
             backoff_cap: Maximum seconds between retries of a file that keeps failing transiently. The interval
                 starts at ``wait_time`` and doubles on each failure up to this cap.
 

{pyobs_core-2.10.2 → pyobs_core-2.10.4}/pyobs/object.py

@@ -529,19 +529,29 @@ class Object(PrivateAttrMixin):
 
     @staticmethod
     def config_or_object_get_param(config_or_object: dict[str, Any] | Any, param: str) -> Any:
-        """Checks, whether a config_or_object has the given parameter.
+        """Returns the given parameter's value from a config dict or object, or None if it does not
+        define it.
+
+        A class passed in place of a config/object is only used as the type to instantiate, so it
+        carries no configured values of its own and always reports None. Inspecting it with
+        hasattr() would instead report every property as present -- `observer`, `vfs`, and
+        `timezone` are all properties on PrivateAttrMixin -- so the parent's value would look like
+        the child's own and never be inherited; a class-created child such as
+        LcoObservationArchive's LcoScheduleReader then ended up without an observer, breaking
+        observer-dependent scripts (e.g. DarkBiasScript's night resolution) downstream.
 
         Args:
             config_or_object: Dict config or object.
             param: Parameter name to check.
 
         Returns:
-
+            Value of the parameter, or None if it is not configured.
         """
-        is_dict = isinstance(config_or_object, dict)
-        if is_dict and param in config_or_object:
-            return config_or_object[param]
-        if not is_dict and hasattr(config_or_object, param):
+        if isinstance(config_or_object, dict):
+            return config_or_object.get(param)
+        if inspect.isclass(config_or_object):
+            return None
+        if hasattr(config_or_object, param):
             return getattr(config_or_object, param)
         return None
 

{pyobs_core-2.10.2 → pyobs_core-2.10.4}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pyobs-core"
-version = "2.10.2"
+version = "2.10.4"
 description = "robotic telescope software"
 authors = [{ name = "Tim-Oliver Husser", email = "thusser@uni-goettingen.de" }]
 requires-python = ">=3.11"