pyobs-core 2.0.0.dev34__tar.gz → 2.0.0.dev36__tar.gz

{pyobs_core-2.0.0.dev34 → pyobs_core-2.0.0.dev36}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pyobs-core
-Version: 2.0.0.dev34
+Version: 2.0.0.dev36
 Summary: robotic telescope software
 Author-email: Tim-Oliver Husser <thusser@uni-goettingen.de>
 License-Expression: MIT

{pyobs_core-2.0.0.dev34 → pyobs_core-2.0.0.dev36}/pyobs/comm/comm.py

@@ -663,7 +663,27 @@ class Comm:
                 # handle it
                 ret = handler(event, from_client)
                 if asyncio.iscoroutine(ret):
-                    asyncio.create_task(ret)
+                    task = asyncio.create_task(ret)
+                    task.add_done_callback(functools.partial(self._log_handler_exception, handler=handler, event=event))
+
+    @staticmethod
+    def _log_handler_exception(task: asyncio.Task[Any], handler: Callable[..., Any], event: Event) -> None:
+        """Log an event handler's exception with context, instead of leaving it to asyncio's own
+        "Task exception was never retrieved" warning at garbage-collection time, which gives no
+        indication of which handler or event actually failed -- every event handler is dispatched
+        as a fire-and-forget task (see _send_event_to_module), so this is the only place any of
+        them get their exceptions surfaced at all.
+        """
+        if task.cancelled():
+            return
+        exc = task.exception()
+        if exc is not None:
+            log.error(
+                "Unhandled exception in event handler %s for %s.",
+                getattr(handler, "__qualname__", handler),
+                event.__class__.__name__,
+                exc_info=exc,
+            )
 
 
 __all__ = ["Comm"]

{pyobs_core-2.0.0.dev34 → pyobs_core-2.0.0.dev36}/pyobs/comm/proxy.py

@@ -195,7 +195,13 @@ class Proxy:
         interface: type[Interface],
         timeout: float = 10.0,
     ) -> Any:
-        """Return state immediately if available, otherwise wait for the first update."""
+        """Return state immediately if available, otherwise wait for the first update.
+
+        Returns None on timeout rather than raising -- every caller across the codebase already
+        does `if state is not None else ...` right after calling this, so that's the contract
+        actually being relied on; letting asyncio.wait_for's TimeoutError propagate would just
+        turn "peer hasn't published yet" into an unhandled exception for all of them.
+        """
         if self._state.get(interface) is not None:
             return self._state[interface]
 
@@ -209,6 +215,8 @@ class Proxy:
         await self._comm.subscribe_state(self._client, interface, _notify)
         try:
             await asyncio.wait_for(event.wait(), timeout=timeout)
+        except TimeoutError:
+            pass
         finally:
             await self._comm.unsubscribe_state(self._client, interface, _notify)
 

{pyobs_core-2.0.0.dev34 → pyobs_core-2.0.0.dev36}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pyobs-core"
-version = "2.0.0.dev34"
+version = "2.0.0.dev36"
 description = "robotic telescope software"
 authors = [{ name = "Tim-Oliver Husser", email = "thusser@uni-goettingen.de" }]
 requires-python = ">=3.11"