pyobs-aravis 2.0.0.dev6__tar.gz → 2.0.0.dev8__tar.gz

{pyobs_aravis-2.0.0.dev6 → pyobs_aravis-2.0.0.dev8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pyobs-aravis
-Version: 2.0.0.dev6
+Version: 2.0.0.dev8
 Summary: pyobs module for Aravis cameras
 Author-email: Tim-Oliver Husser <thusser@uni-goettingen.de>
 License-Expression: MIT

{pyobs_aravis-2.0.0.dev6 → pyobs_aravis-2.0.0.dev8}/pyobs_aravis/araviscamera.py

@@ -1,6 +1,8 @@
 import asyncio
 import logging
+import threading
 import time
+from collections.abc import Callable
 from typing import Any
 
 import numpy.typing as npt
@@ -9,6 +11,11 @@ from pyobs.modules.camera import BaseVideo
 
 log = logging.getLogger(__name__)
 
+# aravis/GLib calls are blocking and are made directly on the event loop thread (see _run_blocking).
+# If the camera has gone unresponsive, they can hang indefinitely, so we bound them with a timeout
+# rather than let a single dead camera freeze the whole module.
+_SDK_CALL_TIMEOUT = 5.0
+
 
 class AravisCamera(BaseVideo, IExposureTime):
     """A pyobs module for Aravis cameras."""
@@ -50,7 +57,18 @@ class AravisCamera(BaseVideo, IExposureTime):
 
         await BaseVideo.open(self)
 
-        ids: list[str] = aravis.get_device_ids()  # type: ignore[assignment]
+        # device discovery is a blocking, network-based scan (GigE Vision/USB3 Vision devices
+        # reply to a broadcast query) that can take multiple seconds -- run it like the other
+        # aravis/GLib calls (see _run_blocking) instead of freezing the whole module's event
+        # loop, and with it, the ability to respond to any other module, for that long
+        ids: list[str] = []
+
+        def _list_device_ids() -> None:
+            ids.extend(aravis.get_device_ids())  # type: ignore[arg-type]
+
+        if not await self._run_blocking(_list_device_ids):
+            raise TimeoutError(f"Timed out listing available cameras after {_SDK_CALL_TIMEOUT}s.")
+
         if self._camera_device_name not in ids:
             raise ValueError("Could not find given device name in list of available cameras.")
 
@@ -59,8 +77,7 @@ class AravisCamera(BaseVideo, IExposureTime):
     async def close(self) -> None:
         """Close the module."""
         await BaseVideo.close(self)
-        async with self._camera_lock:
-            self._close_camera()
+        await self._deactivate_camera()
 
     def _open_camera(self) -> None:
         """Open camera."""
@@ -87,15 +104,45 @@ class AravisCamera(BaseVideo, IExposureTime):
                 log.exception("Error closing camera.")
         self._camera = None
 
+    @staticmethod
+    async def _run_blocking(func: Callable[[], None], timeout: float = _SDK_CALL_TIMEOUT) -> bool:
+        """Run a blocking aravis/GLib call in a daemon thread, so a hung call can't freeze the module.
+
+        A plain executor isn't used here, since its worker threads are non-daemon and Python joins
+        them on interpreter shutdown -- a hung call would then just move the freeze to process exit.
+
+        Returns:
+            True if func completed within timeout, False if it's still running in the background.
+        """
+        loop = asyncio.get_running_loop()
+        future: asyncio.Future[None] = loop.create_future()
+
+        def _wrapper() -> None:
+            try:
+                func()
+            finally:
+                loop.call_soon_threadsafe(future.set_result, None)
+
+        threading.Thread(target=_wrapper, daemon=True).start()
+        try:
+            await asyncio.wait_for(future, timeout=timeout)
+            return True
+        except TimeoutError:
+            return False
+
     async def _activate_camera(self) -> None:
         """Open camera on activation."""
         async with self._camera_lock:
-            self._open_camera()
+            if not await self._run_blocking(self._open_camera):
+                log.error("Timed out connecting to camera after %.1fs.", _SDK_CALL_TIMEOUT)
+                self._camera = None
 
     async def _deactivate_camera(self) -> None:
         """Close camera on deactivation."""
         async with self._camera_lock:
-            self._close_camera()
+            if not await self._run_blocking(self._close_camera):
+                log.error("Timed out closing camera after %.1fs, abandoning cleanup.", _SDK_CALL_TIMEOUT)
+                self._camera = None
 
     async def _capture(self) -> None:
         """Take new images in loop."""

{pyobs_aravis-2.0.0.dev6 → pyobs_aravis-2.0.0.dev8}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pyobs-aravis"
-version = "2.0.0.dev6"
+version = "2.0.0.dev8"
 description = "pyobs module for Aravis cameras"
 authors = [{ name = "Tim-Oliver Husser", email = "thusser@uni-goettingen.de" }]
 requires-python = ">=3.11,<3.14"

{pyobs_aravis-2.0.0.dev6 → pyobs_aravis-2.0.0.dev8}/uv.lock

@@ -1770,7 +1770,7 @@ wheels = [
 
 [[package]]
 name = "pyobs-aravis"
-version = "2.0.0.dev6"
+version = "2.0.0.dev8"
 source = { editable = "." }
 dependencies = [
     { name = "numpy", version = "2.4.6", source = { registry = "https://pypi.org/simple" }, marker = "python_full_version < '3.12'" },